116741 2013-05-24 15:08:43 -0700 fourthTier: FTL boolify should support ObjectOrOtherUse 2013-05-24 15:27:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 893464 0 fpizlo 2013-05-24 15:08:43 -0700 Patch forthcoming. 893465 1 202855 fpizlo 2013-05-24 15:10:22 -0700 Created attachment 202855 the patch 893467 2 202855 ggaren 2013-05-24 15:20:07 -0700 Comment on attachment 202855 the patch r=me 893470 3 fpizlo 2013-05-24 15:27:53 -0700 Landed in http://trac.webkit.org/changeset/150661 202855 2013-05-24 15:10:22 -0700 2013-05-24 15:20:07 -0700 the patch blah.patch text/plain 7638 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUwNjYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEzLTA1LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogRlRMIGJvb2xpZnkgc2hvdWxkIHN1cHBvcnQgT2JqZWN0T3JPdGhlclVzZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NzQxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBK dXN0IHJldXNpbmcgd2hhdCB3YXMgYWxyZWFkeSB0aGVyZSBpbiBlcXVhbE51bGxPclVuZGVmaW5l ZCgpLiBOb3RlIHRoYXQgd2Ugd2lsbAorICAgICAgICBzb21ldGltZXMgZ2VuZXJhdGUgc29tZSBy ZWR1bmRhbnQgSVIgLSBsaWtlIGhhdmluZyBzb21lIHNwdXJpb3VzIGJpdE5vdCdzIGluCisgICAg ICAgIHBsYWNlcyAtIGJ1dCBpdCdzIHNhZmUgdG8gYXNzdW1lIHRoYXQgTExWTSB3aWxsIHNpbXBs aWZ5IHRob3NlLCBhbmQgdGhhdCBpdCB3b24ndAorICAgICAgICBiZSB0aGUgbG9uZ2VzdCBwb2xl IGluIHRoZSB0ZW50IGZvciBjb21waWxlIHRpbWVzLgorCisgICAgICAgICogZnRsL0ZUTENhcGFi aWxpdGllcy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6Y2FuQ29tcGlsZSk6CisgICAgICAgICog ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1Rv TExWTTo6Y29tcGlsZUNvbXBhcmVFcUNvbnN0YW50KToKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dl ckRGR1RvTExWTTo6Y29tcGlsZUNvbXBhcmVTdHJpY3RFcUNvbnN0YW50KToKKyAgICAgICAgKEpT Qzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Ym9vbGlmeSk6CisgICAgICAgIChKU0M6OkZUTDo6TG93 ZXJERkdUb0xMVk06OmVxdWFsTnVsbE9yVW5kZWZpbmVkKToKKwogMjAxMy0wNS0yNCAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIGZvdXJ0aFRpZXI6IEZUTCBzaG91 bGQgc3VwcG9ydCBMb2dpY2FsTm90IGFuZCBCcmFuY2ggb24gSW50MzIgYW5kIE51bWJlcgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkocmV2 aXNpb24gMTUwNjU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRp ZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNiArMTI4LDcgQEAgaW5saW5lIGJvb2wgY2Fu Q29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICBjYXNlIEJvb2xlYW5Vc2U6CiAgICAgICAgIGNh c2UgSW50MzJVc2U6CiAgICAgICAgIGNhc2UgTnVtYmVyVXNlOgorICAgICAgICBjYXNlIE9iamVj dE9yT3RoZXJVc2U6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDoKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTE2NSw2ICsxNjYsNyBAQCBib29sIGNhbkNvbXBpbGUo R3JhcGgmIGdyYXBoKQogICAgICAgICAgICAgICAgIGNhc2UgQ2VsbFVzZToKICAgICAgICAgICAg ICAgICBjYXNlIEtub3duQ2VsbFVzZToKICAgICAgICAgICAgICAgICBjYXNlIE9iamVjdFVzZToK KyAgICAgICAgICAgICAgICBjYXNlIE9iamVjdE9yT3RoZXJVc2U6CiAgICAgICAgICAgICAgICAg ICAgIC8vIFRoZXNlIGFyZSBPSy4KICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICAgICAgZGVmYXVsdDoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0xMVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwv RlRMTG93ZXJERkdUb0xMVk0uY3BwCShyZXZpc2lvbiAxNTA2NTgpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTkw LDcgKzk5MCw5IEBAIHByaXZhdGU6CiAgICAgewogICAgICAgICBBU1NFUlQobV9ncmFwaC52YWx1 ZU9mSlNDb25zdGFudChtX25vZGUtPmNoaWxkMigpLm5vZGUoKSkuaXNOdWxsKCkpOwogICAgICAg ICBtYXNxdWVyYWRlc0FzVW5kZWZpbmVkV2F0Y2hwb2ludElmSXNTdGlsbFZhbGlkKCk7Ci0gICAg ICAgIGVxdWFsTnVsbE9yVW5kZWZpbmVkKG1fbm9kZS0+Y2hpbGQxKCksIEVxdWFsTnVsbE9yVW5k ZWZpbmVkKTsKKyAgICAgICAgbV9ib29sZWFuVmFsdWVzLmFkZCgKKyAgICAgICAgICAgIG1fbm9k ZSwgZXF1YWxOdWxsT3JVbmRlZmluZWQoCisgICAgICAgICAgICAgICAgbV9ub2RlLT5jaGlsZDEo KSwgQWxsQ2VsbHNBcmVGYWxzZSwgRXF1YWxOdWxsT3JVbmRlZmluZWQpKTsKICAgICB9CiAgICAg CiAgICAgdm9pZCBjb21waWxlQ29tcGFyZVN0cmljdEVxKCkKQEAgLTEwMjgsMTIgKzEwMzAsMTQg QEAgcHJpdmF0ZToKICAgICAgICAgaWYgKGNvbnN0YW50LmlzVW5kZWZpbmVkT3JOdWxsKCkKICAg ICAgICAgICAgICYmICFtYXNxdWVyYWRlc0FzVW5kZWZpbmVkV2F0Y2hwb2ludElmSXNTdGlsbFZh bGlkKCkpIHsKICAgICAgICAgICAgIGlmIChjb25zdGFudC5pc051bGwoKSkgewotICAgICAgICAg ICAgICAgIGVxdWFsTnVsbE9yVW5kZWZpbmVkKG1fbm9kZS0+Y2hpbGQxKCksIEVxdWFsTnVsbCk7 CisgICAgICAgICAgICAgICAgbV9ib29sZWFuVmFsdWVzLmFkZCgKKyAgICAgICAgICAgICAgICAg ICAgbV9ub2RlLCBlcXVhbE51bGxPclVuZGVmaW5lZChtX25vZGUtPmNoaWxkMSgpLCBBbGxDZWxs c0FyZUZhbHNlLCBFcXVhbE51bGwpKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg ICAgICB9CiAgICAgICAgIAogICAgICAgICAgICAgQVNTRVJUKGNvbnN0YW50LmlzVW5kZWZpbmVk KCkpOwotICAgICAgICAgICAgZXF1YWxOdWxsT3JVbmRlZmluZWQobV9ub2RlLT5jaGlsZDEoKSwg RXF1YWxVbmRlZmluZWQpOworICAgICAgICAgICAgbV9ib29sZWFuVmFsdWVzLmFkZCgKKyAgICAg ICAgICAgICAgICBtX25vZGUsIGVxdWFsTnVsbE9yVW5kZWZpbmVkKG1fbm9kZS0+Y2hpbGQxKCks IEFsbENlbGxzQXJlRmFsc2UsIEVxdWFsVW5kZWZpbmVkKSk7CiAgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIH0KICAgICAgICAgCkBAIC0xMTYzLDIyICsxMTY3LDM4IEBAIHByaXZhdGU6CiAg ICAgICAgICAgICByZXR1cm4gbV9vdXQubm90WmVybzMyKGxvd0ludDMyKG1fbm9kZS0+Y2hpbGQx KCkpKTsKICAgICAgICAgY2FzZSBOdW1iZXJVc2U6CiAgICAgICAgICAgICByZXR1cm4gbV9vdXQu ZG91YmxlTm90RXF1YWwobG93RG91YmxlKGVkZ2UpLCBtX291dC5kb3VibGVaZXJvKTsKKyAgICAg ICAgY2FzZSBPYmplY3RPck90aGVyVXNlOgorICAgICAgICAgICAgcmV0dXJuIG1fb3V0LmJpdE5v dCgKKyAgICAgICAgICAgICAgICBlcXVhbE51bGxPclVuZGVmaW5lZCgKKyAgICAgICAgICAgICAg ICAgICAgZWRnZSwgQ2VsbENhc2VTcGVjdWxhdGVzT2JqZWN0LCBTcGVjdWxhdGVOdWxsT3JVbmRl ZmluZWQsCisgICAgICAgICAgICAgICAgICAgIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbikpOwog ICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQo KTsKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICB9CiAgICAgfQogICAgIAotICAgIGVu dW0gRXF1YWxOdWxsT3JVbmRlZmluZWRNb2RlIHsgRXF1YWxOdWxsLCBFcXVhbFVuZGVmaW5lZCwg RXF1YWxOdWxsT3JVbmRlZmluZWQgfTsKLSAgICB2b2lkIGVxdWFsTnVsbE9yVW5kZWZpbmVkKEVk Z2UgZWRnZSwgRXF1YWxOdWxsT3JVbmRlZmluZWRNb2RlIG1vZGUpCisgICAgZW51bSBTdHJpbmdP ck9iamVjdE1vZGUgeworICAgICAgICBBbGxDZWxsc0FyZUZhbHNlLAorICAgICAgICBDZWxsQ2Fz ZVNwZWN1bGF0ZXNPYmplY3QKKyAgICB9OworICAgIGVudW0gRXF1YWxOdWxsT3JVbmRlZmluZWRN b2RlIHsKKyAgICAgICAgRXF1YWxOdWxsLAorICAgICAgICBFcXVhbFVuZGVmaW5lZCwKKyAgICAg ICAgRXF1YWxOdWxsT3JVbmRlZmluZWQsCisgICAgICAgIFNwZWN1bGF0ZU51bGxPclVuZGVmaW5l ZAorICAgIH07CisgICAgTFZhbHVlIGVxdWFsTnVsbE9yVW5kZWZpbmVkKAorICAgICAgICBFZGdl IGVkZ2UsIFN0cmluZ09yT2JqZWN0TW9kZSBjZWxsTW9kZSwgRXF1YWxOdWxsT3JVbmRlZmluZWRN b2RlIHByaW1pdGl2ZU1vZGUsCisgICAgICAgIE9wZXJhbmRTcGVjdWxhdGlvbk1vZGUgb3BlcmFu ZE1vZGUgPSBBdXRvbWF0aWNPcGVyYW5kU3BlY3VsYXRpb24pCiAgICAgewogICAgICAgICBib29s IHZhbGlkV2F0Y2hwb2ludCA9IG1hc3F1ZXJhZGVzQXNVbmRlZmluZWRXYXRjaHBvaW50SXNTdGls bFZhbGlkKCk7CiAgICAgICAgIAotICAgICAgICBMVmFsdWUgdmFsdWUgPSBsb3dKU1ZhbHVlKGVk Z2UpOworICAgICAgICBMVmFsdWUgdmFsdWUgPSBsb3dKU1ZhbHVlKGVkZ2UsIG9wZXJhbmRNb2Rl KTsKICAgICAgICAgCi0gICAgICAgIExCYXNpY0Jsb2NrIGNlbGxDYXNlID0gRlRMX05FV19CTE9D SyhtX291dCwgKCJDb21wYXJlRXFDb25zdGFudCBjZWxsIGNhc2UiKSk7Ci0gICAgICAgIExCYXNp Y0Jsb2NrIHByaW1pdGl2ZUNhc2UgPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkNvbXBhcmVFcUNv bnN0YW50IHByaW1pdGl2ZSBjYXNlIikpOwotICAgICAgICBMQmFzaWNCbG9jayBjb250aW51YXRp b24gPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkNvbXBhcmVFcUNvbnN0YW50IGNvbnRpbnVhdGlv biIpKTsKKyAgICAgICAgTEJhc2ljQmxvY2sgY2VsbENhc2UgPSBGVExfTkVXX0JMT0NLKG1fb3V0 LCAoIkVxdWFsTnVsbE9yVW5kZWZpbmVkIGNlbGwgY2FzZSIpKTsKKyAgICAgICAgTEJhc2ljQmxv Y2sgcHJpbWl0aXZlQ2FzZSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiRXF1YWxOdWxsT3JVbmRl ZmluZWQgcHJpbWl0aXZlIGNhc2UiKSk7CisgICAgICAgIExCYXNpY0Jsb2NrIGNvbnRpbnVhdGlv biA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiRXF1YWxOdWxsT3JVbmRlZmluZWQgY29udGludWF0 aW9uIikpOwogICAgICAgICAKICAgICAgICAgbV9vdXQuYnJhbmNoKGlzTm90Q2VsbCh2YWx1ZSks IHByaW1pdGl2ZUNhc2UsIGNlbGxDYXNlKTsKICAgICAgICAgCkBAIC0xMTg2LDEyICsxMjA2LDI0 IEBAIHByaXZhdGU6CiAgICAgICAgIAogICAgICAgICBWZWN0b3I8VmFsdWVGcm9tQmxvY2ssIDM+ IHJlc3VsdHM7CiAgICAgICAgIAorICAgICAgICBzd2l0Y2ggKGNlbGxNb2RlKSB7CisgICAgICAg IGNhc2UgQWxsQ2VsbHNBcmVGYWxzZToKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNl IENlbGxDYXNlU3BlY3VsYXRlc09iamVjdDoKKyAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNLKAor ICAgICAgICAgICAgICAgIGpzVmFsdWVWYWx1ZSh2YWx1ZSksIGVkZ2UsICh+U3BlY0NlbGwpIHwg U3BlY09iamVjdCwKKyAgICAgICAgICAgICAgICBtX291dC5lcXVhbCgKKyAgICAgICAgICAgICAg ICAgICAgbV9vdXQubG9hZFB0cih2YWx1ZSwgbV9oZWFwcy5KU0NlbGxfc3RydWN0dXJlKSwKKyAg ICAgICAgICAgICAgICAgICAgbV9vdXQuY29uc3RJbnRQdHIodm0oKS5zdHJpbmdTdHJ1Y3R1cmUu Z2V0KCkpKSk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAgICAKICAgICAg ICAgaWYgKHZhbGlkV2F0Y2hwb2ludCkgewogICAgICAgICAgICAgcmVzdWx0cy5hcHBlbmQobV9v dXQuYW5jaG9yKG1fb3V0LmJvb2xlYW5GYWxzZSkpOwogICAgICAgICAgICAgbV9vdXQuanVtcChj b250aW51YXRpb24pOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgTEJhc2ljQmxvY2sg bWFzcXVlcmFkZXNDYXNlID0KLSAgICAgICAgICAgICAgICBGVExfTkVXX0JMT0NLKG1fb3V0LCAo IkNvbXBhcmVFcUNvbnN0YW50IG1hc3F1ZXJhZGVzIGNhc2UiKSk7CisgICAgICAgICAgICAgICAg RlRMX05FV19CTE9DSyhtX291dCwgKCJFcXVhbE51bGxPclVuZGVmaW5lZCBtYXNxdWVyYWRlcyBj YXNlIikpOwogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgTFZhbHVlIHN0cnVjdHVyZSA9 IG1fb3V0LmxvYWRQdHIodmFsdWUsIG1faGVhcHMuSlNDZWxsX3N0cnVjdHVyZSk7CiAgICAgICAg ICAgICAKQEAgLTEyMTUsNyArMTI0Nyw3IEBAIHByaXZhdGU6CiAgICAgICAgIG1fb3V0LmFwcGVu ZFRvKHByaW1pdGl2ZUNhc2UsIGNvbnRpbnVhdGlvbik7CiAgICAgICAgIAogICAgICAgICBMVmFs dWUgcHJpbWl0aXZlUmVzdWx0OwotICAgICAgICBzd2l0Y2ggKG1vZGUpIHsKKyAgICAgICAgc3dp dGNoIChwcmltaXRpdmVNb2RlKSB7CiAgICAgICAgIGNhc2UgRXF1YWxOdWxsOgogICAgICAgICAg ICAgcHJpbWl0aXZlUmVzdWx0ID0gbV9vdXQuZXF1YWwodmFsdWUsIG1fb3V0LmNvbnN0SW50NjQo VmFsdWVOdWxsKSk7CiAgICAgICAgICAgICBicmVhazsKQEAgLTEyMjcsMTMgKzEyNTksMjEgQEAg cHJpdmF0ZToKICAgICAgICAgICAgICAgICBtX291dC5iaXRBbmQodmFsdWUsIG1fb3V0LmNvbnN0 SW50NjQoflRhZ0JpdFVuZGVmaW5lZCkpLAogICAgICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50 NjQoVmFsdWVOdWxsKSk7CiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBTcGVjdWxh dGVOdWxsT3JVbmRlZmluZWQ6CisgICAgICAgICAgICBGVExfVFlQRV9DSEVDSygKKyAgICAgICAg ICAgICAgICBqc1ZhbHVlVmFsdWUodmFsdWUpLCBlZGdlLCBTcGVjQ2VsbCB8IFNwZWNPdGhlciwK KyAgICAgICAgICAgICAgICBtX291dC5ub3RFcXVhbCgKKyAgICAgICAgICAgICAgICAgICAgbV9v dXQuYml0QW5kKHZhbHVlLCBtX291dC5jb25zdEludDY0KH5UYWdCaXRVbmRlZmluZWQpKSwKKyAg ICAgICAgICAgICAgICAgICAgbV9vdXQuY29uc3RJbnQ2NChWYWx1ZU51bGwpKSk7CisgICAgICAg ICAgICBwcmltaXRpdmVSZXN1bHQgPSBtX291dC5ib29sZWFuVHJ1ZTsKKyAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICB9CiAgICAgICAgIHJlc3VsdHMuYXBwZW5kKG1fb3V0LmFuY2hvcihwcmlt aXRpdmVSZXN1bHQpKTsKICAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwogICAgICAg ICAKICAgICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7CiAgICAg ICAgIAotICAgICAgICBtX2Jvb2xlYW5WYWx1ZXMuYWRkKG1fbm9kZSwgbV9vdXQucGhpKG1fb3V0 LmJvb2xlYW4sIHJlc3VsdHMpKTsKKyAgICAgICAgcmV0dXJuIG1fb3V0LnBoaShtX291dC5ib29s ZWFuLCByZXN1bHRzKTsKICAgICB9CiAgICAgCiAgICAgdm9pZCBzcGVjdWxhdGVCYWNrd2FyZCgK