116603 2013-05-22 02:57:29 -0700 [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError 2013-05-23 07:14:36 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 1 cgarcia webkit-unassigned commit-queue rwlbuis xan.lopez oldest_to_newest 892201 0 cgarcia 2013-05-22 02:57:29 -0700 It's passing an empty error domain 892205 1 202513 cgarcia 2013-05-22 03:01:00 -0700 Created attachment 202513 Patch 892210 2 202513 xan.lopez 2013-05-22 03:23:38 -0700 Comment on attachment 202513 Patch To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog. 892726 3 cgarcia 2013-05-23 03:52:46 -0700 (In reply to comment #2) > (From update of attachment 202513 [details]) > To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog. This is an internal commit made by Rob, I think it's pretty obvious that we were passing an empty string to the Error and now we are passing a valid error domain. I guess he meant that this doesn't affect any test, because it simply provides a valid error domain, it's up to the api consumers to use that domain or not. 892840 4 202513 xan.lopez 2013-05-23 06:29:54 -0700 Comment on attachment 202513 Patch OK. I was a bit confused because I didn't get why we would put there a FIXME instead of putting whatever error domain fits better, was wondering if there was something more subtle at play here. 892856 5 202513 commit-queue 2013-05-23 07:14:33 -0700 Comment on attachment 202513 Patch Clearing flags on attachment: 202513 Committed r150585: <http://trac.webkit.org/changeset/150585> 892857 6 commit-queue 2013-05-23 07:14:36 -0700 All reviewed patches have been landed. Closing bug. 202513 2013-05-22 03:01:00 -0700 2013-05-23 07:14:32 -0700 Patch bb-error-domain.diff text/plain 1931 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDliYjEzN2UuLmY0MWFhOTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTIyICBS b2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFByb3Blcmx5 IGZpbGwgdGhlIFJlc291cmNlRXJyb3IgaW4gRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Ojpj YW5ub3RTaG93VVJMRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNjYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFBSIDExOTc4OQorICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IFlvbmcg TGkuCisKKyAgICAgICAgUHJvdmlkZSBhIGRvbWFpbiB2YWx1ZSBmb3IgdGhpcyBSZXNvdXJjZUVy cm9yIGluc3RhbmNlLiBOb3RlIHRoYXQKKyAgICAgICAgdGhpcyBkb2VzIG5vdCBjaGFuZ2UgYmVo YXZpb3IuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5 OjpkaWRSZXN0b3JlRnJvbVBhZ2VDYWNoZSk6CisKIDIwMTMtMDUtMjAgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBu b3QgdXNlIHNraWEgaW4gRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaERpZFJl Y2VpdmVJY29uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAK aW5kZXggMjI1ZWQ1Ni4uMDliZTNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeS5jcHAKQEAgLTEzMDcsOCArMTMwNyw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5Ojpwcm92aXNpb25hbExvYWRTdGFydGVkKCkKIC8vIFdlIGRvbid0IG5lZWQg dG8gcHJvdmlkZSB0aGUgZXJyb3IgbWVzc2FnZSBzdHJpbmcsIHRoYXQgd2lsbCBiZSBoYW5kbGVk IGluIEJyb3dzZXJFcnJvclBhZ2UgYWNjb3JkaW5nIHRvIHRoZSBlcnJvciBjb2RlLgogUmVzb3Vy Y2VFcnJvciBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNhbm5vdFNob3dVUkxFcnJvcihj b25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7Ci0gICAgLy8gRklYTUU6IFdoeSBhcmUg d2Ugbm90IHBhc3NpbmcgdGhlIGRvbWFpbiB0byB0aGUgUmVzb3VyY2VFcnJvcj8gU2VlIFBSICMx MTk3ODkuCi0gICAgcmV0dXJuIFJlc291cmNlRXJyb3IoU3RyaW5nKCksIFdlYktpdEVycm9yQ2Fu bm90U2hvd1VSTCwgcmVxdWVzdC51cmwoKS5zdHJpbmcoKSwgU3RyaW5nKCkpOworICAgIHJldHVy biBSZXNvdXJjZUVycm9yKCJXZWJLaXRFcnJvckRvbWFpbiIsIFdlYktpdEVycm9yQ2Fubm90U2hv d1VSTCwgcmVxdWVzdC51cmwoKS5zdHJpbmcoKSwgU3RyaW5nKCkpOwogfQogCiB2b2lkIEZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlkUmVzdG9yZUZyb21QYWdlQ2FjaGUoKQo=