116538 2013-05-21 08:16:37 -0700 JSC ARM Traditional asserting on SunSpider after r148893 2013-05-21 09:43:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 114963 1 rgabor mark.lam commit-queue mark.lam oliver ossy zherczeg oldest_to_newest 891772 0 rgabor 2013-05-21 08:16:37 -0700 JSC ARM Traditional asserting on SunSpider after r148893 ASSERTION FAILED: (cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero) /home/rgabor/WebKit/Source/JavaScriptCore/assembler/MacroAssemblerARM.h(718) : JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Jump JSC::MacroAssemblerARM::branchAdd32(JSC::MacroAssemblerARM::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::AbsoluteAddress) 891778 1 mark.lam 2013-05-21 08:28:35 -0700 Looks like a simple case of needing to add "|| (cond ==PositiveOrZero)" to the branchAdd32 asserts. Patch coming soon. 891790 2 202433 mark.lam 2013-05-21 08:42:09 -0700 Created attachment 202433 the patch 891831 3 202433 ggaren 2013-05-21 09:23:05 -0700 Comment on attachment 202433 the patch r=me 891844 4 202433 commit-queue 2013-05-21 09:43:36 -0700 Comment on attachment 202433 the patch Clearing flags on attachment: 202433 Committed r150449: <http://trac.webkit.org/changeset/150449> 891845 5 commit-queue 2013-05-21 09:43:37 -0700 All reviewed patches have been landed. Closing bug. 202433 2013-05-21 08:42:09 -0700 2013-05-21 09:43:36 -0700 the patch bug-116538.patch text/plain 3043 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUwNDQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTA1LTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGRlZCBtaXNzaW5nIGFzc2VydCBjb25kaXRpb24gZm9yIFBvc2l0aXZlT3JaZXJvIGluIEFSTSBi cmFuY2gzMigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE2NTM4LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAgICAgIChKU0M6Ok1hY3Jv QXNzZW1ibGVyQVJNOjpicmFuY2hBZGQzMik6CisKIDIwMTMtMDUtMjAgIE1hcmsgSGFobmVuYmVy ZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIFN1cGVyUmVnaW9u CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTS5oCShyZXZpc2lvbiAxNTA0NDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4NywzNSAr Njg3LDQwIEBAIHB1YmxpYzoKIAogICAgIEp1bXAgYnJhbmNoQWRkMzIoUmVzdWx0Q29uZGl0aW9u IGNvbmQsIFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAgICAgICBB U1NFUlQoKGNvbmQgPT0gT3ZlcmZsb3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0g WmVybykgfHwgKGNvbmQgPT0gTm9uWmVybykpOworICAgICAgICBBU1NFUlQoKGNvbmQgPT0gT3Zl cmZsb3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVybykKKyAgICAgICAgICAg IHx8IChjb25kID09IE5vblplcm8pIHx8IChjb25kID09IFBvc2l0aXZlT3JaZXJvKSk7CiAgICAg ICAgIGFkZDMyKHNyYywgZGVzdCk7CiAgICAgICAgIHJldHVybiBKdW1wKG1fYXNzZW1ibGVyLmpt cChBUk1Db25kaXRpb24oY29uZCkpKTsKICAgICB9CiAKICAgICBKdW1wIGJyYW5jaEFkZDMyKFJl c3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIG9wMSwgUmVnaXN0ZXJJRCBvcDIsIFJlZ2lz dGVySUQgZGVzdCkKICAgICB7Ci0gICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwg KGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7 CisgICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwgKGNvbmQgPT0gU2lnbmVkKSB8 fCAoY29uZCA9PSBaZXJvKQorICAgICAgICAgICAgfHwgKGNvbmQgPT0gTm9uWmVybykgfHwgKGNv bmQgPT0gUG9zaXRpdmVPclplcm8pKTsKICAgICAgICAgYWRkMzIob3AxLCBvcDIsIGRlc3QpOwog ICAgICAgICByZXR1cm4gSnVtcChtX2Fzc2VtYmxlci5qbXAoQVJNQ29uZGl0aW9uKGNvbmQpKSk7 CiAgICAgfQogCiAgICAgSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25kaXRpb24gY29uZCwgVHJ1 c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAgICAgICAgQVNTRVJUKChj b25kID09IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWduZWQpIHx8IChjb25kID09IFplcm8pIHx8 IChjb25kID09IE5vblplcm8pKTsKKyAgICAgICAgQVNTRVJUKChjb25kID09IE92ZXJmbG93KSB8 fCAoY29uZCA9PSBTaWduZWQpIHx8IChjb25kID09IFplcm8pCisgICAgICAgICAgICB8fCAoY29u ZCA9PSBOb25aZXJvKSB8fCAoY29uZCA9PSBQb3NpdGl2ZU9yWmVybykpOwogICAgICAgICBhZGQz MihpbW0sIGRlc3QpOwogICAgICAgICByZXR1cm4gSnVtcChtX2Fzc2VtYmxlci5qbXAoQVJNQ29u ZGl0aW9uKGNvbmQpKSk7CiAgICAgfQogCiAgICAgSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25k aXRpb24gY29uZCwgUmVnaXN0ZXJJRCBzcmMsIFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQg ZGVzdCkKICAgICB7Ci0gICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwgKGNvbmQg PT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7CisgICAg ICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwgKGNvbmQgPT0gU2lnbmVkKSB8fCAoY29u ZCA9PSBaZXJvKQorICAgICAgICAgICAgfHwgKGNvbmQgPT0gTm9uWmVybykgfHwgKGNvbmQgPT0g UG9zaXRpdmVPclplcm8pKTsKICAgICAgICAgYWRkMzIoc3JjLCBpbW0sIGRlc3QpOwogICAgICAg ICByZXR1cm4gSnVtcChtX2Fzc2VtYmxlci5qbXAoQVJNQ29uZGl0aW9uKGNvbmQpKSk7CiAgICAg fQogCiAgICAgSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25kaXRpb24gY29uZCwgVHJ1c3RlZElt bTMyIGltbSwgQWJzb2x1dGVBZGRyZXNzIGRlc3QpCiAgICAgewotICAgICAgICBBU1NFUlQoKGNv bmQgPT0gT3ZlcmZsb3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVybykgfHwg KGNvbmQgPT0gTm9uWmVybykpOworICAgICAgICBBU1NFUlQoKGNvbmQgPT0gT3ZlcmZsb3cpIHx8 IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVybykKKyAgICAgICAgICAgIHx8IChjb25k ID09IE5vblplcm8pIHx8IChjb25kID09IFBvc2l0aXZlT3JaZXJvKSk7CiAgICAgICAgIGFkZDMy KGltbSwgZGVzdCk7CiAgICAgICAgIHJldHVybiBKdW1wKG1fYXNzZW1ibGVyLmptcChBUk1Db25k aXRpb24oY29uZCkpKTsKICAgICB9Cg==