116343 2013-05-17 12:47:16 -0700 Get rid of Custom code for Audio global constructor 2013-05-17 17:15:51 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116116 116147 115853 1 cdumez cdumez benjamin commit-queue eric.carlson esprehn+autocc ggaren glenn haraken jer.noble laszlo.gombos rniwa oldest_to_newest 890597 0 cdumez 2013-05-17 12:47:16 -0700 The following DOMWindow attribute currently has a [CustomGetter]: [CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementNamedConstructor Audio; // Usable with the new operator This should no longer be needed now that Bug 116116 and Bug 116147 were fixed. 890639 1 202149 cdumez 2013-05-17 13:38:09 -0700 Created attachment 202149 Patch 890640 2 202150 cdumez 2013-05-17 13:38:32 -0700 Created attachment 202150 JSDOMWindow.cpp diff 890665 3 202149 ggaren 2013-05-17 14:09:58 -0700 Comment on attachment 202149 Patch r=me 890743 4 202149 commit-queue 2013-05-17 17:15:48 -0700 Comment on attachment 202149 Patch Clearing flags on attachment: 202149 Committed r150311: <http://trac.webkit.org/changeset/150311> 890744 5 commit-queue 2013-05-17 17:15:51 -0700 All reviewed patches have been landed. Closing bug. 202149 2013-05-17 13:38:09 -0700 2013-05-17 17:15:48 -0700 Patch 116343_Audio_CustomCode.patch text/plain 2927 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMjFkNWI3Li4wOTZkZGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDUtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIEdldCByaWQgb2YgQ3VzdG9tIGNvZGUgZm9yIEF1ZGlvIGdsb2JhbCBj b25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE2MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGN1c3RvbSBjb2RlIGZvciBBdWRpbyBnbG9iYWwgY29uc3RydWN0b3IuIEl0IGlz IG5vIGxvbmdlciBuZWVkZWQKKyAgICAgICAgbm93IHRoYXQgdGhlIHRoZSBiaW5kaW5ncyBnZW5l cmF0b3Igbm8gbG9uZ2VyIHJlcXVpcmUgY3VzdG9tIGNvZGUgZm9yCisgICAgICAgIG5hbWVkIGNv bnN0cnVjdG9ycyBhbmQgbm93IHRoYXQgW0VuYWJsZWRBdFJ1bnRpbWVdIGV4dGVuZGVkIGF0dHJp YnV0ZSBpcworICAgICAgICBzdXBwb3J0ZWQgZm9yIGdsb2JhbCBjb25zdHJ1Y3RvcnMuCisKKyAg ICAgICAgSFRNTEF1ZGlvRWxlbWVudCBnbG9iYWwgY29uc3RydWN0b3JzIGFyZSBub3cgYXV0b21h dGljYWxseSBnZW5lcmF0ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBj aGFuZ2UgZm9yIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2lu ZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKiBodG1sL0hUTUxBdWRpb0VsZW1lbnQuaWRsOgorICAg ICAgICAqIHBhZ2UvRE9NV2luZG93LmlkbDoKKwogMjAxMy0wNS0xNyAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKaW5kZXggOTRmYWU3NS4u OWIyZTU0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5k b3dDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 Q3VzdG9tLmNwcApAQCAtNTMzLDE1ICs1MzMsNiBAQCBKU1ZhbHVlIEpTRE9NV2luZG93OjppbWFn ZShFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CiAgICAgcmV0dXJuIGdldERPTUNvbnN0cnVjdG9yPEpT SW1hZ2VDb25zdHJ1Y3Rvcj4oZXhlYywgdGhpcyk7CiB9CiAKLSNpZiBFTkFCTEUoVklERU8pCi1K U1ZhbHVlIEpTRE9NV2luZG93OjphdWRpbyhFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0Ci17Ci0gICAg aWYgKCFNZWRpYVBsYXllcjo6aXNBdmFpbGFibGUoKSkKLSAgICAgICAgcmV0dXJuIGpzVW5kZWZp bmVkKCk7Ci0gICAgcmV0dXJuIGdldERPTUNvbnN0cnVjdG9yPEpTSFRNTEF1ZGlvRWxlbWVudE5h bWVkQ29uc3RydWN0b3I+KGV4ZWMsIHRoaXMpOwotfQotI2VuZGlmCi0KIC8vIEN1c3RvbSBmdW5j dGlvbnMKIAogSlNWYWx1ZSBKU0RPTVdpbmRvdzo6b3BlbihFeGVjU3RhdGUqIGV4ZWMpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdWRpb0VsZW1lbnQuaWRsIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQXVkaW9FbGVtZW50LmlkbAppbmRleCAwZDhjZjk0Li40Njg1YWM5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdWRpb0VsZW1lbnQuaWRsCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF1ZGlvRWxlbWVudC5pZGwKQEAgLTI0LDcgKzI0 LDcgQEAKICAqLwogCiBbCi0gICAgTm9JbnRlcmZhY2VPYmplY3QsCisgICAgRW5hYmxlZEF0UnVu dGltZSwKICAgICBDb25kaXRpb25hbD1WSURFTywKICAgICBOYW1lZENvbnN0cnVjdG9yPUF1ZGlv KFtEZWZhdWx0PU51bGxTdHJpbmddIG9wdGlvbmFsIERPTVN0cmluZyBzcmMpCiBdIGludGVyZmFj ZSBIVE1MQXVkaW9FbGVtZW50IDogSFRNTE1lZGlhRWxlbWVudCB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdp bmRvdy5pZGwKaW5kZXggYjBiMDBmMy4uNzIxZTIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93 LmlkbApAQCAtMzIyLDggKzMyMiw2IEBACiAjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBU KSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBUCiAgICAgLy8gQWRkaXRpb25hbCBjb25zdHJ1Y3RvcnMu CiAgICAgW0N1c3RvbUdldHRlciwgQ3VzdG9tQ29uc3RydWN0b3JdIGF0dHJpYnV0ZSBIVE1MSW1h Z2VFbGVtZW50TmFtZWRDb25zdHJ1Y3RvciBJbWFnZTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJh dG9yCi0gICAgW0N1c3RvbUdldHRlciwgQ29uZGl0aW9uYWw9VklERU9dIGF0dHJpYnV0ZSBIVE1M QXVkaW9FbGVtZW50TmFtZWRDb25zdHJ1Y3RvciBBdWRpbzsgLy8gVXNhYmxlIHdpdGggdGhlIG5l dyBvcGVyYXRvcgotICAgIFtDb25kaXRpb25hbD1WSURFT10gYXR0cmlidXRlIEhUTUxBdWRpb0Vs ZW1lbnRDb25zdHJ1Y3RvciBIVE1MQXVkaW9FbGVtZW50OwogICAgIC8vIE1vemlsbGEgaGFzIGEg c2VwYXJhdGUgWE1MRG9jdW1lbnQgb2JqZWN0IGZvciBYTUwgZG9jdW1lbnRzLgogICAgIC8vIFdl IGp1c3QgdXNlIERvY3VtZW50IGZvciB0aGlzLgogICAgIGF0dHJpYnV0ZSBEb2N1bWVudENvbnN0 cnVjdG9yIFhNTERvY3VtZW50Owo= 202150 2013-05-17 13:38:32 -0700 2013-05-17 13:38:32 -0700 JSDOMWindow.cpp diff JSDOMWindow.cpp.diff text/plain 1139 cdumez LS0tIFdlYktpdEJ1aWxkL0RlYnVnL0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNET01XaW5kb3cu Y3BwLmJhawkyMDEzLTA1LTE3IDIyOjM4OjE2LjA2NjMyMzUwMCArMDMwMAorKysgV2ViS2l0QnVp bGQvRGVidWcvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU0RPTVdpbmRvdy5jcHAJMjAxMy0wNS0x NyAyMjozMToxOC4yODYzMTIzMTMgKzAzMDAKQEAgLTc4MDEsNiArNzgwMSw4IEBACiAjaWYgRU5B QkxFKFZJREVPKQogSlNWYWx1ZSBqc0RPTVdpbmRvd0hUTUxBdWRpb0VsZW1lbnRDb25zdHJ1Y3Rv cihFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgc2xvdEJhc2UsIFByb3BlcnR5TmFtZSkKIHsKKyAg ICBpZiAoIVJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6Omh0bWxBdWRpb0VsZW1lbnRFbmFibGVkKCkp CisgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwogICAgIEpTRE9NV2luZG93KiBjYXN0ZWRU aGlzID0ganNDYXN0PEpTRE9NV2luZG93Kj4oYXNPYmplY3Qoc2xvdEJhc2UpKTsKICAgICBpZiAo IUJpbmRpbmdTZWN1cml0eTo6c2hvdWxkQWxsb3dBY2Nlc3NUb0RPTVdpbmRvdyhleGVjLCBjYXN0 ZWRUaGlzLT5pbXBsKCkpKQogICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKQEAgLTc4MTIs MTAgKzc4MTQsMTIgQEAKICNpZiBFTkFCTEUoVklERU8pCiBKU1ZhbHVlIGpzRE9NV2luZG93QXVk aW9Db25zdHJ1Y3RvcihFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgc2xvdEJhc2UsIFByb3BlcnR5 TmFtZSkKIHsKKyAgICBpZiAoIVJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmF1ZGlvRW5hYmxlZCgp KQorICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKICAgICBKU0RPTVdpbmRvdyogY2FzdGVk VGhpcyA9IGpzQ2FzdDxKU0RPTVdpbmRvdyo+KGFzT2JqZWN0KHNsb3RCYXNlKSk7CiAgICAgaWYg KCFCaW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3coZXhlYywgY2Fz dGVkVGhpcy0+aW1wbCgpKSkKICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0gICAgcmV0 dXJuIGNhc3RlZFRoaXMtPmF1ZGlvKGV4ZWMpOworICAgIHJldHVybiBKU0hUTUxBdWRpb0VsZW1l bnQ6OmdldE5hbWVkQ29uc3RydWN0b3IoZXhlYywgY2FzdGVkVGhpcyk7CiB9CiAKICNlbmRpZgo=