116310 2013-05-17 06:30:26 -0700 [CSSRegions] Constrain auto-height region computation in a different way 2013-05-21 01:01:59 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea mihnea achicu commit-queue esprehn+autocc glenn WebkitBugTracker oldest_to_newest 890331 0 mihnea 2013-05-17 06:30:26 -0700 After https://bugs.webkit.org/show_bug.cgi?id=74132, the region is a render block. We can use RenderBox::constrainContentBoxLogicalHeightByMinMax instead of RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight. 890336 1 202077 mihnea 2013-05-17 06:37:33 -0700 Created attachment 202077 Patch 890420 2 202077 achicu 2013-05-17 09:05:27 -0700 Comment on attachment 202077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review Looks good. Please, add a separate bug to track the other issue. > Source/WebCore/ChangeLog:10 > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height. 891603 3 mihnea 2013-05-21 00:10:34 -0700 (In reply to comment #2) > (From update of attachment 202077 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review > > Looks good. Please, add a separate bug to track the other issue. > > > Source/WebCore/ChangeLog:10 > > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. > > We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height. Added bug: https://bugs.webkit.org/show_bug.cgi?id=116518 to track this issue. 891605 4 202387 mihnea 2013-05-21 00:26:57 -0700 Created attachment 202387 Patch for landing 891629 5 commit-queue 2013-05-21 01:00:34 -0700 The commit-queue encountered the following flaky tests while processing attachment 202387: media/track/track-remove-crash.html bug 115892 (author: eric.carlson@apple.com) svg/batik/text/textFeatures.svg bug 116326 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textLength.svg bug 116329 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textEffect3.svg bug 116521 (authors: darin@apple.com and zimmermann@kde.org) compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) editing/inserting/typing-at-end-of-line.html bug 116486 (author: enrica@apple.com) The commit-queue is continuing to process your patch. 891631 6 202387 commit-queue 2013-05-21 01:01:56 -0700 Comment on attachment 202387 Patch for landing Clearing flags on attachment: 202387 Committed r150427: <http://trac.webkit.org/changeset/150427> 891632 7 commit-queue 2013-05-21 01:01:59 -0700 All reviewed patches have been landed. Closing bug. 202077 2013-05-17 06:37:33 -0700 2013-05-21 00:26:43 -0700 Patch 116310.patch text/plain 2239 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjBhYzQ5Li4xYTE3YzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDUtMTcgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIENvbnN0cmFpbiBhdXRvLWhlaWdodCByZWdpb24gY29tcHV0YXRp b24gaW4gYSBkaWZmZXJlbnQgd2F5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTYzMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzQxMzIsIHRoZSByZWdpb24gaXMgYSByZW5kZXIgYmxvY2suIFdlIGNhbiB1c2UgUmVuZGVy Qm94Ojpjb25zdHJhaW5Db250ZW50Qm94TG9naWNhbEhlaWdodEJ5TWluTWF4CisgICAgICAgIGlu c3RlYWQgb2YgUmVuZGVyQm94Ojpjb21wdXRlUmVwbGFjZWRMb2dpY2FsSGVpZ2h0UmVzcGVjdGlu Z01pbk1heEhlaWdodCB0byBiZXR0ZXIgcmVmbGVjdCB0aGUgZmFjdCB0aGF0IHRoZSByZWdpb24g aXMgbm90IGEgcmVwbGFjZWQgZWxlbWVudC4KKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyBy ZWdpb25zIHRlc3RzLCBzaW5jZSB3aGVuIHJlcGxhY2VkLWJhc2VkIHRoZSByZWdpb24gaGFkIGFu IGludHJpbnNpYyBoZWlnaHQgb2YgMCBhbmQgbm93LCBibG9jay1iYXNlZCwgaXQgZG9lcyBub3Qg aGF2ZSBhbnkgY2hpbGRyZW4uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVh ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFkOjphZGRGb3JjZWRSZWdp b25CcmVhayk6CisKIDIwMTMtMDUtMTYgIEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5w YWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEFkZCBzdHVicyBmb3IgQ29udGV4dE1l bnUgYW5kIENvbnRleHRNZW51SXRlbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsb3dUaHJlYWQuY3BwCmluZGV4IGM2YzA2N2IuLjQ4YzdlNDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKQEAgLTg5MCw4ICs4OTAsOCBAQCBi b29sIFJlbmRlckZsb3dUaHJlYWQ6OmFkZEZvcmNlZFJlZ2lvbkJyZWFrKExheW91dFVuaXQgb2Zm c2V0QnJlYWtJbkZsb3dUaHJlYWQsCiAgICAgICAgIG92ZXJyaWRlTG9naWNhbENvbnRlbnRIZWln aHRDb21wdXRlZCA9IHRydWU7CiAKICAgICAgICAgLy8gQ29tcHV0ZSB0aGUgcmVnaW9uIGhlaWdo dCBwcmV0ZW5kaW5nIHRoYXQgdGhlIG9mZnNldEJyZWFrSW5DdXJyZW50UmVnaW9uIGlzIHRoZSBs b2dpY2FsSGVpZ2h0IGZvciB0aGUgYXV0by1oZWlnaHQgcmVnaW9uLgotICAgICAgICBMYXlvdXRV bml0IHJlZ2lvbk92ZXJyaWRlTG9naWNhbENvbnRlbnRIZWlnaHQgPSByZWdpb24tPmNvbXB1dGVS ZXBsYWNlZExvZ2ljYWxIZWlnaHRSZXNwZWN0aW5nTWluTWF4SGVpZ2h0KG9mZnNldEJyZWFrSW5D dXJyZW50UmVnaW9uKTsKLQorICAgICAgICBMYXlvdXRVbml0IHJlZ2lvbk92ZXJyaWRlTG9naWNh bENvbnRlbnRIZWlnaHQgPSByZWdpb24tPmNvbnN0cmFpbkNvbnRlbnRCb3hMb2dpY2FsSGVpZ2h0 QnlNaW5NYXgob2Zmc2V0QnJlYWtJbkN1cnJlbnRSZWdpb24pOworICAgICAgICAKICAgICAgICAg Ly8gVGhlIG5ldyBoZWlnaHQgb2YgdGhpcyByZWdpb24gbmVlZHMgdG8gYmUgc21hbGxlciB0aGFu IHRoZSBpbml0aWFsIHZhbHVlLCB0aGUgbWF4IGhlaWdodC4gQSBmb3JjZWQgYnJlYWsgaXMgdGhl IG9ubHkgd2F5IHRvIGNoYW5nZSB0aGUgaW5pdGlhbAogICAgICAgICAvLyBoZWlnaHQgb2YgYW4g YXV0by1oZWlnaHQgcmVnaW9uIGJlc2lkZXMgY29udGVudCBlbmRpbmcuCiAgICAgICAgIEFTU0VS VChyZWdpb25PdmVycmlkZUxvZ2ljYWxDb250ZW50SGVpZ2h0IDw9IHJlZ2lvbi0+bWF4UGFnZUxv Z2ljYWxIZWlnaHQoKSk7Cg== 202387 2013-05-21 00:26:57 -0700 2013-05-21 01:01:56 -0700 Patch for landing bug-116310-20130521102546.patch text/plain 2413 mihnea U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI1ZDhhM2QwZjAwZGFm NjFiNTUxNmIxOGE3YTY2NDIyMTY1MWQxMi4uMTI2MDc4NDhhZjk3YmVlZjc2OGE3NTk4YmRkMWIy MGUxZTI4NDM4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTIxICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1NSZWdpb25zXSBD b25zdHJhaW4gYXV0by1oZWlnaHQgcmVnaW9uIGNvbXB1dGF0aW9uIGluIGEgZGlmZmVyZW50IHdh eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MzEw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGFuZHJ1IENoaWN1bGl0YS4KKworICAgICAgICBB ZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQxMzIsIHRoZSBy ZWdpb24gaXMgYSByZW5kZXIgYmxvY2suIFdlIGNhbiB1c2UgUmVuZGVyQm94Ojpjb25zdHJhaW5D b250ZW50Qm94TG9naWNhbEhlaWdodEJ5TWluTWF4CisgICAgICAgIGluc3RlYWQgb2YgUmVuZGVy Qm94Ojpjb21wdXRlUmVwbGFjZWRMb2dpY2FsSGVpZ2h0UmVzcGVjdGluZ01pbk1heEhlaWdodCB0 byBiZXR0ZXIgcmVmbGVjdCB0aGUgZmFjdCB0aGF0IHRoZSByZWdpb24gaXMgbm90IGEgcmVwbGFj ZWQgZWxlbWVudC4KKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyByZWdpb25zIHRlc3RzLCBz aW5jZSB3aGVuIHJlcGxhY2VkLWJhc2VkIHRoZSByZWdpb24gaGFkIGFuIGludHJpbnNpYyBoZWln aHQgb2YgMCBhbmQgbm93LCBibG9jay1iYXNlZCwgaXQgZG9lcyBub3QgaGF2ZSBhbnkgY2hpbGRy ZW4uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFkOjphZGRGb3JjZWRSZWdpb25CcmVhayk6CisKIDIw MTMtMDUtMjAgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIEZpeCBjb25jYXRlbmF0aW9ucyBvZiBzdHJpbmcgbGl0ZXJhbHMgdGhhdCBhcmUgbm90 IEMrKzExLWNvbXBsaWFudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dU aHJlYWQuY3BwCmluZGV4IGM2Mjg2MGQ3MTVjYjk5MmJlMjQ4NzFhZDFmMWZkNDAzZGNmZDlhZmUu LjI0MzZiMDY1ZDY0ZjU4MWYyNGU1ODhlMGUyOTZhZmNkNGU1ZGQ3ZmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKQEAgLTk3Miw4ICs5NzIsOCBA QCBib29sIFJlbmRlckZsb3dUaHJlYWQ6OmFkZEZvcmNlZFJlZ2lvbkJyZWFrKExheW91dFVuaXQg b2Zmc2V0QnJlYWtJbkZsb3dUaHJlYWQsCiAgICAgICAgIG92ZXJyaWRlTG9naWNhbENvbnRlbnRI ZWlnaHRDb21wdXRlZCA9IHRydWU7CiAKICAgICAgICAgLy8gQ29tcHV0ZSB0aGUgcmVnaW9uIGhl aWdodCBwcmV0ZW5kaW5nIHRoYXQgdGhlIG9mZnNldEJyZWFrSW5DdXJyZW50UmVnaW9uIGlzIHRo ZSBsb2dpY2FsSGVpZ2h0IGZvciB0aGUgYXV0by1oZWlnaHQgcmVnaW9uLgotICAgICAgICBMYXlv dXRVbml0IHJlZ2lvbk92ZXJyaWRlTG9naWNhbENvbnRlbnRIZWlnaHQgPSByZWdpb24tPmNvbXB1 dGVSZXBsYWNlZExvZ2ljYWxIZWlnaHRSZXNwZWN0aW5nTWluTWF4SGVpZ2h0KG9mZnNldEJyZWFr SW5DdXJyZW50UmVnaW9uKTsKLQorICAgICAgICBMYXlvdXRVbml0IHJlZ2lvbk92ZXJyaWRlTG9n aWNhbENvbnRlbnRIZWlnaHQgPSByZWdpb24tPmNvbnN0cmFpbkNvbnRlbnRCb3hMb2dpY2FsSGVp Z2h0QnlNaW5NYXgob2Zmc2V0QnJlYWtJbkN1cnJlbnRSZWdpb24pOworICAgICAgICAKICAgICAg ICAgLy8gVGhlIG5ldyBoZWlnaHQgb2YgdGhpcyByZWdpb24gbmVlZHMgdG8gYmUgc21hbGxlciB0 aGFuIHRoZSBpbml0aWFsIHZhbHVlLCB0aGUgbWF4IGhlaWdodC4gQSBmb3JjZWQgYnJlYWsgaXMg dGhlIG9ubHkgd2F5IHRvIGNoYW5nZSB0aGUgaW5pdGlhbAogICAgICAgICAvLyBoZWlnaHQgb2Yg YW4gYXV0by1oZWlnaHQgcmVnaW9uIGJlc2lkZXMgY29udGVudCBlbmRpbmcuCiAgICAgICAgIEFT U0VSVChyZWdpb25PdmVycmlkZUxvZ2ljYWxDb250ZW50SGVpZ2h0IDw9IHJlZ2lvbi0+bWF4UGFn ZUxvZ2ljYWxIZWlnaHQoKSk7Cg==