116160 2013-05-15 09:35:37 -0700 [CSS Shapes] LineSegment logicalLeft and logicalRight members should be floats 2014-04-03 15:35:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 1 giles_joplin giles_joplin commit-queue esprehn+autocc glenn kondapallykalyan zoltan oldest_to_newest 889345 0 giles_joplin 2013-05-15 09:35:37 -0700 The type of LineSegment logicalLeft and logicalRight edges should not have been changed to LayoutUnit. They should be floats because all of the RenderBlockLineLayout calculations are based on floats for left,right values (vertical values are LayoutUnits). The mistake was pointed out and corrected in Blink, here: https://chromiumcodereview.appspot.com/14892005#msg6 997223 1 228519 zoltan 2014-04-03 10:47:48 -0700 Created attachment 228519 Patch 997321 2 228519 kling 2014-04-03 15:03:43 -0700 Comment on attachment 228519 Patch rs=me 997332 3 228519 commit-queue 2014-04-03 15:35:01 -0700 Comment on attachment 228519 Patch Clearing flags on attachment: 228519 Committed r166747: <http://trac.webkit.org/changeset/166747> 997333 4 commit-queue 2014-04-03 15:35:04 -0700 All reviewed patches have been landed. Closing bug. 228519 2014-04-03 10:47:48 -0700 2014-04-03 15:35:00 -0700 Patch linesegmenttofloats.patch text/plain 1214 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxM2NhMDVlLi45NGNkY2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDQtMDMgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIExpbmVTZWdtZW50IGxvZ2ljYWxMZWZ0IGFuZCBsb2dpY2FsUmln aHQgbWVtYmVycyBzaG91bGQgYmUgZmxvYXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4gCisKKyAgICAgICAgTGluZVNlZ21lbnQgZWRnZXMgc2hvdWxkIG5vdCBoYXZlIGJl ZW4gY2hhbmdlZCB0byBMYXlvdXRVbml0LiBUaGVzZSBhcmUKKyAgICAgICAgdXNlZCBvbmx5IGFz IGZsb2F0cy4gSSBtb2RpZmllZCB0aGVtIGJhY2sgdG8gZmxvYXRzLiAKKworICAgICAgICBObyBu ZXcgdGVzdHMgYXJlIG5lZWRlZCwgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVu ZGVyaW5nL3NoYXBlcy9TaGFwZS5oOgorCiAyMDE0LTA0LTAzICBBbmRyZWkgQnVjdXIgIDxhYnVj dXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gSW5jbHVkZSByZWdpb24gcmFu Z2UgaW5mb3JtYXRpb24gd2hlbiBwcmludGluZyB0aGUgcmVuZGVyIHRyZWUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvU2hhcGUuaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zaGFwZXMvU2hhcGUuaAppbmRleCBlMDg1NzRhLi40ZGIxMmRlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1NoYXBlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZS5oCkBAIC00OCw4ICs0OCw4IEBAIHN0cnVj dCBMaW5lU2VnbWVudCB7CiAgICAgewogICAgIH0KIAotICAgIExheW91dFVuaXQgbG9naWNhbExl ZnQ7Ci0gICAgTGF5b3V0VW5pdCBsb2dpY2FsUmlnaHQ7CisgICAgZmxvYXQgbG9naWNhbExlZnQ7 CisgICAgZmxvYXQgbG9naWNhbFJpZ2h0OwogfTsKIAogdHlwZWRlZiBWZWN0b3I8TGluZVNlZ21l bnQ+IFNlZ21lbnRMaXN0Owo=