116115 2013-05-14 12:09:31 -0700 [CSS Exclusions] Some layout tests fail to account for inline pixel snapping 2013-05-14 19:17:20 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115292 1 giles_joplin giles_joplin commit-queue oldest_to_newest 888967 0 giles_joplin 2013-05-14 12:09:31 -0700 Inline layout snaps boxes' logical top and bottom to pixels and line segment layout rounds the logical left and floors the logical right of segments. The following exclusions tests did not take this into account: shape-inside/shape-inside-polygon-layout.html shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html shape-outside-floats/shape-outside-floats-ellipse-margin-left.html shape-outside-floats/shape-outside-floats-ellipse-margin-right.html This patch reflects changes included in https://code.google.com/p/chromium/issues/detail?id=237568 889036 1 201762 giles_joplin 2013-05-14 14:51:29 -0700 Created attachment 201762 Patch 889057 2 201762 krit 2013-05-14 16:17:36 -0700 Comment on attachment 201762 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201762&action=review r=me. > LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:73 > + return String( Math.floor(f) ); I don not really like the spaces, but do not care that much about them. 889093 3 201762 commit-queue 2013-05-14 19:17:19 -0700 Comment on attachment 201762 Patch Clearing flags on attachment: 201762 Committed r150097: <http://trac.webkit.org/changeset/150097> 889094 4 commit-queue 2013-05-14 19:17:20 -0700 All reviewed patches have been landed. Closing bug. 201762 2013-05-14 14:51:29 -0700 2013-05-14 19:17:19 -0700 Patch tmp.patch text/plain 7273 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3Y2M0Y2JkLi4xMDljNTY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMDUt MTQgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBFeGNs dXNpb25zXSBTb21lIGxheW91dCB0ZXN0cyBmYWlsIHRvIGFjY291bnQgZm9yIGlubGluZSBwaXhl bCBzbmFwcGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE2MTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRqdXN0IHRoZSBleHBlY3RlZCBsb2NhdGlvbnMgb2Ygc3BhbnMgdG8gYWNjb3VudCBmb3Ig dGhlIGZhY3QgdGhhdCBpbmxpbmUgbGF5b3V0IHNuYXBzIGJveGVzJyBsb2dpY2FsIHRvcAorICAg ICAgICBhbmQgYm90dG9tIHRvIHBpeGVscywgYW5kIHRoZSBmYWN0IHRoYXQgbGluZSBzZWdtZW50 IGxheW91dCByb3VuZHMgdGhlIGxvZ2ljYWwgbGVmdCBhbmQgZmxvb3JzIHRoZSBsb2dpY2FsCisg ICAgICAgIHJpZ2h0IG9mIHNlZ21lbnRzLgorCisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3No YXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1sYXlvdXQuaHRtbDogVXNlIHRoZSBxdWll dCB2YXJpYWJsZSEKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9h dHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZGlhbW9uZC1tYXJnaW4tcG9seWdvbi1leHBlY3RlZC50 eHQ6CisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtZmxvYXRzLWRpYW1vbmQtbWFyZ2luLXBvbHlnb24uaHRtbDoKKyAgICAgICAgKiBm YXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMt ZWxsaXBzZS1tYXJnaW4tbGVmdC5odG1sOgorICAgICAgICAqIGZhc3QvZXhjbHVzaW9ucy9zaGFw ZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1lbGxpcHNlLW1hcmdpbi1yaWdo dC5odG1sOgorCiAyMDEzLTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJlbW92aW5nIEF0dHIgY2FuIGRlbGV0ZSBhIHdyb25nIEF0dHJpYnV0ZSBpbiBF bGVtZW50RGF0YQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBl LWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1sYXlvdXQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHlnb24tbGF5b3V0Lmh0 bWwKaW5kZXggOTQ1ZWI3Ni4uYzdmNjRmZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9l eGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1sYXlvdXQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lk ZS1wb2x5Z29uLWxheW91dC5odG1sCkBAIC01MSw3ICs1MSw4IEBACiAgIC8vIFRoZSB0b3Agb2Yg dGhlIHBvbHlnb24gaXMgYSBob3J6b250YWwgZWRnZSBhdCB5PTEuNDIlLCBhbmQgaXRzIHBhcmVu dCdzIGhlaWdodCBpcyA1MDBweC4gIFRoZSB0b3Agb2YKICAgLy8gdGhlIGZpcnN0IGxpbmUsIHNw YW4gImEiLCB3aWxsIGFsaWduIHdpdGggdGhlIHRvcCBvZiB0aGUgcG9seWdvbi4gVGhlIEV4Y2x1 c2lvblNoYXBlOjpmaXJzdEluY2x1ZGVkSW50ZXJ2YWxMb2dpY2FsVG9wKCkKICAgLy8gbWV0aG9k cyB1c2UgY2VpbGVkTGF5b3V0VW5pdCgpIHRvIGVuc3VyZSB0aGF0IHRoZWlyIHJldHVybiB2YWx1 ZSBpcyB3aXRoaW4gdGhlIHNoYXBlLgotICB2YXIgbGluZUFUb3AgPSBTdWJQaXhlbExheW91dC5j ZWlsU25hcFRvTGF5b3V0VW5pdCguMDE0MiAqIDUwMCk7CisKKyAgdmFyIGxpbmVBVG9wID0gTWF0 aC5mbG9vcihTdWJQaXhlbExheW91dC5jZWlsU25hcFRvTGF5b3V0VW5pdCguMDE0MiAqIDUwMCkp OyAKIAogICAvLyBWZXJpZnkgdGhhdCBhbGwgZm91ciBvbmUtY2hhcmFjdGVyIGxpbmVzIGFyZSB2 ZXJ0aWNhbGx5IGFkamFjZW50IGFuZCAxNSBwaXhlbHMgaGlnaC4KICAgdmFyIHF1aWV0ID0gdHJ1 ZTsgLy8gUEFTUyBvdXRwdXQgZGVwZW5kcyBvbiBTdWJQaXhlbExheW91dC5pc0VuYWJsZWQoKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxv YXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWRpYW1vbmQtbWFyZ2luLXBvbHlnb24tZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3No YXBlLW91dHNpZGUtZmxvYXRzLWRpYW1vbmQtbWFyZ2luLXBvbHlnb24tZXhwZWN0ZWQudHh0Cmlu ZGV4IGUzNWE0MGMuLmIzN2I3NDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVz aW9ucy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1kaWFtb25kLW1h cmdpbi1wb2x5Z29uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lv bnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZGlhbW9uZC1tYXJn aW4tcG9seWdvbi1leHBlY3RlZC50eHQKQEAgLTYsMTUgKzYsOSBAQCBYCiBYCiBYCiBQQVNTIGVs ZW1lbnRSZWN0KCdsMScpLnRvcCBpcyAwCi1QQVNTIGVsZW1lbnRSZWN0KCdsMScpLmxlZnQgaXMg d2l0aGluIDEgb2YgOTgKIFBBU1MgZWxlbWVudFJlY3QoJ2wyJykudG9wIGlzIDIwCi1QQVNTIGVs ZW1lbnRSZWN0KCdsMicpLmxlZnQgaXMgd2l0aGluIDEgb2YgMTE4CiBQQVNTIGVsZW1lbnRSZWN0 KCdsMycpLnRvcCBpcyA0MAotUEFTUyBlbGVtZW50UmVjdCgnbDMnKS5sZWZ0IGlzIHdpdGhpbiAx IG9mIDEzOAogUEFTUyBlbGVtZW50UmVjdCgnbDQnKS50b3AgaXMgODAKLVBBU1MgZWxlbWVudFJl Y3QoJ2w0JykubGVmdCBpcyB3aXRoaW4gMSBvZiAxMzgKIFBBU1MgZWxlbWVudFJlY3QoJ2w1Jyku dG9wIGlzIDEwMAotUEFTUyBlbGVtZW50UmVjdCgnbDUnKS5sZWZ0IGlzIHdpdGhpbiAxIG9mIDEx OAogUEFTUyBlbGVtZW50UmVjdCgnbDYnKS50b3AgaXMgMTIwCi1QQVNTIGVsZW1lbnRSZWN0KCds NicpLmxlZnQgaXMgd2l0aGluIDEgb2YgOTgKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWRp YW1vbmQtbWFyZ2luLXBvbHlnb24uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9z aGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1kaWFtb25kLW1hcmdpbi1w b2x5Z29uLmh0bWwKaW5kZXggY2JjMDAwMy4uMzFkNDBjZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxv YXRzLWRpYW1vbmQtbWFyZ2luLXBvbHlnb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4 Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZGlhbW9u ZC1tYXJnaW4tcG9seWdvbi5odG1sCkBAIC01OSwyOSArNTksMjkgQEAgZnVuY3Rpb24gZWxlbWVu dFJlY3QoZWxlbWVudElkKQogCiBmdW5jdGlvbiBtYXJnaW5MZWZ0WEludGVyY2VwdChsaW5lTnVt YmVyKQogewotICAgIHJldHVybiBTdWJQaXhlbExheW91dC5zbmFwVG9MYXlvdXRVbml0KGxpbmVO dW1iZXIgKiAyMCArIDIwICogTWF0aC5zcXJ0KDIpICsgNTApOworICAgIHZhciBmID0gU3ViUGl4 ZWxMYXlvdXQuc25hcFRvTGF5b3V0VW5pdChsaW5lTnVtYmVyICogMjAgKyAyMCAqIE1hdGguc3Fy dCgyKSArIDUwKTsKKyAgICByZXR1cm4gTWF0aC5yb3VuZChmKTsKIH0KIAogdmFyIHF1aWV0ID0g dHJ1ZTsgLy8gUEFTUyBvdXRwdXQgZGVwZW5kcyBvbiBTdWJQaXhlbExheW91dC5pc0VuYWJsZWQo KQogCiBzaG91bGRCZSgiZWxlbWVudFJlY3QoJ2wxJykudG9wIiwgIjAiKTsKLXNob3VsZEJlQ2xv c2VUbygiZWxlbWVudFJlY3QoJ2wxJykubGVmdCIsIG1hcmdpbkxlZnRYSW50ZXJjZXB0KDEpLCAx KTsKK3Nob3VsZEJlQ2xvc2VUbygiZWxlbWVudFJlY3QoJ2wxJykubGVmdCIsIG1hcmdpbkxlZnRY SW50ZXJjZXB0KDEpLCAxLCBxdWlldCk7CiAKIHNob3VsZEJlKCJlbGVtZW50UmVjdCgnbDInKS50 b3AiLCAiMjAiKTsKLXNob3VsZEJlQ2xvc2VUbygiZWxlbWVudFJlY3QoJ2wyJykubGVmdCIsIG1h cmdpbkxlZnRYSW50ZXJjZXB0KDIpLCAxKTsKK3Nob3VsZEJlQ2xvc2VUbygiZWxlbWVudFJlY3Qo J2wyJykubGVmdCIsIG1hcmdpbkxlZnRYSW50ZXJjZXB0KDIpLCAxLCBxdWlldCk7CiAKIHNob3Vs ZEJlKCJlbGVtZW50UmVjdCgnbDMnKS50b3AiLCAiNDAiKTsKLXNob3VsZEJlQ2xvc2VUbygiZWxl bWVudFJlY3QoJ2wzJykubGVmdCIsIG1hcmdpbkxlZnRYSW50ZXJjZXB0KDMpLCAxKTsKK3Nob3Vs ZEJlQ2xvc2VUbygiZWxlbWVudFJlY3QoJ2wzJykubGVmdCIsIG1hcmdpbkxlZnRYSW50ZXJjZXB0 KDMpLCAxLCBxdWlldCk7CiAKIHNob3VsZEJlKCJlbGVtZW50UmVjdCgnbDQnKS50b3AiLCAiODAi KTsKLXNob3VsZEJlQ2xvc2VUbygiZWxlbWVudFJlY3QoJ2w0JykubGVmdCIsIG1hcmdpbkxlZnRY SW50ZXJjZXB0KDMpLCAxKTsKK3Nob3VsZEJlQ2xvc2VUbygiZWxlbWVudFJlY3QoJ2w0JykubGVm dCIsIG1hcmdpbkxlZnRYSW50ZXJjZXB0KDMpLCAxLCBxdWlldCk7CiAKIHNob3VsZEJlKCJlbGVt ZW50UmVjdCgnbDUnKS50b3AiLCAiMTAwIik7Ci1zaG91bGRCZUNsb3NlVG8oImVsZW1lbnRSZWN0 KCdsNScpLmxlZnQiLCBtYXJnaW5MZWZ0WEludGVyY2VwdCgyKSwgMSk7CitzaG91bGRCZUNsb3Nl VG8oImVsZW1lbnRSZWN0KCdsNScpLmxlZnQiLCBtYXJnaW5MZWZ0WEludGVyY2VwdCgyKSwgMSwg cXVpZXQpOwogCiBzaG91bGRCZSgiZWxlbWVudFJlY3QoJ2w2JykudG9wIiwgIjEyMCIpOwotc2hv dWxkQmVDbG9zZVRvKCJlbGVtZW50UmVjdCgnbDYnKS5sZWZ0IiwgbWFyZ2luTGVmdFhJbnRlcmNl cHQoMSksIDEpOworc2hvdWxkQmVDbG9zZVRvKCJlbGVtZW50UmVjdCgnbDYnKS5sZWZ0IiwgbWFy Z2luTGVmdFhJbnRlcmNlcHQoMSksIDEsIHF1aWV0KTsKIAogPC9zY3JpcHQ+CiA8L2h0bWw+Ci0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRlLWZs b2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1lbGxpcHNlLW1hcmdpbi1sZWZ0Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lk ZS1mbG9hdHMtZWxsaXBzZS1tYXJnaW4tbGVmdC5odG1sCmluZGV4IGM3MmUwNDYuLmZmMjExNWYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRlLWZs b2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1lbGxpcHNlLW1hcmdpbi1sZWZ0Lmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91 dHNpZGUtZmxvYXRzLWVsbGlwc2UtbWFyZ2luLWxlZnQuaHRtbApAQCAtNjcsNyArNjcsOCBAQCBm dW5jdGlvbiBlbGVtZW50UmVjdChlbGVtZW50SWQpCiAKIGZ1bmN0aW9uIG1hcmdpbkVsbGlwc2VM ZWZ0WEludGVyY2VwdCh5LCBjeCwgcngsIHJ5KQogewotICAgIHJldHVybiBTdHJpbmcoIFN1YlBp eGVsTGF5b3V0LnNuYXBUb0xheW91dFVuaXQoY3ggKyByeCAqIE1hdGguc3FydCgxIC0gTWF0aC5w b3coKHJ5IC0geSkgLyByeSwgMikpKSApOworICAgIHZhciBmID0gU3ViUGl4ZWxMYXlvdXQuc25h cFRvTGF5b3V0VW5pdChjeCArIHJ4ICogTWF0aC5zcXJ0KDEgLSBNYXRoLnBvdygocnkgLSB5KSAv IHJ5LCAyKSkpOworICAgIHJldHVybiBTdHJpbmcoIE1hdGgucm91bmQoZikgKTsKIH0KIAogLy8g SW4gdGhlICIubGVmdCIgdGVzdHMgYmVsb3csIGl0J3MgdGhlIGxvd2VyIGVkZ2Ugb2YgdGhlIDIw cHggQWhlbSBnbHlwaCB0aGF0IHRoYXQgZGVmaW5lcyB0aGUgZWxlbWVudCByZWN0J3MgbGVmdCBl ZGdlLiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRz aWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1lbGxpcHNlLW1hcmdpbi1yaWdodC5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtZmxvYXRzLWVsbGlwc2UtbWFyZ2luLXJpZ2h0Lmh0bWwKaW5kZXggNTRjZjVhYS4u YjY2MDFjZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91 dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWVsbGlwc2UtbWFyZ2luLXJpZ2h0Lmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRz L3NoYXBlLW91dHNpZGUtZmxvYXRzLWVsbGlwc2UtbWFyZ2luLXJpZ2h0Lmh0bWwKQEAgLTY5LDcg KzY5LDggQEAgZnVuY3Rpb24gZWxlbWVudFJlY3QoZWxlbWVudElkKQogZnVuY3Rpb24gbWFyZ2lu RWxsaXBzZVJpZ2h0WEludGVyY2VwdCh5LCBjeCwgcngsIHJ5KQogewogICAgIHZhciBjb250YWlu ZXJXaWR0aCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250YWluZXIiKS5nZXRCb3VuZGlu Z0NsaWVudFJlY3QoKS53aWR0aDsKLSAgICByZXR1cm4gU3RyaW5nKCBTdWJQaXhlbExheW91dC5z bmFwVG9MYXlvdXRVbml0KGNvbnRhaW5lcldpZHRoIC0gKGN4ICsgcnggKiBNYXRoLnNxcnQoMSAt IE1hdGgucG93KChyeSAtIHkpIC8gcnksIDIpKSkpICk7CisgICAgdmFyIGYgPSBTdWJQaXhlbExh eW91dC5zbmFwVG9MYXlvdXRVbml0KGNvbnRhaW5lcldpZHRoIC0gKGN4ICsgcnggKiBNYXRoLnNx cnQoMSAtIE1hdGgucG93KChyeSAtIHkpIC8gcnksIDIpKSkpOworICAgIHJldHVybiBTdHJpbmco IE1hdGguZmxvb3IoZikgKTsKIH0KIAogLy8gSW4gdGhlICIucmlnaHQiIHRlc3RzIGJlbG93LCBp dCdzIHRoZSBsb3dlciBlZGdlIG9mIHRoZSAyMHB4IEFoZW0gZ2x5cGggdGhhdCB0aGF0IGRlZmlu ZXMgdGhlIGVsZW1lbnQgcmVjdCdzIGxlZnQgZWRnZS4gCg==