115965 2013-05-11 11:47:07 -0700 [GTK] Move defines that will never be configured to Platform.h 2013-05-12 11:10:05 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115966 1 mrobinson mrobinson benjamin cmarcelo commit-queue laszlo.gombos oldest_to_newest 887811 0 mrobinson 2013-05-11 11:47:07 -0700 Instead of putting defines that are never configured (think USE_HARFBUZZ) into the autoconf configuration file, we should just put them in Platform.h. This has a couple benefits. It makes it easier for developers from other ports to see what GTK+ uses and it also lets us share the defines with the cmake build. 887813 1 201467 mrobinson 2013-05-11 11:53:50 -0700 Created attachment 201467 Patch 887959 2 laszlo.gombos 2013-05-12 09:36:52 -0700 Great ! 887979 3 mrobinson 2013-05-12 11:10:05 -0700 Committed r149966: <http://trac.webkit.org/changeset/149966> 201467 2013-05-11 11:53:50 -0700 2013-05-11 15:22:04 -0700 Patch bug-115965-20130511115250.patch text/plain 2733 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNjMGJkMjU4Mzg5MTBhOTg3MzBhYzc3 MTI0NmI5NzMyNDllNWUxMTAuLjYzNmI4OGI0MzJkZWY1YWRlMjM4ZDE1MjhhYTZjMDRkZjQ4MDcx M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDUtMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIE1vdmUgZGVmaW5lcyB0byBwbGF0Zm9ybQor CisgICAgICAgIFtHVEtdIE1vdmUgZGVmaW5lcyB0aGF0IHdpbGwgbmV2ZXIgYmUgY29uZmlndXJl ZCB0byBQbGF0Zm9ybS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTU5NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBBZGQgbmV3IGRlZmluZXMgdGhhdCB3ZXJlIHByZXZp b3VzbHkgaW4gdGhlIGF1dG9jb25mIGhlYWRlci4KKwogMjAxMy0wNS0xMCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIHVu bmVjZXNzYXJ5IEdMSUJfQ0hFQ0tfVkVSU0lPTiAjaWZkZWZzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBiZTRl ODdhZDRjZmJlNTY5OWJlMTkwYTUxNjA4ZGMwZDIzZTRlY2FmLi41ZTlkMGU1MjE0ODBhOTRlNGM2 MGYxODc4ZjM3NGRkMGMxNzQyN2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTQ3Nyw3ICs0NzcsMTMgQEAK IAogI2lmIFBMQVRGT1JNKEdUSykKICNkZWZpbmUgV1RGX1VTRV9DQUlSTyAxCisjZGVmaW5lIFdU Rl9VU0VfR0xJQiAxCisjZGVmaW5lIFdURl9VU0VfRlJFRVRZUEUgMQorI2RlZmluZSBXVEZfVVNF X0hBUkZCVVpaIDEKKyNkZWZpbmUgV1RGX1VTRV9TT1VQIDEKKyNkZWZpbmUgV1RGX1VTRV9XRUJQ IDEKICNkZWZpbmUgRU5BQkxFX0dMT0JBTF9GQVNUTUFMTE9DX05FVyAwCisjZGVmaW5lIEdTVF9B UElfVkVSU0lPTl8xIDEKICNlbmRpZgogCiAvKiBPbiBXaW5kb3dzLCB1c2UgUXVlcnlQZXJmb3Jt YW5jZUNvdW50ZXIgYnkgZGVmYXVsdCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL2F1dG90b29scy9T ZXR1cEF1dG9jb25mSGVhZGVyLm00IGIvU291cmNlL2F1dG90b29scy9TZXR1cEF1dG9jb25mSGVh ZGVyLm00CmluZGV4IDJjYjQwZWFkODk4YzNiMDQzYTYxNzM1N2RiNmYyMzA1ZmJmMTFhMzcuLmUx Mjk3NDUyYWYwNzE3ZjNhNjM4NDZlZmExNzI2YjM1NTk0M2I1NmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9hdXRvdG9vbHMvU2V0dXBBdXRvY29uZkhlYWRlci5tNAorKysgYi9Tb3VyY2UvYXV0b3Rvb2xz L1NldHVwQXV0b2NvbmZIZWFkZXIubTQKQEAgLTEsMTEgKzEsNCBAQAogIyBDb25maWd1cmF0aW9u IGZsYWdzIHRoYXQgYXJlIHVzZWQgdGhyb3VnaG91dCBXZWJLaXRHVEsrLgotQUNfREVGSU5FKFtX VEZfVVNFX0dMSUJdLCBbMV0sIFsgXSkKLUFDX0RFRklORShbV1RGX1VTRV9GUkVFVFlQRV0sIFsx XSwgWyBdKQotQUNfREVGSU5FKFtXVEZfVVNFX0hBUkZCVVpaXSwgWzFdLCBbIF0pCi1BQ19ERUZJ TkUoW1dURl9VU0VfU09VUF0sIFsxXSwgWyBdKQotQUNfREVGSU5FKFtXVEZfVVNFX1dFQlBdLCBb MV0sIFsgXSkKLUFDX0RFRklORShbV1RGX1VTRV9JQ1VfVU5JQ09ERV0sIFsxXSwgWyBdKQotQUNf REVGSU5FKFtHU1RfQVBJX1ZFUlNJT05fMV0sIFsxXSwgW1VzaW5nIEdTdHJlYW1lciAxLjBdKQog QUNfREVGSU5FX1VOUVVPVEVEKEdFVFRFWFRfUEFDS0FHRSwiJEdFVFRFWFRfUEFDS0FHRSIsIFtU aGUgZ2V0dGV4dCBjYXRhbG9nIG5hbWVdKQogCiBpZiB0ZXN0ICIkZW5hYmxlX2RlYnVnIiA9ICJ5 ZXMiOyB0aGVuCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzcxYmUy MzFiZmRlMTg3ZTYxYThmMjQ2MDQ2ZjZhZGQyYWEzYmJlZS4uNDhjMmFlMWM2MzJmNzc1ZmRjYzEx MmQxYWZkOGZkYzBiMTcyZTc4OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTExICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z b25AaWdhbGlhLmNvbT4KKworICAgICAgICBNb3ZlIGRlZmluZXMgdG8gcGxhdGZvcm0KKworICAg ICAgICBbR1RLXSBNb3ZlIGRlZmluZXMgdGhhdCB3aWxsIG5ldmVyIGJlIGNvbmZpZ3VyZWQgdG8g UGxhdGZvcm0uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE1OTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTb3VyY2UvYXV0b3Rvb2xzL1NldHVwQXV0b2NvbmZIZWFkZXIubTQ6IE1vdmUgc29tZSB1 bmNoYW5naW5nIGRlZmluZXMgdG8gUGxhdGZvcm0uaC4KKwogMjAxMy0wNS0wOSAgQ2hyaXN0b3Bo ZSBEdW1leiAgPGNoLmR1bWV6QHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRkIHN1cHBv cnQgZm9yIFtOb0ludGVyZmFjZU9iamVjdF0gV2ViIElETCBleHRlbmRlZCBhdHRyaWJ1dGUK