115864 2013-05-09 09:56:03 -0700 [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser 2013-05-13 01:41:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 57311 1 zoltan zoltan abecsi allan.jensen hausmann kling vestbo oldest_to_newest 886925 0 zoltan 2013-05-09 09:56:03 -0700 Qt-port runs all the CSS-Exclusion tests. If there is an test failiure when running the tests there is no way to test via QtTestBrowser. This patch enables the feature in QtTestBrowser. 886927 1 201246 zoltan 2013-05-09 09:59:54 -0700 Created attachment 201246 proposed patch 886942 2 201246 kling 2013-05-09 10:39:28 -0700 Comment on attachment 201246 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > Source/WebKit/qt/Api/qwebsettings.h:82 > + CSSExclusionsEnabled, I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility. 886959 3 zoltan 2013-05-09 11:14:24 -0700 (In reply to comment #2) > (From update of attachment 201246 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > > > Source/WebKit/qt/Api/qwebsettings.h:82 > > + CSSExclusionsEnabled, > > I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility. I don't want to break any compatibility. Do you know any way how to add this settings as a private setting? 887643 4 201246 zoltan 2013-05-10 15:22:54 -0700 Comment on attachment 201246 proposed patch We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug. 888143 5 hausmann 2013-05-13 01:41:13 -0700 (In reply to comment #4) > (From update of attachment 201246 [details]) > We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug. I very much like that approach :) 201246 2013-05-09 09:59:54 -0700 2013-05-10 15:22:53 -0700 proposed patch exclusions_enable_qt.patch text/plain 2667 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCmluZGV4IDczNDRiYWUuLjdlMjM0NTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcApAQCAtMTc3LDYgKzE3Nyw4IEBA IHZvaWQgUVdlYlNldHRpbmdzUHJpdmF0ZTo6YXBwbHkoKQogICAgICAgICB2YWx1ZSA9IGF0dHJp YnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpXZWJBdWRpb0VuYWJsZWQsIGdsb2JhbC0+YXR0cmli dXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OldlYkF1ZGlvRW5hYmxlZCkpOwogICAgICAgICBzZXR0 aW5ncy0+c2V0V2ViQXVkaW9FbmFibGVkKHZhbHVlKTsKICNlbmRpZgorICAgICAgICB2YWx1ZSA9 IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpDU1NFeGNsdXNpb25zRW5hYmxlZCwgZ2xv YmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6Q1NTRXhjbHVzaW9uc0VuYWJsZWQp KTsKKyAgICAgICAgV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0Q1NTRXhjbHVz aW9uc0VuYWJsZWQodmFsdWUpOwogCiAgICAgICAgIHZhbHVlID0gYXR0cmlidXRlcy52YWx1ZShR V2ViU2V0dGluZ3M6OkNTU1JlZ2lvbnNFbmFibGVkLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6Q1NTUmVnaW9u c0VuYWJsZWQpKTsKQEAgLTU1NCw2ICs1NTYsNyBAQCBRV2ViU2V0dGluZ3M6OlFXZWJTZXR0aW5n cygpCiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpBY2NlbGVyYXRlZENv bXBvc2l0aW5nRW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNl dHRpbmdzOjpXZWJHTEVuYWJsZWQsIHRydWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFX ZWJTZXR0aW5nczo6V2ViQXVkaW9FbmFibGVkLCBmYWxzZSk7CisgICAgZC0+YXR0cmlidXRlcy5p bnNlcnQoUVdlYlNldHRpbmdzOjpDU1NFeGNsdXNpb25zRW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+ YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpDU1NSZWdpb25zRW5hYmxlZCwgdHJ1ZSk7 CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpDU1NDb21wb3NpdGluZ0Vu YWJsZWQsIHRydWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6Q1NT R3JpZExheW91dEVuYWJsZWQsIGZhbHNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv QXBpL3F3ZWJzZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgK aW5kZXggNjFmZjkzMC4uNDE1N2FlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9BcGkv cXdlYnNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgK QEAgLTc5LDYgKzc5LDcgQEAgcHVibGljOgogICAgICAgICBTaXRlU3BlY2lmaWNRdWlya3NFbmFi bGVkLAogICAgICAgICBKYXZhc2NyaXB0Q2FuQ2xvc2VXaW5kb3dzLAogICAgICAgICBXZWJHTEVu YWJsZWQsCisgICAgICAgIENTU0V4Y2x1c2lvbnNFbmFibGVkLAogICAgICAgICBDU1NSZWdpb25z RW5hYmxlZCwKICAgICAgICAgQ1NTQ29tcG9zaXRpbmdFbmFibGVkLAogICAgICAgICBIeXBlcmxp bmtBdWRpdGluZ0VuYWJsZWQsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGI1NzZkMjkuLjcwN2IzYzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDUtMDkgIFpvbHRhbiBIb3J2YXRo ICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBDU1MgRXhjbHVzaW9ucyBmZWF0 dXJlIGlzIGVuYWJsZWQgaW4gRFJULCBidXQgbm90IGluIFF0VGVzdEJyb3dzZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTg2NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFF0LXBvcnQgcnVucyBhbGwg dGhlIENTUy1FeGNsdXNpb24gdGVzdHMuIElmIHRoZXJlIGlzIGFuIHRlc3QgZmFpbGl1cmUgd2hl biBydW5uaW5nIHRoZSB0ZXN0cworICAgICAgICB0aGVyZSBpcyBubyB3YXkgdG8gdGVzdCB2aWEg UXRUZXN0QnJvd3Nlci4gVGhpcyBwYXRjaCBlbmFibGVzIHRoZSBmZWF0dXJlIGluIFF0VGVzdEJy b3dzZXIuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKFFXZWJT ZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKFFXZWJTZXR0aW5nczo6UVdlYlNldHRp bmdzKToKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6CisKIDIwMTMtMDQtMjMgIEFsbGFu IFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0 XVtXSzFdIE1lbW9yeUNhY2hlIGlzIG5vdCBjbGVhbmVkIGJ5IGRlZmF1bHQK