115672 2013-05-06 13:58:57 -0700 Switch off a deprecated API 2013-05-06 15:32:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue oldest_to_newest 885362 0 mrowe 2013-05-06 13:58:57 -0700 Rather than just disabling deprecation warnings around our use of it, we should switch to the replacement API. <rdar://problem/13775921> 885363 1 200805 mrowe 2013-05-06 13:59:31 -0700 Created attachment 200805 Patch v1 885364 2 commit-queue 2013-05-06 14:01:05 -0700 Attachment 200805 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/ChildProcessMac.mm']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 885478 3 commit-queue 2013-05-06 15:31:37 -0700 The commit-queue encountered the following flaky tests while processing attachment 200805: http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) svg/dom/SVGScriptElement/script-load-and-error-events.svg bug 114279 (authors: fmalita@chromium.org, yurys@chromium.org, and zimmermann@kde.org) svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: fmalita@chromium.org and timothy_horton@apple.com) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) media/video-played-collapse.html bug 58630 (authors: annacc@chromium.org, jamesr@chromium.org, pnormand@igalia.com, and vrk@chromium.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. 885479 4 200805 commit-queue 2013-05-06 15:32:26 -0700 Comment on attachment 200805 Patch v1 Clearing flags on attachment: 200805 Committed r149644: <http://trac.webkit.org/changeset/149644> 885480 5 commit-queue 2013-05-06 15:32:29 -0700 All reviewed patches have been landed. Closing bug. 200805 2013-05-06 13:59:31 -0700 2013-05-06 15:32:26 -0700 Patch v1 0001-rdar-problem-13775921-Switch-off-a-deprecated-API.patch text/plain 2878 mrowe RnJvbSBhNDNkODQ4NzY4NGM0YTJhYjJmYzk5OGUxZjQyNjg0ZjljM2JjY2ViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogTW9u LCA2IE1heSAyMDEzIDEzOjUyOjQ5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gPHJkYXI6Ly9wcm9i bGVtLzEzNzc1OTIxPiBTd2l0Y2ggb2ZmIGEgZGVwcmVjYXRlZCBBUEkuCgpSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiogU2hhcmVkL21hYy9DaGlsZFByb2Nlc3NNYWMubW06CihXZWJLaXQ6 OkNoaWxkUHJvY2Vzczo6c2V0UHJvY2Vzc1N1cHByZXNzaW9uRW5hYmxlZCk6IFdoZW4gZGlzYWJs aW5nIHByb2Nlc3Mgc3VwcHJlc3Npb24sCmJlZ2luIGFuIGFjdGl2aXR5IHRoYXQgZG9lc24ndCBk aXNhYmxlIGlkbGUgc2xlZXAsIHN1ZGRlbiB0ZXJtaW5hdGlvbiBvciBhdXRvbWF0aWMgdGVybWlu YXRpb24uCldoZW4gZW5hYmxpbmcgcHJvY2VzcyBzdXBwcmVzc2lvbiwgZW5kIHRoZSBhY3Rpdml0 eS4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8IDEx ICsrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5t bSB8IDEyICsrKysrKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwOWQ0YjMzLi44OGYxMTdmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDUtMDYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNv bT4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTM3NzU5MjE+IFN3aXRjaCBvZmYgYSBkZXBy ZWNhdGVkIEFQSS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNoYXJlZC9tYWMvQ2hpbGRQcm9jZXNzTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpD aGlsZFByb2Nlc3M6OnNldFByb2Nlc3NTdXBwcmVzc2lvbkVuYWJsZWQpOiBXaGVuIGRpc2FibGlu ZyBwcm9jZXNzIHN1cHByZXNzaW9uLAorICAgICAgICBiZWdpbiBhbiBhY3Rpdml0eSB0aGF0IGRv ZXNuJ3QgZGlzYWJsZSBpZGxlIHNsZWVwLCBzdWRkZW4gdGVybWluYXRpb24gb3IgYXV0b21hdGlj IHRlcm1pbmF0aW9uLgorICAgICAgICBXaGVuIGVuYWJsaW5nIHByb2Nlc3Mgc3VwcHJlc3Npb24s IGVuZCB0aGUgYWN0aXZpdHkuCisKIDIwMTMtMDUtMDIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFtXSzJdW0N1c3RvbVByb3RvY29sc10gTlNVUkxQcm90b2NvbENs aWVudCBtZXRob2RzIHNob3VsZCBiZSBkaXNwYXRjaGVkIG9uIE5TVVJMQ29ubmVjdGlvbidzIHJl c291cmNlIGxvYWRlciBydW4gbG9vcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVk L21hYy9DaGlsZFByb2Nlc3NNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0NoaWxk UHJvY2Vzc01hYy5tbQppbmRleCAyOGFiMjA0Li45Y2ZlZWVmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5tbQpAQCAtNjUsMTMgKzY1LDEzIEBAIHZvaWQg Q2hpbGRQcm9jZXNzOjpzZXRQcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkKGJvb2wgcHJvY2Vzc1N1 cHByZXNzaW9uRW5hYmxlZCkKICAgICBpZiAodGhpcy0+cHJvY2Vzc1N1cHByZXNzaW9uRW5hYmxl ZCgpID09IHByb2Nlc3NTdXBwcmVzc2lvbkVuYWJsZWQpCiAgICAgICAgIHJldHVybjsKIAotI3By YWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25v cmVkICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgotICAgIGlmIChwcm9jZXNzU3VwcHJlc3Np b25FbmFibGVkKQorICAgIGlmIChwcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkKSB7CisgICAgICAg IFtbTlNQcm9jZXNzSW5mbyBwcm9jZXNzSW5mb10gZW5kQWN0aXZpdHk6bV9wcm9jZXNzU3VwcHJl c3Npb25Bc3NlcnRpb24uZ2V0KCldOwogICAgICAgICBtX3Byb2Nlc3NTdXBwcmVzc2lvbkFzc2Vy dGlvbi5jbGVhcigpOwotICAgIGVsc2UKLSAgICAgICAgbV9wcm9jZXNzU3VwcHJlc3Npb25Bc3Nl cnRpb24gPSBbW05TUHJvY2Vzc0luZm8gcHJvY2Vzc0luZm9dIGJlZ2luU3VzcGVuc2lvbk9mU3lz dGVtQmVoYXZpb3JzOldLUHJvY2Vzc1N1cHByZXNzaW9uU3lzdGVtQmVoYXZpb3JzIHJlYXNvbjpA IlByb2Nlc3MgU3VwcHJlc3Npb24gRGlzYWJsZWQiXTsKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3Rp YyBwb3AKKyAgICB9IGVsc2UgeworICAgICAgICBOU0FjdGl2aXR5T3B0aW9ucyBvcHRpb25zID0g TlNBY3Rpdml0eVVzZXJJbml0aWF0ZWRBbGxvd2luZ0lkbGVTeXN0ZW1TbGVlcCAmIH4oTlNBY3Rp dml0eVN1ZGRlblRlcm1pbmF0aW9uRGlzYWJsZWQgfCBOU0FjdGl2aXR5QXV0b21hdGljVGVybWlu YXRpb25EaXNhYmxlZCk7CisgICAgICAgIG1fcHJvY2Vzc1N1cHByZXNzaW9uQXNzZXJ0aW9uID0g W1tOU1Byb2Nlc3NJbmZvIHByb2Nlc3NJbmZvXSBiZWdpbkFjdGl2aXR5V2l0aE9wdGlvbnM6b3B0 aW9ucyByZWFzb246QCJQcm9jZXNzIFN1cHByZXNzaW9uIERpc2FibGVkIl07CisgICAgfQogI2Vs c2UKICAgICBVTlVTRURfUEFSQU0ocHJvY2Vzc1N1cHByZXNzaW9uRW5hYmxlZCk7CiAjZW5kaWYK LS0gCjEuOC4xLjUgKEFwcGxlIEdpdC00NCkKCg==