115602 2013-05-04 15:42:59 -0700 Get rid of special cases in AddIncludesForTypeInImpl 2013-05-04 18:52:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue haraken laszlo.gombos rniwa oldest_to_newest 884599 0 cdumez 2013-05-04 15:42:59 -0700 We should get rid of the special cases in AddIncludesForTypeInImpl subroutine in the JS bindings generator. Those do not seem to be needed and special cases should be avoided in the generator. 884600 1 200549 cdumez 2013-05-04 15:44:09 -0700 Created attachment 200549 Patch 884684 2 commit-queue 2013-05-04 18:52:03 -0700 The commit-queue encountered the following flaky tests while processing attachment 200549: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/cookies/multiple-cookies.html bug 115608 (authors: ap@webkit.org, hamaji@chromium.org, and jchaffraix@webkit.org) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 884685 3 200549 commit-queue 2013-05-04 18:52:55 -0700 Comment on attachment 200549 Patch Clearing flags on attachment: 200549 Committed r149572: <http://trac.webkit.org/changeset/149572> 884686 4 commit-queue 2013-05-04 18:52:58 -0700 All reviewed patches have been landed. Closing bug. 200549 2013-05-04 15:44:09 -0700 2013-05-04 18:52:54 -0700 Patch 115602_bindings_cleanup.patch text/plain 1966 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNTg5MzBjLi44ODc4ZDkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDUtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIEdldCByaWQgb2Ygc3BlY2lhbCBjYXNlcyBpbiBBZGRJbmNsdWRlc0Zv clR5cGVJbkltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNTYwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEdldCByaWQgb2YgdGhlIHNwZWNpYWwgY2FzZXMgaW4gQWRkSW5jbHVkZXNGb3JUeXBlSW5J bXBsIHN1YnJvdXRpbmUgaW4gdGhlCisgICAgICAgIEpTIGJpbmRpbmdzIGdlbmVyYXRvci4gVGhv c2UgYXJlIG5vIGxvbmdlciBuZWVkZWQgYW5kIHNwZWNpYWwgY2FzZXMgc2hvdWxkCisgICAgICAg IGJlIGF2b2lkZWQgaW4gdGhlIGdlbmVyYXRvci4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5v IGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtOgorICAgICAgICAoQWRkSW5jbHVkZXNGb3JUeXBlSW5JbXBsKToKKwogMjAxMy0w NS0wMyAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5jb20+CiAKICAgICAgICAgW1F0 XSBCdWlsZCB3aXRoIC0tdmlkZW8tdHJhY2sgZmFpbHMgYmVjYXVzZSBTdHJpbmcoQXRvbWljU3Ry aW5nKSBpcyBhbWJpZ3VvdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggZjc5ZTViMC4uMjM3ZjkxNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTE5 MiwyNSArMTkyLDYgQEAgc3ViIEFkZEluY2x1ZGVzRm9yVHlwZUluSW1wbAogICAgIG15ICRpc0Nh bGxiYWNrID0gQF8gPyBzaGlmdCA6IDA7CiAgICAgCiAgICAgQWRkSW5jbHVkZXNGb3JUeXBlKCR0 eXBlLCAkaXNDYWxsYmFjaywgXCVpbXBsSW5jbHVkZXMpOwotICAgIAotICAgICMgYWRkaXRpb25h bCBpbmNsdWRlcyAodGhpbmdzIG5lZWRlZCB0byBjb21waWxlIHRoZSBiaW5kaW5ncyBidXQgbm90 IHRoZSBoZWFkZXIpCi0gICAgaWYgKCR0eXBlIGVxICJDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQi KSB7Ci0gICAgICAgICRpbXBsSW5jbHVkZXN7IkNhbnZhc0dyYWRpZW50LmgifSA9IDE7Ci0gICAg ICAgICRpbXBsSW5jbHVkZXN7IkNhbnZhc1BhdHRlcm4uaCJ9ID0gMTsKLSAgICAgICAgJGltcGxJ bmNsdWRlc3siQ2FudmFzU3R5bGUuaCJ9ID0gMTsKLSAgICB9Ci0KLSAgICBpZiAoJHR5cGUgZXEg IkNhbnZhc0dyYWRpZW50IiBvciAkdHlwZSBlcSAiWFBhdGhOU1Jlc29sdmVyIiBvciAkdHlwZSBl cSAiTWVzc2FnZVBvcnQiKSB7Ci0gICAgICAgICRpbXBsSW5jbHVkZXN7Ijx3dGYvdGV4dC9XVEZT dHJpbmcuaD4ifSA9IDE7Ci0gICAgfQotCi0gICAgaWYgKCR0eXBlIGVxICJEb2N1bWVudCIpIHsK LSAgICAgICAgJGltcGxJbmNsdWRlc3siTm9kZUZpbHRlci5oIn0gPSAxOwotICAgIH0KLQotICAg IGlmICgkdHlwZSBlcSAiTWVkaWFRdWVyeUxpc3RMaXN0ZW5lciIpIHsKLSAgICAgICAgJGltcGxJ bmNsdWRlc3siTWVkaWFRdWVyeUxpc3RMaXN0ZW5lci5oIn0gPSAxOwotICAgIH0KIH0KIAogc3Vi IEFkZEluY2x1ZGVzRm9yVHlwZUluSGVhZGVyCg==