115515 2013-05-02 06:54:59 -0700 [BlackBerry] GraphicsContext: add missing definitions. 2013-05-28 11:45:56 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia commit-queue xan.lopez oldest_to_newest 883774 0 berto 2013-05-02 06:54:59 -0700 PlatformGraphicsContext is not defined in GraphicsContext.h RoundedRect is not defined in GraphicsContextBlackBerry.cpp 883775 1 200312 berto 2013-05-02 06:56:46 -0700 Created attachment 200312 Patch 886477 2 200312 rwlbuis 2013-05-08 14:31:16 -0700 Comment on attachment 200312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200312&action=review > Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 > +#include "RoundedRect.h" Are you sure we need this? 886735 3 berto 2013-05-09 04:56:30 -0700 (In reply to comment #2) > > Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 > > +#include "RoundedRect.h" > > Are you sure we need this? Well, there's calls to RoundedRect::rect() and RoundedRect::radii() in that file. Why wouldn't we need it? 886965 4 200312 rwlbuis 2013-05-09 11:19:04 -0700 Comment on attachment 200312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200312&action=review >> Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 >> +#include "RoundedRect.h" > > Are you sure we need this? We do not use this internally so I think you should remove it from the patch. 886987 5 berto 2013-05-09 11:37:52 -0700 (In reply to comment #4) > >> +#include "RoundedRect.h" > > We do not use this internally so I think you should remove it from > the patch. But that's because we have that internally in Path.h, which I believe is unnecessary. 890225 6 berto 2013-05-16 23:59:22 -0700 I still think this is the best option because I don't see us including RoundRect.h from Path.h Or do you have any other suggestion? 891657 7 200312 berto 2013-05-21 02:14:02 -0700 Comment on attachment 200312 Patch Requesting review again based on my previous comments. 894083 8 200312 rwlbuis 2013-05-27 10:34:30 -0700 Comment on attachment 200312 Patch Patch is fine but please check if we need the GraphicsContextBlackBerry.cpp change. 894440 9 200312 commit-queue 2013-05-28 11:45:54 -0700 Comment on attachment 200312 Patch Clearing flags on attachment: 200312 Committed r150820: <http://trac.webkit.org/changeset/150820> 894441 10 commit-queue 2013-05-28 11:45:56 -0700 All reviewed patches have been landed. Closing bug. 200312 2013-05-02 06:56:46 -0700 2013-05-28 11:45:54 -0700 Patch 115515.diff text/plain 2003 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MzRjZGRkLi41NWRhZWZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDUtMDIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBHcmFwaGljc0NvbnRleHQ6IGFkZCBtaXNzaW5nIGRlZmluaXRp b25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1 NTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaDoKKyAgICAgICAgKEdyYXBoaWNzKToK KyAgICAgICAgQWRkIGRlZmluaXRpb24gZm9yIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0LgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0QmxhY2tC ZXJyeS5jcHA6CisgICAgICAgIEluY2x1ZGUgUm91bmRlZFJlY3QuaAorCiAyMDEzLTA1LTAxICBF bnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgdGV4dC1jb21iaW5l OiBob3Jpem9udGFsIGRvZXMgbm90IHdvcmsgcHJvcGVybHkgZm9yIHNvbWUgZm9udHMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCmlu ZGV4IDU2Zjc2NDUuLjllZDRjNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCkBAIC01MSw2ICs1MSwxNSBAQCB0eXBlZGVmIFdl YkNvcmU6OlBsYXRmb3JtQ29udGV4dENhaXJvIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0OwogdHlw ZWRlZiBRUGFpbnRlciBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDsKICNlbGlmIE9TKFdJTkNFKQog dHlwZWRlZiBzdHJ1Y3QgSERDX18gUGxhdGZvcm1HcmFwaGljc0NvbnRleHQ7CisjZWxpZiBQTEFU Rk9STShCTEFDS0JFUlJZKQorbmFtZXNwYWNlIEJsYWNrQmVycnkgeworbmFtZXNwYWNlIFBsYXRm b3JtIHsKK25hbWVzcGFjZSBHcmFwaGljcyB7CitjbGFzcyBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4 dDsKK30KK30KK30KK3VzaW5nIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6UGxhdGZv cm1HcmFwaGljc0NvbnRleHQ7CiAjZWxzZQogdHlwZWRlZiB2b2lkIFBsYXRmb3JtR3JhcGhpY3ND b250ZXh0OwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHRCbGFja0Jl cnJ5LmNwcAppbmRleCAxNTRmNDlkLi5lNmU0MDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dEJsYWNrQmVycnku Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3Jh cGhpY3NDb250ZXh0QmxhY2tCZXJyeS5jcHAKQEAgLTIzLDYgKzIzLDcgQEAKICNpbmNsdWRlICJH cmFwaGljc0NvbnRleHQzRC5oIgogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJOb3RJbXBs ZW1lbnRlZC5oIgorI2luY2x1ZGUgIlJvdW5kZWRSZWN0LmgiCiAjaW5jbHVkZSAiVHJhbnNmb3Jt YXRpb25NYXRyaXguaCIKIAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUdyYXBoaWNzQ29u dGV4dC5oPgo=