115235 2013-04-26 01:32:04 -0700 [Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail. 2013-04-26 02:15:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110573 79666 1 kadam cdumez cdumez commit-queue ggaren haraken ossy szledan zarvai oldest_to_newest 881756 0 kadam 2013-04-26 01:32:04 -0700 * fast/dom/DeviceMotion/window-property.html diff: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-actual.txt @@ -5,7 +5,7 @@ PASS typeof window.DeviceMotionEvent == 'object' is true PASS typeof window.DeviceMotionEvent == 'function' is false -PASS hasDeviceMotionEventProperty() is true +FAIL hasDeviceMotionEventProperty() should be true. Was false. PASS 'DeviceMotionEvent' in window is true PASS window.hasOwnProperty('DeviceMotionEvent') is true PASS typeof window.ondevicemotion == 'object' is true * fast/dom/DeviceOrientation/window-property.html diff: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-actual.txt @@ -5,7 +5,7 @@ PASS typeof window.DeviceOrientationEvent == 'object' is true PASS typeof window.DeviceOrientationEvent == 'function' is false -PASS hasDeviceOrientationEventProperty() is true +FAIL hasDeviceOrientationEventProperty() should be true. Was false. PASS 'DeviceOrientationEvent' in window is true PASS window.hasOwnProperty('DeviceOrientationEvent') is true PASS typeof window.ondeviceorientation == 'object' is true 881757 1 kadam 2013-04-26 01:33:02 -0700 Could you check what happened to it, please? 881759 2 cdumez 2013-04-26 01:34:08 -0700 I'm on it. 881764 3 199802 cdumez 2013-04-26 01:44:41 -0700 Created attachment 199802 Patch Sorry about that, those tests are skipped on EFL so I did not notice the failure. 881765 4 199802 haraken 2013-04-26 01:48:10 -0700 Comment on attachment 199802 Patch Thanks for the quick fix! 881775 5 199802 commit-queue 2013-04-26 02:15:29 -0700 Comment on attachment 199802 Patch Clearing flags on attachment: 199802 Committed r149171: <http://trac.webkit.org/changeset/149171> 881776 6 commit-queue 2013-04-26 02:15:32 -0700 All reviewed patches have been landed. Closing bug. 199802 2013-04-26 01:44:41 -0700 2013-04-26 02:15:29 -0700 Patch 115235_fix_qt_tests.patch text/plain 4670 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYjkxOGY0Li40NjZhNWM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDQt MjYgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCisgICAg ICAgIFtRdF0gUkVHUkVTU0lPTihyMTQ5MDAxKTogSXQgbWFkZSB0d28gZmFzdC9kb20vRGV2aWNl TW90aW9uIHRlc3RzIGZhaWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTUyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVcGRhdGUgd2luZG93LXByb3BlcnR5Lmh0bWwgdGVzdCBjYXNlcyBmb3IgRGV2 aWNlTW90aW9uIGFuZCBEZXZpY2VPcmllbnRhdGlvbi4KKyAgICAgICAgVGhlIGdsb2JhbCBjb25z dHJ1Y3RvcnMgYXJlIG5vIGxvbmdlciBlbnVtZXJhYmxlIGFmdGVyIHIxNDkwMDEuCisKKyAgICAg ICAgKiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vc2NyaXB0LXRlc3RzL3dpbmRvdy1wcm9wZXJ0eS5q czoKKyAgICAgICAgKiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vd2luZG93LXByb3BlcnR5LWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9EZXZpY2VPcmllbnRhdGlvbi9zY3JpcHQtdGVz dHMvd2luZG93LXByb3BlcnR5LmpzOgorICAgICAgICAqIGZhc3QvZG9tL0RldmljZU9yaWVudGF0 aW9uL3dpbmRvdy1wcm9wZXJ0eS1leHBlY3RlZC50eHQ6CisKIDIwMTMtMDQtMjUgIE1paG5lYSBP dmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBIaXQg dGVzdGluZyBpcyBicm9rZW4gZm9yIGFic29sdXRlbHkgcG9zaXRpb25lZCByZWdpb25zIHRoYXQg aGF2ZSBvdmVyZmxvdzogaGlkZGVuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9E ZXZpY2VNb3Rpb24vc2NyaXB0LXRlc3RzL3dpbmRvdy1wcm9wZXJ0eS5qcyBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL0RldmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5LmpzCmlu ZGV4IDYxYTM4NTIuLmVhMjIyMjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0Rl dmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5LmpzCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZG9tL0RldmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5Lmpz CkBAIC0xLDE3ICsxLDggQEAKIGRlc2NyaXB0aW9uKCJUZXN0cyB0aGF0IHRoZSB3aW5kb3cuRGV2 aWNlTW90aW9uRXZlbnQgYW5kIHdpbmRvdy5vbmRldmljZW1vdGlvbiBwcm9wZXJ0aWVzIGFyZSBw cmVzZW50LiIpOwogCi1mdW5jdGlvbiBoYXNEZXZpY2VNb3Rpb25FdmVudFByb3BlcnR5KCkKLXsK LSAgICBmb3IgKHZhciBwcm9wZXJ0eSBpbiB3aW5kb3cpIHsKLSAgICAgICAgaWYgKHByb3BlcnR5 ID09ICJEZXZpY2VNb3Rpb25FdmVudCIpCi0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9 Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCiBzaG91bGRCZVRydWUoInR5cGVvZiB3aW5kb3cuRGV2 aWNlTW90aW9uRXZlbnQgPT0gJ29iamVjdCciKTsKIHNob3VsZEJlRmFsc2UoInR5cGVvZiB3aW5k b3cuRGV2aWNlTW90aW9uRXZlbnQgPT0gJ2Z1bmN0aW9uJyIpOwotc2hvdWxkQmVUcnVlKCJoYXNE ZXZpY2VNb3Rpb25FdmVudFByb3BlcnR5KCkiKTsKK3Nob3VsZEJlRmFsc2UoIndpbmRvdy5wcm9w ZXJ0eUlzRW51bWVyYWJsZSgnRGV2aWNlTW90aW9uRXZlbnQnKSIpOwogc2hvdWxkQmVUcnVlKCIn RGV2aWNlTW90aW9uRXZlbnQnIGluIHdpbmRvdyIpOwogc2hvdWxkQmVUcnVlKCJ3aW5kb3cuaGFz T3duUHJvcGVydHkoJ0RldmljZU1vdGlvbkV2ZW50JykiKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vRGV2aWNlTW90aW9uL3dpbmRvdy1wcm9wZXJ0eS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9EZXZpY2VNb3Rpb24vd2luZG93LXByb3BlcnR5LWV4cGVj dGVkLnR4dAppbmRleCAzOTE2NzdhLi4xOWE4ZWY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9EZXZpY2VNb3Rpb24vd2luZG93LXByb3BlcnR5LWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9EZXZpY2VNb3Rpb24vd2luZG93LXByb3BlcnR5LWV4cGVjdGVk LnR4dApAQCAtNSw3ICs1LDcgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUKIAogUEFTUyB0eXBl b2Ygd2luZG93LkRldmljZU1vdGlvbkV2ZW50ID09ICdvYmplY3QnIGlzIHRydWUKIFBBU1MgdHlw ZW9mIHdpbmRvdy5EZXZpY2VNb3Rpb25FdmVudCA9PSAnZnVuY3Rpb24nIGlzIGZhbHNlCi1QQVNT IGhhc0RldmljZU1vdGlvbkV2ZW50UHJvcGVydHkoKSBpcyB0cnVlCitQQVNTIHdpbmRvdy5wcm9w ZXJ0eUlzRW51bWVyYWJsZSgnRGV2aWNlTW90aW9uRXZlbnQnKSBpcyBmYWxzZQogUEFTUyAnRGV2 aWNlTW90aW9uRXZlbnQnIGluIHdpbmRvdyBpcyB0cnVlCiBQQVNTIHdpbmRvdy5oYXNPd25Qcm9w ZXJ0eSgnRGV2aWNlTW90aW9uRXZlbnQnKSBpcyB0cnVlCiBQQVNTIHR5cGVvZiB3aW5kb3cub25k ZXZpY2Vtb3Rpb24gPT0gJ29iamVjdCcgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9kb20vRGV2aWNlT3JpZW50YXRpb24vc2NyaXB0LXRlc3RzL3dpbmRvdy1wcm9wZXJ0eS5q cyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU9yaWVudGF0aW9uL3NjcmlwdC10ZXN0cy93 aW5kb3ctcHJvcGVydHkuanMKaW5kZXggMGQ4NzUwYS4uNThjM2M4ZCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vRGV2aWNlT3JpZW50YXRpb24vc2NyaXB0LXRlc3RzL3dpbmRvdy1w cm9wZXJ0eS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9EZXZpY2VPcmllbnRhdGlvbi9z Y3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5LmpzCkBAIC0xLDE3ICsxLDggQEAKIGRlc2NyaXB0 aW9uKCdUZXN0cyB0aGF0IHRoZSB3aW5kb3cuRGV2aWNlT3JpZW50YXRpb25FdmVudCBhbmQgd2lu ZG93Lm9uZGV2aWNlb3JpZW50YXRpb24gcHJvcGVydGllcyBhcmUgcHJlc2VudC4nKTsKIAotZnVu Y3Rpb24gaGFzRGV2aWNlT3JpZW50YXRpb25FdmVudFByb3BlcnR5KCkKLXsKLSAgICBmb3IgKHZh ciBwcm9wZXJ0eSBpbiB3aW5kb3cpIHsKLSAgICAgICAgaWYgKHByb3BlcnR5ID09ICdEZXZpY2VP cmllbnRhdGlvbkV2ZW50JykKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLSAgICBy ZXR1cm4gZmFsc2U7Ci19Ci0KIHNob3VsZEJlVHJ1ZSgidHlwZW9mIHdpbmRvdy5EZXZpY2VPcmll bnRhdGlvbkV2ZW50ID09ICdvYmplY3QnIik7CiBzaG91bGRCZUZhbHNlKCJ0eXBlb2Ygd2luZG93 LkRldmljZU9yaWVudGF0aW9uRXZlbnQgPT0gJ2Z1bmN0aW9uJyIpOwotc2hvdWxkQmVUcnVlKCJo YXNEZXZpY2VPcmllbnRhdGlvbkV2ZW50UHJvcGVydHkoKSIpOworc2hvdWxkQmVGYWxzZSgid2lu ZG93LnByb3BlcnR5SXNFbnVtZXJhYmxlKCdEZXZpY2VPcmllbnRhdGlvbkV2ZW50JykiKTsKIHNo b3VsZEJlVHJ1ZSgiJ0RldmljZU9yaWVudGF0aW9uRXZlbnQnIGluIHdpbmRvdyIpOwogc2hvdWxk QmVUcnVlKCJ3aW5kb3cuaGFzT3duUHJvcGVydHkoJ0RldmljZU9yaWVudGF0aW9uRXZlbnQnKSIp OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9EZXZpY2VPcmllbnRhdGlvbi93 aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vRGV2aWNl T3JpZW50YXRpb24vd2luZG93LXByb3BlcnR5LWV4cGVjdGVkLnR4dAppbmRleCAzMDhhYjdhLi5k MWYxMTgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9EZXZpY2VPcmllbnRhdGlv bi93aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L0RldmljZU9yaWVudGF0aW9uL3dpbmRvdy1wcm9wZXJ0eS1leHBlY3RlZC50eHQKQEAgLTUsNyAr NSw3IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFCiAKIFBBU1MgdHlwZW9mIHdpbmRvdy5EZXZp Y2VPcmllbnRhdGlvbkV2ZW50ID09ICdvYmplY3QnIGlzIHRydWUKIFBBU1MgdHlwZW9mIHdpbmRv dy5EZXZpY2VPcmllbnRhdGlvbkV2ZW50ID09ICdmdW5jdGlvbicgaXMgZmFsc2UKLVBBU1MgaGFz RGV2aWNlT3JpZW50YXRpb25FdmVudFByb3BlcnR5KCkgaXMgdHJ1ZQorUEFTUyB3aW5kb3cucHJv cGVydHlJc0VudW1lcmFibGUoJ0RldmljZU9yaWVudGF0aW9uRXZlbnQnKSBpcyBmYWxzZQogUEFT UyAnRGV2aWNlT3JpZW50YXRpb25FdmVudCcgaW4gd2luZG93IGlzIHRydWUKIFBBU1Mgd2luZG93 Lmhhc093blByb3BlcnR5KCdEZXZpY2VPcmllbnRhdGlvbkV2ZW50JykgaXMgdHJ1ZQogUEFTUyB0 eXBlb2Ygd2luZG93Lm9uZGV2aWNlb3JpZW50YXRpb24gPT0gJ29iamVjdCcgaXMgdHJ1ZQo=