115107 2013-04-24 08:10:36 -0700 [Qt] Animated opacity does not trigger accelerated compositing 2013-04-26 06:46:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106309 110211 1 allan.jensen allan.jensen commit-queue esprehn+autocc noam simon.fraser oldest_to_newest 880555 0 allan.jensen 2013-04-24 08:10:36 -0700 Opacity is one of the properties where we support accelerated compositing, but only animated transforms and filters they do not themselves trigger accelerated compositing. Since opacity are always performed through some type of compositing (using TransparencyLayers if not accelerated), it should always be faster for us to choose AC. That opacity animations does not trigger compositing was changed in http://trac.webkit.org/changeset/45309, which means it is desired behavior at least on Mac. So we should make sure this is an optional behavior change. 880557 1 199457 allan.jensen 2013-04-24 08:15:50 -0700 Created attachment 199457 Patch 880559 2 commit-queue 2013-04-24 08:18:32 -0700 Attachment 199457 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/ChromeClient.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp']" exit_code: 1 Source/WebCore/rendering/RenderLayerCompositor.cpp:2110: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 880560 3 allan.jensen 2013-04-24 08:19:26 -0700 (In reply to comment #0) > but only animated transforms and filters they do not themselves trigger accelerated compositing. > Sentence refactoring mistake, read: "but unlike..." 880654 4 199457 noam 2013-04-24 09:05:37 -0700 Comment on attachment 199457 Patch Shouldn't AnimationTrigger cover this? 880672 5 allan.jensen 2013-04-24 09:35:27 -0700 (In reply to comment #4) > (From update of attachment 199457 [details]) > Shouldn't AnimationTrigger cover this? Well apparently not. It only triggers on animated transforms and filters. 881378 6 199457 commit-queue 2013-04-25 11:18:02 -0700 Comment on attachment 199457 Patch Clearing flags on attachment: 199457 Committed r149123: <http://trac.webkit.org/changeset/149123> 881380 7 commit-queue 2013-04-25 11:18:05 -0700 All reviewed patches have been landed. Closing bug. 199457 2013-04-24 08:15:50 -0700 2013-04-25 11:18:02 -0700 Patch bug-115107-20130424171513.patch text/plain 4043 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdlNjk1MzM0Y2NkZTEw NzM2YjljMjdhNDVkNjNjNmVjZGJkZmNhNS4uZjA1NDExYTdjOGNkMTE5ODEzODJlMTJlZWYwYmVk NTBmYTNiZDlkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTI0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gQW5pbWF0ZWQgb3BhY2l0eSBkb2VzIG5vdCB0cmlnZ2VyIGFjY2VsZXJhdGVkIGNvbXBvc2l0 aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUx MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg ZXh0cmEgb3B0aW9uIHRvIGFsc28gdHJpZ2dlciBjb21wb3NpdGluZyBvbiBhbmltYXRlZCBvcGFj aXR5LgorCisgICAgICAgICogcGFnZS9DaHJvbWVDbGllbnQuaDoKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3NpdGluZ0ZvckFuaW1hdGlvbik6CisKIDIwMTMt MDQtMjQgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIERP TUZpbGVTeXN0ZW1CYXNlOiBmaXggbXVsdGlwbGUgZGVmaW5pdGlvbnMgaW4gdGhlIEJsYWNrQmVy cnkgcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBiNTc2ZDI5MjQ2YTVhNTlmZDNhNTI0ZmM3NzllMzk1 YzVmMzIyMzQ2Li4yNTZiNGUxODVkYzE4NjcyNWI1ODU0OGU2MWY1ZmFmZDI4NDhiYWJmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTI0ICBBbGxhbiBTYW5kZmVsZCBK ZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtRdF0gQW5pbWF0ZWQg b3BhY2l0eSBkb2VzIG5vdCB0cmlnZ2VyIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxMDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgdHJpZ2dl ciBjb21wb3NpdGluZyBvbiBhbmltYXRlZCBvcGFjaXR5IGFzIGl0IGlzIGFsd2F5cyBmYXN0ZXIg b24gUXQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHA6Cisg ICAgICAgIFZpZGVvVHJpZ2dlciByZW1vdmVkIGJlY2F1c2Ugd2UgaGF2ZSBhbHJlYWR5IGRpc2Fi bGVkIEFDIGZvciB2aWRlbyBpbiBxd2Vic2V0dGluZ3MuCisKIDIwMTMtMDQtMjMgIEFsbGFuIFNh bmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XVtX SzFdIE1lbW9yeUNhY2hlIGlzIG5vdCBjbGVhbmVkIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0No cm9tZUNsaWVudC5oCmluZGV4IDYxMWNjYTk5Y2VhN2NhYjJkNWQ2ZTgyZTU1OTc2ZTcwZmRmOWJm NTYuLjI3MzliYmJlZTdkYzVjNmQ2Mjg5ZWJmMWYyM2U0MmMxZjQ0ZjdlYTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9DaHJvbWVDbGllbnQuaApAQCAtMjc5LDYgKzI3OSw3IEBAIHB1YmxpYzoKICAgICAgICAg QW5pbWF0aW9uVHJpZ2dlciA9IDEgPDwgNCwKICAgICAgICAgRmlsdGVyVHJpZ2dlciA9IDEgPDwg NSwKICAgICAgICAgU2Nyb2xsYWJsZUlubmVyRnJhbWVUcmlnZ2VyID0gMSA8PCA2LAorICAgICAg ICBBbmltYXRlZE9wYWNpdHlUcmlnZ2VyID0gMSA8PCA3LAogICAgICAgICBBbGxUcmlnZ2VycyA9 IDB4RkZGRkZGRkYKICAgICB9OwogICAgIHR5cGVkZWYgdW5zaWduZWQgQ29tcG9zaXRpbmdUcmln Z2VyRmxhZ3M7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCmluZGV4IDNmMTAyZjEwYmM2ZWI4ZmRkMTRhNzYwYjRhMjNhMjMzYjU3M2Jm YjkuLjA0OTAyNWY5YzI2YTIyMjM4Y2Y5ZGQwZGI0N2QwZjMyZDlhZWMxZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0y MTA2LDcgKzIxMDYsOCBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21w b3NpdGluZ0ZvckFuaW1hdGlvbihSZW5kZXJPYmplY3QqIHJlbmRlcgogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICBpZiAoQW5pbWF0aW9uQ29udHJvbGxlciogYW5pbUNvbnRyb2xsZXIgPSBy ZW5kZXJlci0+YW5pbWF0aW9uKCkpIHsKLSAgICAgICAgcmV0dXJuIChhbmltQ29udHJvbGxlci0+ aXNSdW5uaW5nQW5pbWF0aW9uT25SZW5kZXJlcihyZW5kZXJlciwgQ1NTUHJvcGVydHlPcGFjaXR5 KSAmJiBpbkNvbXBvc2l0aW5nTW9kZSgpKQorICAgICAgICByZXR1cm4gKGFuaW1Db250cm9sbGVy LT5pc1J1bm5pbmdBbmltYXRpb25PblJlbmRlcmVyKHJlbmRlcmVyLCBDU1NQcm9wZXJ0eU9wYWNp dHkpCisgICAgICAgICAgICAgICAgJiYgKGluQ29tcG9zaXRpbmdNb2RlKCkgfHwgKG1fY29tcG9z aXRpbmdUcmlnZ2VycyAmIENocm9tZUNsaWVudDo6QW5pbWF0ZWRPcGFjaXR5VHJpZ2dlcikpKQog I2lmIEVOQUJMRShDU1NfRklMVEVSUykKICNpZiAhUExBVEZPUk0oTUFDKSB8fCAoIVBMQVRGT1JN KElPUykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwKQogICAgICAg ICAgICAgLy8gPHJkYXI6Ly9wcm9ibGVtLzEwOTA3MjUxPiAtIFdlYktpdDIgZG9lc24ndCBzdXBw b3J0IENBIGFuaW1hdGlvbnMgb2YgQ0kgZmlsdGVycyBvbiBMaW9uIGFuZCBiZWxvdwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAppbmRl eCBlMmM4NDNlMTI1N2JkZWRjYTM5M2FkZDQ2MjhiMjMwOTllYjU1YmZmLi5lNTk0NDljYzY5MGRk ODc3YTFiMDI2NTdhMTRhZDc5MDcwNTY3YWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcApAQCAtNjU1LDcgKzY1NSw3IEBAIHZv aWQgQ2hyb21lQ2xpZW50UXQ6OnNjaGVkdWxlQ29tcG9zaXRpbmdMYXllckZsdXNoKCkKIENocm9t ZUNsaWVudDo6Q29tcG9zaXRpbmdUcmlnZ2VyRmxhZ3MgQ2hyb21lQ2xpZW50UXQ6OmFsbG93ZWRD b21wb3NpdGluZ1RyaWdnZXJzKCkgY29uc3QKIHsKICAgICBpZiAoYWxsb3dzQWNjZWxlcmF0ZWRD b21wb3NpdGluZygpKQotICAgICAgICByZXR1cm4gVGhyZWVEVHJhbnNmb3JtVHJpZ2dlciB8IFZp ZGVvVHJpZ2dlciB8IENhbnZhc1RyaWdnZXIgfCBBbmltYXRpb25UcmlnZ2VyOworICAgICAgICBy ZXR1cm4gVGhyZWVEVHJhbnNmb3JtVHJpZ2dlciB8IENhbnZhc1RyaWdnZXIgfCBBbmltYXRpb25U cmlnZ2VyIHwgQW5pbWF0ZWRPcGFjaXR5VHJpZ2dlcjsKIAogICAgIHJldHVybiAwOwogfQo=