115042 2013-04-23 08:13:28 -0700 Avoid computing style twice when element has no existing style 2013-04-23 09:24:48 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111627 1 koivisto webkit-unassigned cmarcelo commit-queue esprehn+autocc kling oldest_to_newest 879865 0 koivisto 2013-04-23 08:13:28 -0700 Element::recalcStyle can be more efficient. 879871 1 199243 koivisto 2013-04-23 08:28:21 -0700 Created attachment 199243 patch 879875 2 199243 kling 2013-04-23 08:36:18 -0700 Comment on attachment 199243 patch Nice catch! r=me 879884 3 koivisto 2013-04-23 09:12:26 -0700 http://trac.webkit.org/changeset/148970 199243 2013-04-23 08:28:21 -0700 2013-04-23 08:36:17 -0700 patch double-style-recalc-no-style.patch text/plain 4327 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODk2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTIzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCBjb21wdXRpbmcgc3R5 bGUgdHdpY2Ugd2hlbiBlbGVtZW50IGhhcyBubyBleGlzdGluZyBzdHlsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MDQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBXZSBjdXJyZW50bHkg Y29tcHV0ZSBlbGVtZW50IHN0eWxlIHR3aWNlIGlmIHdlIGVuZCB1cCBoYXZpbmcgdG8gcmVhdHRh Y2gsIGZpcnN0IGluIHJlY2FsY1N0eWxlIGFuZCB0aGVuCisgICAgICAgIGFnYWluIGR1cmluZyBh dHRhY2goKS4gV2UgY2FuIGVhc2lseSBhdm9pZCB0aGlzIGluIGNvbW1vbiBjYXNlIHdoZXJlIHRo ZSBlbGVtZW50IGhhcyBubyBleGlzdGluZyBzdHlsZQorICAgICAgICAodXN1YWxseSBiZWNhdXNl IGl0IGlzIGRpc3BsYXk6bm9uZSkuIAorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVjYWxjU3R5bGUpOgorICAgICAgICAKKyAgICAgICAg ICAgIERvbid0IGNvbXB1dGUgdGhlIHN0eWxlIGFuZCBkaWZmIGlmIHRoZXJlIGlzIG5vIGV4aXN0 aW5nIHN0eWxlLiBUaGVyZSBpcyBub3RoaW5nIHRvIGRpZmYgYWdhaW5zdC4KKyAgICAgICAgICAg IEluc3RlYWQganVzdCBjYWxsIHJlYXR0YWNoKCkgZGlyZWN0bHksIHdlIGVuZGVkIHVwIGRvaW5n IGFueXdheSB3aXRoIHRoZSBleGlzdGluZyBjb2RlLgorICAgICAgICAKIDIwMTMtMDQtMjMgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFNjcm9s bGJhclRoZW1lQ29tcG9zaXRlIGRlcGVuZHMgb24gUGFnZS9GcmFtZVZpZXcvQ2hyb21lQ2xpZW50 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCShyZXZpc2lvbiAxNDg1MTYpCisrKyBTb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MTAsOSArMTQxMCwx MyBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlIGNoCiAgICAgICAgICAg ICBlbGVtZW50UmFyZURhdGEoKS0+cmVzZXRDb21wdXRlZFN0eWxlKCk7CiAgICAgfQogICAgIGlm IChoYXNQYXJlbnRTdHlsZSAmJiAoY2hhbmdlID49IEluaGVyaXQgfHwgbmVlZHNTdHlsZVJlY2Fs YygpKSkgewotICAgICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IG5ld1N0eWxlID0gc3R5bGVGb3JS ZW5kZXJlcigpOwotICAgICAgICBTdHlsZUNoYW5nZSBjaCA9IE5vZGU6OmRpZmYoY3VycmVudFN0 eWxlLmdldCgpLCBuZXdTdHlsZS5nZXQoKSwgZG9jdW1lbnQoKSk7Ci0gICAgICAgIGlmIChjaCA9 PSBEZXRhY2ggfHwgIWN1cnJlbnRTdHlsZSkgeworICAgICAgICBTdHlsZUNoYW5nZSBsb2NhbENo YW5nZSA9IERldGFjaDsKKyAgICAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiBuZXdTdHlsZTsKKyAg ICAgICAgaWYgKGN1cnJlbnRTdHlsZSkgeworICAgICAgICAgICAgbmV3U3R5bGUgPSBzdHlsZUZv clJlbmRlcmVyKCk7CisgICAgICAgICAgICBsb2NhbENoYW5nZSA9IE5vZGU6OmRpZmYoY3VycmVu dFN0eWxlLmdldCgpLCBuZXdTdHlsZS5nZXQoKSwgZG9jdW1lbnQoKSk7CisgICAgICAgIH0KKyAg ICAgICAgaWYgKGxvY2FsQ2hhbmdlID09IERldGFjaCkgewogICAgICAgICAgICAgLy8gRklYTUU6 IFRoZSBzdHlsZSBnZXRzIGNvbXB1dGVkIHR3aWNlIGJ5IGNhbGxpbmcgYXR0YWNoLiBXZSBjb3Vs ZCBkbyBiZXR0ZXIgaWYgd2UgcGFzc2VkIHRoZSBzdHlsZSBhbG9uZy4KICAgICAgICAgICAgIHJl YXR0YWNoKCk7CiAgICAgICAgICAgICAvLyBhdHRhY2ggcmVjYWxjdWxhdGVzIHRoZSBzdHlsZSBm b3IgYWxsIGNoaWxkcmVuLiBObyBuZWVkIHRvIGRvIGl0IHR3aWNlLgpAQCAtMTQyNSw3ICsxNDI5 LDcgQEAgdm9pZCBFbGVtZW50OjpyZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBjaAogICAgICAgICB9 CiAKICAgICAgICAgaWYgKFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSB0aGlzLT5yZW5kZXJlcigp KSB7Ci0gICAgICAgICAgICBpZiAoY2ggIT0gTm9DaGFuZ2UgfHwgcHNldWRvU3R5bGVDYWNoZUlz SW52YWxpZChjdXJyZW50U3R5bGUuZ2V0KCksIG5ld1N0eWxlLmdldCgpKSB8fCAoY2hhbmdlID09 IEZvcmNlICYmIHJlbmRlcmVyLT5yZXF1aXJlc0ZvcmNlZFN0eWxlUmVjYWxjUHJvcGFnYXRpb24o KSkgfHwgc3R5bGVDaGFuZ2VUeXBlKCkgPT0gU3ludGhldGljU3R5bGVDaGFuZ2UpCisgICAgICAg ICAgICBpZiAobG9jYWxDaGFuZ2UgIT0gTm9DaGFuZ2UgfHwgcHNldWRvU3R5bGVDYWNoZUlzSW52 YWxpZChjdXJyZW50U3R5bGUuZ2V0KCksIG5ld1N0eWxlLmdldCgpKSB8fCAoY2hhbmdlID09IEZv cmNlICYmIHJlbmRlcmVyLT5yZXF1aXJlc0ZvcmNlZFN0eWxlUmVjYWxjUHJvcGFnYXRpb24oKSkg fHwgc3R5bGVDaGFuZ2VUeXBlKCkgPT0gU3ludGhldGljU3R5bGVDaGFuZ2UpCiAgICAgICAgICAg ICAgICAgcmVuZGVyZXItPnNldEFuaW1hdGFibGVTdHlsZShuZXdTdHlsZS5nZXQoKSk7CiAgICAg ICAgICAgICBlbHNlIGlmIChuZWVkc1N0eWxlUmVjYWxjKCkpIHsKICAgICAgICAgICAgICAgICAv LyBBbHRob3VnaCBubyBjaGFuZ2Ugb2NjdXJyZWQsIHdlIHVzZSB0aGUgbmV3IHN0eWxlIHNvIHRo YXQgdGhlIGNvdXNpbiBzdHlsZSBzaGFyaW5nIGNvZGUgd29uJ3QgZ2V0CkBAIC0xNDM2LDcgKzE0 NDAsNyBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlIGNoCiAKICAgICAg ICAgLy8gSWYgInJlbSIgdW5pdHMgYXJlIHVzZWQgYW55d2hlcmUgaW4gdGhlIGRvY3VtZW50LCBh bmQgaWYgdGhlIGRvY3VtZW50IGVsZW1lbnQncyBmb250IHNpemUgY2hhbmdlcywgdGhlbiBnbyBh aGVhZCBhbmQgZm9yY2UgZm9udCB1cGRhdGluZwogICAgICAgICAvLyBhbGwgdGhlIHdheSBkb3du IHRoZSB0cmVlLiBUaGlzIGlzIHNpbXBsZXIgdGhhbiBoYXZpbmcgdG8gbWFpbnRhaW4gYSBjYWNo ZSBvZiBvYmplY3RzIChhbmQgc3VjaCBmb250IHNpemUgY2hhbmdlcyBzaG91bGQgYmUgcmFyZSBh bnl3YXkpLgotICAgICAgICBpZiAoZG9jdW1lbnQoKS0+c3R5bGVTaGVldENvbGxlY3Rpb24oKS0+ dXNlc1JlbVVuaXRzKCkgJiYgZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50KCkgPT0gdGhpcyAm JiBjaCAhPSBOb0NoYW5nZSAmJiBjdXJyZW50U3R5bGUgJiYgbmV3U3R5bGUgJiYgY3VycmVudFN0 eWxlLT5mb250U2l6ZSgpICE9IG5ld1N0eWxlLT5mb250U2l6ZSgpKSB7CisgICAgICAgIGlmIChk b2N1bWVudCgpLT5zdHlsZVNoZWV0Q29sbGVjdGlvbigpLT51c2VzUmVtVW5pdHMoKSAmJiBkb2N1 bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKSA9PSB0aGlzICYmIGxvY2FsQ2hhbmdlICE9IE5vQ2hh bmdlICYmIGN1cnJlbnRTdHlsZSAmJiBuZXdTdHlsZSAmJiBjdXJyZW50U3R5bGUtPmZvbnRTaXpl KCkgIT0gbmV3U3R5bGUtPmZvbnRTaXplKCkpIHsKICAgICAgICAgICAgIC8vIENhY2hlZCBSZW5k ZXJTdHlsZXMgbWF5IGRlcGVuZCBvbiB0aGUgcmUgdW5pdHMuCiAgICAgICAgICAgICBkb2N1bWVu dCgpLT5zdHlsZVJlc29sdmVyKCktPmludmFsaWRhdGVNYXRjaGVkUHJvcGVydGllc0NhY2hlKCk7 CiAgICAgICAgICAgICBjaGFuZ2UgPSBGb3JjZTsKQEAgLTE0NDYsNyArMTQ1MCw3IEBAIHZvaWQg RWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2gKICAgICAgICAgICAgIGlmIChzdHls ZUNoYW5nZVR5cGUoKSA+PSBGdWxsU3R5bGVDaGFuZ2UpCiAgICAgICAgICAgICAgICAgY2hhbmdl ID0gRm9yY2U7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgY2hhbmdlID0gY2g7 CisgICAgICAgICAgICAgICAgY2hhbmdlID0gbG9jYWxDaGFuZ2U7CiAgICAgICAgIH0KICAgICB9 CiAgICAgU3R5bGVSZXNvbHZlclBhcmVudFB1c2hlciBwYXJlbnRQdXNoZXIodGhpcyk7Cg==