114970 2013-04-22 11:25:27 -0700 StringImpl.h should compile with -Wshorten-64-to-32 2013-04-22 19:41:59 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107093 1 ddkilzer ddkilzer benjamin cmarcelo commit-queue darin oldest_to_newest 879274 0 ddkilzer 2013-04-22 11:25:27 -0700 Fixes the following warnings with -Wshorten-64-to-32: StringImpl.h:317:25: error: implicit conversion loses integer precision: 'uintptr_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] unsigned hash = reinterpret_cast<uintptr_t>(this); ~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 879280 1 199053 ddkilzer 2013-04-22 11:27:24 -0700 Created attachment 199053 Patch v1 879286 2 199053 darin 2013-04-22 11:33:28 -0700 Comment on attachment 199053 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=199053&action=review > Source/WTF/wtf/text/StringImpl.h:316 > - unsigned hash = reinterpret_cast<uintptr_t>(this); > + unsigned hash = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(this)); This is a silly approach to creating the hash. For example, the low bits will always be due to alignment zero. I suggest we use a random number instead. Code change is OK, but code is dumb. 879371 3 commit-queue 2013-04-22 12:11:27 -0700 The commit-queue encountered the following flaky tests while processing attachment 199053: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 879372 4 199053 commit-queue 2013-04-22 12:12:20 -0700 Comment on attachment 199053 Patch v1 Clearing flags on attachment: 199053 Committed r148900: <http://trac.webkit.org/changeset/148900> 879373 5 commit-queue 2013-04-22 12:12:22 -0700 All reviewed patches have been landed. Closing bug. 879381 6 ddkilzer 2013-04-22 12:20:04 -0700 (In reply to comment #2) > (From update of attachment 199053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199053&action=review > > > Source/WTF/wtf/text/StringImpl.h:316 > > - unsigned hash = reinterpret_cast<uintptr_t>(this); > > + unsigned hash = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(this)); > > This is a silly approach to creating the hash. For example, the low bits will always be due to alignment zero. I suggest we use a random number instead. > > Code change is OK, but code is dumb. Should we use WTF::intHash(uint32_t) on 32-bit platforms and WTF::intHas(uint64_t) on 64-bit platforms instead? 879488 7 benjamin 2013-04-22 15:48:53 -0700 (In reply to comment #6) > (In reply to comment #2) > > (From update of attachment 199053 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=199053&action=review > > > > > Source/WTF/wtf/text/StringImpl.h:316 > > > - unsigned hash = reinterpret_cast<uintptr_t>(this); > > > + unsigned hash = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(this)); > > > > This is a silly approach to creating the hash. For example, the low bits will always be due to alignment zero. I suggest we use a random number instead. > > > > Code change is OK, but code is dumb. > > Should we use WTF::intHash(uint32_t) on 32-bit platforms and WTF::intHas(uint64_t) on 64-bit platforms instead? The only property needed for that hash is it should never equals the hash of emptyString(). We could basically use a constant here. Any number !m hash(empty()) has the same theoretical chances of conflicts. I have been trying to kill this constructor every now and then :) 879520 8 darin 2013-04-22 16:34:51 -0700 (In reply to comment #7) > The only property needed for that hash is it should never equals the hash of emptyString(). Maybe (hash(emptyString()) ^ 0x100) would work? 879565 9 ddkilzer 2013-04-22 19:41:59 -0700 (In reply to comment #8) > (In reply to comment #7) > > The only property needed for that hash is it should never equals the hash of emptyString(). > > Maybe (hash(emptyString()) ^ 0x100) would work? Filed Bug 115008 to track this issue. 199053 2013-04-22 11:27:24 -0700 2013-04-22 12:12:19 -0700 Patch v1 bug-114970-20130422112649.patch text/plain 1910 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4ODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZhYmFlOTRjNjQ1ZjNiMjk0MmVkMjI3 MjE1ZjliMzY5MTNkMTlmMzAuLjk0MTY0ZjQwYWIxMWYyYzk1ODYyZGJiOWJjMzBkZTQ1YWRjNjc1 N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTMtMDQtMjIgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAorICAgICAgICBTdHJpbmdJbXBsLmggc2hvdWxkIGNvbXBpbGUgd2l0 aCAtV3Nob3J0ZW4tNjQtdG8tMzIKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTE0OTcw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVz IHRoZSBmb2xsb3dpbmcgd2FybmluZ3Mgd2l0aCAtV3Nob3J0ZW4tNjQtdG8tMzI6CisKKyAgICAg ICAgICAgIFN0cmluZ0ltcGwuaDozMTc6MjU6IGVycm9yOiBpbXBsaWNpdCBjb252ZXJzaW9uIGxv c2VzIGludGVnZXIgcHJlY2lzaW9uOiAndWludHB0cl90JyAoYWthICd1bnNpZ25lZCBsb25nJykg dG8gJ3Vuc2lnbmVkIGludCcgWy1XZXJyb3IsLVdzaG9ydGVuLTY0LXRvLTMyXQorICAgICAgICAg ICAgICAgICAgICB1bnNpZ25lZCBoYXNoID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHRo aXMpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICB+fn5+ICAgXn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+CisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6Cisg ICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OlN0cmluZ0ltcGwpOiBBZGQgc3RhdGljX2Nhc3Q8dWlu dDMyX3Q+KCkgdG8KKyAgICAgICAgZm9ybWFsaXplIHRha2luZyB0aGUgbG93ZXIgMzItYml0cyBv ZiB0aGUgcG9pbnRlciB2YWx1ZSBvbgorICAgICAgICA2NC1iaXQgYXJjaGl0ZWN0dXJlcy4KKwor MjAxMy0wNC0yMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAg IFdURjo6QXRvbWljU3RyaW5nOjpmaW5kKCkgc2hvdWxkIHRha2UgdW5zaWduZWQgJ3N0YXJ0JyBh cmd1bWVudAogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMTQ5NTg+CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oIGIvU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdJbXBsLmgKaW5kZXggMTg2OWQ2YzZjZDk2ZDkzYTU0NzZiY2RiNjVlOThhNmM3ZjZi YTViMi4uMGQ5ZGI0OGIxNTBjZTdiODkxN2JiMDA2NGJjZWQwZjZjNDQxZWE4OSAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIvU291cmNlL1dURi93dGYv dGV4dC9TdHJpbmdJbXBsLmgKQEAgLTMxMyw3ICszMTMsNyBAQCBwcml2YXRlOgogICAgICAgICAv LyBrZXlzIG1lYW5zIHRoYXQgd2UgZG9uJ3QgbmVlZCB0aGVtIHRvIG1hdGNoIGFueSBvdGhlciBz dHJpbmcgKGluIGZhY3QsCiAgICAgICAgIC8vIHRoYXQncyBleGFjdGx5IHRoZSBvcG9zaXRlIG9m IHdoYXQgd2Ugd2FudCEpLCBhbmQgdGVoIG5vcm1hbCBoYXNoIHdvdWxkCiAgICAgICAgIC8vIGxl YWQgdG8gbG90cyBvZiBjb25mbGljdHMuCi0gICAgICAgIHVuc2lnbmVkIGhhc2ggPSByZWludGVy cHJldF9jYXN0PHVpbnRwdHJfdD4odGhpcyk7CisgICAgICAgIHVuc2lnbmVkIGhhc2ggPSBzdGF0 aWNfY2FzdDx1aW50MzJfdD4ocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHRoaXMpKTsKICAg ICAgICAgaGFzaCA8PD0gc19mbGFnQ291bnQ7CiAgICAgICAgIGlmICghaGFzaCkKICAgICAgICAg ICAgIGhhc2ggPSAxIDw8IHNfZmxhZ0NvdW50Owo=