114953 2013-04-22 06:36:08 -0700 BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect() 2013-05-09 11:37:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia commit-queue oldest_to_newest 879109 0 berto 2013-04-22 06:36:08 -0700 We have this error: Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.cpp:68:28: error: 'class WebCore::LayerWebKitThread' has no member named 'setHolePunchRect' The problem is that HolePunchData holds a pointer to LayerWebKitThread (PlatformLayer). 879111 1 199023 berto 2013-04-22 06:44:17 -0700 Created attachment 199023 Patch This would be the simplest patch, and is consistent with what it's already being done in other parts of the same code. However I wonder if it wouldn't be better to change the pointer in HolePunchData directly. 886954 2 199023 rwlbuis 2013-05-09 11:07:58 -0700 Comment on attachment 199023 Patch LGTM. 886988 3 199023 commit-queue 2013-05-09 11:37:53 -0700 Comment on attachment 199023 Patch Clearing flags on attachment: 199023 Committed r149827: <http://trac.webkit.org/changeset/149827> 886989 4 commit-queue 2013-05-09 11:37:55 -0700 All reviewed patches have been landed. Closing bug. 199023 2013-04-22 06:44:17 -0700 2013-05-09 11:37:53 -0700 Patch 114953.diff text/plain 1418 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTFhMDA2Li41ODk1NDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDQtMjIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIEJsYWNrQmVycnk6IGZpeCBjYWxsIHRvIFBsdWdpbkxheWVyV2ViS2l0VGhyZWFkOjpz ZXRIb2xlUHVuY2hSZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDk1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGRhdGEtPmxheWVyIG5lZWRzIGEgY2FzdCBpbiBvcmRlciB0byBjYWxsIHNldEhv bGVQdW5jaFJlY3QoKS4KKworICAgICAgICAqIHBsdWdpbnMvYmxhY2tiZXJyeS9OUENhbGxiYWNr c0JsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bnBTZXRIb2xlUHVuY2hIYW5kbGVy KToKKwogMjAxMy0wNC0yMSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtQYXJ0IDRdIFBhcnNlIHRoZSBjdXN0b20oKSBmdW5jdGlvbiBpbiAtd2Via2l0LWZpbHRl cjogcGFyc2UgdGhlIG1hdE4oKSBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvYmxhY2tiZXJyeS9OUENhbGxiYWNrc0JsYWNrQmVycnkuY3BwIGIvU291cmNlL1dl YkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L05QQ2FsbGJhY2tzQmxhY2tCZXJyeS5jcHAKaW5kZXgg ZDEyMmVmNi4uYWQwYTQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFj a2JlcnJ5L05QQ2FsbGJhY2tzQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9ibGFja2JlcnJ5L05QQ2FsbGJhY2tzQmxhY2tCZXJyeS5jcHAKQEAgLTY1LDcgKzY1LDcg QEAgdm9pZCBucFNldEhvbGVQdW5jaEhhbmRsZXIodm9pZCogaG9sZVB1bmNoRGF0YSkKIHsKICAg ICBPd25QdHI8SG9sZVB1bmNoRGF0YT4gZGF0YSA9IGFkb3B0UHRyKHN0YXRpY19jYXN0PEhvbGVQ dW5jaERhdGEqPihob2xlUHVuY2hEYXRhKSk7CiAgICAgaWYgKGRhdGEtPmxheWVyKQotICAgICAg ICBkYXRhLT5sYXllci0+c2V0SG9sZVB1bmNoUmVjdChJbnRSZWN0KGRhdGEtPngsIGRhdGEtPnks IGRhdGEtPncsIGRhdGEtPmgpKTsKKyAgICAgICAgc3RhdGljX2Nhc3Q8UGx1Z2luTGF5ZXJXZWJL aXRUaHJlYWQqPihkYXRhLT5sYXllci5nZXQoKSktPnNldEhvbGVQdW5jaFJlY3QoSW50UmVjdChk YXRhLT54LCBkYXRhLT55LCBkYXRhLT53LCBkYXRhLT5oKSk7CiB9CiAjZW5kaWYKIAo=