114750 2013-04-17 11:01:17 -0700 [Qt][Mac] Remove obsolete workaround for debug builds 2013-04-20 02:52:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110211 1 abecsi abecsi jturcotte vestbo zeno oldest_to_newest 877378 0 abecsi 2013-04-17 11:01:17 -0700 [Qt][Mac] Remove obsolete workaround for debug builds 877380 1 198585 abecsi 2013-04-17 11:02:48 -0700 Created attachment 198585 Patch 877383 2 198587 abecsi 2013-04-17 11:08:00 -0700 Created attachment 198587 Patch 877730 3 198587 jturcotte 2013-04-18 00:44:35 -0700 Comment on attachment 198587 Patch If this is broken there is good chance that all references to BASE_TARGET are also broken. 877782 4 abecsi 2013-04-18 03:15:25 -0700 (In reply to comment #3) > (From update of attachment 198587 [details]) > If this is broken there is good chance that all references to BASE_TARGET are also broken. My understanding is that the BASE_TARGET hack only applies for framework builds of Qt, which do not have the version number in their name. (The corresponding issue was reported here https://bugreports.qt-project.org/browse/QTBUG-30466) This causes a problem for non-framework builds where we tried to support debug-only builds with this hack. My assumption is that this workaround was put in place to remove the "_debug" suffix and probably worked before the library split when there was no version number in the libraries. 877784 5 abecsi 2013-04-18 03:19:33 -0700 Btw, I tried both framework and non-framework builds with this, using build-webkit and simply qmake && make and both worked. The stable branch is also missing the BASE_TARGET hack from the widgets.pri, so I'm going to cherry-pick that from trunk. 878442 6 jturcotte 2013-04-19 08:12:26 -0700 Personally I don't use the configuration covered by that code, so if Tor Arne and Zeno are good with it I think it's good. 878444 7 198587 jturcotte 2013-04-19 08:12:57 -0700 Comment on attachment 198587 Patch r=me if you make sure they are OK with it. 878547 8 zeno 2013-04-19 09:42:37 -0700 (In reply to comment #7) > (From update of attachment 198587 [details]) > r=me if you make sure they are OK with it. Lgtm 878745 9 198587 abecsi 2013-04-20 02:51:57 -0700 Comment on attachment 198587 Patch Clearing flags on attachment: 198587 Committed r148789: <http://trac.webkit.org/changeset/148789> 878746 10 abecsi 2013-04-20 02:52:04 -0700 All reviewed patches have been landed. Closing bug. 198585 2013-04-17 11:02:48 -0700 2013-04-17 11:07:55 -0700 Patch bug-114750-20130417200219.patch text/plain 1915 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2Uvd2lkZ2V0c2Fw aS5wcmkgYi9Tb3VyY2Uvd2lkZ2V0c2FwaS5wcmkKaW5kZXggYTIzN2Y5OWIyNGQzODhkOGE1ZTUy MmRhNDVmM2RiNDRiYWQwZmY1My4uYWEwN2Y3ZWM1ZmI3NjkxZWIwZGY5M2U0YWYzYmVkZmIzNGMz NzAxZiAxMDA2NDQKLS0tIGEvU291cmNlL3dpZGdldHNhcGkucHJpCisrKyBiL1NvdXJjZS93aWRn ZXRzYXBpLnByaQpAQCAtNzMsOSArNzMsNiBAQCBCQVNFX1RBUkdFVCA9ICQkVEFSR0VUCiAKIGxv YWQocXRfbW9kdWxlKQogCi0jIEFsbG93IGRvaW5nIGEgZGVidWctb25seSBidWlsZCBvZiBXZWJL aXQgKG5vdCBzdXBwb3J0ZWQgYnkgUXQpCi1tYWN4OiFkZWJ1Z19hbmRfcmVsZWFzZTpkZWJ1Zzog VEFSR0VUID0gJCRCQVNFX1RBUkdFVAotCiAjIE1ha2Ugc3VyZSB0aGUgaW5zdGFsbF9uYW1lIG9m IHRoZSBRdFdlYktpdCBsaWJyYXJ5IHBvaW50IHRvIHdlYmtpdAogZm9yY2VfaW5kZXBlbmRlbnQ6 bWFjeCB7CiAgICAgIyBXZSBkbyBvdXIgb3duIGFic29sdXRlIHBhdGggc28gdGhhdCB3ZSBjYW4g dHJpY2sgcW1ha2UgaW50bwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDQ1MTVkMDM2MzA5YjRhYTVmZmViY2ZjNDNiNGY2NDRlY2ZmYWJlZTcuLmI1Y2RiZTlhNDVmZTEy MDEwYzA1NGZhYjI1OWJiZGVlNGE2YjZhZDYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMy0wNC0xNyAgQW5kcmFzIEJlY3NpICA8YW5k cmFzLmJlY3NpQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdW01hY10gUmVtb3ZlIG9ic29sZXRl IHdvcmthcm91bmQgZm9yIGRlYnVnIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3b3JrYXJvdW5kIG1hZGUgZGVmYXVsdCBidWlsZHMg ZmFpbCB3aXRoIHJlY2VudCBRdDUgYmVjYXVzZQorICAgICAgICBpdCByZW1vdmVkIHRoZSBtYWpv ciB2ZXJzaW9uIG51bWJlciBmcm9tIHRoZSBsaWJyYXJ5IG5hbWUsIHByb2R1Y2luZworICAgICAg ICBRdFdlYktpdFdpZGdldHMsIHdoZXJlYXMgdGhlIGxpbmtpbmcgY29tbWFuZCBsaW5lIHRyaWVk IHRvIGxpbmsKKyAgICAgICAgYWdhaW5zdCBRdDVXZWJLaXRXaWRnZXRzLgorICAgICAgICBEZWJ1 ZyBidWlsZHMgYXJlIHBvc3NpYmxlIHdpdGggYW5kIHdpdGhvdXQgZnJhbWV3b3JrLWVuYWJsZWQg YnVpbGRzCisgICAgICAgIG9mIFF0LCBidXQgdGhlIGRlYnVnIHZlcnNpb25zIG9mIHRoZSBRdCBs aWJyYXJpZXMgaGF2ZSB0byBiZSBwcmVzZW50LgorICAgICAgICBEZWJ1ZyBidWlsZHMgd2l0aCBh IHJlbGVhc2UgdmVyc2lvbiBvZiBRdCBhcmUgbm90IHBvc3NpYmxlIG9uIE1hYworICAgICAgICBz aW5jZSBmb3IgZGVidWcgYnVpbGRzIHFtYWtlIHByb2R1Y2VzIGEgbGlua2VyIGNvbW1hZCBsaW5l IHdoZXJlCisgICAgICAgIGFsbCB0aGUgUXQgbGlicmFyaWVzIGhhdmUgdGhlICJfZGVidWciIHN1 ZmZpeCwgdGhlcmVmb3Igb25seSByZW1vdmluZworICAgICAgICB0aGUgIl9kZWJ1ZyIgc3VmZml4 IGZyb20gdGhlIHdpZGdldHMgbGlicmFyeSBkb2VzIG5vdCByZXN1bHQgaW4KKyAgICAgICAgc3Vj Y2Vzc2Z1bCBidWlsZHMuCisKKyAgICAgICAgKiBTb3VyY2Uvd2lkZ2V0c2FwaS5wcmk6CisKIDIw MTMtMDQtMTYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW0NNYWtlXSBEbyBub3QgdXNlIEpBVkFTQ1JJUFRDT1JFX0RJUiBpbiBhZGRfY3VzdG9tX2Nv bW1hbmQoKSBvZiBKYXZhU2NyaXB0Y29yZSBwcm9qZWN0Cg== 198587 2013-04-17 11:08:00 -0700 2013-04-20 02:51:57 -0700 Patch bug-114750-20130417200731.patch text/plain 1863 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2Uvd2lkZ2V0c2Fw aS5wcmkgYi9Tb3VyY2Uvd2lkZ2V0c2FwaS5wcmkKaW5kZXggYTIzN2Y5OWIyNGQzODhkOGE1ZTUy MmRhNDVmM2RiNDRiYWQwZmY1My4uYWEwN2Y3ZWM1ZmI3NjkxZWIwZGY5M2U0YWYzYmVkZmIzNGMz NzAxZiAxMDA2NDQKLS0tIGEvU291cmNlL3dpZGdldHNhcGkucHJpCisrKyBiL1NvdXJjZS93aWRn ZXRzYXBpLnByaQpAQCAtNzMsOSArNzMsNiBAQCBCQVNFX1RBUkdFVCA9ICQkVEFSR0VUCiAKIGxv YWQocXRfbW9kdWxlKQogCi0jIEFsbG93IGRvaW5nIGEgZGVidWctb25seSBidWlsZCBvZiBXZWJL aXQgKG5vdCBzdXBwb3J0ZWQgYnkgUXQpCi1tYWN4OiFkZWJ1Z19hbmRfcmVsZWFzZTpkZWJ1Zzog VEFSR0VUID0gJCRCQVNFX1RBUkdFVAotCiAjIE1ha2Ugc3VyZSB0aGUgaW5zdGFsbF9uYW1lIG9m IHRoZSBRdFdlYktpdCBsaWJyYXJ5IHBvaW50IHRvIHdlYmtpdAogZm9yY2VfaW5kZXBlbmRlbnQ6 bWFjeCB7CiAgICAgIyBXZSBkbyBvdXIgb3duIGFic29sdXRlIHBhdGggc28gdGhhdCB3ZSBjYW4g dHJpY2sgcW1ha2UgaW50bwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDQ1MTVkMDM2MzA5YjRhYTVmZmViY2ZjNDNiNGY2NDRlY2ZmYWJlZTcuLmEwYzY2MTBmMmMxYWM5 YmE0NzY4NzUxZjc3NzI3NTlkMjVhMTk5MzUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wNC0xNyAgQW5kcmFzIEJlY3NpICA8YW5k cmFzLmJlY3NpQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdW01hY10gUmVtb3ZlIG9ic29sZXRl IHdvcmthcm91bmQgZm9yIGRlYnVnIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3b3JrYXJvdW5kIG1hZGUgZGVmYXVsdCBidWlsZHMg ZmFpbCB3aXRoIHJlY2VudCBRdDUgYmVjYXVzZQorICAgICAgICBpdCByZW1vdmVkIHRoZSBtYWpv ciB2ZXJzaW9uIG51bWJlciBmcm9tIHRoZSBsaWJyYXJ5IG5hbWUsIHByb2R1Y2luZworICAgICAg ICBRdFdlYktpdFdpZGdldHMsIHdoZXJlYXMgdGhlIGxpbmtpbmcgY29tbWFuZCBsaW5lIHRyaWVk IHRvIGxpbmsKKyAgICAgICAgYWdhaW5zdCBRdDVXZWJLaXRXaWRnZXRzLgorICAgICAgICBEZWJ1 ZyBidWlsZHMgYXJlIHBvc3NpYmxlIHdpdGggYW5kIHdpdGhvdXQgZnJhbWV3b3JrLWVuYWJsZWQg YnVpbGRzCisgICAgICAgIG9mIFF0LCBidXQgdGhlIGRlYnVnIHZlcnNpb25zIG9mIHRoZSBRdCBs aWJyYXJpZXMgaGF2ZSB0byBiZSBwcmVzZW50LgorICAgICAgICBEZWJ1ZyBidWlsZHMgd2l0aCBh IHJlbGVhc2UgdmVyc2lvbiBvZiBRdCBhcmUgbm90IHBvc3NpYmxlIG9uIE1hYworICAgICAgICBz aW5jZSBmb3IgZGVidWcgYnVpbGRzIHFtYWtlIHByb2R1Y2VzIGEgbGlua2VyIGNvbW1hbmQgbGlu ZSB3aGVyZQorICAgICAgICBhbGwgdGhlIFF0IGxpYnJhcmllcyBoYXZlIHRoZSAiX2RlYnVnIiBz dWZmaXgsIHRoZXJlZm9yZSBpZiB0aGUgZGVidWcKKyAgICAgICAgbGlicmFyaWVzIGFyZSBtaXNz aW5nIHRoZSBidWlsZCBmYWlscy4KKworICAgICAgICAqIFNvdXJjZS93aWRnZXRzYXBpLnByaToK KwogMjAxMy0wNC0xNiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbQ01ha2VdIERvIG5vdCB1c2UgSkFWQVNDUklQVENPUkVfRElSIGluIGFkZF9jdXN0 b21fY29tbWFuZCgpIG9mIEphdmFTY3JpcHRjb3JlIHByb2plY3QK