114686 2013-04-16 09:09:41 -0700 [BlackBerry] Add support for filesystem: URLs to media player 2013-04-17 08:55:30 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jgriggs jgriggs commit-queue eric.carlson jer.noble mifenton rwlbuis tonikitoo oldest_to_newest 876566 0 jgriggs 2013-04-16 09:09:41 -0700 Add support to allow the BlackBerry Media Player to load media resources identified by filesystem: URLs that refer to entities in the Web File System. 876572 1 198335 jgriggs 2013-04-16 09:18:34 -0700 Created attachment 198335 Patch 877178 2 198335 rwlbuis 2013-04-17 08:00:51 -0700 Comment on attachment 198335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198335&action=review Looks good. > Source/WebCore/ChangeLog:9 > + Translate filesystem: URLs to file:// URLs for use by the media player, but only after the filesystem: URL has been checked for security, etc. Next time please add the internal reviewer (Liam Quinn in this case). 877319 3 commit-queue 2013-04-17 08:54:34 -0700 The commit-queue encountered the following flaky tests while processing attachment 198335: platform/mac/fonts/han-disunification.html bug 114207 (author: ap@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) media/video-no-audio.html bug 114748 (authors: annacc@chromium.org, jamesr@chromium.org, rniwa@webkit.org, and vrk@chromium.org) The commit-queue is continuing to process your patch. 877320 4 198335 commit-queue 2013-04-17 08:55:28 -0700 Comment on attachment 198335 Patch Clearing flags on attachment: 198335 Committed r148613: <http://trac.webkit.org/changeset/148613> 877321 5 commit-queue 2013-04-17 08:55:30 -0700 All reviewed patches have been landed. Closing bug. 198335 2013-04-16 09:18:34 -0700 2013-04-17 08:55:28 -0700 Patch bug-114686-20130416121807.patch text/plain 5410 jgriggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk2NjM2NTQyMTFmZWRl ZTE4ZjE2MGEyOTdhNmUyMDg4ZDVjZGNmZC4uYWVkNzI4NTk1ZmUwNWRmOGI1NDQzMGMyOTYzMDdk Nzk5NWRkYmU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTE2ICBKb2hu IEdyaWdncyAgPGpncmlnZ3NAYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IEFkZCBzdXBwb3J0IGZvciBmaWxlc3lzdGVtOiBVUkxzIHRvIEJsYWNrQmVycnkgTWVkaWEgUGxh eWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0 Njg2CisgICAgICAgIGh0dHBzOi8vcHJ6aWxsYS5vdHQucW54LmNvbS9idWd6aWxsYS9zaG93X2J1 Zy5jZ2k/aWQ9MzE0ODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVHJhbnNsYXRlIGZpbGVzeXN0ZW06IFVSTHMgdG8gZmlsZTovLyBVUkxzIGZvciB1 c2UgYnkgdGhlIG1lZGlhIHBsYXllciwgYnV0IG9ubHkgYWZ0ZXIgdGhlIGZpbGVzeXN0ZW06IFVS TCBoYXMgYmVlbiBjaGVja2VkIGZvciBzZWN1cml0eSwgZXRjLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6bG9hZCk6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6Om9uRXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFQbGF5ZXJQcml2YXRlOjpvbkR1cmF0aW9uQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGU6Om5vdGlmeUNoYWxsZW5nZVJlc3VsdCk6CisKIDIwMTMtMDQt MTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04ocjE0ODEyOCk6IHdpbmRvdy5yZXNpemVUbyBkb2Vzbid0IHdvcmsgZnJvbSBTYWZhcmkgYWRk cmVzcyBiYXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0Jl cnJ5LmNwcAppbmRleCA0OTg3ZTUzZWE5NDA5NDRkODc1YWM3NGY3MDk3MmYxOWViYzhkNTYxLi45 OGMzNjk4ZTM4ZmNhMTE5NzIxNjZjN2U4ZTY3MDZjNjc0MjkwOGIxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0 ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKQEAgLTIzLDEzICsyMywx NiBAQAogCiAjaW5jbHVkZSAiQ29va2llTWFuYWdlci5oIgogI2luY2x1ZGUgIkNyZWRlbnRpYWxT dG9yYWdlLmgiCisjaW5jbHVkZSAiRE9NRmlsZVN5c3RlbUJhc2UuaCIKICNpbmNsdWRlICJIb3N0 V2luZG93LmgiCiAjaW5jbHVkZSAiTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmgiCiAjaW5jbHVkZSAi TWVkaWFTdHJlYW1SZWdpc3RyeS5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAKICNp bmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1EZXZpY2VJbmZvLmg+CiAjaW5jbHVkZSA8QmxhY2tC ZXJyeVBsYXRmb3JtUHJpbWl0aXZlcy5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNl dHRpbmdzLmg+CisjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtV2ViRmlsZVN5c3RlbS5oPgog I2luY2x1ZGUgPEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oPgogCiAjaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQpAQCAtMTQ2LDcgKzE0OSw0MSBAQCB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZTo6bG9hZChjb25zdCBXVEY6OlN0cmluZyYgdXJsKQogICAgICAgICBrdXJsLnNldFBh dGgodGVtcFBhdGgpOwogICAgICAgICBtb2RpZmllZFVybCA9IGt1cmwuc3RyaW5nKCk7CiAgICAg fQotICAgIGlmIChtb2RpZmllZFVybC5zdGFydHNXaXRoKCJmaWxlOi8vIikpIHsKKyAgICAvLyBm aWxlc3lzdGVtOiBVUkxzIHJlZmVyIHRvIGVudGl0aWVzIGluIHRoZSBXZWIgRmlsZSBTeXN0ZW0g KFdGUykgYW5kIGFyZQorICAgIC8vIGludGVuZGVkIHRvIGJlIHVzZWFibGUgYnkgSFRNTCA1IG1l ZGlhIGVsZW1lbnRzIGRpcmVjdGx5LiBVbmZvcnR1bmF0ZWx5CisgICAgLy8gdGhlIGxvYWRlciBm b3Igb3VyIG1lZGlhIHBsYXllciBpcyBpbXBsZW1lbnRlZCBpbiBhIHNlcGFyYXRlIHByb2Nlc3Mg YW5kCisgICAgLy8gZG9lcyBub3QgaGF2ZSBhY2Nlc3MgdG8gV0ZTLCBzbyB3ZSB0cmFuc2xhdGUg dG8gYSBmaWxlOi8vIFVSTC4gTm9ybWFsbHkKKyAgICAvLyB0aGlzIHdvdWxkIGJlIGEgc2VjdXJp dHkgdmlvbGF0aW9uLCBidXQgc2luY2UgdGhlIE1lZGlhRWxlbWVudCBoYXMKKyAgICAvLyBhbHJl YWR5IGRvbmUgYSBzZWN1cml0eSBjaGVjayBvbiB0aGUgZmlsZXN5c3RlbTogVVJMIGFzIHBhcnQg b2YgdGhlCisgICAgLy8gbWVkaWEgcmVzb3VyY2Ugc2VsZWN0aW9uIGFsZ29yaXRobSwgd2Ugc2hv dWxkIGJlIE9LIGhlcmUuCisgICAgaWYgKG1vZGlmaWVkVXJsLnN0YXJ0c1dpdGgoImZpbGVzeXN0 ZW06IikpIHsKKyAgICAgICAgS1VSTCBrdXJsID0gS1VSTChLVVJMKCksIG1vZGlmaWVkVXJsKTsK KyAgICAgICAgS1VSTCBtZWRpYVVSTDsKKyAgICAgICAgV1RGOjpTdHJpbmcgZnNQYXRoOworICAg ICAgICBGaWxlU3lzdGVtVHlwZSBmc1R5cGU7CisgICAgICAgIFdlYkZpbGVTeXN0ZW06OlR5cGUg dHlwZTsKKworICAgICAgICAvLyBFeHRyYWN0IHRoZSByb290IGFuZCBmaWxlIHBhdGhzIGZyb20g V0ZTCisgICAgICAgIERPTUZpbGVTeXN0ZW1CYXNlOjpjcmFja0ZpbGVTeXN0ZW1VUkwoa3VybCwg ZnNUeXBlLCBmc1BhdGgpOworICAgICAgICBpZiAoZnNUeXBlID09IEZpbGVTeXN0ZW1UeXBlVGVt cG9yYXJ5KQorICAgICAgICAgICAgdHlwZSA9IFdlYkZpbGVTeXN0ZW06OlRlbXBvcmFyeTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgdHlwZSA9IFdlYkZpbGVTeXN0ZW06OlBlcnNpc3RlbnQ7 CisgICAgICAgIFdURjo6U3RyaW5nIGZzUm9vdCA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpXZWJG aWxlU3lzdGVtOjpyb290UGF0aEZvcldlYkZpbGVTeXN0ZW0odHlwZSk7CisKKyAgICAgICAgLy8g QnVpbGQgYSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U2VjdXJpdHlPcmlnaW4gZnJvbSB0aGUgZG9j dW1lbnQncyAKKyAgICAgICAgLy8gV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4gYW5kIHNlcmlhbGl6 ZSBpdCB0byBidWlsZCB0aGUgbGFzdAorICAgICAgICAvLyBwYXRoIGNvbXBvbmVudAorICAgICAg ICBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiogd2tPcmlnaW4gPSBtX3dlYkNvcmVQbGF5ZXItPm1l ZGlhUGxheWVyQ2xpZW50KCktPm1lZGlhUGxheWVyT3duaW5nRG9jdW1lbnQoKS0+c2VjdXJpdHlP cmlnaW4oKTsKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNlY3VyaXR5T3JpZ2luIGJi T3JpZ2luKHdrT3JpZ2luLT5wcm90b2NvbCgpLCB3a09yaWdpbi0+aG9zdCgpLCB3a09yaWdpbi0+ cG9ydCgpKTsKKyAgICAgICAgV1RGOjpTdHJpbmcgc2VjT3JpZ2luKGJiT3JpZ2luLnNlcmlhbGl6 ZSgnXycpKTsKKworICAgICAgICAvLyBCdWlsZCBhIGZpbGU6Ly8gVVJMIGZyb20gdGhlIHBhdGgg Y29tcG9uZW50cyBhbmQgZXh0cmFjdCBpdCB0byAKKyAgICAgICAgLy8gYSBzdHJpbmcgZm9yIGZ1 cnRoZXIgcHJvY2Vzc2luZworICAgICAgICBtZWRpYVVSTC5zZXRQcm90b2NvbCgiZmlsZSIpOwor ICAgICAgICBtZWRpYVVSTC5zZXRQYXRoKGZzUm9vdCArICIvIiArIHNlY09yaWdpbiArICIvIiAr IGZzUGF0aCk7CisgICAgICAgIG1vZGlmaWVkVXJsID0gbWVkaWFVUkwuc3RyaW5nKCk7CisgICAg fSBlbHNlIGlmIChtb2RpZmllZFVybC5zdGFydHNXaXRoKCJmaWxlOi8vIikpIHsKICAgICAgICAg Ly8gVGhlIFFOWCBNdWx0aW1lZGlhIEZyYW1ld29yayBjYW5ub3QgaGFuZGxlIGZpbGVuYW1lcyBj b250YWluaW5nIFVSTCBlc2NhcGUgc2VxdWVuY2VzLgogICAgICAgICBtb2RpZmllZFVybCA9IGRl Y29kZVVSTEVzY2FwZVNlcXVlbmNlcyhtb2RpZmllZFVybCk7CiAgICAgfQpAQCAtNTc2LDEyICs2 MTMsMTIgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6Om9uTWVkaWFTdGF0dXNDaGFuZ2VkKFBs YXRmb3JtUGxheWVyOjpNTVJQbGF5U3RhdGUpCiAgICAgdXBkYXRlU3RhdGVzKCk7CiB9CiAKLXZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpvbkVycm9yKFBsYXRmb3JtUGxheWVyOjpFcnJvciB0eXBl KQordm9pZCBNZWRpYVBsYXllclByaXZhdGU6Om9uRXJyb3IoUGxhdGZvcm1QbGF5ZXI6OkVycm9y KQogewogICAgIHVwZGF0ZVN0YXRlcygpOwogfQogCi12b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6 b25EdXJhdGlvbkNoYW5nZWQoZmxvYXQgZHVyYXRpb24pCit2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZTo6b25EdXJhdGlvbkNoYW5nZWQoZmxvYXQpCiB7CiAgICAgdXBkYXRlU3RhdGVzKCk7CiAgICAg bV93ZWJDb3JlUGxheWVyLT5kdXJhdGlvbkNoYW5nZWQoKTsKQEAgLTcyMiw3ICs3NTksNyBAQCB2 b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6b25BdXRoZW50aWNhdGlvbk5lZWRlZChNTVJBdXRoQ2hh bGxlbmdlJiBhdXRoQ2hhbGxlbmdlKQogICAgICAgICB0aGlzLCBtX3dlYkNvcmVQbGF5ZXItPm1l ZGlhUGxheWVyQ2xpZW50KCktPm1lZGlhUGxheWVySG9zdFdpbmRvdygpLT5wbGF0Zm9ybVBhZ2VD bGllbnQoKSk7CiB9CiAKLXZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpub3RpZnlDaGFsbGVuZ2VS ZXN1bHQoY29uc3QgS1VSTCYgdXJsLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmIHByb3RlY3Rpb25T cGFjZSwgQXV0aGVudGljYXRpb25DaGFsbGVuZ2VSZXN1bHQgcmVzdWx0LCBjb25zdCBDcmVkZW50 aWFsJiBjcmVkZW50aWFsKQordm9pZCBNZWRpYVBsYXllclByaXZhdGU6Om5vdGlmeUNoYWxsZW5n ZVJlc3VsdChjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFByb3RlY3Rpb25TcGFjZSYsIEF1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlUmVzdWx0IHJlc3VsdCwgY29uc3QgQ3JlZGVudGlhbCYgY3JlZGVudGlh bCkKIHsKICAgICBtX2lzQXV0aGVudGljYXRpb25DaGFsbGVuZ2luZyA9IGZhbHNlOwogCg==