114636 2013-04-15 14:04:12 -0700 [CSS Shaders] Add a test with a vertex, fragment shader pair that compiles but don't link 2013-04-16 17:06:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71392 1 mvujovic michelangelo achicu commit-queue michelangelo oldest_to_newest 876052 0 mvujovic 2013-04-15 14:04:12 -0700 We should have a test in which a fragment shader tries to read from a varying that the vertex shader did not define. I suspect that this case works correctly, but we have an incorrect assertion that will get tripped. 876884 1 198437 michelangelo 2013-04-16 14:58:43 -0700 Created attachment 198437 Patch 876895 2 198437 mvujovic 2013-04-16 15:17:02 -0700 Comment on attachment 198437 Patch Looks great! Just a couple of nits. View in context: https://bugs.webkit.org/attachment.cgi?id=198437&action=review > LayoutTests/ChangeLog:7 > + don't lead to unexpected crashes due to linking errors. You might want to add that "The current implementation does not crash, and this test will verify that it doesn't crash in the future." > LayoutTests/css3/filters/custom/custom-filter-unavailable-varying.html:5 > + #ohmymy { Could you change this name to "#filter-target"? > LayoutTests/css3/filters/custom/custom-filter-unavailable-varying.html:9 > + -webkit-filter: custom(url('../resources/unavailable-varying.vs') mix(url('../resources/unavailable-varying.fs') normal source-atop)); Your vertex shader looks a lot like the implementation's default shader. Maybe you use the "none" keyword instead of "unavailable-varying.vs"? 876898 3 198442 michelangelo 2013-04-16 15:20:24 -0700 Created attachment 198442 Patch 876953 4 198442 commit-queue 2013-04-16 17:06:11 -0700 Comment on attachment 198442 Patch Clearing flags on attachment: 198442 Committed r148581: <http://trac.webkit.org/changeset/148581> 876954 5 commit-queue 2013-04-16 17:06:14 -0700 All reviewed patches have been landed. Closing bug. 198437 2013-04-16 14:58:43 -0700 2013-04-16 15:20:22 -0700 Patch bug-114636-20130416145816.patch text/plain 3792 michelangelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDM3NTRiNjlmYmIxYTRkYmM3NDIw MDU1OGEyZGFmM2Q1NDUxYzIyMi4uMTA1NTljNTg3NmU3MmY5ZDU4NDAxM2VkODcwNjk3YmYwNjIw MzkxYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTE2ICBNaWNoZWxhbmdlbG8gRGUg U2ltb25lICA8bWljaGVsYW5nZWxvQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBTaGFkZXJz XSBBZGQgYSB0ZXN0IHdpdGggYSB2ZXJ0ZXgsIGZyYWdtZW50IHNoYWRlciBwYWlyIHRoYXQgY29t cGlsZXMgYnV0IGRvbid0IGxpbmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNDYzNgorCisgICAgICAgIEFkZGVkIGEgdGVzdCB0byBjaGVjayB0aGF0 IHVuYXZhaWxhYmxlIHZhcnlpbmdzIGluIGZyYWdtZW50IHNoYWRlcnMKKyAgICAgICAgZG9uJ3Qg bGVhZCB0byB1bmV4cGVjdGVkIGNyYXNoZXMgZHVlIHRvIGxpbmtpbmcgZXJyb3JzLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzMy9maWx0ZXJz L2N1c3RvbS9jdXN0b20tZmlsdGVyLXVuYXZhaWxhYmxlLXZhcnlpbmctZXhwZWN0ZWQuaHRtbDog QWRkZWQuCisgICAgICAgICogY3NzMy9maWx0ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVyLXVuYXZh aWxhYmxlLXZhcnlpbmcuaHRtbDogQWRkZWQuCisgICAgICAgICogY3NzMy9maWx0ZXJzL3Jlc291 cmNlcy91bmF2YWlsYWJsZS12YXJ5aW5nLmZzOiBBZGRlZC4KKyAgICAgICAgKiBjc3MzL2ZpbHRl cnMvcmVzb3VyY2VzL3VuYXZhaWxhYmxlLXZhcnlpbmcudnM6IEFkZGVkLgorCiAyMDEzLTA0LTE2 ICBKYW1lcyBDcmFpZyAgPGphbWVzQGNvb2tpZWNyb29rLmNvbT4KIAogICAgICAgICBkZm4gZWxl bWVudCBzaG91bGQgYmUgZXhwb3NlZCBhcyBBWEdyb3VwOkFYRGVmaW5pdGlvbgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVyLXVuYXZhaWxh YmxlLXZhcnlpbmctZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9jdXN0 b20vY3VzdG9tLWZpbHRlci11bmF2YWlsYWJsZS12YXJ5aW5nLWV4cGVjdGVkLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uOTY5MzE2YTU3MWZjMmZhNDlhNWNjM2UyODdhNjA2NDAyZjUyNjY5ZgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9jdXN0b20vY3VzdG9tLWZpbHRlci11 bmF2YWlsYWJsZS12YXJ5aW5nLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFET0NU WVBFIEhUTUw+Cis8aGVhZD4KKyAgICA8dGl0bGU+VW5hdmFpbGFibGUgdmFyeWluZzwvdGl0bGU+ CisgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyAgICAgICAgI29obXlteSB7CisgICAgICAg ICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAg ICAgYmFja2dyb3VuZDogcmdiKDAsIDI1NSwgMCk7CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgor PC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBpZD0ib2hteW15Ij48L2Rpdj4gCis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvY3VzdG9tL2N1c3Rv bS1maWx0ZXItdW5hdmFpbGFibGUtdmFyeWluZy5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0 ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVyLXVuYXZhaWxhYmxlLXZhcnlpbmcuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi5hMjlkYTdmYzgwNjE5ZTJjNDY2ZGQzM2ZkZjM2NWI1Yjk4MWJmYjJjCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVyLXVu YXZhaWxhYmxlLXZhcnlpbmcuaHRtbApAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgSFRNTD4K KzxoZWFkPgorICAgIDx0aXRsZT5VbmF2YWlsYWJsZSB2YXJ5aW5nPC90aXRsZT4KKyAgICA8c3R5 bGUgdHlwZT0idGV4dC9jc3MiPgorICAgICAgICAjb2hteW15IHsKKyAgICAgICAgICAgIHdpZHRo OiAxMDBweDsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3Jv dW5kOiByZ2IoMCwgMjU1LCAwKTsKKyAgICAgICAgICAgIC13ZWJraXQtZmlsdGVyOiBjdXN0b20o dXJsKCcuLi9yZXNvdXJjZXMvdW5hdmFpbGFibGUtdmFyeWluZy52cycpIG1peCh1cmwoJy4uL3Jl c291cmNlcy91bmF2YWlsYWJsZS12YXJ5aW5nLmZzJykgbm9ybWFsIHNvdXJjZS1hdG9wKSk7Cisg ICAgICAgIH0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgICAgPCEtLQorICAgICAg ICBUaGlzIGlzIGEgbmVnYXRpdmUgdGVzdCBhaW1lZCB0byBjaGVjayB3ZSBkb24ndCBjcmFzaCB3 aGlsZSBsaW5raW5nIGEgdmVydGV4IHNoYWRlciBhZ2FpbnN0IGEgZnJhZ21lbnQgc2hhZGVyIHdo ZW4gdGhlIGxhdHRlciBtYWtlcworICAgICAgICB1c2Ugb2YgYW4gdW5hdmFpbGFibGUgdmFyeWlu ZyB3aGljaCBpcyBub3QgYmVpbmcgcGFzc2VkIGZyb20gdGhlIHZlcnRleCBzaGFkZXIuIAorICAg IC0tPgorICAgIDxkaXYgaWQ9Im9obXlteSI+PC9kaXY+IAorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNlcy91bmF2YWlsYWJsZS12 YXJ5aW5nLmZzIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNlcy91bmF2YWlsYWJs ZS12YXJ5aW5nLmZzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg3NThlM2NmODhmMGM0NGJlYTQxMWZmMTEwNmUwNmY0 NWVlZGRjMTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvcmVz b3VyY2VzL3VuYXZhaWxhYmxlLXZhcnlpbmcuZnMKQEAgLTAsMCArMSw4IEBACitwcmVjaXNpb24g bWVkaXVtcCBmbG9hdDsKK3ZhcnlpbmcgdmVjNCB1bmF2YWlsYWJsZTsKKwordm9pZCBtYWluICgp Cit7CisgICAgY3NzX01peENvbG9yID0gdW5hdmFpbGFibGU7Cit9CisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvdW5hdmFpbGFibGUtdmFyeWluZy52cyBi L0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvdW5hdmFpbGFibGUtdmFyeWluZy52 cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4wYzUzMGRhYzYyMzlkZTYwZTc1MmJjMjMwMzhlMWY0ZWM0MTY3NmViCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNlcy91bmF2 YWlsYWJsZS12YXJ5aW5nLnZzCkBAIC0wLDAgKzEsMTAgQEAKK3ByZWNpc2lvbiBtZWRpdW1wIGZs b2F0OworCithdHRyaWJ1dGUgdmVjNCBhX3Bvc2l0aW9uOwordW5pZm9ybSBtYXQ0IHVfcHJvamVj dGlvbk1hdHJpeDsKKwordm9pZCBtYWluKCkKK3sKKyAgICBnbF9Qb3NpdGlvbiA9IHVfcHJvamVj dGlvbk1hdHJpeCAqIGFfcG9zaXRpb247Cit9CisK 198442 2013-04-16 15:20:24 -0700 2013-04-16 17:06:11 -0700 Patch bug-114636-20130416151957.patch text/plain 3317 michelangelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDM3NTRiNjlmYmIxYTRkYmM3NDIw MDU1OGEyZGFmM2Q1NDUxYzIyMi4uNDc1N2MzZDhjNWYzMGU1MmJhMzVkYjVmNzU5YjM3YzY3NzY4 ZjEzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTE2ICBNaWNoZWxhbmdlbG8gRGUg U2ltb25lICA8bWljaGVsYW5nZWxvQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBTaGFkZXJz XSBBZGQgYSB0ZXN0IHdpdGggYSB2ZXJ0ZXgsIGZyYWdtZW50IHNoYWRlciBwYWlyIHRoYXQgY29t cGlsZXMgYnV0IGRvbid0IGxpbmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNDYzNgorCisgICAgICAgIEFkZGVkIGEgdGVzdCB0byBjaGVjayB0aGF0 IHVuYXZhaWxhYmxlIHZhcnlpbmdzIGluIGZyYWdtZW50IHNoYWRlcnMKKyAgICAgICAgZG9uJ3Qg bGVhZCB0byB1bmV4cGVjdGVkIGNyYXNoZXMgZHVlIHRvIGxpbmtpbmcgZXJyb3JzLgorICAgICAg ICBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2VzIG5vdCBjcmFzaCwgYW5kIHRoaXMgbWFr ZXMgc3VyZSBpdAorICAgICAgICB3b24ndCBpbiBmdXR1cmUuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MzL2ZpbHRlcnMvY3VzdG9tL2N1c3Rv bS1maWx0ZXItdW5hdmFpbGFibGUtdmFyeWluZy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBjc3MzL2ZpbHRlcnMvY3VzdG9tL2N1c3RvbS1maWx0ZXItdW5hdmFpbGFibGUtdmFyeWlu Zy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBjc3MzL2ZpbHRlcnMvcmVzb3VyY2VzL3VuYXZhaWxh YmxlLXZhcnlpbmcuZnM6IEFkZGVkLgorCiAyMDEzLTA0LTE2ICBKYW1lcyBDcmFpZyAgPGphbWVz QGNvb2tpZWNyb29rLmNvbT4KIAogICAgICAgICBkZm4gZWxlbWVudCBzaG91bGQgYmUgZXhwb3Nl ZCBhcyBBWEdyb3VwOkFYRGVmaW5pdGlvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9m aWx0ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVyLXVuYXZhaWxhYmxlLXZhcnlpbmctZXhwZWN0ZWQu aHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9jdXN0b20vY3VzdG9tLWZpbHRlci11bmF2 YWlsYWJsZS12YXJ5aW5nLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzJlZTAzODRmYmIxMjRi MTM1ZTI0YmEyYjMyNjVhMzFhZGUzZjcxNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2NzczMvZmlsdGVycy9jdXN0b20vY3VzdG9tLWZpbHRlci11bmF2YWlsYWJsZS12YXJ5aW5nLWV4 cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFET0NUWVBFIEhUTUw+Cis8aGVhZD4KKyAg ICA8dGl0bGU+VW5hdmFpbGFibGUgdmFyeWluZzwvdGl0bGU+CisgICAgPHN0eWxlIHR5cGU9InRl eHQvY3NzIj4KKyAgICAgICAgI2ZpbHRlci10YXJnZXQgeworICAgICAgICAgICAgd2lkdGg6IDEw MHB4OworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgIGJhY2tncm91bmQ6 IHJnYigwLCAyNTUsIDApOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5 PgorICAgIDxkaXYgaWQ9ImZpbHRlci10YXJnZXQiPjwvZGl2PiAKKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9jdXN0b20vY3VzdG9tLWZpbHRl ci11bmF2YWlsYWJsZS12YXJ5aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvY3Vz dG9tL2N1c3RvbS1maWx0ZXItdW5hdmFpbGFibGUtdmFyeWluZy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ5 MDk3ODYwOWZiMWVjZDY1OGVjNDNlMTgyYTBjZjRlOTYxOTkwNjcKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvY3VzdG9tL2N1c3RvbS1maWx0ZXItdW5hdmFpbGFi bGUtdmFyeWluZy5odG1sCkBAIC0wLDAgKzEsMjAgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGhlYWQ+ CisgICAgPHRpdGxlPlVuYXZhaWxhYmxlIHZhcnlpbmc8L3RpdGxlPgorICAgIDxzdHlsZSB0eXBl PSJ0ZXh0L2NzcyI+CisgICAgICAgICNmaWx0ZXItdGFyZ2V0IHsKKyAgICAgICAgICAgIHdpZHRo OiAxMDBweDsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3Jv dW5kOiByZ2IoMCwgMjU1LCAwKTsKKyAgICAgICAgICAgIC13ZWJraXQtZmlsdGVyOiBjdXN0b20o bm9uZSBtaXgodXJsKCcuLi9yZXNvdXJjZXMvdW5hdmFpbGFibGUtdmFyeWluZy5mcycpIG5vcm1h bCBzb3VyY2UtYXRvcCkpOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5 PgorICAgIDwhLS0KKyAgICAgICAgVGhpcyBpcyBhIG5lZ2F0aXZlIHRlc3QgYWltZWQgdG8gY2hl Y2sgd2UgZG9uJ3QgY3Jhc2ggd2hpbGUgbGlua2luZyBhIHZlcnRleCBzaGFkZXIgYWdhaW5zdCBh IGZyYWdtZW50IHNoYWRlciB3aGVuIHRoZSBsYXR0ZXIgbWFrZXMKKyAgICAgICAgdXNlIG9mIGFu IHVuYXZhaWxhYmxlIHZhcnlpbmcgd2hpY2ggaXMgbm90IGJlaW5nIHBhc3NlZCBmcm9tIHRoZSB2 ZXJ0ZXggc2hhZGVyLiAKKyAgICAtLT4KKyAgICA8ZGl2IGlkPSJmaWx0ZXItdGFyZ2V0Ij48L2Rp dj4gCis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRl cnMvcmVzb3VyY2VzL3VuYXZhaWxhYmxlLXZhcnlpbmcuZnMgYi9MYXlvdXRUZXN0cy9jc3MzL2Zp bHRlcnMvcmVzb3VyY2VzL3VuYXZhaWxhYmxlLXZhcnlpbmcuZnMKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODc1OGUz Y2Y4OGYwYzQ0YmVhNDExZmYxMTA2ZTA2ZjQ1ZWVkZGMxMwotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvdW5hdmFpbGFibGUtdmFyeWluZy5mcwpA QCAtMCwwICsxLDggQEAKK3ByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OwordmFyeWluZyB2ZWM0IHVu YXZhaWxhYmxlOworCit2b2lkIG1haW4gKCkKK3sKKyAgICBjc3NfTWl4Q29sb3IgPSB1bmF2YWls YWJsZTsKK30KKwo=