114624 2013-04-15 07:50:09 -0700 Crash when favicon is requested 2013-04-16 00:15:51 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Unspecified RESOLVED FIXED http://www.hotmail.com P2 Normal --- 0 peavo webkit-unassigned beidson commit-queue roger_fong thorton oldest_to_newest 875816 0 peavo 2013-04-15 07:50:09 -0700 A NULL pointer exception occurs when a favicon is requested with WebIconDatabase::iconForURL. The crash occurs in WebIconDatabase::getOrCreateDefaultIconBitmap (WebKit/win/WebIconDatabase.cpp, line 310), because the call iconDatabase().defaultIcon(*size) returns NULL and gets dereferenced. 875819 1 198127 peavo 2013-04-15 07:53:59 -0700 Created attachment 198127 Patch 875929 2 198127 bfulgham 2013-04-15 11:51:20 -0700 Comment on attachment 198127 Patch r=me. Is there an existing test for this? 875998 3 commit-queue 2013-04-15 12:30:35 -0700 The commit-queue encountered the following flaky tests while processing attachment 198127: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 875999 4 198127 commit-queue 2013-04-15 12:31:24 -0700 Comment on attachment 198127 Patch Clearing flags on attachment: 198127 Committed r148456: <http://trac.webkit.org/changeset/148456> 876000 5 commit-queue 2013-04-15 12:31:26 -0700 All reviewed patches have been landed. Closing bug. 876365 6 peavo 2013-04-16 00:15:51 -0700 (In reply to comment #2) > (From update of attachment 198127 [details]) > r=me. Is there an existing test for this? No, not that I'm aware of. 198127 2013-04-15 07:53:59 -0700 2013-04-15 12:31:24 -0700 Patch bug-114624-20130415165331.patch text/plain 1259 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODQzNikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA0LTE1 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIENyYXNo IHdoZW4gZmF2aWNvbiBpcyByZXF1ZXN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNDYyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViSWNvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYklj b25EYXRhYmFzZTo6Z2V0T3JDcmVhdGVEZWZhdWx0SWNvbkJpdG1hcCk6IEFkZGVkIE5VTEwgcG9p bnRlciBjaGVjay4KKwogMjAxMy0wNC0xMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIEFsbCB0ZXN0cyBjcmFzaCBvbiBXaW5kb3dzCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L3dpbi9XZWJJY29uRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvd2luL1dlYkljb25EYXRhYmFzZS5jcHAJKHJldmlzaW9uIDE0ODQxNSkKKysrIFNvdXJj ZS9XZWJLaXQvd2luL1dlYkljb25EYXRhYmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNyw3 ICszMDcsNyBAQCBIQklUTUFQIFdlYkljb25EYXRhYmFzZTo6Z2V0T3JDcmVhdGVEZWZhCiAgICAg cmVzdWx0ID0gY3JlYXRlRElCKHNpemUpOwogCiAgICAgbV9kZWZhdWx0SWNvbk1hcC5zZXQoKnNp emUsIHJlc3VsdCk7Ci0gICAgaWYgKCFpY29uRGF0YWJhc2UoKS5kZWZhdWx0SWNvbigqc2l6ZSkt PmdldEhCSVRNQVBPZlNpemUocmVzdWx0LCBzaXplKSkgeworICAgIGlmICghaWNvbkRhdGFiYXNl KCkuZGVmYXVsdEljb24oKnNpemUpIHx8ICFpY29uRGF0YWJhc2UoKS5kZWZhdWx0SWNvbigqc2l6 ZSktPmdldEhCSVRNQVBPZlNpemUocmVzdWx0LCBzaXplKSkgewogICAgICAgICBMT0dfRVJST1Io IkZhaWxlZCB0byBkcmF3IEltYWdlIHRvIEhCSVRNQVAiKTsKICAgICAgICAgcmV0dXJuIDA7CiAg ICAgfQo=