114428 2013-04-11 02:54:22 -0700 [Qt] EventHandler should handle Space and BackSpace 2013-04-11 04:44:56 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi cmarcelo commit-queue hausmann jturcotte menard oldest_to_newest 873658 0 allan.jensen 2013-04-11 02:54:22 -0700 WebCore's eventhandler has code to handle space and backspace key-presses. Qt should use those instead of handling them in our own WK1 or WK2 event handling code. 873685 1 197546 allan.jensen 2013-04-11 02:56:08 -0700 Created attachment 197546 Patch 873726 2 jturcotte 2013-04-11 03:19:33 -0700 The code LGTM but I'd like to know if Simon think of anything this patch could break. 873729 3 197546 jturcotte 2013-04-11 03:27:42 -0700 Comment on attachment 197546 Patch r=me in any case, the risk is low 873732 4 hausmann 2013-04-11 03:55:27 -0700 I can't think of anything, so LGTM :) 873756 5 commit-queue 2013-04-11 04:43:27 -0700 The commit-queue encountered the following flaky tests while processing attachment 197546: svg/as-image/img-preserveAspectRatio-support-2.html bug 114434 (author: zimmermann@kde.org) The commit-queue is continuing to process your patch. 873757 6 197546 commit-queue 2013-04-11 04:44:53 -0700 Comment on attachment 197546 Patch Clearing flags on attachment: 197546 Committed r148195: <http://trac.webkit.org/changeset/148195> 873758 7 commit-queue 2013-04-11 04:44:56 -0700 All reviewed patches have been landed. Closing bug. 197546 2013-04-11 02:56:08 -0700 2013-04-11 04:44:53 -0700 Patch bug-114428-20130411115547.patch text/plain 7152 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ4ZDBlMzRhNWVhNGRi N2I1ZWZkNTE3MWE1OWM2NWEyYTA0NDk1Ny4uNjYwNDA5NjQ1OWRiN2MwN2UxOTFkOTZhMDYxN2U2 Y2E4MTU0YjhmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA0LTExICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gRXZlbnRIYW5kbGVyIHNob3VsZCBoYW5kbGUgU3BhY2UgYW5kIEJhY2tTcGFjZSAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDQyOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBkZWZhdWx0 IHNwYWNlLWhhbmRsaW5nIGZvciBRdC4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNw cDoKKwogMjAxMy0wNC0xMCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXBsYWNlIEVOQUJMRV9NSUNST0RBVEEgcHJlcHJvY2Vzc29yIHN0YXRlbWVu dHMgaW4gSURMIGZpbGVzIHdpdGggQ29uZGl0aW9uYWwgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGVjYWYyZWE4N2Y2Yjc4N2JjNjUxMTI4MzU1NmNjNTNmZjVkODRkNGMuLjkyMDUwNmQ5MGQy NDA0NTVkYjBhZDI0MGM3YmIwNDlmYzk2MTFjODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTcgQEAKKzIwMTMtMDQtMTEgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBk aWdpYS5jb20+CisKKyAgICAgICAgW1F0XSBFdmVudEhhbmRsZXIgc2hvdWxkIGhhbmRsZSBTcGFj ZSBhbmQgQmFja1NwYWNlIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0NDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlIG91ciBvd24gaGFuZGxpbmcgb2Ygc3BhY2UgYW5kIGJhY2tzcGFjZS4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5jcHA6CisgICAgICAg IChRV2ViUGFnZUFkYXB0ZXI6OmhhbmRsZVNjcm9sbGluZyk6CisgICAgICAgICogV2lkZ2V0QXBp L3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6a2V5UHJlc3NFdmVudCk6 CisKIDIwMTMtMDQtMTAgIEpvc2UgTGVqaW4gUEogIDxqb3NlLmxlamluQGdtYWlsLmNvbT4KIAog ICAgICAgICBbUXRdIEFkZCBBUEkgaW4gUVdlYlNldHRpbmdzIGZvciBzZXR0aW5nIHRoZSBDU1Mg bWVkaWEgdHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDc2NDM3YTg3MGQ3NDZlNDY5YzZkYzdkMDg2ZDU2ZThi YzZjYmNiYjMuLmJiNzQyMWJiOWFkZTcwYzBhYjBlZDM1ZGIzNDI5M2YxNDg1NWI0ZDcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNC0xMSAgQWxsYW4gU2FuZGZlbGQgSmVuc2Vu ICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdIEV2ZW50SGFuZGxlciBz aG91bGQgaGFuZGxlIFNwYWNlIGFuZCBCYWNrU3BhY2UgCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ0MjgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgb3VyIG93biBoYW5kbGluZyBvZiBzcGFj ZSBhbmQgYmFja3NwYWNlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL3F0L1dlYlBh Z2VRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBlcmZvcm1EZWZhdWx0QmVoYXZp b3JGb3JLZXlFdmVudCk6CisKIDIwMTMtMDQtMTAgIEFudG9uIE9iemhpcm92ICA8YS5vYnpoaXJv dkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgc3VwcG9ydCBmb3IgUGFnZSBWaXNp YmlsaXR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggMmQ3ZTQyZTU0MDk5 NGVlZDFmNzM1ZGNjYjdhMWI5NzMyZjE5NWFkMS4uNTFhYTEyOTEwMWIyYjZiOWZmNzliNDFmYTZk MzExNzZhM2VjZDAyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMzY4 NiwxMyArMzY4Niw2IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0VGV4dElucHV0RXZlbnRI YW5kbGVyKFRleHRFdmVudCogZXZlbnQpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxl ZCgpOwogfQogCi0jaWYgUExBVEZPUk0oUVQpCi0vLyBRdCBoYW5kbGVzIHRoZSBzcGFjZSBldmVu dCBpbiBwbGF0Zm9ybS1zcGVjaWZpYyBXZWJLaXQgY29kZS4KLS8vIEV2ZW50dWFsbHkgaXQgd291 bGQgYmUgZ29vZCB0byBlbGltaW5hdGUgdGhhdCBhbmQgdXNlIHRoZSBjb2RlIGhlcmUgaW5zdGVh ZC4KLXZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0U3BhY2VFdmVudEhhbmRsZXIoS2V5Ym9hcmRF dmVudCopCi17Ci19Ci0jZWxzZQogCiB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVsdFNwYWNlRXZl bnRIYW5kbGVyKEtleWJvYXJkRXZlbnQqIGV2ZW50KQogewpAQCAtMzcxNSw4ICszNzA4LDYgQEAg dm9pZCBFdmVudEhhbmRsZXI6OmRlZmF1bHRTcGFjZUV2ZW50SGFuZGxlcihLZXlib2FyZEV2ZW50 KiBldmVudCkKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiB9CiAKLSNlbmRp ZgotCiB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVsdEJhY2tzcGFjZUV2ZW50SGFuZGxlcihLZXli b2FyZEV2ZW50KiBldmVudCkKIHsKICAgICBBU1NFUlQoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5h bWVzKCkua2V5ZG93bkV2ZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmNwcAppbmRleCAwM2NkODliYTQ1NDExYmExOGI5Y2RjZTU1 ZmYzMTIxYzI3ZGM1ZWMxLi5mOGNmYmFlODEzNDM4MzU5Yzc4YjJmYzc2MjUwNTZmZTUxYmI2ZGE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRh cHRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFk YXB0ZXIuY3BwCkBAIC0xMjQ3LDEwICsxMjQ3LDEwIEBAIGJvb2wgUVdlYlBhZ2VBZGFwdGVyOjpo YW5kbGVTY3JvbGxpbmcoUUtleUV2ZW50ICpldikKICAgICBXZWJDb3JlOjpTY3JvbGxHcmFudWxh cml0eSBncmFudWxhcml0eTsKIAogI2lmbmRlZiBRVF9OT19TSE9SVENVVAotICAgIGlmIChldiA9 PSBRS2V5U2VxdWVuY2U6Ok1vdmVUb05leHRQYWdlIHx8IChldi0+a2V5KCkgPT0gUXQ6OktleV9T cGFjZSAmJiAhKGV2LT5tb2RpZmllcnMoKSAmIFF0OjpTaGlmdE1vZGlmaWVyKSkpIHsKKyAgICBp ZiAoZXYgPT0gUUtleVNlcXVlbmNlOjpNb3ZlVG9OZXh0UGFnZSkgewogICAgICAgICBncmFudWxh cml0eSA9IFdlYkNvcmU6OlNjcm9sbEJ5UGFnZTsKICAgICAgICAgZGlyZWN0aW9uID0gV2ViQ29y ZTo6U2Nyb2xsRG93bjsKLSAgICB9IGVsc2UgaWYgKGV2ID09IFFLZXlTZXF1ZW5jZTo6TW92ZVRv UHJldmlvdXNQYWdlIHx8ICgoZXYtPmtleSgpID09IFF0OjpLZXlfU3BhY2UpICYmIChldi0+bW9k aWZpZXJzKCkgJiBRdDo6U2hpZnRNb2RpZmllcikpKSB7CisgICAgfSBlbHNlIGlmIChldiA9PSBR S2V5U2VxdWVuY2U6Ok1vdmVUb1ByZXZpb3VzUGFnZSkgewogICAgICAgICBncmFudWxhcml0eSA9 IFdlYkNvcmU6OlNjcm9sbEJ5UGFnZTsKICAgICAgICAgZGlyZWN0aW9uID0gV2ViQ29yZTo6U2Ny b2xsVXA7CiAgICAgfSBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFw aS9xd2VicGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFwaS9xd2VicGFnZS5jcHAK aW5kZXggNDY1NDJhYzQxNDFjMjc3ZDEzNmZhODNiOTY1ZDE4OGY2NWI0ZGUwZS4uNmM0MTA1NmE3 ZDBmODJlMTQyNWFiODA4ZmUwY2E0ZGU2N2NjOGJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9xdC9XaWRnZXRBcGkvcXdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2lkZ2V0 QXBpL3F3ZWJwYWdlLmNwcApAQCAtODM0LDMyICs4MzQsMjcgQEAgdm9pZCBRV2ViUGFnZVByaXZh dGU6OmtleVByZXNzRXZlbnQoUUtleUV2ZW50ICpldikKICAgICAvLyB0byB0cmlnZ2VyIGVkaXRv ciBjb21tYW5kcyB2aWEgdHJpZ2dlckFjdGlvbigpLgogICAgIGJvb2wgaGFuZGxlZCA9IGhhbmRs ZUtleUV2ZW50KGV2KTsKIAorICAgIGlmICghaGFuZGxlZCkKKyAgICAgICAgaGFuZGxlZCA9IGhh bmRsZVNjcm9sbGluZyhldik7CisKICAgICBpZiAoIWhhbmRsZWQpIHsKICAgICAgICAgaGFuZGxl ZCA9IHRydWU7Ci0gICAgICAgIGlmICghaGFuZGxlU2Nyb2xsaW5nKGV2KSkgewotICAgICAgICAg ICAgc3dpdGNoIChldi0+a2V5KCkpIHsKLSAgICAgICAgICAgIGNhc2UgUXQ6OktleV9CYWNrOgot ICAgICAgICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkJhY2spOwotICAgICAg ICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgY2FzZSBRdDo6S2V5X0ZvcndhcmQ6Ci0gICAg ICAgICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6Rm9yd2FyZCk7Ci0gICAgICAg ICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlIFF0OjpLZXlfU3RvcDoKLSAgICAgICAg ICAgICAgICBxLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpTdG9wKTsKLSAgICAgICAgICAgICAg ICBicmVhazsKLSAgICAgICAgICAgIGNhc2UgUXQ6OktleV9SZWZyZXNoOgotICAgICAgICAgICAg ICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OlJlbG9hZCk7Ci0gICAgICAgICAgICAgICAg YnJlYWs7Ci0gICAgICAgICAgICBjYXNlIFF0OjpLZXlfQmFja3NwYWNlOgotICAgICAgICAgICAg ICAgIGlmIChldi0+bW9kaWZpZXJzKCkgPT0gUXQ6OlNoaWZ0TW9kaWZpZXIpCi0gICAgICAgICAg ICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkZvcndhcmQpOwotICAgICAgICAg ICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFn ZTo6QmFjayk7Ci0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBkZWZhdWx0Ogot ICAgICAgICAgICAgICAgIGhhbmRsZWQgPSBmYWxzZTsKLSAgICAgICAgICAgICAgICBicmVhazsK LSAgICAgICAgICAgIH0KKyAgICAgICAgc3dpdGNoIChldi0+a2V5KCkpIHsKKyAgICAgICAgY2Fz ZSBRdDo6S2V5X0JhY2s6CisgICAgICAgICAgICBxLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpC YWNrKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFF0OjpLZXlfRm9yd2FyZDoK KyAgICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkZvcndhcmQpOworICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgUXQ6OktleV9TdG9wOgorICAgICAgICAgICAgcS0+ dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6U3RvcCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgY2FzZSBRdDo6S2V5X1JlZnJlc2g6CisgICAgICAgICAgICBxLT50cmlnZ2VyQWN0aW9uKFFX ZWJQYWdlOjpSZWxvYWQpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGRlZmF1bHQ6Cisg ICAgICAgICAgICBoYW5kbGVkID0gZmFsc2U7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L3F0L1dlYlBhZ2VRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQv V2ViUGFnZVF0LmNwcAppbmRleCA0OGE4MDEwM2M0MzZhNTZlMDkyMWI0NGE0MTMyMTMxNWJlMmYw ZTAzLi5iOTYwYTcxN2RlODNkOGQ2M2ViYjU1MjhhZTZkZGJmYTI0ODFjMzdkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQvV2ViUGFnZVF0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQvV2ViUGFnZVF0LmNwcApAQCAt MjM2LDE1ICsyMzYsNiBAQCBib29sIFdlYlBhZ2U6OnBlcmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JL ZXlFdmVudChjb25zdCBXZWJLZXlib2FyZEV2ZW50JiBrZXlib2FyZAogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICBzd2l0Y2ggKGtleWJvYXJkRXZlbnQud2luZG93c1ZpcnR1YWxLZXlDb2Rl KCkpIHsKLSAgICBjYXNlIFZLX0JBQ0s6Ci0gICAgICAgIGlmIChrZXlib2FyZEV2ZW50LnNoaWZ0 S2V5KCkpCi0gICAgICAgICAgICBtX3BhZ2UtPmdvRm9yd2FyZCgpOwotICAgICAgICBlbHNlCi0g ICAgICAgICAgICBtX3BhZ2UtPmdvQmFjaygpOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIFZL X1NQQUNFOgotICAgICAgICBsb2dpY2FsU2Nyb2xsKG1fcGFnZS5nZXQoKSwga2V5Ym9hcmRFdmVu dC5zaGlmdEtleSgpID8gU2Nyb2xsQmxvY2tEaXJlY3Rpb25CYWNrd2FyZCA6IFNjcm9sbEJsb2Nr RGlyZWN0aW9uRm9yd2FyZCwgU2Nyb2xsQnlQYWdlKTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBWS19MRUZUOgogICAgICAgICBzY3JvbGwobV9wYWdlLmdldCgpLCBTY3JvbGxMZWZ0LCBTY3Jv bGxCeUxpbmUpOwogICAgICAgICBicmVhazsK