114348 2013-04-10 03:50:26 -0700 Replace ENABLE_CSS_* preprocessor statements in IDL files with Conditional attribute 2013-04-10 08:45:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All NEW P2 Normal --- 67400 1 paroga paroga buildbot ggaren rniwa oldest_to_newest 872698 0 paroga 2013-04-10 03:50:26 -0700 Replace ENABLE_CSS_* preprocessor statements in IDL files with Conditional attribute 872699 1 197239 paroga 2013-04-10 03:52:46 -0700 Created attachment 197239 Patch 872721 2 197239 buildbot 2013-04-10 04:45:55 -0700 Comment on attachment 197239 Patch Attachment 197239 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17634134 872725 3 197239 buildbot 2013-04-10 05:04:18 -0700 Comment on attachment 197239 Patch Attachment 197239 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17712016 872808 4 ggaren 2013-04-10 08:45:39 -0700 I believe the problem here is that DOM*.h is public API, and ENABLE(XXX) macros don't work in public API: ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:45' included forbidden macro 'ENABLE' => '#if ENABLE(CSS3_CONDITIONAL_RULES)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:48' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_DEVICE_ADAPTATION)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:51' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_REGIONS)' ERROR: '/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/Versions/A/Headers/DOMCSSRule.h:54' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_SHADERS)' Command /bin/sh failed with exit code 1 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution "Check For Inappropriate Macros in External Headers" /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Script-A55DEAA516703F9F003DB841.sh 197239 2013-04-10 03:52:46 -0700 2013-04-10 08:45:47 -0700 Patch bug-114348.patch text/plain 3986 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MTdiMmZkLi4zODdjYzAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmVwbGFjZSBFTkFCTEVfQ1NTXyogcHJlcHJvY2Vzc29yIHN0YXRlbWVudHMgaW4g SURMIGZpbGVzIHdpdGggQ29uZGl0aW9uYWwgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQzNDgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgQ29uZGl0aW9uYWwgYXR0cmlidXRlIGRv ZXMgbm90IG5lZWQgYSBwcmVwcm9jZXNzb3IsIHdoaWNoIGlzIHNvdXJjZSBvZiBtdWNoIHBhaW4g b24gbmF0aXZlIHdpbmRvd3MuCisKKyAgICAgICAgKiBjc3MvQ1NTUnVsZS5pZGw6CisgICAgICAg ICogY3NzL1dlYktpdENTU0ZpbHRlclZhbHVlLmlkbDoKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRv dy5pZGw6CisKIDIwMTMtMDQtMDkgIExhbWFycXVlIFYuIFNvdXphICA8TGFtYXJxdWUuU291emFA YmFzeXNrb20uY29tPgogCiAgICAgICAgIFtXZWJTb2NrZXRdIElnbm9yZSBpbmNvbWluZyBtZXNz YWdlIGluIENMT1NJTkcgc3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NS dWxlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmlkbAppbmRleCBkNDJkNDg0Li44 ZWNkMTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1J1bGUuaWRsCkBAIC0zNywxOCArMzcsMTAgQEAKICAgICBj b25zdCB1bnNpZ25lZCBzaG9ydCBQQUdFX1JVTEUgPSA2OwogICAgIGNvbnN0IHVuc2lnbmVkIHNo b3J0IFdFQktJVF9LRVlGUkFNRVNfUlVMRSA9IDc7CiAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQg V0VCS0lUX0tFWUZSQU1FX1JVTEUgPSA4OwotI2lmIGRlZmluZWQoRU5BQkxFX0NTUzNfQ09ORElU SU9OQUxfUlVMRVMpICYmIEVOQUJMRV9DU1MzX0NPTkRJVElPTkFMX1JVTEVTCi0gICAgY29uc3Qg dW5zaWduZWQgc2hvcnQgU1VQUE9SVFNfUlVMRSA9IDEyOwotI2VuZGlmCi0jaWYgZGVmaW5lZChF TkFCTEVfQ1NTX0RFVklDRV9BREFQVEFUSU9OKSAmJiBFTkFCTEVfQ1NTX0RFVklDRV9BREFQVEFU SU9OCi0gICAgY29uc3QgdW5zaWduZWQgc2hvcnQgV0VCS0lUX1ZJRVdQT1JUX1JVTEUgPSAxNTsK LSNlbmRpZgotI2lmIGRlZmluZWQoRU5BQkxFX0NTU19SRUdJT05TKSAmJiBFTkFCTEVfQ1NTX1JF R0lPTlMKLSAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBXRUJLSVRfUkVHSU9OX1JVTEUgPSAxNjsK LSNlbmRpZgotI2lmIGRlZmluZWQoRU5BQkxFX0NTU19TSEFERVJTKSAmJiBFTkFCTEVfQ1NTX1NI QURFUlMKLSAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBXRUJLSVRfRklMVEVSX1JVTEUgPSAxNzsK LSNlbmRpZgorICAgIFtDb25kaXRpb25hbD1DU1MzX0NPTkRJVElPTkFMX1JVTEVTXSBjb25zdCB1 bnNpZ25lZCBzaG9ydCBTVVBQT1JUU19SVUxFID0gMTI7CisgICAgW0NvbmRpdGlvbmFsPUNTU19E RVZJQ0VfQURBUFRBVElPTl0gY29uc3QgdW5zaWduZWQgc2hvcnQgV0VCS0lUX1ZJRVdQT1JUX1JV TEUgPSAxNTsKKyAgICBbQ29uZGl0aW9uYWw9Q1NTX1JFR0lPTlNdIGNvbnN0IHVuc2lnbmVkIHNo b3J0IFdFQktJVF9SRUdJT05fUlVMRSA9IDE2OworICAgIFtDb25kaXRpb25hbD1DU1NfU0hBREVS U10gY29uc3QgdW5zaWduZWQgc2hvcnQgV0VCS0lUX0ZJTFRFUl9SVUxFID0gMTc7CiAjaWYgZGVm aW5lZChFTkFCTEVfU0hBRE9XX0RPTSkgJiYgRU5BQkxFX1NIQURPV19ET00KICAgICBjb25zdCB1 bnNpZ25lZCBzaG9ydCBIT1NUX1JVTEUgPSAxMDAxOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTRmlsdGVyVmFsdWUuaWRsIGIvU291cmNlL1dlYkNvcmUv Y3NzL1dlYktpdENTU0ZpbHRlclZhbHVlLmlkbAppbmRleCAwMjFmZmE2Li4xNDZmZjVjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTRmlsdGVyVmFsdWUuaWRsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NGaWx0ZXJWYWx1ZS5pZGwKQEAgLTQ0LDkgKzQ0 LDcgQEAKICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBDU1NfRklMVEVSX0JMVVIgPSAxMDsKICAg ICBjb25zdCB1bnNpZ25lZCBzaG9ydCBDU1NfRklMVEVSX0RST1BfU0hBRE9XID0gMTE7CiAKLSNp ZiBkZWZpbmVkKEVOQUJMRV9DU1NfU0hBREVSUykgJiYgRU5BQkxFX0NTU19TSEFERVJTCi0gICAg Y29uc3QgdW5zaWduZWQgc2hvcnQgQ1NTX0ZJTFRFUl9DVVNUT00gPSAxMjsKLSNlbmRpZgorICAg IFtDb25kaXRpb25hbD1DU1NfU0hBREVSU10gY29uc3QgdW5zaWduZWQgc2hvcnQgQ1NTX0ZJTFRF Ul9DVVNUT00gPSAxMjsKIAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBzaG9ydCBv cGVyYXRpb25UeXBlOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCBiMWI1ODNi Li5jODY4ZGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBAIC0zMjcsMTggKzMyNywx MiBAQAogICAgIGF0dHJpYnV0ZSBDU1NWYWx1ZUxpc3RDb25zdHJ1Y3RvciBDU1NWYWx1ZUxpc3Q7 CiAgICAgYXR0cmlidXRlIFdlYktpdENTU1RyYW5zZm9ybVZhbHVlQ29uc3RydWN0b3IgV2ViS2l0 Q1NTVHJhbnNmb3JtVmFsdWU7CiAKLSNpZiBkZWZpbmVkKEVOQUJMRV9DU1NfU0hBREVSUykgJiYg RU5BQkxFX0NTU19TSEFERVJTCi0gICAgYXR0cmlidXRlIFdlYktpdENTU0ZpbHRlclJ1bGVDb25z dHJ1Y3RvciBXZWJLaXRDU1NGaWx0ZXJSdWxlOwotICAgIGF0dHJpYnV0ZSBXZWJLaXRDU1NNaXhG dW5jdGlvblZhbHVlQ29uc3RydWN0b3IgV2ViS2l0Q1NTTWl4RnVuY3Rpb25WYWx1ZTsKLSNlbmRp ZgorICAgIFtDb25kaXRpb25hbD1DU1NfU0hBREVSU10gYXR0cmlidXRlIFdlYktpdENTU0ZpbHRl clJ1bGVDb25zdHJ1Y3RvciBXZWJLaXRDU1NGaWx0ZXJSdWxlOworICAgIFtDb25kaXRpb25hbD1D U1NfU0hBREVSU10gYXR0cmlidXRlIFdlYktpdENTU01peEZ1bmN0aW9uVmFsdWVDb25zdHJ1Y3Rv ciBXZWJLaXRDU1NNaXhGdW5jdGlvblZhbHVlOwogCi0jaWYgZGVmaW5lZChFTkFCTEVfQ1NTX0ZJ TFRFUlMpICYmIEVOQUJMRV9DU1NfRklMVEVSUwotICAgIGF0dHJpYnV0ZSBXZWJLaXRDU1NGaWx0 ZXJWYWx1ZUNvbnN0cnVjdG9yIFdlYktpdENTU0ZpbHRlclZhbHVlOwotI2VuZGlmCisgICAgW0Nv bmRpdGlvbmFsPUNTU19GSUxURVJTXSBhdHRyaWJ1dGUgV2ViS2l0Q1NTRmlsdGVyVmFsdWVDb25z dHJ1Y3RvciBXZWJLaXRDU1NGaWx0ZXJWYWx1ZTsKIAotI2lmIGRlZmluZWQoRU5BQkxFX0NTU19E RVZJQ0VfQURBUFRBVElPTikgJiYgRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTgotICAgIGF0 dHJpYnV0ZSBXZWJLaXRDU1NWaWV3cG9ydFJ1bGVDb25zdHJ1Y3RvciBXZWJLaXRDU1NWaWV3cG9y dFJ1bGU7Ci0jZW5kaWYKKyAgICBbQ29uZGl0aW9uYWw9Q1NTX0RFVklDRV9BREFQVEFUSU9OXSBh dHRyaWJ1dGUgV2ViS2l0Q1NTVmlld3BvcnRSdWxlQ29uc3RydWN0b3IgV2ViS2l0Q1NTVmlld3Bv cnRSdWxlOwogCiAgICAgYXR0cmlidXRlIENTU1J1bGVDb25zdHJ1Y3RvciBDU1NSdWxlOwogICAg IGF0dHJpYnV0ZSBDU1NDaGFyc2V0UnVsZUNvbnN0cnVjdG9yIENTU0NoYXJzZXRSdWxlOwo=