114283 2013-04-09 06:48:19 -0700 [BlackBerry] InputHandler: fix calls to HTMLInputElement methods 2013-04-09 07:46:50 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia commit-queue mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 871797 0 berto 2013-04-09 06:48:19 -0700 Some calls to methods from HTMLInputElement have to be renamed from isXXXControl() to isXXXField(). 871799 1 197099 berto 2013-04-09 06:53:49 -0700 Created attachment 197099 Patch 871800 2 197099 rwlbuis 2013-04-09 07:01:38 -0700 Comment on attachment 197099 Patch LGTM. 871883 3 commit-queue 2013-04-09 07:45:54 -0700 The commit-queue encountered the following flaky tests while processing attachment 197099: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/shorthand-transitions.html bug 114289 (authors: jparent@google.com and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 871884 4 197099 commit-queue 2013-04-09 07:46:47 -0700 Comment on attachment 197099 Patch Clearing flags on attachment: 197099 Committed r148024: <http://trac.webkit.org/changeset/148024> 871885 5 commit-queue 2013-04-09 07:46:50 -0700 All reviewed patches have been landed. Closing bug. 197099 2013-04-09 06:53:49 -0700 2013-04-09 07:46:47 -0700 Patch 114283.diff text/plain 2099 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDI1MDMzY2IuLjI4OWZlYWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTA5ICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gSW5wdXRIYW5kbGVyOiBmaXggY2FsbHMgdG8gSFRNTElucHV0RWxlbWVudCBtZXRob2RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQyODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY2FsbHMg d2l0aCB3cm9uZyBuYW1lcy4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVy LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6Y29udmVydElucHV0VHlwZSk6CisK IDIwMTMtMDQtMDggIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJlbW92ZSBIVE1MIE5vdGlmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKaW5kZXggZjRiZTQ5 OTQuLjVlOGI2YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtMTcwLDcgKzE3MCw3IEBAIHN0YXRpYyBC bGFja0JlcnJ5SW5wdXRUeXBlIGNvbnZlcnRJbnB1dFR5cGUoY29uc3QgSFRNTElucHV0RWxlbWVu dCogaW5wdXRFbGVtZW50CiAgICAgICAgIHJldHVybiBJbnB1dFR5cGVTZWFyY2g7CiAgICAgaWYg KGlucHV0RWxlbWVudC0+aXNFbWFpbEZpZWxkKCkpCiAgICAgICAgIHJldHVybiBJbnB1dFR5cGVF bWFpbDsKLSAgICBpZiAoaW5wdXRFbGVtZW50LT5pc01vbnRoQ29udHJvbCgpKQorICAgIGlmIChp bnB1dEVsZW1lbnQtPmlzTW9udGhGaWVsZCgpKQogICAgICAgICByZXR1cm4gSW5wdXRUeXBlTW9u dGg7CiAgICAgaWYgKGlucHV0RWxlbWVudC0+aXNOdW1iZXJGaWVsZCgpKQogICAgICAgICByZXR1 cm4gSW5wdXRUeXBlTnVtYmVyOwpAQCAtMTgyLDEzICsxODIsMTMgQEAgc3RhdGljIEJsYWNrQmVy cnlJbnB1dFR5cGUgY29udmVydElucHV0VHlwZShjb25zdCBIVE1MSW5wdXRFbGVtZW50KiBpbnB1 dEVsZW1lbnQKICAgICBpZiAoaW5wdXRFbGVtZW50LT5pc0NvbG9yQ29udHJvbCgpKQogICAgICAg ICByZXR1cm4gSW5wdXRUeXBlQ29sb3I7CiAjZW5kaWYKLSAgICBpZiAoaW5wdXRFbGVtZW50LT5p c0RhdGVDb250cm9sKCkpCisgICAgaWYgKGlucHV0RWxlbWVudC0+aXNEYXRlRmllbGQoKSkKICAg ICAgICAgcmV0dXJuIElucHV0VHlwZURhdGU7Ci0gICAgaWYgKGlucHV0RWxlbWVudC0+aXNEYXRl VGltZUNvbnRyb2woKSkKKyAgICBpZiAoaW5wdXRFbGVtZW50LT5pc0RhdGVUaW1lRmllbGQoKSkK ICAgICAgICAgcmV0dXJuIElucHV0VHlwZURhdGVUaW1lOwotICAgIGlmIChpbnB1dEVsZW1lbnQt PmlzRGF0ZVRpbWVMb2NhbENvbnRyb2woKSkKKyAgICBpZiAoaW5wdXRFbGVtZW50LT5pc0RhdGVU aW1lTG9jYWxGaWVsZCgpKQogICAgICAgICByZXR1cm4gSW5wdXRUeXBlRGF0ZVRpbWVMb2NhbDsK LSAgICBpZiAoaW5wdXRFbGVtZW50LT5pc1RpbWVDb250cm9sKCkpCisgICAgaWYgKGlucHV0RWxl bWVudC0+aXNUaW1lRmllbGQoKSkKICAgICAgICAgcmV0dXJuIElucHV0VHlwZVRpbWU7CiAgICAg Ly8gRklYTUU6IG1pc3NpbmcgV0VFSyBwb3B1cCBzZWxlY3RvcgogICAgIGlmIChET01TdXBwb3J0 OjplbGVtZW50SWRPck5hbWVJbmRpY2F0ZXNFbWFpbChpbnB1dEVsZW1lbnQpKQo=