114172 2013-04-08 08:58:31 -0700 [BlackBerry] More null checks for m_mainFrame 2013-04-08 13:04:14 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson commit-queue rwlbuis oldest_to_newest 870798 0 jpetsovits 2013-04-08 08:58:31 -0700 After r147744, some unit tests were crashing on WebPage shutdown, because BackingStorePrivate::repaint() now uses pixelContentsRect() (accessing m_webPage->contentsRect()) instead of BackingStoreClient::contentsRect() (which wrapped the frame separately). In m_webPage, m_mainFrame had already been set to 0. Make us more robust against these errors by checking the existence of m_mainFrame more diligently. Patch below. 870809 1 196863 jpetsovits 2013-04-08 09:28:25 -0700 Created attachment 196863 Patch 870988 2 196863 rwlbuis 2013-04-08 12:05:10 -0700 Comment on attachment 196863 Patch Ok. 871070 3 commit-queue 2013-04-08 13:03:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 196863: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: vsevik@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 871082 4 196863 commit-queue 2013-04-08 13:04:10 -0700 Comment on attachment 196863 Patch Clearing flags on attachment: 196863 Committed r147945: <http://trac.webkit.org/changeset/147945> 871084 5 commit-queue 2013-04-08 13:04:14 -0700 All reviewed patches have been landed. Closing bug. 196863 2013-04-08 09:28:25 -0700 2013-04-08 13:04:10 -0700 Patch bug-114172-20130408122803.patch text/plain 3362 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzY2Q3MTdkZGQ5ODlkMDZkMTYxOWNjYTQwOGIwODgwMDZjNzQ2NmRlLi40OTMzYjhhMDgz ZmI3MWU3NjY4MDQxMDdiZjA0ZmVmZTIzZGE1NGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMy0wNC0wOCAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0BibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gTW9yZSBudWxs IGNoZWNrcyBmb3IgbV9tYWluRnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDE3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFmdGVyIHIxNDc3NDQsIHNvbWUgdW5pdCB0ZXN0cyB3ZXJlIGNyYXNo aW5nIG9uIFdlYlBhZ2UKKyAgICAgICAgc2h1dGRvd24sIGJlY2F1c2UgQmFja2luZ1N0b3JlUHJp dmF0ZTo6cmVwYWludCgpIG5vdyB1c2VzCisgICAgICAgIHBpeGVsQ29udGVudHNSZWN0KCkgKGFj Y2Vzc2luZyBtX3dlYlBhZ2UtPmNvbnRlbnRzUmVjdCgpKQorICAgICAgICBpbnN0ZWFkIG9mIEJh Y2tpbmdTdG9yZUNsaWVudDo6Y29udGVudHNSZWN0KCkuIEluIG1fd2ViUGFnZSwKKyAgICAgICAg bV9tYWluRnJhbWUgaGFkIGFscmVhZHkgYmVlbiBzZXQgdG8gMC4KKworICAgICAgICBNYWtlIHVz IG1vcmUgcm9idXN0IGFnYWluc3QgdGhlc2UgZXJyb3JzIGJ5IGNoZWNraW5nCisgICAgICAgIHRo ZSBleGlzdGVuY2Ugb2YgbV9tYWluRnJhbWUgbW9yZSBkaWxpZ2VudGx5LgorCisgICAgICAgICog QXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJp dmF0ZTo6c2hvdWxkWm9vbUFib3V0UG9pbnQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpXZWJQYWdlUHJpdmF0ZTo6c2hvdWxkU2VuZFJlc2l6ZUV2ZW50KToKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmNvbnRlbnRzU2l6ZSk6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjphYnNvbHV0ZVZpc2libGVPdmVyZmxv d1NpemUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0 Vmlld01vZGUpOgorCiAyMDEzLTA0LTA4ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gV2ViUGFnZTogbWlzYyBidWlsZCBmaXhlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggOGJiYTI4ZjliODAw OGI1MTRlMTQzZDFiYzMyNzY2NDIyNWViNTVhOC4uN2ZlZTA1M2QwNGJkM2U3YTBmMTJmODY1YmQ1 YTE5ZGVkMGNhMzRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3Bw CkBAIC0xMTc3LDcgKzExNzcsNyBAQCBkb3VibGUgV2ViUGFnZVByaXZhdGU6OmNsYW1wZWRTY2Fs ZShkb3VibGUgc2NhbGUpIGNvbnN0CiAKIGJvb2wgV2ViUGFnZVByaXZhdGU6OnNob3VsZFpvb21B Ym91dFBvaW50KGRvdWJsZSBzY2FsZSwgY29uc3QgRmxvYXRQb2ludCYsIGJvb2wgZW5mb3JjZVNj YWxlQ2xhbXBpbmcsIGRvdWJsZSogY2xhbXBlZFNjYWxlKQogewotICAgIGlmICghbV9tYWluRnJh bWUtPnZpZXcoKSkKKyAgICBpZiAoIW1fbWFpbkZyYW1lIHx8ICFtX21haW5GcmFtZS0+dmlldygp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoZW5mb3JjZVNjYWxlQ2xhbXBpbmcp CkBAIC0xMzgxLDcgKzEzODEsNyBAQCB2b2lkIFdlYlBhZ2U6OnNldERvY3VtZW50U2Nyb2xsUG9z aXRpb24oY29uc3QgUGxhdGZvcm06OkludFBvaW50JiBkb2N1bWVudFNjcm9sbAogCiBib29sIFdl YlBhZ2VQcml2YXRlOjpzaG91bGRTZW5kUmVzaXplRXZlbnQoKQogewotICAgIGlmICghbV9tYWlu RnJhbWUtPmRvY3VtZW50KCkpCisgICAgaWYgKCFtX21haW5GcmFtZSB8fCAhbV9tYWluRnJhbWUt PmRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIFBSIzk2ODY1IDog UHJvdmlkZSBhbiBvcHRpb24gdG8gYWx3YXlzIHNlbmQgcmVzaXplIGV2ZW50cywgcmVnYXJkbGVz cyBvZiB0aGUgbG9hZGluZwpAQCAtMTUxOCw3ICsxNTE4LDcgQEAgSW50UmVjdCBXZWJQYWdlUHJp dmF0ZTo6dmlzaWJsZUNvbnRlbnRzUmVjdCgpIGNvbnN0CiAKIEludFNpemUgV2ViUGFnZVByaXZh dGU6OmNvbnRlbnRzU2l6ZSgpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX21haW5GcmFtZS0+dmlldygp KQorICAgIGlmICghbV9tYWluRnJhbWUgfHwgIW1fbWFpbkZyYW1lLT52aWV3KCkpCiAgICAgICAg IHJldHVybiBJbnRTaXplKCk7CiAKICAgICByZXR1cm4gbV9iYWNraW5nU3RvcmVDbGllbnQtPmNv bnRlbnRzU2l6ZSgpOwpAQCAtMTUyNiw3ICsxNTI2LDcgQEAgSW50U2l6ZSBXZWJQYWdlUHJpdmF0 ZTo6Y29udGVudHNTaXplKCkgY29uc3QKIAogSW50U2l6ZSBXZWJQYWdlUHJpdmF0ZTo6YWJzb2x1 dGVWaXNpYmxlT3ZlcmZsb3dTaXplKCkgY29uc3QKIHsKLSAgICBpZiAoIW1fbWFpbkZyYW1lLT5j b250ZW50UmVuZGVyZXIoKSkKKyAgICBpZiAoIW1fbWFpbkZyYW1lIHx8ICFtX21haW5GcmFtZS0+ Y29udGVudFJlbmRlcmVyKCkpCiAgICAgICAgIHJldHVybiBJbnRTaXplKCk7CiAKICAgICByZXR1 cm4gSW50U2l6ZShtX21haW5GcmFtZS0+Y29udGVudFJlbmRlcmVyKCktPnJpZ2h0QWJzb2x1dGVW aXNpYmxlT3ZlcmZsb3coKSwgbV9tYWluRnJhbWUtPmNvbnRlbnRSZW5kZXJlcigpLT5ib3R0b21B YnNvbHV0ZVZpc2libGVPdmVyZmxvdygpKTsKQEAgLTE4NTksNyArMTg1OSw3IEBAIHZvaWQgV2Vi UGFnZVByaXZhdGU6Om5vdGlmeVRyYW5zZm9ybWVkU2Nyb2xsQ2hhbmdlZCgpCiAKIGJvb2wgV2Vi UGFnZVByaXZhdGU6OnNldFZpZXdNb2RlKFZpZXdNb2RlIG1vZGUpCiB7Ci0gICAgaWYgKCFtX21h aW5GcmFtZS0+dmlldygpKQorICAgIGlmICghbV9tYWluRnJhbWUgfHwgIW1fbWFpbkZyYW1lLT52 aWV3KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIG1fdmlld01vZGUgPSBtb2RlOwo=