114057 2013-04-05 13:00:11 -0700 [GTK][AC] use a smart pointer for GList and ClutterCanvas 2013-04-11 07:40:48 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105699 0 kevin.cs.oh webkit-unassigned commit-queue gustavo oldest_to_newest 869976 0 kevin.cs.oh 2013-04-05 13:00:11 -0700 We can make simple code & prevent possible memory leak by using smart pointer. 870027 1 196672 kevin.cs.oh 2013-04-05 13:12:38 -0700 Created attachment 196672 Patch 873794 2 196672 gustavo 2013-04-11 06:55:15 -0700 Comment on attachment 196672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196672&action=review > Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:286 > + int width = std::max(static_cast<int>(ceilf(clutter_actor_get_width(actor))), 1); > + int height = std::max(static_cast<int>(ceilf(clutter_actor_get_height(actor))), 1); fwiw, I'm not sure this size or 1 is required with ClutterCanvas, might be worth checking. 873813 3 196672 commit-queue 2013-04-11 07:40:46 -0700 Comment on attachment 196672 Patch Clearing flags on attachment: 196672 Committed r148202: <http://trac.webkit.org/changeset/148202> 873814 4 commit-queue 2013-04-11 07:40:48 -0700 All reviewed patches have been landed. Closing bug. 196672 2013-04-05 13:12:38 -0700 2013-04-11 07:40:46 -0700 Patch bug-114057-20130406051225.patch text/plain 4032 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFhNzYxNWNmYzVmZjNl MDE5MGM4MDk5YmM1M2QwY2UyYjRkMWE5MS4uMzg4ODcyODFhZTRlODAwYjY1MzQ0NTQ4OWJkMDdk MWYyYjkyMTk0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTA1ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXVtB Q10gdXNlIGEgc21hcnQgcG9pbnRlciBmb3IgR0xpc3QgYW5kIENsdXR0ZXJDYW52YXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA1NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGNhbiBtYWtlIHNp bXBsZSBjb2RlICYgcHJldmVudCBwb3NzaWJsZSBtZW1vcnkgbGVhayBieSB1c2luZyBhIHByb3Bl ciBzbWFydCBwb2ludGVyLgorICAgICAgICBFc3BlY2lhbGx5IGlmIHdlIGdldCBjaGlsZHJlbiBi eSBjbHV0dGVyX2FjdG9yX2dldF9jaGlsZHJlbiwgd2Ugc2hvdWxkIGZyZWUgaXQgYWZ0ZXIgdXNp bmcuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwOgorICAgICAgICAo Z3JhcGhpY3NMYXllckFjdG9yVXBkYXRlVGV4dHVyZSk6CisgICAgICAgIChncmFwaGljc0xheWVy QWN0b3JSZW1vdmVBbGwpOgorCiAyMDEzLTAzLTI4ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gQ3JlYXRlIFNoYWRvd0JsdXIg b24gZGVtYW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwCmluZGV4IGIyNzk4OWI3NjU5 MWVhNGM1OTEzMDliMzhjODZkM2MwZDA5MzBiZDYuLjk3OWRjOTYyMzUxNmQxZjBlN2RhZTg4NGM4 YTYzYjE0NDVmMTViNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckFjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJBY3Rvci5jcHAKQEAgLTI5LDYg KzI5LDggQEAKICNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRDYWlyby5oIgogI2luY2x1ZGUgIlJl ZlB0ckNhaXJvLmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtYXRpb25NYXRyaXguaCIKKyNpbmNsdWRl IDxhbGdvcml0aG0+CisjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgogI2luY2x1ZGUg PHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC0yNjYs MjYgKzI2OCwyNSBAQCBzdGF0aWMgdm9pZCBncmFwaGljc0xheWVyQWN0b3JVcGRhdGVUZXh0dXJl KEdyYXBoaWNzTGF5ZXJBY3RvciogbGF5ZXIpCiAgICAgQVNTRVJUKHByaXYtPmxheWVyVHlwZSAh PSBHcmFwaGljc0xheWVyQ2x1dHRlcjo6TGF5ZXJUeXBlVmlkZW9MYXllcik7CiAKICAgICBDbHV0 dGVyQWN0b3IqIGFjdG9yID0gQ0xVVFRFUl9BQ1RPUihsYXllcik7Ci0gICAgQ2x1dHRlckNvbnRl bnQqIGNhbnZhcyA9IGNsdXR0ZXJfYWN0b3JfZ2V0X2NvbnRlbnQoYWN0b3IpOworICAgIEdSZWZQ dHI8Q2x1dHRlckNvbnRlbnQ+IGNhbnZhcyA9IGFkb3B0R1JlZihjbHV0dGVyX2FjdG9yX2dldF9j b250ZW50KGFjdG9yKSk7CiAgICAgaWYgKGNhbnZhcykgewogICAgICAgICAvLyBOb3RoaW5nIG5l ZWRzIGEgdGV4dHVyZSwgcmVtb3ZlIHRoZSBvbmUgd2UgaGF2ZSwgaWYgYW55LgogICAgICAgICBp ZiAoIXByaXYtPmRyYXdzQ29udGVudCAmJiAhcHJpdi0+c3VyZmFjZSkgewotICAgICAgICAgICAg Z19zaWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9mdW5jKGNhbnZhcywgcmVpbnRlcnByZXRf Y2FzdDx2b2lkKj4oZ3JhcGhpY3NMYXllckFjdG9yRHJhdyksIGxheWVyKTsKKyAgICAgICAgICAg IGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhjYW52YXMuZ2V0KCksIHJlaW50 ZXJwcmV0X2Nhc3Q8dm9pZCo+KGdyYXBoaWNzTGF5ZXJBY3RvckRyYXcpLCBsYXllcik7CiAgICAg ICAgICAgICBjbHV0dGVyX2FjdG9yX3NldF9jb250ZW50KGFjdG9yLCAwKTsKICAgICAgICAgfQog ICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgLy8gV2Ugc2hvdWxkIGhhdmUgYSB0ZXh0dXJl LCBzbyBjcmVhdGUgb25lLgotICAgIGludCB3aWR0aCA9IGNlaWxmKGNsdXR0ZXJfYWN0b3JfZ2V0 X3dpZHRoKGFjdG9yKSk7Ci0gICAgaW50IGhlaWdodCA9IGNlaWxmKGNsdXR0ZXJfYWN0b3JfZ2V0 X2hlaWdodChhY3RvcikpOworICAgIGNhbnZhcyA9IGFkb3B0R1JlZihjbHV0dGVyX2NhbnZhc19u ZXcoKSk7CisgICAgY2x1dHRlcl9hY3Rvcl9zZXRfY29udGVudChhY3RvciwgY2FudmFzLmdldCgp KTsKIAotICAgIGNhbnZhcyA9IGNsdXR0ZXJfY2FudmFzX25ldygpOwotICAgIGNsdXR0ZXJfYWN0 b3Jfc2V0X2NvbnRlbnQoYWN0b3IsIGNhbnZhcyk7Ci0gICAgY2x1dHRlcl9jYW52YXNfc2V0X3Np emUoQ0xVVFRFUl9DQU5WQVMoY2FudmFzKSwgd2lkdGggPiAwID8gd2lkdGggOiAxLCBoZWlnaHQg PiAwID8gaGVpZ2h0IDogMSk7Ci0gICAgZ19vYmplY3RfdW5yZWYoY2FudmFzKTsKLSAgICAKLSAg ICBnX3NpZ25hbF9jb25uZWN0KGNhbnZhcywgImRyYXciLCBHX0NBTExCQUNLKGdyYXBoaWNzTGF5 ZXJBY3RvckRyYXcpLCBsYXllcik7CisgICAgaW50IHdpZHRoID0gc3RkOjptYXgoc3RhdGljX2Nh c3Q8aW50PihjZWlsZihjbHV0dGVyX2FjdG9yX2dldF93aWR0aChhY3RvcikpKSwgMSk7CisgICAg aW50IGhlaWdodCA9IHN0ZDo6bWF4KHN0YXRpY19jYXN0PGludD4oY2VpbGYoY2x1dHRlcl9hY3Rv cl9nZXRfaGVpZ2h0KGFjdG9yKSkpLCAxKTsKKyAgICBjbHV0dGVyX2NhbnZhc19zZXRfc2l6ZShD TFVUVEVSX0NBTlZBUyhjYW52YXMuZ2V0KCkpLCB3aWR0aCwgaGVpZ2h0KTsKKworICAgIGdfc2ln bmFsX2Nvbm5lY3QoY2FudmFzLmdldCgpLCAiZHJhdyIsIEdfQ0FMTEJBQ0soZ3JhcGhpY3NMYXll ckFjdG9yRHJhdyksIGxheWVyKTsKIH0KIAogLy8gRHJhdyBjb250ZW50IGludG8gdGhlIGxheWVy LgpAQCAtMzM5LDkgKzM0MCw5IEBAIHZvaWQgZ3JhcGhpY3NMYXllckFjdG9yUmVtb3ZlQWxsKEdy YXBoaWNzTGF5ZXJBY3RvciogbGF5ZXIpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChHUkFQSElD U19MQVlFUl9JU19BQ1RPUihsYXllcikpOwogCi0gICAgR0xpc3QqIGNoaWxkcmVuID0gY2x1dHRl cl9hY3Rvcl9nZXRfY2hpbGRyZW4oQ0xVVFRFUl9BQ1RPUihsYXllcikpOwotICAgIGZvciAoOyBj aGlsZHJlbjsgY2hpbGRyZW4gPSBjaGlsZHJlbi0+bmV4dCkKLSAgICAgICAgY2x1dHRlcl9hY3Rv cl9yZW1vdmVfY2hpbGQoQ0xVVFRFUl9BQ1RPUihsYXllciksIENMVVRURVJfQUNUT1IoY2hpbGRy ZW4tPmRhdGEpKTsKKyAgICBHT3duUHRyPEdMaXN0PiBjaGlsZHJlbihjbHV0dGVyX2FjdG9yX2dl dF9jaGlsZHJlbihDTFVUVEVSX0FDVE9SKGxheWVyKSkpOworICAgIGZvciAoR0xpc3QqIGNoaWxk ID0gY2hpbGRyZW4uZ2V0KCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0KQorICAgICAgICBj bHV0dGVyX2FjdG9yX3JlbW92ZV9jaGlsZChDTFVUVEVSX0FDVE9SKGxheWVyKSwgQ0xVVFRFUl9B Q1RPUihjaGlsZC0+ZGF0YSkpOwogfQogCiBjYWlyb19zdXJmYWNlX3QqIGdyYXBoaWNzTGF5ZXJB Y3RvckdldFN1cmZhY2UoR3JhcGhpY3NMYXllckFjdG9yKiBsYXllcikK