113512 2013-03-28 10:09:25 -0700 [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow 2013-03-29 04:28:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson feature-media-reviews gustavo jer.noble menard mrobinson pnormand webkit.review.bot oldest_to_newest 865593 0 pnormand 2013-03-28 10:09:25 -0700 We should pause the pipeline when we get a buffering message that is not the final one. This is a strong advice from the GStreamer developers :) 865595 1 195589 pnormand 2013-03-28 10:12:55 -0700 Created attachment 195589 patch 865599 2 195589 mrobinson 2013-03-28 10:17:49 -0700 Comment on attachment 195589 patch Does the player automatically unpause? 865616 3 pnormand 2013-03-28 10:39:15 -0700 (In reply to comment #2) > (From update of attachment 195589 [details]) > Does the player automatically unpause? Yes when buffering is finished and also once the pipeline pre-rolled. 865621 4 195589 mrobinson 2013-03-28 10:43:06 -0700 Comment on attachment 195589 patch View in context: https://bugs.webkit.org/attachment.cgi?id=195589&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:806 > + if (!m_paused && (m_bufferingPercentage < 100)) { You can probably dispense with the inner parenthesis here. 866076 5 pnormand 2013-03-29 04:28:35 -0700 Committed r147206: <http://trac.webkit.org/changeset/147206> 195589 2013-03-28 10:12:55 -0700 2013-03-28 10:43:06 -0700 patch patch.patch text/plain 2144 pnormand RnJvbSBjOTQwNWNmYjIwYWM1MjQwMzBlYTM2MWZkOWZjYjI5OGY3YmRkNzI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI4IE1hciAyMDEzIDE4OjEyOjIyICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgfCAgNSArKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlhZGQzNjYuLmE2OTU3YzEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMy0yOCAgUGhpbGlwcGUgTm9ybWFu ZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gcGxheWJhY2sg Z2V0cyBidW1weSBzb21ldGltZXMgd2hlbiBvbi1kaXNrIGJ1ZmZlcmluZyBpcyBzbG93CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM1MTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBIVFRQ IHNvdXJjZSBlbGVtZW50IGlzIHNsb3cgZG93bmxvYWRpbmcgZGF0YSBmb3Igb24tZGlzaworICAg ICAgICBidWZmZXJpbmcgdGhlIHBsYXliYWNrIHBvc2l0aW9uIG1pZ2h0IHJlYWNoIGFuIHVuYnVm ZmVyZWQgcmVnaW9uCisgICAgICAgIGFuZCBoYXZlIGJhZCBjb25zZXF1ZW5jZXMsIHBhdXNpbmcg dGhlIHBpcGVsaW5lIGJlZm9yZWhhbmQKKyAgICAgICAgcHJldmVudHMgdGhpcyBjYXNlIHRvIGhh cHBlbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyOjpwcm9jZXNzQnVmZmVyaW5nU3RhdHMpOgorCiAyMDEzLTAzLTI4ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBbR1RLXVtB Q10gQW5pbWF0aW5nIGxheWVyIGRpc2FwcGVhcnMgd2hpbGUgcnVubmluZyB3aXRoIGNsdXR0ZXIg YmFja2VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cAppbmRleCBmNmJhMjgyLi43ZGQ3ZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtODAyLDYgKzgwMiwxMSBAQCB2b2lkIE1lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lcjo6cHJvY2Vzc0J1ZmZlcmluZ1N0YXRzKEdzdE1lc3NhZ2UqIG1l c3NhZ2UpCiAKICAgICAgICAgbV9maWxsVGltZXIuc3RhcnRSZXBlYXRpbmcoMC4yKTsKICAgICB9 CisKKyAgICBpZiAoIW1fcGF1c2VkICYmIChtX2J1ZmZlcmluZ1BlcmNlbnRhZ2UgPCAxMDApKSB7 CisgICAgICAgIExPR19NRURJQV9NRVNTQUdFKCJbQnVmZmVyaW5nXSBEb3dubG9hZCBpbiBwcm9n cmVzcywgcGF1c2luZyBwaXBlbGluZS4iKTsKKyAgICAgICAgZ3N0X2VsZW1lbnRfc2V0X3N0YXRl KG1fcGxheUJpbi5nZXQoKSwgR1NUX1NUQVRFX1BBVVNFRCk7CisgICAgfQogfQogCiB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6ZmlsbFRpbWVyRmlyZWQoVGltZXI8TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyPiopCi0tIAoxLjguMi5yYzM=