113457 2013-03-27 17:05:06 -0700 remove parentsOnly variable in codeGenerator.pm 2013-03-27 18:09:45 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier abarth haraken japhet webkit.review.bot oldest_to_newest 865007 0 a.renevier 2013-03-27 17:05:06 -0700 Hi, since bug #26398, parentsOnly argument is not used anymore by idl parser. So, for cleanup, parentsOnly arguments could be removed from codeGenerator.pm. 865016 1 195441 a.renevier 2013-03-27 17:10:59 -0700 Created attachment 195441 patch proposal 865029 2 195441 haraken 2013-03-27 17:15:36 -0700 Comment on attachment 195441 patch proposal ok 865068 3 webkit.review.bot 2013-03-27 18:08:11 -0700 The commit-queue encountered the following flaky tests while processing attachment 195441: fast/preloader/document-write-noscript.html bug 113464 (authors: rniwa@webkit.org and tonyg@chromium.org) The commit-queue is continuing to process your patch. 865072 4 195441 webkit.review.bot 2013-03-27 18:09:40 -0700 Comment on attachment 195441 patch proposal Clearing flags on attachment: 195441 Committed r147041: <http://trac.webkit.org/changeset/147041> 865073 5 webkit.review.bot 2013-03-27 18:09:45 -0700 All reviewed patches have been landed. Closing bug. 195441 2013-03-27 17:10:59 -0700 2013-03-27 18:09:40 -0700 patch proposal bug-113457-20130327171057.patch text/plain 3941 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYyZmFkOWY1ODA4MGE5 ZDllMzQzNjJlZmY0ZDQ0OTg4ZWJmNDA3Ni4uMDJkYzczODgxOWFkMDc2MTk5ZmIwZjM5MjJkMGJm NDYxYTFjZTc3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTAzLTI3ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgcmVt b3ZlIHBhcmVudHNPbmx5IHZhcmlhYmxlIGluIGNvZGVHZW5lcmF0b3IucG0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzQ1NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgdmFyaWFi bGUgcGFyZW50c09ubHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBubyBjaGFuZ2UgaW4gYmVo YXZpb3VyLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtOgor ICAgICAgICAoRm9yQWxsUGFyZW50cyk6CisgICAgICAgIChBZGRNZXRob2RzQ29uc3RhbnRzQW5k QXR0cmlidXRlc0Zyb21QYXJlbnRJbnRlcmZhY2VzKToKKyAgICAgICAgKFBhcnNlSW50ZXJmYWNl KToKKyAgICAgICAgKEluaGVyaXRzSW50ZXJmYWNlKToKKyAgICAgICAgKEluaGVyaXRzRXh0ZW5k ZWRBdHRyaWJ1dGUpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorICAgICAgICAoQmFzZUludGVyZmFjZU5hbWUpOgorCisyMDEzLTAzLTI3ICBBcm5hdWQg UmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgdXNlIENh bnZhc1dpbmRpbmdSdWxlIGVudW1lcmF0aW9uIGluIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5p ZGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzQ1 NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3IucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3Iu cG0KaW5kZXggYWI0OTAyYjg4YmQ3ZGQ0OGQwMjhhZDE1OWJiNjYwYmNmOTg1YmM5Zi4uNmE3Y2Ni OTVhNWY4NzIwYWUwM2VkYmVhOWExNWZhMDc3YjgxYzAzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQpAQCAtMTc1LDcgKzE3NSw2IEBA IHN1YiBGb3JBbGxQYXJlbnRzCiAgICAgbXkgJGludGVyZmFjZSA9IHNoaWZ0OwogICAgIG15ICRi ZWZvcmVSZWN1cnNpb24gPSBzaGlmdDsKICAgICBteSAkYWZ0ZXJSZWN1cnNpb24gPSBzaGlmdDsK LSAgICBteSAkcGFyZW50c09ubHkgPSBzaGlmdDsKIAogICAgIG15ICRyZWN1cnNlOwogICAgICRy ZWN1cnNlID0gc3ViIHsKQEAgLTE4Myw3ICsxODIsNyBAQCBzdWIgRm9yQWxsUGFyZW50cwogCiAg ICAgICAgIGZvciAoQHskY3VycmVudEludGVyZmFjZS0+cGFyZW50c30pIHsKICAgICAgICAgICAg IG15ICRpbnRlcmZhY2VOYW1lID0gJF87Ci0gICAgICAgICAgICBteSAkcGFyZW50SW50ZXJmYWNl ID0gJG9iamVjdC0+UGFyc2VJbnRlcmZhY2UoJGludGVyZmFjZU5hbWUsICRwYXJlbnRzT25seSk7 CisgICAgICAgICAgICBteSAkcGFyZW50SW50ZXJmYWNlID0gJG9iamVjdC0+UGFyc2VJbnRlcmZh Y2UoJGludGVyZmFjZU5hbWUpOwogCiAgICAgICAgICAgICBpZiAoJGJlZm9yZVJlY3Vyc2lvbikg ewogICAgICAgICAgICAgICAgICYkYmVmb3JlUmVjdXJzaW9uKCRwYXJlbnRJbnRlcmZhY2UpIGVx ICdwcnVuZScgYW5kIG5leHQ7CkBAIC0yMjYsNyArMjI1LDcgQEAgc3ViIEFkZE1ldGhvZHNDb25z dGFudHNBbmRBdHRyaWJ1dGVzRnJvbVBhcmVudEludGVyZmFjZXMKICAgICAgICAgICAgICAgICAk b2JqZWN0LT5Gb3JBbGxQYXJlbnRzKCRjdXJyZW50SW50ZXJmYWNlLCBzdWIgewogICAgICAgICAg ICAgICAgICAgICBteSAkY3VycmVudEludGVyZmFjZSA9IHNoaWZ0OwogICAgICAgICAgICAgICAg ICAgICBwdXNoKEAkcGFyZW50cywgJGN1cnJlbnRJbnRlcmZhY2UtPm5hbWUpOwotICAgICAgICAg ICAgICAgIH0sIHVuZGVmLCAxKTsKKyAgICAgICAgICAgICAgICB9LCB1bmRlZik7CiAgICAgICAg ICAgICB9CiAKICAgICAgICAgICAgICMgUHJ1bmUgdGhlIHJlY3Vyc2lvbiBoZXJlLgpAQCAtMjkw LDcgKzI4OSw2IEBAIHN1YiBQYXJzZUludGVyZmFjZQogewogICAgIG15ICRvYmplY3QgPSBzaGlm dDsKICAgICBteSAkaW50ZXJmYWNlTmFtZSA9IHNoaWZ0OwotICAgIG15ICRwYXJlbnRzT25seSA9 IHNoaWZ0OwogCiAgICAgcmV0dXJuIHVuZGVmIGlmICRpbnRlcmZhY2VOYW1lIGVxICdPYmplY3Qn OwogCkBAIC0zMDYsNyArMzA0LDcgQEAgc3ViIFBhcnNlSW50ZXJmYWNlCiAKICAgICAjIFN0ZXAg IzI6IFBhcnNlIHRoZSBmb3VuZCBJREwgZmlsZSAoaW4gcXVpZXQgbW9kZSkuCiAgICAgbXkgJHBh cnNlciA9IElETFBhcnNlci0+bmV3KDEpOwotICAgIG15ICRkb2N1bWVudCA9ICRwYXJzZXItPlBh cnNlKCRmaWxlbmFtZSwgJGRlZmluZXMsICRwcmVwcm9jZXNzb3IsICRwYXJlbnRzT25seSk7Cisg ICAgbXkgJGRvY3VtZW50ID0gJHBhcnNlci0+UGFyc2UoJGZpbGVuYW1lLCAkZGVmaW5lcywgJHBy ZXByb2Nlc3Nvcik7CiAKICAgICBmb3JlYWNoIG15ICRpbnRlcmZhY2UgKEB7JGRvY3VtZW50LT5p bnRlcmZhY2VzfSkgewogICAgICAgICBpZiAoJGludGVyZmFjZS0+bmFtZSBlcSAkaW50ZXJmYWNl TmFtZSkgewpAQCAtNzc3LDcgKzc3NSw3IEBAIHN1YiBJbmhlcml0c0ludGVyZmFjZQogICAgICAg ICAgICAgJGZvdW5kID0gMTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gMSBpZiAkZm91bmQ7 Ci0gICAgfSwgMCwgMSk7CisgICAgfSwgMCk7CiAKICAgICByZXR1cm4gJGZvdW5kOwogfQpAQCAt Nzk2LDcgKzc5NCw3IEBAIHN1YiBJbmhlcml0c0V4dGVuZGVkQXR0cmlidXRlCiAgICAgICAgICAg ICAkZm91bmQgPSAxOwogICAgICAgICB9CiAgICAgICAgIHJldHVybiAxIGlmICRmb3VuZDsKLSAg ICB9LCAwLCAxKTsKKyAgICB9LCAwKTsKIAogICAgIHJldHVybiAkZm91bmQ7CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4 IGUzZDgyNTQ3NDFkM2VmNGVjYzk5OTY5YjI5YjBkY2Q0OTg4ZmZiMDguLjg1MTM0ZWE0NjAyMzBh ZDNkZGJjYTFhNDVjOTkzNjEwMjIzNDYxM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0zNjgwLDcgKzM2ODAsNyBAQCBz dWIgQmFzZUludGVyZmFjZU5hbWUKICAgICBteSAkaW50ZXJmYWNlID0gc2hpZnQ7CiAKICAgICB3 aGlsZSAoQHskaW50ZXJmYWNlLT5wYXJlbnRzfSkgewotICAgICAgICAkaW50ZXJmYWNlID0gJGNv ZGVHZW5lcmF0b3ItPlBhcnNlSW50ZXJmYWNlKEB7JGludGVyZmFjZS0+cGFyZW50c31bMF0sIDEp OworICAgICAgICAkaW50ZXJmYWNlID0gJGNvZGVHZW5lcmF0b3ItPlBhcnNlSW50ZXJmYWNlKEB7 JGludGVyZmFjZS0+cGFyZW50c31bMF0pOwogICAgIH0KIAogICAgIHJldHVybiAkaW50ZXJmYWNl LT5uYW1lOwo=