113394 2013-03-27 05:11:47 -0700 Add support for runtime flags for experimental blending to chromium 2013-04-10 18:11:14 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 108550 1 cabanier mitica cabanier eric jamesr schenney syoichi oldest_to_newest 864425 0 cabanier 2013-03-27 05:11:47 -0700 Add the option to enable blending CSS features to chromium through chrome://flags/ 864488 1 195305 mitica 2013-03-27 06:48:21 -0700 Created attachment 195305 Patch 864537 2 cabanier 2013-03-27 07:37:06 -0700 The CSS_COMPOSITING flag enables the parsing of the blend CSS keywords. By default, those functions are turned off. Only when the flag for experimental features is enabled, will the css keywords be parsed. 865780 3 195305 jamesr 2013-03-28 14:12:44 -0700 Comment on attachment 195305 Patch This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger 865785 4 eric 2013-03-28 14:16:22 -0700 I must be searching wrong. I only see this controlling parsing? https://code.google.com/p/chromium/codesearch#search/&q=CSS_COMPOSITING&sq=package:chromium&type=cs 865791 5 mitica 2013-03-28 14:20:47 -0700 As far as I know, indeed only the parsing bit is currently done for Chromium. I don't think the other changes under this flag impact the chromium port, as they seem WebKit specific. 865795 6 cabanier 2013-03-28 14:23:00 -0700 (In reply to comment #4) > I must be searching wrong. I only see this controlling parsing? > https://code.google.com/p/chromium/codesearch#search/&q=CSS_COMPOSITING&sq=package:chromium&type=cs That is correct. We are still working on getting the actual rendering in. There are patches in the works. 865811 7 cabanier 2013-03-28 14:38:52 -0700 (In reply to comment #3) > (From update of attachment 195305 [details]) > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. StyleRareNonInheritedData should not be *that* much bigger. 866206 8 jamesr 2013-03-29 09:57:05 -0700 (In reply to comment #7) > (In reply to comment #3) > > (From update of attachment 195305 [details] [details]) > > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger > > When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. > StyleRareNonInheritedData should not be *that* much bigger. OK, but that doesn't answer my question. Where are the runtime guards for this functionality? 866233 9 cabanier 2013-03-29 10:56:42 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #3) > > > (From update of attachment 195305 [details] [details] [details]) > > > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger > > > > When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. > > StyleRareNonInheritedData should not be *that* much bigger. > > OK, but that doesn't answer my question. Where are the runtime guards for this functionality? ah, I was replying to making StyleRareNonInheritedData bigger. see https://bugs.webkit.org/show_bug.cgi?id=111818 for the runtime hooks. 873405 10 195305 rniwa 2013-04-10 18:11:14 -0700 Comment on attachment 195305 Patch Clearing the flag. 195305 2013-03-27 06:48:21 -0700 2013-04-10 18:11:13 -0700 Patch bug-113394-20130327154402.patch text/plain 1380 mitica SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDY5NzgpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAzLTI3ICBNaWhhaSBUaWNhICA8bWl0aWNhQGFkb2JlLmNvbT4KKworICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgcnVudGltZSBmbGFncyBmb3IgZXhwZXJpbWVudGFsIGJsZW5kaW5n IHRvIGNocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTMzOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBFbmFibGUgQ1NTX0NPTVBPU0lUSU5HIGJ1aWxkIGZsYWcgZm9yIENocm9taXVtLCBhcyB0 aGUgZmlyc3QgcGFydCBvZiBlbmFibGluZyBDU1MgQmxlbmRpbmcgYXMgYW4gZXhwZXJpZW50YWwK KyAgICAgICAgd2Via2l0IGZlYXR1cmUuIEFkZGl0aW9uYWwgY2hhbmdlcyBhcmUgcmVxdWlyZWQg aW4gdGhlIGNocm9taXVtIGNvbnRlbnQsIHdoaWNoIHdpbGwgYmUgc3VibWl0dGVkIGFzIGEgZnV0 dXJlIGNocm9taXVtIHBhdGNoLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMy0w My0yNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVuYW1l IEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnJlYWRPbmx5IHRvIGlzUmVhZE9ubHkKSW5kZXg6IFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDE0Njk3OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtNDQsNyAr NDQsNyBAQAogICAgICAgJ0VOQUJMRV9DU1MzX1RFWFQ9MCcsCiAgICAgICAnRU5BQkxFX0NTUzNf VEVYVF9MSU5FX0JSRUFLPTAnLAogICAgICAgJ0VOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJF QUs9MScsCi0gICAgICAnRU5BQkxFX0NTU19DT01QT1NJVElORz0wJywKKyAgICAgICdFTkFCTEVf Q1NTX0NPTVBPU0lUSU5HPTEnLAogICAgICAgJ0VOQUJMRV9DU1NfREVWSUNFX0FEQVBUQVRJT049 MCcsCiAgICAgICAnRU5BQkxFX0NTU19FWENMVVNJT05TPTEnLAogICAgICAgJ0VOQUJMRV9DU1Nf RklMVEVSUz0xJywK