113369 2013-03-27 00:55:40 -0700 [BlackBerry] Assert failure when destructing DumpRenderTree 2013-05-09 10:53:20 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED DUPLICATE 114503 P2 Normal --- 0 xiaobwang webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 864275 0 xiaobwang 2013-03-27 00:55:40 -0700 RIM PR 316822 Back traces ============ #0 0x7817d142 in BlackBerry::Platform::platformCrash (file=0x78338fa8 "/home/worker/workspace/playbook/platform/blackberryplatform/BlackBerryPlatformGuardedPointer.cpp", line=<optimized out>, function=<optimized out>) at /home/worker/workspace/playbook/platform/blackberryplatform/BlackBerryPlatformAssert.cpp:24 #1 0x78186c8c in BlackBerry::Platform::GuardedPointerBase::~GuardedPointerBase (this=0x816426c, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/platform/blackberryplatform/BlackBerryPlatformGuardedPointer.cpp:138 #2 0x782d97b4 in BlackBerry::Platform::LayoutTestClient::~LayoutTestClient (this=0x816426c, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/platform/blackberryplatform/BlackBerryPlatformLayoutTest.cpp:22 #3 0x784c5a5a in ~Timer (this=0x81642f0, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/webkit/Source/WebCore/platform/Timer.h:98 #4 BlackBerry::WebKit::DumpRenderTree::~DumpRenderTree (this=0x8164268, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/webkit/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:207 #5 0x784c5ac8 in destruct (end=0x0, begin=0x0) at /home/worker/workspace/playbook/webkit/Source/WTF/wtf/Vector.h:58 #6 destruct (end=0x0, begin=0x0) at /home/worker/workspace/playbook/webkit/Source/WTF/wtf/Vector.h:221 #7 shrink (this=0x8164278, size=<optimized out>) at /home/worker/workspace/playbook/webkit/Source/WTF/wtf/Vector.h:941 #8 ~Vector (this=0x8164278, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/webkit/Source/WTF/wtf/Vector.h:547 #9 BlackBerry::WebKit::DumpRenderTree::~DumpRenderTree (this=0x8164268, __in_chrg=<optimized out>) at /home/worker/workspace/playbook/webkit/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:207 #10 0x080980c8 in ?? () #11 0x080980c8 in ?? () Root cause ============ B::W::DumpRenderTree derived from B::W::DumpRenderTreeClient and B::P::LayoutTestClient, and B::P::LayoutTestClient derived from B::P::GuardedPointerBase. In WebPagePrivate::m_dumpRenderTree is a B::W::DumpRenderTreeClient pointer backed by a B::W::DumpRenderTree instance. So if we delete m_dumpRenderTree the DumpRenderTree object will be deleted directory without calling deleteGuardedObject, and hit the assert in GuardedPointerBase::~GuardedPointerBase(). Solution ========== Since WebPagePrivate::m_dumpRenderTree is not derived from GuardedPointerBase, we can't use "deleteGuardedObject(m_dumpRenderTree);". We can add a virtual function DumpRenderTreeClient::destroy() and use it to destruct the DumpRenderTree instance. 864291 1 195241 xiaobwang 2013-03-27 01:30:52 -0700 Created attachment 195241 patch 875439 2 xiaobwang 2013-04-14 20:13:12 -0700 Fixed in another bug https://bugs.webkit.org/show_bug.cgi?id=114503 by Carlos Garcia Campos. So close this one for now. *** This bug has been marked as a duplicate of bug 114503 *** 875441 3 xiaobwang 2013-04-14 20:14:18 -0700 close 886950 4 195241 rwlbuis 2013-05-09 10:53:09 -0700 Comment on attachment 195241 patch This was fixed in a different way, internal commit webkit/92b8ab4cf0514289f6114dd39c3944115ce5e72b. 195241 2013-03-27 01:30:52 -0700 2013-05-09 10:53:20 -0700 patch 0001-BlackBerry-Assert-failure-when-destructing-DumpRende.patch text/plain 6269 xiaobwang RnJvbSBjNWZkYWJiYTQ2MjI3ODBkODQwYzQ3OTA3NjM4ZGUzMTBiYzEzZDUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogV2VkLCAyNyBNYXIgMjAxMyAxNjoyNTozNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSAgQXNzZXJ0IGZhaWx1cmUgd2hlbiBkZXN0cnVjdGluZyBEdW1wUmVuZGVy VHJlZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzM2OSBQUiAz MTY4MjIKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5OgoKKiBBcGkvRHVtcFJlbmRlclRyZWVDbGllbnQuaDoKQWRkIGEgcHVibGljIHZpcnR1YWwg ZnVuY3Rpb24gZGVzdHJveSgpIHRvIER1bXBSZW5kZXJUcmVlQ2xpZW50LCBhbmQKbWFrZSB0aGUg ZGVzdHJ1Y3RvciBwcm90ZWN0ZWQgdG8gYXZvaWQgZXhwbGljaXQgZGVsZXRlLiBTaG91bGQgYWx3 YXlzCmNhbGwgZGVzdHJveSgpIHRvIGRlc3RydWN0IGZyb20gb3V0c2lkZS4KCiogQXBpL1dlYlBh Z2UuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6fldlYlBhZ2VQcml2 YXRlKToKQ2FsbCBtX2R1bXBSZW5kZXJUcmVlLT5kZXN0cm95KCkgdG8gZGVzdHJ1Y3QgbV9kdW1w UmVuZGVyVHJlZS4KClRvb2xzOgoKSW1wbGVtZW50IER1bXBSZW5kZXJUcmVlQ2xpZW50OjpkZXN0 cm95KCkgYnkgZGVzdHJ1Y3Rpbmcgd2l0aApkZWxldGVHdWFyZGVkT2JqZWN0KCksIGFuZCBtYWtl IHRoZSBkZXN0cnVjdG9yIHByaXZhdGUgdG8gYXZvaWQKZXhwbGljaXQgZGVsZXRlLgoKKiBEdW1w UmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcDoKKEJsYWNrQmVycnk6Oldl YktpdDo6RHVtcFJlbmRlclRyZWU6OmRlc3Ryb3kpOgooV2ViS2l0KToKKiBEdW1wUmVuZGVyVHJl ZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlQmxhY2tCZXJyeS5oOgooRHVtcFJlbmRlclRyZWUp OgotLS0KIC4uLi9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvRHVtcFJlbmRlclRyZWVDbGllbnQuaCAg IHwgICAgNCArKystCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwICAg ICAgICAgICB8ICAgIDYgKysrKy0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIFRvb2xzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysr KysrKysKIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3Bw IHwgICAgNSArKysrKwogLi4uL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWVCbGFja0JlcnJ5Lmgg ICAgICAgICAgfCAgICA0ICsrKy0KIDYgZmlsZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L0R1bXBSZW5kZXJUcmVlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0R1 bXBSZW5kZXJUcmVlQ2xpZW50LmgKaW5kZXggZTk3NDFjMC4uYjdkZmNmZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9EdW1wUmVuZGVyVHJlZUNsaWVudC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvRHVtcFJlbmRlclRyZWVDbGllbnQuaApAQCAt NDIsOCArNDIsOCBAQCBjbGFzcyBXZWJQYWdlOwogCiBjbGFzcyBCTEFDS0JFUlJZX0VYUE9SVCBE dW1wUmVuZGVyVHJlZUNsaWVudCB7CiBwdWJsaWM6Ci0gICAgdmlydHVhbCB+RHVtcFJlbmRlclRy ZWVDbGllbnQoKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgcnVuVGVzdHMoKSA9IDA7CisgICAgdmly dHVhbCB2b2lkIGRlc3Ryb3koKSA9IDA7CiAKICAgICAvLyBGcmFtZUxvYWRlckNsaWVudCBkZWxl Z2F0ZXMKICAgICB2aXJ0dWFsIHZvaWQgZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZShX ZWJDb3JlOjpGcmFtZSopID0gMDsKQEAgLTg1LDYgKzg1LDggQEAgcHVibGljOgogICAgIHZpcnR1 YWwgYm9vbCBzaG91bGRJbnNlcnRUZXh0KGNvbnN0IFN0cmluZyYsIFdlYkNvcmU6OlJhbmdlKiwg aW50IGluc2VydEFjdGlvbikgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBkaWRSZWNlaXZlQXV0aGVu dGljYXRpb25DaGFsbGVuZ2UoV2ViQ29yZTo6Q3JlZGVudGlhbCYpID0gMDsKIAorcHJvdGVjdGVk OgorICAgIHZpcnR1YWwgfkR1bXBSZW5kZXJUcmVlQ2xpZW50KCkgeyB9CiB9OwogfQogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggZDM4ZmE1ZC4uNTQ2NWNl MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC00OTMsOCAr NDkzLDEwIEBAIFdlYlBhZ2VQcml2YXRlOjp+V2ViUGFnZVByaXZhdGUoKQogICAgIG1fcHJveGlt aXR5RGV0ZWN0b3IgPSAwOwogCiAjaWYgIWRlZmluZWQoUFVCTElDX0JVSUxEKSB8fCAhUFVCTElD X0JVSUxECi0gICAgZGVsZXRlIG1fZHVtcFJlbmRlclRyZWU7Ci0gICAgbV9kdW1wUmVuZGVyVHJl ZSA9IDA7CisgICAgaWYgKG1fZHVtcFJlbmRlclRyZWUpIHsKKyAgICAgICAgbV9kdW1wUmVuZGVy VHJlZS0+ZGVzdHJveSgpOworICAgICAgICBtX2R1bXBSZW5kZXJUcmVlID0gMDsKKyAgICB9CiAj ZW5kaWYKIAogICAgIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlTWFuYWdlcjo6aW5zdGFuY2UoKS0+ cGFnZURlbGV0ZWQodGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzYjgx OTM5Li5kNjI5OWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxMy0wMy0yNyAgWGlhb2JvIFdhbmcgIDx4YndhbmdAdG9yY2htb2JpbGUuY29tLmNu PgorCisgICAgICAgIFtCbGFja0JlcnJ5XSAgQXNzZXJ0IGZhaWx1cmUgd2hlbiBkZXN0cnVjdGlu ZyBEdW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEzMzY5CisgICAgICAgIFBSIDMxNjgyMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL0R1bXBSZW5kZXJUcmVlQ2xpZW50Lmg6 CisgICAgICAgIEFkZCBhIHB1YmxpYyB2aXJ0dWFsIGZ1bmN0aW9uIGRlc3Ryb3koKSB0byBEdW1w UmVuZGVyVHJlZUNsaWVudCwgYW5kCisgICAgICAgIG1ha2UgdGhlIGRlc3RydWN0b3IgcHJvdGVj dGVkIHRvIGF2b2lkIGV4cGxpY2l0IGRlbGV0ZS4gU2hvdWxkIGFsd2F5cworICAgICAgICBjYWxs IGRlc3Ryb3koKSB0byBkZXN0cnVjdCBmcm9tIG91dHNpZGUuCisKKyAgICAgICAgKiBBcGkvV2Vi UGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjp+ V2ViUGFnZVByaXZhdGUpOgorICAgICAgICBDYWxsIG1fZHVtcFJlbmRlclRyZWUtPmRlc3Ryb3ko KSB0byBkZXN0cnVjdCBtX2R1bXBSZW5kZXJUcmVlLgorCiAyMDEzLTAzLTI2ICBIYXlhdG8gSXRv ICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBbGxvdyBTaGFkb3dDb250ZW50cyBp biBIaXRUZXN0cyBieSBkZWZhdWx0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDAyNWE4NGEuLjc4MGFmM2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wMy0y NyAgWGlhb2JvIFdhbmcgIDx4YndhbmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtC bGFja0JlcnJ5XSAgQXNzZXJ0IGZhaWx1cmUgd2hlbiBkZXN0cnVjdGluZyBEdW1wUmVuZGVyVHJl ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMzY5 CisgICAgICAgIFBSIDMxNjgyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEltcGxlbWVudCBEdW1wUmVuZGVyVHJlZUNsaWVudDo6ZGVzdHJveSgpIGJ5 IGRlc3RydWN0aW5nIHdpdGgKKyAgICAgICAgZGVsZXRlR3VhcmRlZE9iamVjdCgpLCBhbmQgbWFr ZSB0aGUgZGVzdHJ1Y3RvciBwcml2YXRlIHRvIGF2b2lkCisgICAgICAgIGV4cGxpY2l0IGRlbGV0 ZS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUu Y3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpEdW1wUmVuZGVyVHJlZTo6ZGVzdHJv eSk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVy cnkvRHVtcFJlbmRlclRyZWVCbGFja0JlcnJ5Lmg6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZSk6 CisKIDIwMTMtMDMtMjYgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIEZsYWtpbmVzcyBkYXNoYm9hcmQ6IHNpbXBsaWZ5IGxvZ2ljIGFyb3VuZCB3aGljaCB0 ZXN0cyB0byBzaG93LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJy eS9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1 bXBSZW5kZXJUcmVlLmNwcAppbmRleCA5NTY0NDRiLi5iN2NiYjU1IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMTk0LDYg KzE5NCwxMSBAQCBEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUoQmxhY2tCZXJyeTo6V2Vi S2l0OjpXZWJQYWdlKiBwYWdlKQogICAgIHNfY3VycmVudEluc3RhbmNlID0gdGhpczsKIH0KIAor dm9pZCBEdW1wUmVuZGVyVHJlZTo6ZGVzdHJveSgpCit7CisgICAgZGVsZXRlR3VhcmRlZE9iamVj dCh0aGlzKTsKK30KKwogRHVtcFJlbmRlclRyZWU6On5EdW1wUmVuZGVyVHJlZSgpCiB7CiAgICAg ZGVsZXRlIG1fZ2NDb250cm9sbGVyOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv YmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZUJsYWNrQmVycnkuaCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWVCbGFja0JlcnJ5LmgKaW5kZXggMjY3YzRkYy4u NDdmMjBjOCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1w UmVuZGVyVHJlZUJsYWNrQmVycnkuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2Jl cnJ5L0R1bXBSZW5kZXJUcmVlQmxhY2tCZXJyeS5oCkBAIC01MCw3ICs1MCw3IEBAIGNsYXNzIFdl YlBhZ2U7CiBjbGFzcyBEdW1wUmVuZGVyVHJlZSA6IHB1YmxpYyBCbGFja0JlcnJ5OjpXZWJLaXQ6 OkR1bXBSZW5kZXJUcmVlQ2xpZW50LCBwdWJsaWMgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkxheW91 dFRlc3RDbGllbnQgewogcHVibGljOgogICAgIER1bXBSZW5kZXJUcmVlKFdlYlBhZ2UqKTsKLSAg ICB2aXJ0dWFsIH5EdW1wUmVuZGVyVHJlZSgpOworICAgIHZpcnR1YWwgdm9pZCBkZXN0cm95KCk7 CiAKICAgICBzdGF0aWMgRHVtcFJlbmRlclRyZWUqIGN1cnJlbnRJbnN0YW5jZSgpIHsgcmV0dXJu IHNfY3VycmVudEluc3RhbmNlOyB9CiAKQEAgLTEwOCw2ICsxMDgsOCBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCB2b2lkIGFkZFRlc3QoY29uc3QgY2hhciogdGVzdEZpbGUpOwogICAgIHZvaWQgc2V0 Q3VzdG9tUG9saWN5RGVsZWdhdGUoYm9vbCBzZXREZWxlZ2F0ZSwgYm9vbCBwZXJtaXNzaXZlKTsK IHByaXZhdGU6CisgICAgdmlydHVhbCB+RHVtcFJlbmRlclRyZWUoKTsKKwogICAgIHZvaWQgcnVu VGVzdChjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgU3RyaW5nJiBpbWFnZUhhc2gpOwogICAgIHZv aWQgcnVuVGVzdHMoKTsKICAgICB2b2lkIHJ1bkN1cnJlbnRUZXN0KCk7Ci0tIAoxLjcuOS41Cgo=