113255 2013-03-25 17:11:18 -0700 [CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension 2013-03-26 15:12:00 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 1 zoltan zoltan betravis eric esprehn+autocc giles_joplin jchaffraix ojan.autocc webkit.review.bot oldest_to_newest 863188 0 zoltan 2013-03-25 17:11:18 -0700 When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the width or height is not resolvable for the circle we should not have a radius for it. 863214 1 194961 zoltan 2013-03-25 17:29:56 -0700 Created attachment 194961 proposed patch 863807 2 zoltan 2013-03-26 10:34:52 -0700 *** Bug 111609 has been marked as a duplicate of this bug. *** 863991 3 194961 jchaffraix 2013-03-26 14:13:37 -0700 Comment on attachment 194961 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=194961&action=review > LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:6 > + font: 14px Ahem, sans-serif; Not really needed as it's a ref test and I would expect the font resolution to give similar results on both tests. It also makes the output unreadable by maintainers. (and btw using 14px as the font size makes little sense, it's a lot easier to use a round number like 10px or 15px so that it's easier to know where the line layout algorithm breaks). > LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:9 > + height: 300px; This is unneeded and should be removed. > LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:28 > +<p>Requires Ahem font. Since the nested container's height is not resolvable, we shouldn't apply the circle shape-inside on the content.</p> No need for Ahem. > LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:29 > +<p>Bug <a href="http://webkit.org/b/113255 ">113255</a>: The radius of a circle should be computed based on the shorter available dimensions</p> Please add a description (ie what is expected in the output) before landing. 864047 4 zoltan 2013-03-26 15:12:00 -0700 Landed in http://trac.webkit.org/changeset/146938 194961 2013-03-25 17:29:56 -0700 2013-03-26 14:13:37 -0700 proposed patch heightunresolved.patch text/plain 6213 zoltan SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5z aWRlLW9uLW5lc3RlZC1jb250YWluZXItd2l0aC11bnJlc29sdmVkLWhlaWdodC1leHBlY3RlZC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNp ZGUvc2hhcGUtaW5zaWRlLW9uLW5lc3RlZC1jb250YWluZXItd2l0aC11bnJlc29sdmVkLWhlaWdo dC1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNp b25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtb24tbmVzdGVkLWNvbnRhaW5lci13aXRoLXVu cmVzb2x2ZWQtaGVpZ2h0LWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKy5wYXJlbnQgewor ICAgIGZvbnQ6IDE0cHggQWhlbSwgc2Fucy1zZXJpZjsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsKKyAgICB3aWR0aDogMzAwcHg7CisgICAgaGVpZ2h0OiAzMDBweDsKKyAgICBib3JkZXI6 IDFweCBzb2xpZCBibHVlOworfQorLmNvbnRhaW5lciB7CisgICAgYmFja2dyb3VuZC1jb2xvcjog eWVsbG93OworfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorCis8ZGl2IGNsYXNzPSJwYXJl bnQiPgorPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICBCdXQgaHVtYW5lIFN0YXJidWNrIHdh cyB0b28gbGF0ZS4gQXQgdGhlIGluc3RhbnQgb2YgdGhlIGRhcnQgYW4gdWxjZXJvdXMgamV0IHNo b3QgZnJvbSB0aGlzIGNydWVsIHdvdW5kLCBhbmQgZ29hZGVkIGJ5IGl0IGludG8gbW9yZSB0aGFu IHN1ZmZlcmFibGUgYW5ndWlzaCwKKyAgICB0aGUgd2hhbGUgbm93IHNwb3V0aW5nIHRoaWNrIGJs b29kLCB3aXRoIHN3aWZ0IGZ1cnkgYmxpbmRseSBkYXJ0ZWQgYXQgdGhlIGNyYWZ0LCBiZXNwYXR0 ZXJpbmcgdGhlbSBhbmQgdGhlaXIgZ2xvcnlpbmcgY3Jld3MgYWxsIG92ZXIgd2l0aCBzaG93ZXJz IG9mIGdvcmUsIGNhcHNpemluZworICAgIEZsYXNrJ3MgYm9hdCBhbmQgbWFycmluZyB0aGUgYm93 cy4KKzwvZGl2PgorPC9kaXY+CisKKzxwPlJlcXVpcmVzIEFoZW0gZm9udC4gU2luY2UgdGhlIG5l c3RlZCBjb250YWluZXIncyBoZWlnaHQgaXMgbm90IHJlc29sdmFibGUsIHdlIHNob3VsZG4ndCBh cHBseSB0aGUgY2lyY2xlIHNoYXBlLWluc2lkZSBvbiB0aGUgY29udGVudC48L3A+Cis8cD5CdWcg PGEgaHJlZj0iaHR0cDovL3dlYmtpdC5vcmcvYi8xMTMyNTUgIj4xMTMyNTU8L2E+OiBUaGUgcmFk aXVzIG9mIGEgY2lyY2xlIHNob3VsZCBiZSBjb21wdXRlZCBiYXNlZCBvbiB0aGUgc2hvcnRlciBh dmFpbGFibGUgZGltZW5zaW9uczwvcD4KKworPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtb24tbmVzdGVk LWNvbnRhaW5lci13aXRoLXVucmVzb2x2ZWQtaGVpZ2h0Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtb24tbmVz dGVkLWNvbnRhaW5lci13aXRoLXVucmVzb2x2ZWQtaGVpZ2h0Lmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1v bi1uZXN0ZWQtY29udGFpbmVyLXdpdGgtdW5yZXNvbHZlZC1oZWlnaHQuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwzMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0 eWxlPgorLnBhcmVudCB7CisgICAgZm9udDogMTRweCBBaGVtLCBzYW5zLXNlcmlmOworICAgIGJh Y2tncm91bmQtY29sb3I6IGdyZWVuOworICAgIHdpZHRoOiAzMDBweDsKKyAgICBoZWlnaHQ6IDMw MHB4OworICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsdWU7Cit9CisuY29udGFpbmVyIHsKKyAgICBi YWNrZ3JvdW5kLWNvbG9yOiB5ZWxsb3c7CisgICAgLXdlYmtpdC1zaGFwZS1pbnNpZGU6IGNpcmNs ZSg1MCUsIDUwJSwgNTAlKTsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKworPGRpdiBj bGFzcz0icGFyZW50Ij4KKyAgICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgICAgICBCdXQg aHVtYW5lIFN0YXJidWNrIHdhcyB0b28gbGF0ZS4gQXQgdGhlIGluc3RhbnQgb2YgdGhlIGRhcnQg YW4gdWxjZXJvdXMgamV0IHNob3QgZnJvbSB0aGlzIGNydWVsIHdvdW5kLCBhbmQgZ29hZGVkIGJ5 IGl0IGludG8gbW9yZSB0aGFuIHN1ZmZlcmFibGUgYW5ndWlzaCwKKyAgICAgICAgdGhlIHdoYWxl IG5vdyBzcG91dGluZyB0aGljayBibG9vZCwgd2l0aCBzd2lmdCBmdXJ5IGJsaW5kbHkgZGFydGVk IGF0IHRoZSBjcmFmdCwgYmVzcGF0dGVyaW5nIHRoZW0gYW5kIHRoZWlyIGdsb3J5aW5nIGNyZXdz IGFsbCBvdmVyIHdpdGggc2hvd2VycyBvZiBnb3JlLCBjYXBzaXppbmcKKyAgICAgICAgRmxhc2sn cyBib2F0IGFuZCBtYXJyaW5nIHRoZSBib3dzLgorICAgIDwvZGl2PgorPC9kaXY+CisKKzxwPlJl cXVpcmVzIEFoZW0gZm9udC4gU2luY2UgdGhlIG5lc3RlZCBjb250YWluZXIncyBoZWlnaHQgaXMg bm90IHJlc29sdmFibGUsIHdlIHNob3VsZG4ndCBhcHBseSB0aGUgY2lyY2xlIHNoYXBlLWluc2lk ZSBvbiB0aGUgY29udGVudC48L3A+Cis8cD5CdWcgPGEgaHJlZj0iaHR0cDovL3dlYmtpdC5vcmcv Yi8xMTMyNTUgIj4xMTMyNTU8L2E+OiBUaGUgcmFkaXVzIG9mIGEgY2lyY2xlIHNob3VsZCBiZSBj b21wdXRlZCBiYXNlZCBvbiB0aGUgc2hvcnRlciBhdmFpbGFibGUgZGltZW5zaW9uczwvcD4KKwor PC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2ODI5KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDMtMjUg IFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBFeGNs dXNpb25zXSBUaGUgcmFkaXVzIG9mIGEgY2lyY2xlIHNob3VsZCBiZSBjb21wdXRlZCBiYXNlZCBv biB0aGUgc2hvcnRlciBhdmFpbGFibGUgZGltZW5zaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMyNTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGRlY2lkZSB3aGF0IHNob3VsZCBiZSB0 aGUgcmFkaXVzIG9mIGEgY2lyY2xlLCB3ZSBzaG91bGQgY2hvb3NlIHRoZSBzbWFsbGVzdCBhdmFp bGFibGUgc3BhY2UuIEZvciBpbnN0YW5jZSB3aGVuIHRoZQorICAgICAgICB3aWR0aCBvciBoZWln aHQgaXMgbm90IHJlc29sdmFibGUgZm9yIHRoZSBjaXJjbGUgd2Ugc2hvdWxkIG5vdCBoYXZlIGEg cmFkaXVzIGZvciBpdC4gVGhpcyBjaGFuZ2UgbW9kaWZpZXMgdGhlIGJlaGF2aW9yIHRvCisgICAg ICAgIHVzZSB0aGUgc21hbGxlciBhdmFpbGFibGUgc3BhY2UsIHNvIHdlIHdvbid0IHJlbmRlciB1 bm5lY2Vzc2FyeSBjaXJjbGUgc2hhcGVzLgorCisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3No YXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtb24tbmVzdGVkLWNvbnRhaW5lci13aXRoLXVucmVzb2x2 ZWQtaGVpZ2h0LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXhjbHVzaW9u cy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLW9uLW5lc3RlZC1jb250YWluZXItd2l0aC11bnJl c29sdmVkLWhlaWdodC5odG1sOiBBZGRlZC4KKwogMjAxMy0wMy0yNSAgTWFyayBIYWhuZW5iZXJn ICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEpTT2JqZWN0OjplbnRlckRpY3Rp b25hcnlJbmRleGluZ01vZGUgZG9lc24ndCBoYXZlIGEgY2FzZSBmb3IgQUxMX0JMQU5LX0lOREVY SU5HX1RZUEVTCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDY4MjkpCisrKyBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMy0wMy0y NSAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbQ1NTIEV4 Y2x1c2lvbnNdIFRoZSByYWRpdXMgb2YgYSBjaXJjbGUgc2hvdWxkIGJlIGNvbXB1dGVkIGJhc2Vk IG9uIHRoZSBzaG9ydGVyIGF2YWlsYWJsZSBkaW1lbnNpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzI1NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gd2UgZGVjaWRlIHdoYXQgc2hvdWxkIGJl IHRoZSByYWRpdXMgb2YgYSBjaXJjbGUsIHdlIHNob3VsZCBjaG9vc2UgdGhlIHNtYWxsZXN0IGF2 YWlsYWJsZSBzcGFjZS4gRm9yIGluc3RhbmNlIHdoZW4gdGhlCisgICAgICAgIHdpZHRoIG9yIGhl aWdodCBpcyBub3QgcmVzb2x2YWJsZSBmb3IgdGhlIGNpcmNsZSB3ZSBzaG91bGQgbm90IGhhdmUg YSByYWRpdXMgZm9yIGl0LiBUaGlzIGNoYW5nZSBtb2RpZmllcyB0aGUgYmVoYXZpb3IgdG8KKyAg ICAgICAgdXNlIHRoZSBzbWFsbGVyIGF2YWlsYWJsZSBzcGFjZSwgc28gd2Ugd29uJ3QgcmVuZGVy IHVubmVjZXNzYXJ5IGNpcmNsZSBzaGFwZXMuCisKKyAgICAgICAgVGVzdDogZmFzdC9leGNsdXNp b25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtb24tbmVzdGVkLWNvbnRhaW5lci13aXRoLXVu cmVzb2x2ZWQtaGVpZ2h0Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9FeGNsdXNpb25TaGFw ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFeGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhjbHVzaW9u U2hhcGUpOgorCiAyMDEzLTAzLTI1ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBTdXBwb3J0IEdyYXBoaWNzTGF5ZXI6OnNldENvbnRl bnRzVG9Tb2xpZENvbG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9u U2hhcGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNp b25TaGFwZS5jcHAJKHJldmlzaW9uIDE0NjQ4MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9FeGNsdXNpb25TaGFwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNCw3ICsxMjQsNyBAQAog ICAgICAgICBjb25zdCBCYXNpY1NoYXBlQ2lyY2xlKiBjaXJjbGUgPSBzdGF0aWNfY2FzdDxjb25z dCBCYXNpY1NoYXBlQ2lyY2xlKj4oYmFzaWNTaGFwZSk7CiAgICAgICAgIGZsb2F0IGNlbnRlclgg PSBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNpcmNsZS0+Y2VudGVyWCgpLCBib3hXaWR0aCk7CiAgICAg ICAgIGZsb2F0IGNlbnRlclkgPSBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNpcmNsZS0+Y2VudGVyWSgp LCBib3hIZWlnaHQpOwotICAgICAgICBmbG9hdCByYWRpdXMgPSAgZmxvYXRWYWx1ZUZvckxlbmd0 aChjaXJjbGUtPnJhZGl1cygpLCBzdGQ6Om1heChib3hIZWlnaHQsIGJveFdpZHRoKSk7CisgICAg ICAgIGZsb2F0IHJhZGl1cyA9ICBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNpcmNsZS0+cmFkaXVzKCks IHN0ZDo6bWluKGJveEhlaWdodCwgYm94V2lkdGgpKTsKICAgICAgICAgRmxvYXRQb2ludCBsb2dp Y2FsQ2VudGVyID0gcGh5c2ljYWxQb2ludFRvTG9naWNhbChGbG9hdFBvaW50KGNlbnRlclgsIGNl bnRlclkpLCBsb2dpY2FsQm94SGVpZ2h0LCB3cml0aW5nTW9kZSk7CiAKICAgICAgICAgZXhjbHVz aW9uU2hhcGUgPSBjcmVhdGVFeGNsdXNpb25DaXJjbGUobG9naWNhbENlbnRlciwgcmFkaXVzKTsK