113168 2013-03-24 20:03:06 -0700 LayoutTests/fast/js/large-expressions.html crashes on Linux 2025-08-16 19:26:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Android Android UNCONFIRMED /LayoutTests/fast/js/large-expressions.html P1 Normal --- 107257 76379 0 manjian2006 webkit-unassigned allan.jensen barraclough benjamin cmarcelo dglazkov fpizlo ggaren Jackjimlobster147 ojan.autocc oliver realsat35 webkit.review.bot zan oldest_to_newest 862482 0 manjian2006 2013-03-24 20:03:06 -0700 LayoutTests/fast/js/large-expressions.html results in crash because buffer overflowed when JSC is running in non-main thread. This is because the logic which StackBounds::initialize sets stack base parameter has bug. No matter Linux's glibc or bionic(android's libc)'s implementation configures the newly-being-created thread's stack to having guarded pages in the stack bottom(or the begin of stack memory region).The following is the source from allocatestack.c in glibc: mem = mmap (NULL, size, prot, MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, -1, 0); ... char *guard = mem; ... if (mprotect (guard, guardsize, PROT_NONE) != 0) ... And the following is the source from pthread.c in bionic's implementation: static void *mkstack(size_t size, size_t guard_size) { void * stack; pthread_mutex_lock(&mmap_lock); stack = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE, -1, 0); if(stack == MAP_FAILED) { stack = NULL; goto done; } if(mprotect(stack, guard_size, PROT_NONE)){ munmap(stack, size); stack = NULL; goto done; } It's clear that the bottom of a pthread's stack is pieces of guarded pages.My patch will fix this bug. 862483 1 194781 manjian2006 2013-03-24 20:04:28 -0700 Created attachment 194781 patch 862485 2 webkit.review.bot 2013-03-24 20:06:20 -0700 Attachment 194781 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/wtf/StackBounds.cpp']" exit_code: 1 Source/WTF/wtf/StackBounds.cpp:153: guard_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/StackBounds.cpp:154: Missing space after , [whitespace/comma] [3] Source/WTF/wtf/StackBounds.cpp:159: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 3 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 862486 3 194781 eflews.bot 2013-03-24 20:07:14 -0700 Comment on attachment 194781 patch Attachment 194781 did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17135849 862487 4 194781 webkit-ews 2013-03-24 20:07:37 -0700 Comment on attachment 194781 patch Attachment 194781 did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17323040 862488 5 194781 webkit-ews 2013-03-24 20:09:14 -0700 Comment on attachment 194781 patch Attachment 194781 did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17147781 862489 6 194781 webkit.review.bot 2013-03-24 20:14:59 -0700 Comment on attachment 194781 patch Attachment 194781 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17202999 862492 7 194782 manjian2006 2013-03-24 20:18:08 -0700 Created attachment 194782 patch after style fixed 862495 8 194783 manjian2006 2013-03-24 20:33:09 -0700 Created attachment 194783 patch after compilation error fixed So embarrassing. 863206 9 194783 ggaren 2013-03-25 17:24:07 -0700 Comment on attachment 194783 patch after compilation error fixed View in context: https://bugs.webkit.org/attachment.cgi?id=194783&action=review > Source/WTF/wtf/StackBounds.cpp:149 > + // no matter in glibc or bionic(android's libc) implementation, Let's change this comment to: "glibc and bionic (Android's libc) use the guard size API to set a guard page at the stack base." > Source/WTF/wtf/StackBounds.cpp:154 > + int rc = pthread_attr_getguardsize(&sattr, &guardSize); pthread_attr_getguardsize is standard POSIX, so I think we should do this on all platforms. > Source/WTF/wtf/StackBounds.cpp:155 > + stackBase = reinterpret_cast<void *>(reinterpret_cast<unsigned long>(stackBase) + guardSize); "void*" instead of "void *", please. Also, to cast a pointer to integer, use uintptr_t. Also, you need to round guardSize up to the system page size. 863266 10 194976 manjian2006 2013-03-25 18:58:15 -0700 Created attachment 194976 patch I insist that the OS(LINUX) macro should remains in the source.At lease freebsd's pthread implementation has not been checked. 867005 11 manjian2006 2013-04-01 02:50:51 -0700 WHEN ARE YOU GOING TO REVIEW? (In reply to comment #9) > (From update of attachment 194783 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194783&action=review > > > Source/WTF/wtf/StackBounds.cpp:149 > > + // no matter in glibc or bionic(android's libc) implementation, > > Let's change this comment to: "glibc and bionic (Android's libc) use the guard size API to set a guard page at the stack base." > > > Source/WTF/wtf/StackBounds.cpp:154 > > + int rc = pthread_attr_getguardsize(&sattr, &guardSize); > > pthread_attr_getguardsize is standard POSIX, so I think we should do this on all platforms. > > > Source/WTF/wtf/StackBounds.cpp:155 > > + stackBase = reinterpret_cast<void *>(reinterpret_cast<unsigned long>(stackBase) + guardSize); > > "void*" instead of "void *", please. > > Also, to cast a pointer to integer, use uintptr_t. > > Also, you need to round guardSize up to the system page size. 869144 12 allan.jensen 2013-04-04 06:39:33 -0700 (In reply to comment #10) > Created an attachment (id=194976) [details] > patch > > I insist that the OS(LINUX) macro should remains in the source.At lease freebsd's pthread implementation has not been checked. Let's check it then, and make sure this only needs to be fixed once. 869145 13 194976 allan.jensen 2013-04-04 06:49:12 -0700 Comment on attachment 194976 patch View in context: https://bugs.webkit.org/attachment.cgi?id=194976&action=review > Source/WTF/wtf/StackBounds.cpp:152 > + // FIXME: Not sure if the libc of other unix is using the same implementation as linux does.If anyone does,please remove the OS(LINUX) macro. > +#if OS(LINUX) pthread_attr_getguardsize is a generic POSIX call, please enable it for all UNIX. Whether this code is correct or not only depends on whether the stack grows up or down, but we seem to only handle stacks growing dow here. > Source/WTF/wtf/StackBounds.cpp:161 > + stackBase = reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(stackBase) + guardSize); > + stackSize -= guardSize; GuardSize does not affect stackSize. This hack is only necessary because of how m_origin is set lower down. Remove it and just set m_bound as stackBase + guardSize. 870418 14 196771 manjian2006 2013-04-06 23:34:29 -0700 Created attachment 196771 patch after remove platform macro & move the hack to m_bound 870419 15 196772 manjian2006 2013-04-06 23:42:01 -0700 Created attachment 196772 patch after remove platform macro & move the hack to m_bound 870532 16 allan.jensen 2013-04-07 13:33:31 -0700 (In reply to comment #15) > Created an attachment (id=196772) [details] > patch after remove platform macro & move the hack to m_bound Thanks. I may however have been a bit hasty in saying we don't need an ifdef for Linux.There seems to be a difference in opinion on whether guardsize is included or not in stacksize. http://sourceware.org/ml/libc-help/2008-07/msg00076.html https://bugzilla.redhat.com/show_bug.cgi?id=435337 http://www.sourceware.org/ml/libc-alpha/2008-05/msg00086.html More worryingly it may get fixed in new versions of glibc http://sourceware.org/bugzilla/show_bug.cgi?id=6973 http://sourceware.org/bugzilla/show_bug.cgi?id=11787 None of this matters to setting m_bound which should be correct now, but we may end up setting m_origin too short. I suggest ifdeffing for GLIBC and in that case subtract guardsize from stacksize like you did the previous patch. m_origin can then be redefined as stackbase + stacksize + guardsize. Btw feel free to typecast with static_cast<char*>, it is shorter than the double reinterpret case. 870637 17 196832 manjian2006 2013-04-07 23:45:18 -0700 Created attachment 196832 patch add glibc & android test 870671 18 196832 allan.jensen 2013-04-08 01:44:28 -0700 Comment on attachment 196832 patch add glibc & android test View in context: https://bugs.webkit.org/attachment.cgi?id=196832&action=review Looks good. I however only meant we should subtract guardSize from stackSize for glibc and android. We should still support guardsize for the other cases. It just needs to be added to both m_bound and m_origin. > Source/WTF/wtf/StackBounds.cpp:153 > +#ifdef __GLIBC__ > +#if __GLIBC__ == 2 && __GLIBC_MINOR__ <= 15 Combine into one line. > Source/WTF/wtf/StackBounds.cpp:160 > +#if USE(GUARD_SIZE) I think we should try make the patch general and support guardsize everywhere. It just only needs to be subtracted from stack_size on glibc (and android). > Source/WTF/wtf/StackBounds.cpp:168 > + stackBase = reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(stackBase) + guardSize); use static_cast<char*> so you only need one cast. 871363 19 196980 manjian2006 2013-04-08 18:53:54 -0700 Created attachment 196980 patch 872676 20 196980 allan.jensen 2013-04-10 02:35:57 -0700 Comment on attachment 196980 patch View in context: https://bugs.webkit.org/attachment.cgi?id=196980&action=review > Source/WTF/wtf/StackBounds.cpp:158 > m_bound = stackBase; > m_origin = static_cast<char*>(stackBase) + stackSize; m_bound = stackBase + guardSize m_origin = stackBase + guardSize + stackSize > Source/WTF/wtf/StackBounds.cpp:165 > + m_bound = reinterpret_cast<char*>(m_bound) + guardSize; > + stackSize -= guardSize; m_origin = static_cast<char*>(m_origin) - guardSize; 873422 21 197463 manjian2006 2013-04-10 18:55:54 -0700 Created attachment 197463 patch 873638 22 197463 allan.jensen 2013-04-11 02:20:31 -0700 Comment on attachment 197463 patch That should work to the best of my knowledge. Not sure about GLIBC_MINOR <= 15 though. We might have to maintain that if it doesn't get fixed. 873639 23 manjian2006 2013-04-11 02:23:23 -0700 (In reply to comment #22) > (From update of attachment 197463 [details]) > That should work to the best of my knowledge. Not sure about GLIBC_MINOR <= 15 though. We might have to maintain that if it doesn't get fixed. That number is the version number of my glibc,running in an Ubuntu 12.10 machine. 873642 24 allan.jensen 2013-04-11 02:29:35 -0700 (In reply to comment #23) > (In reply to comment #22) > > (From update of attachment 197463 [details] [details]) > > That should work to the best of my knowledge. Not sure about GLIBC_MINOR <= 15 though. We might have to maintain that if it doesn't get fixed. > > That number is the version number of my glibc,running in an Ubuntu 12.10 machine. Okay, then I would suggest removing the version check before landing. We shouldn't introduce a version check until we know glibc has closed the related bug. http://sourceware.org/bugzilla/show_bug.cgi?id=6973 873779 25 allan.jensen 2013-04-11 06:26:13 -0700 Btw, I seems WinCairo, Qt and GTK+ all have this test disabled. I am going to make it block the respective bugs. It could be this fixes it. 873780 26 allan.jensen 2013-04-11 06:27:28 -0700 (In reply to comment #25) > Btw, I seems WinCairo, Qt and GTK+ all have this test disabled. I am going to make it block the respective bugs. It could be this fixes it. Well, obviously not WinCairo. 873841 27 zan 2013-04-11 08:52:52 -0700 Is checking for the Android libc still relevant given the Chromium port has now forked into Blink? Does any of the remaining ports actually support building with the Android libc? 873848 28 allan.jensen 2013-04-11 08:57:54 -0700 (In reply to comment #27) > Is checking for the Android libc still relevant given the Chromium port has now forked into Blink? Does any of the remaining ports actually support building with the Android libc? Yes, Qt does. 875815 29 zan 2013-04-15 07:48:57 -0700 The r+ed patch still requires a changelog. I'm mainly interested how, if at all, this patch would affect a couple of old stack-related problems on the GTK port as well as the current set of regressions on the GTK 64-bit release builder after r147892. http://trac.webkit.org/changeset/147892 875824 30 197463 allan.jensen 2013-04-15 08:04:21 -0700 Comment on attachment 197463 patch Missing ChangeLog 879563 31 manjian2006 2013-04-22 19:22:09 -0700 I will catch up later,in the middle of something. (In reply to comment #30) > (From update of attachment 197463 [details]) > Missing ChangeLog 1668109 33 ews-feeder 2020-07-01 17:20:35 -0700 realsat35@gmail.com does not have committer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 403335 from commit queue. 194781 2013-03-24 20:04:28 -0700 2013-03-24 20:18:08 -0700 patch patch.patch text/plain 1096 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5hY2U5NzA0IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDUsNyArMTQ1LDE4IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIC8vIEZJWE1FOiB0aGlzIGZ1bmN0aW9uIGlzIG5vbi1wb3J0YWJsZTsgb3RoZXIg UE9TSVggc3lzdGVtcyBtYXkgaGF2ZSBkaWZmZXJlbnQgbnAgYWx0ZXJuYXRpdmVzCiAgICAgcHRo cmVhZF9nZXRhdHRyX25wKHRocmVhZCwgJnNhdHRyKTsKICNlbmRpZgorI2lmIE9TKExJTlVYKQor ICAgIC8vIG5vIG1hdHRlciBpbiBnbGliYyBvciBiaW9uaWMoYW5kcm9pZCdzIGxpYmMpIGltcGxl bWVudGF0aW9uLAorICAgIC8vIFRoZSBzdGFjayBiYXNlIGlzIGZpcnN0IGJlZ2luIHdpdGggYSBy ZWdpb24gb2YgZ3VhcmRlZCBtZW1vcnkKKyAgICAvLyB3aGljaCB3aWxsIHJlc3VsdCBpbiBjcmFz aCB3aGVuIGFjY2VzcyhyL3cpLHNvIHdlIGhhdmUgdG8gbW92ZSB0aGUgc3RhY2sgYmFzZQorICAg IC8vIGZvcndhcmQgdG8gYXZvaWQgc3VjaCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJk X3NpemU7CisgICAgcHRocmVhZF9hdHRyX2dldGd1YXJkc2l6ZSgmc2F0dHIsJmd1YXJkX3NpemUp OworICAgIHN0YWNrQmFzZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCAqPihyZWludGVycHJldF9j YXN0PHVuc2lnbmVkIGxvbmc+KHN0YWNrQmFzZSkgKyBndWFyZF9zaXplKTsKKyAgICBzdGFja1Np emUgLT0gZ3VhcmRfc2l6ZTsKKyNlbHNlCiAgICAgaW50IHJjID0gcHRocmVhZF9hdHRyX2dldHN0 YWNrKCZzYXR0ciwgJnN0YWNrQmFzZSwgJnN0YWNrU2l6ZSk7CisjZW5kaWYgLy9PUyhMSU5VWCkK ICAgICAodm9pZClyYzsgLy8gRklYTUU6IERlYWwgd2l0aCBlcnJvciBjb2RlIHNvbWVob3c/IFNl ZW1zIGZhdGFsLgogICAgIEFTU0VSVChzdGFja0Jhc2UpOwogICAgIHB0aHJlYWRfYXR0cl9kZXN0 cm95KCZzYXR0cik7Cg== 194782 2013-03-24 20:18:08 -0700 2013-03-24 20:33:09 -0700 patch after style fixed patch.patch text/plain 1094 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi43MmRkNWU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDUsNyArMTQ1LDE4IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIC8vIEZJWE1FOiB0aGlzIGZ1bmN0aW9uIGlzIG5vbi1wb3J0YWJsZTsgb3RoZXIg UE9TSVggc3lzdGVtcyBtYXkgaGF2ZSBkaWZmZXJlbnQgbnAgYWx0ZXJuYXRpdmVzCiAgICAgcHRo cmVhZF9nZXRhdHRyX25wKHRocmVhZCwgJnNhdHRyKTsKICNlbmRpZgorI2lmIE9TKExJTlVYKQor ICAgIC8vIG5vIG1hdHRlciBpbiBnbGliYyBvciBiaW9uaWMoYW5kcm9pZCdzIGxpYmMpIGltcGxl bWVudGF0aW9uLAorICAgIC8vIFRoZSBzdGFjayBiYXNlIGlzIGZpcnN0IGJlZ2luIHdpdGggYSBy ZWdpb24gb2YgZ3VhcmRlZCBtZW1vcnkKKyAgICAvLyB3aGljaCB3aWxsIHJlc3VsdCBpbiBjcmFz aCB3aGVuIGFjY2VzcyhyL3cpLHNvIHdlIGhhdmUgdG8gbW92ZSB0aGUgc3RhY2sgYmFzZQorICAg IC8vIGZvcndhcmQgdG8gYXZvaWQgc3VjaCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJk U2l6ZTsKKyAgICBwdGhyZWFkX2F0dHJfZ2V0Z3VhcmRzaXplKCZzYXR0ciwgJmd1YXJkU2l6ZSk7 CisgICAgc3RhY2tCYXNlID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkICo+KHJlaW50ZXJwcmV0X2Nh c3Q8dW5zaWduZWQgbG9uZz4oc3RhY2tCYXNlKSArIGd1YXJkU2l6ZSk7CisgICAgc3RhY2tTaXpl IC09IGd1YXJkU2l6ZTsKKyNlbHNlCiAgICAgaW50IHJjID0gcHRocmVhZF9hdHRyX2dldHN0YWNr KCZzYXR0ciwgJnN0YWNrQmFzZSwgJnN0YWNrU2l6ZSk7CisjZW5kaWYgLy8gT1MoTElOVVgpCiAg ICAgKHZvaWQpcmM7IC8vIEZJWE1FOiBEZWFsIHdpdGggZXJyb3IgY29kZSBzb21laG93PyBTZWVt cyBmYXRhbC4KICAgICBBU1NFUlQoc3RhY2tCYXNlKTsKICAgICBwdGhyZWFkX2F0dHJfZGVzdHJv eSgmc2F0dHIpOwo= 194783 2013-03-24 20:33:09 -0700 2013-04-06 23:34:29 -0700 patch after compilation error fixed patch.patch text/plain 1103 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5mYmEzMmJkIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDUsNyArMTQ1LDE4IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIC8vIEZJWE1FOiB0aGlzIGZ1bmN0aW9uIGlzIG5vbi1wb3J0YWJsZTsgb3RoZXIg UE9TSVggc3lzdGVtcyBtYXkgaGF2ZSBkaWZmZXJlbnQgbnAgYWx0ZXJuYXRpdmVzCiAgICAgcHRo cmVhZF9nZXRhdHRyX25wKHRocmVhZCwgJnNhdHRyKTsKICNlbmRpZgorI2lmIE9TKExJTlVYKQor ICAgIC8vIG5vIG1hdHRlciBpbiBnbGliYyBvciBiaW9uaWMoYW5kcm9pZCdzIGxpYmMpIGltcGxl bWVudGF0aW9uLAorICAgIC8vIFRoZSBzdGFjayBiYXNlIGlzIGZpcnN0IGJlZ2luIHdpdGggYSBy ZWdpb24gb2YgZ3VhcmRlZCBtZW1vcnkKKyAgICAvLyB3aGljaCB3aWxsIHJlc3VsdCBpbiBjcmFz aCB3aGVuIGFjY2VzcyhyL3cpLHNvIHdlIGhhdmUgdG8gbW92ZSB0aGUgc3RhY2sgYmFzZQorICAg IC8vIGZvcndhcmQgdG8gYXZvaWQgc3VjaCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJk U2l6ZTsKKyAgICBpbnQgcmMgPSBwdGhyZWFkX2F0dHJfZ2V0Z3VhcmRzaXplKCZzYXR0ciwgJmd1 YXJkU2l6ZSk7CisgICAgc3RhY2tCYXNlID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkICo+KHJlaW50 ZXJwcmV0X2Nhc3Q8dW5zaWduZWQgbG9uZz4oc3RhY2tCYXNlKSArIGd1YXJkU2l6ZSk7CisgICAg c3RhY2tTaXplIC09IGd1YXJkU2l6ZTsKKyNlbHNlCiAgICAgaW50IHJjID0gcHRocmVhZF9hdHRy X2dldHN0YWNrKCZzYXR0ciwgJnN0YWNrQmFzZSwgJnN0YWNrU2l6ZSk7CisjZW5kaWYgLy8gT1Mo TElOVVgpCiAgICAgKHZvaWQpcmM7IC8vIEZJWE1FOiBEZWFsIHdpdGggZXJyb3IgY29kZSBzb21l aG93PyBTZWVtcyBmYXRhbC4KICAgICBBU1NFUlQoc3RhY2tCYXNlKTsKICAgICBwdGhyZWFkX2F0 dHJfZGVzdHJveSgmc2F0dHIpOwo= 194976 2013-03-25 18:58:15 -0700 2013-04-06 23:34:29 -0700 patch patch.patch text/plain 1223 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi45NTUyNzRkIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsNiArMTQ4LDE4IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisgICAg Ly8gRklYTUU6IE5vdCBzdXJlIGlmIHRoZSBsaWJjIG9mIG90aGVyIHVuaXggaXMgdXNpbmcgdGhl IHNhbWUgaW1wbGVtZW50YXRpb24gYXMgbGludXggZG9lcy5JZiBhbnlvbmUgZG9lcyxwbGVhc2Ug cmVtb3ZlIHRoZSBPUyhMSU5VWCkgbWFjcm8uCisjaWYgT1MoTElOVVgpCisgICAgLy8gZ2xpYmMg YW5kIGJpb25pYyAoQW5kcm9pZCdzIGxpYmMpIHVzZSB0aGUgZ3VhcmQgc2l6ZSBBUEkgdG8gc2V0 IGEgZ3VhcmQgcGFnZSBhdCB0aGUgc3RhY2sgYmFzZS4KKyAgICAvLyBUaGUgc3RhY2sgYmFzZSBm aXJzdCBiZWdpbnMgd2l0aCBhIHJlZ2lvbiBvZiBndWFyZGVkIG1lbW9yeSwKKyAgICAvLyB3aGlj aCB3aWxsIHJlc3VsdCBpbiBjcmFzaCB3aGVuIGFjY2VzcyhyL3cpLAorICAgIC8vIHNvIHdlIGhh dmUgdG8gbW92ZSB0aGUgc3RhY2sgYmFzZSBmb3J3YXJkIHRvIGF2b2lkIHN1Y2ggYSBjb3JydXB0 aW9uLgorICAgIHNpemVfdCBndWFyZFNpemUgPSAwOworICAgIHJjID0gcHRocmVhZF9hdHRyX2dl dGd1YXJkc2l6ZSgmc2F0dHIsICZndWFyZFNpemUpOworICAgICh2b2lkKXJjOworICAgIHN0YWNr QmFzZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90 PihzdGFja0Jhc2UpICsgZ3VhcmRTaXplKTsKKyAgICBzdGFja1NpemUgLT0gZ3VhcmRTaXplOwor I2VuZGlmIC8vIE9TKExJTlVYKQogICAgIHB0aHJlYWRfYXR0cl9kZXN0cm95KCZzYXR0cik7CiAg ICAgbV9ib3VuZCA9IHN0YWNrQmFzZTsKICAgICBtX29yaWdpbiA9IHN0YXRpY19jYXN0PGNoYXIq PihzdGFja0Jhc2UpICsgc3RhY2tTaXplOwo= 196771 2013-04-06 23:34:29 -0700 2013-04-06 23:40:09 -0700 patch after remove platform macro & move the hack to m_bound patch1.patch text/plain 964 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5iZGEwMTcxIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsOCArMTQ4LDE3IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisKKyAg ICAvLyBnbGliYyBhbmQgYmlvbmljIChBbmRyb2lkJ3MgbGliYykgdXNlIHRoZSBndWFyZCBzaXpl IEFQSSB0byBzZXQgYSBndWFyZCBwYWdlIGF0IHRoZSBzdGFjayBiYXNlLgorICAgIC8vIFRoZSBz dGFjayBiYXNlIGZpcnN0IGJlZ2lucyB3aXRoIGEgcmVnaW9uIG9mIGd1YXJkZWQgbWVtb3J5LAor ICAgIC8vIHdoaWNoIHdpbGwgcmVzdWx0IGluIGNyYXNoIHdoZW4gYWNjZXNzKHIvdyksCisgICAg Ly8gc28gd2UgaGF2ZSB0byBtb3ZlIHRoZSBzdGFjayBiYXNlIGZvcndhcmQgdG8gYXZvaWQgc3Vj aCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJkU2l6ZSA9IDA7CisgICAgcmMgPSBwdGhy ZWFkX2F0dHJfZ2V0Z3VhcmRzaXplKCZzYXR0ciwgJmd1YXJkU2l6ZSk7CisgICAgKHZvaWQpcmM7 CisKICAgICBwdGhyZWFkX2F0dHJfZGVzdHJveSgmc2F0dHIpOwotICAgIG1fYm91bmQgPSBzdGFj a0Jhc2U7CisgICAgbV9ib3VuZCA9IHN0YWNrQmFzZSArIGd1YXJkU2l6ZTsKICAgICBtX29yaWdp biA9IHN0YXRpY19jYXN0PGNoYXIqPihzdGFja0Jhc2UpICsgc3RhY2tTaXplOwogfQogCg== 196772 2013-04-06 23:42:01 -0700 2013-04-07 23:45:18 -0700 patch after remove platform macro & move the hack to m_bound patch1.patch text/plain 1019 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi43Yjc3YjMzIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsOCArMTQ4LDE3IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisKKyAg ICAvLyBnbGliYyBhbmQgYmlvbmljIChBbmRyb2lkJ3MgbGliYykgdXNlIHRoZSBndWFyZCBzaXpl IEFQSSB0byBzZXQgYSBndWFyZCBwYWdlIGF0IHRoZSBzdGFjayBiYXNlLgorICAgIC8vIFRoZSBz dGFjayBiYXNlIGZpcnN0IGJlZ2lucyB3aXRoIGEgcmVnaW9uIG9mIGd1YXJkZWQgbWVtb3J5LAor ICAgIC8vIHdoaWNoIHdpbGwgcmVzdWx0IGluIGNyYXNoIHdoZW4gYWNjZXNzKHIvdyksCisgICAg Ly8gc28gd2UgaGF2ZSB0byBtb3ZlIHRoZSBzdGFjayBiYXNlIGZvcndhcmQgdG8gYXZvaWQgc3Vj aCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJkU2l6ZSA9IDA7CisgICAgcmMgPSBwdGhy ZWFkX2F0dHJfZ2V0Z3VhcmRzaXplKCZzYXR0ciwgJmd1YXJkU2l6ZSk7CisgICAgKHZvaWQpcmM7 CisKICAgICBwdGhyZWFkX2F0dHJfZGVzdHJveSgmc2F0dHIpOwotICAgIG1fYm91bmQgPSBzdGFj a0Jhc2U7CisgICAgbV9ib3VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KChyZWludGVycHJl dF9jYXN0PGludHB0cl90PihzdGFja0Jhc2UpICsgZ3VhcmRTaXplKSk7CiAgICAgbV9vcmlnaW4g PSBzdGF0aWNfY2FzdDxjaGFyKj4oc3RhY2tCYXNlKSArIHN0YWNrU2l6ZTsKIH0KIAo= 196832 2013-04-07 23:45:18 -0700 2013-04-08 18:53:54 -0700 patch add glibc & android test patch.patch2 text/plain 1408 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5hM2NmYjRmIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsNiArMTQ4LDI3IEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisjaWYg ZGVmaW5lZChfX0dMSUJDX18pIHx8IGRlZmluZWQoX19BTkRST0lEX18pCisjaWZkZWYgX19HTElC Q19fCisjaWYgX19HTElCQ19fID09IDIgJiYgX19HTElCQ19NSU5PUl9fIDw9IDE1CisjZGVmaW5l IFdURl9VU0VfR1VBUkRfU0laRSAxCisjZW5kaWYgLy8gX19HTElCQ19fIHZlcnNpb24gdGVzdAor I2Vsc2UgLy8gX19HTElCQ19fCisvLyB0aGF0IG1lYW5zIGFuZHJvaWQgCisjZGVmaW5lIFdURl9V U0VfR1VBUkRfU0laRSAxCisjZW5kaWYgLy8gIHRlc3QgaWYgdXNlIGd1YXJkIHNpemUKKyNpZiBV U0UoR1VBUkRfU0laRSkKKyAgICAvLyBnbGliYyBhbmQgYmlvbmljIChBbmRyb2lkJ3MgbGliYykg dXNlIHRoZSBndWFyZCBzaXplIEFQSSB0byBzZXQgYSBndWFyZCBwYWdlIGF0IHRoZSBzdGFjayBi YXNlLgorICAgIC8vIFRoZSBzdGFjayBiYXNlIGZpcnN0IGJlZ2lucyB3aXRoIGEgcmVnaW9uIG9m IGd1YXJkZWQgbWVtb3J5LAorICAgIC8vIHdoaWNoIHdpbGwgcmVzdWx0IGluIGNyYXNoIHdoZW4g YWNjZXNzKHIvdyksCisgICAgLy8gc28gd2UgaGF2ZSB0byBtb3ZlIHRoZSBzdGFjayBiYXNlIGZv cndhcmQgdG8gYXZvaWQgc3VjaCBhIGNvcnJ1cHRpb24uCisgICAgc2l6ZV90IGd1YXJkU2l6ZSA9 IDA7CisgICAgcmMgPSBwdGhyZWFkX2F0dHJfZ2V0Z3VhcmRzaXplKCZzYXR0ciwgJmd1YXJkU2l6 ZSk7CisgICAgKHZvaWQpcmM7CisgICAgc3RhY2tCYXNlID0gcmVpbnRlcnByZXRfY2FzdDx2b2lk Kj4ocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHN0YWNrQmFzZSkgKyBndWFyZFNpemUpOwor ICAgIHN0YWNrU2l6ZSAtPSBndWFyZFNpemU7CisjZW5kaWYgLy8gVVNFKEdVQVJEX1NJWkUpCisj ZW5kaWYgLy8gX19HTElCQ19fIG9yIF9fQU5EUk9JRF9fCiAgICAgcHRocmVhZF9hdHRyX2Rlc3Ry b3koJnNhdHRyKTsKICAgICBtX2JvdW5kID0gc3RhY2tCYXNlOwogICAgIG1fb3JpZ2luID0gc3Rh dGljX2Nhc3Q8Y2hhcio+KHN0YWNrQmFzZSkgKyBzdGFja1NpemU7Cg== 196980 2013-04-08 18:53:54 -0700 2013-04-10 02:35:56 -0700 patch patch.patch3 text/plain 1161 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5jZmY0Yzc5IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsOSArMTQ4LDIyIEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisKKyAg ICBzaXplX3QgZ3VhcmRTaXplID0gMDsKKyAgICByYyA9IHB0aHJlYWRfYXR0cl9nZXRndWFyZHNp emUoJnNhdHRyLCAmZ3VhcmRTaXplKTsKKyAgICAodm9pZClyYzsKKwogICAgIHB0aHJlYWRfYXR0 cl9kZXN0cm95KCZzYXR0cik7CiAgICAgbV9ib3VuZCA9IHN0YWNrQmFzZTsKICAgICBtX29yaWdp biA9IHN0YXRpY19jYXN0PGNoYXIqPihzdGFja0Jhc2UpICsgc3RhY2tTaXplOworI2lmIChkZWZp bmVkKF9fR0xJQkNfXykgJiYgX19HTElCQ19fIDw9IDIgJiYgX19HTElCQ19NSU5PUl9fIDw9IDE1 KSB8fCBkZWZpbmVkKF9fQU5EUk9JRF9fKQorICAgIC8vIGdsaWJjIGFuZCBiaW9uaWMgKEFuZHJv aWQncyBsaWJjKSB1c2UgdGhlIGd1YXJkIHNpemUgQVBJIHRvIHNldCBhIGd1YXJkIHBhZ2UgYXQg dGhlIHN0YWNrIGJhc2UuCisgICAgLy8gVGhlIHN0YWNrIGJhc2UgZmlyc3QgYmVnaW5zIHdpdGgg YSByZWdpb24gb2YgZ3VhcmRlZCBtZW1vcnksCisgICAgLy8gd2hpY2ggd2lsbCByZXN1bHQgaW4g Y3Jhc2ggd2hlbiBhY2Nlc3Moci93KSwKKyAgICAvLyBzbyB3ZSBoYXZlIHRvIG1vdmUgdGhlIHN0 YWNrIGJhc2UgZm9yd2FyZCB0byBhdm9pZCBzdWNoIGEgY29ycnVwdGlvbi4KKyAgICBtX2JvdW5k ID0gcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV9ib3VuZCkgKyBndWFyZFNpemU7CisgICAgc3Rh Y2tTaXplIC09IGd1YXJkU2l6ZTsKKyNlbmRpZiAvLyBfX0dMSUJDXyBvciBfX0FORFJPSURfXwog fQogCiAjZWxpZiBPUyhXSU5DRSkK 197463 2013-04-10 18:55:54 -0700 2013-04-15 08:04:21 -0700 patch patch.patch4 text/plain 1258 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYv d3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBhMjcyY2UzLi5kZGU5YTIwIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tC b3VuZHMuY3BwCkBAIC0xNDgsOSArMTQ4LDIxIEBAIHZvaWQgU3RhY2tCb3VuZHM6OmluaXRpYWxp emUoKQogICAgIGludCByYyA9IHB0aHJlYWRfYXR0cl9nZXRzdGFjaygmc2F0dHIsICZzdGFja0Jh c2UsICZzdGFja1NpemUpOwogICAgICh2b2lkKXJjOyAvLyBGSVhNRTogRGVhbCB3aXRoIGVycm9y IGNvZGUgc29tZWhvdz8gU2VlbXMgZmF0YWwuCiAgICAgQVNTRVJUKHN0YWNrQmFzZSk7CisKKyAg ICBzaXplX3QgZ3VhcmRTaXplID0gMDsKKyAgICByYyA9IHB0aHJlYWRfYXR0cl9nZXRndWFyZHNp emUoJnNhdHRyLCAmZ3VhcmRTaXplKTsKKyAgICAodm9pZClyYzsKKwogICAgIHB0aHJlYWRfYXR0 cl9kZXN0cm95KCZzYXR0cik7Ci0gICAgbV9ib3VuZCA9IHN0YWNrQmFzZTsKLSAgICBtX29yaWdp biA9IHN0YXRpY19jYXN0PGNoYXIqPihzdGFja0Jhc2UpICsgc3RhY2tTaXplOworICAgIG1fYm91 bmQgPSBzdGF0aWNfY2FzdDxjaGFyKj4oc3RhY2tCYXNlKSArIGd1YXJkU2l6ZTsKKyAgICBtX29y aWdpbiA9IHN0YXRpY19jYXN0PGNoYXIqPihzdGFja0Jhc2UpICsgZ3VhcmRTaXplICsgc3RhY2tT aXplOworI2lmIChkZWZpbmVkKF9fR0xJQkNfXykgJiYgX19HTElCQ19fIDw9IDIgJiYgX19HTElC Q19NSU5PUl9fIDw9IDE1KSB8fCBkZWZpbmVkKF9fQU5EUk9JRF9fKQorICAgIC8vIGdsaWJjIGFu ZCBiaW9uaWMgKEFuZHJvaWQncyBsaWJjKSB1c2UgdGhlIGd1YXJkIHNpemUgQVBJIHRvIHNldCBh IGd1YXJkIHBhZ2UgYXQgdGhlIHN0YWNrIGJhc2UuCisgICAgLy8gVGhlIHN0YWNrIGJhc2UgZmly c3QgYmVnaW5zIHdpdGggYSByZWdpb24gb2YgZ3VhcmRlZCBtZW1vcnksCisgICAgLy8gd2hpY2gg d2lsbCByZXN1bHQgaW4gY3Jhc2ggd2hlbiBhY2Nlc3Moci93KSwKKyAgICAvLyBzbyB3ZSBoYXZl IHRvIG1vdmUgdGhlIHN0YWNrIGJhc2UgZm9yd2FyZCB0byBhdm9pZCBzdWNoIGEgY29ycnVwdGlv bi4KKyAgICBtX29yaWdpbiA9IHN0YXRpY19jYXN0PGNoYXIqPihtX29yaWdpbikgLSBndWFyZFNp emU7CisjZW5kaWYgLy8gX19HTElCQ18gb3IgX19BTkRST0lEX18KIH0KIAogI2VsaWYgT1MoV0lO Q0UpCg==