113147 2013-03-23 22:44:44 -0700 Fix the build with GCC 4.8 2013-04-05 04:08:15 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110211 0 net147 abecsi abecsi allan.jensen andersca ap benjamin cmarcelo hausmann jdiggs kai.koehne ojan.autocc rakuco webkit.review.bot zan oldest_to_newest 862317 0 net147 2013-03-23 22:44:44 -0700 Compiling WebKit with GCC 4.8 generates lots of warnings due to COMPILE_ASSERT defining an unused typedef. Example: generated/InspectorTypeBuilder.h: In member function 'WebCore::TypeBuilder::Network::CachedResource::Builder<STATE>::operator WTF::RefPtr<WebCore::TypeBuilder::Network::CachedResource>&()': ..\WTF/wtf/Assertions.h:328:47: warning: typedef 'dummyresult_is_not_ready' locally defined but not used [-Wunused-local-typedefs] #define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1] ^ generated/InspectorTypeBuilder.h:2932:13: note: in expansion of macro 'COMPILE_ASSERT' COMPILE_ASSERT(STATE == AllFieldsSet, result_is_not_ready); 863624 1 allan.jensen 2013-03-26 06:43:02 -0700 Compile_assert should probably be implemented using static_assert when available. 863632 2 kai.koehne 2013-03-26 06:57:21 -0700 We could also just diable the warning: #pragma GCC diagnostic ignored "-Wunused-local-typedefs" (Note that you can't disable it 'locally' with pragma push, pragma pop though cause it's part of a #define). 863651 3 allan.jensen 2013-03-26 07:25:02 -0700 (In reply to comment #1) > Compile_assert should probably be implemented using static_assert when available. Uploaded that to bug 113308 863845 4 ap 2013-03-26 11:02:30 -0700 Does this bug still track anything useful, given that bug 113308 will fix the symptom? 863848 5 allan.jensen 2013-03-26 11:09:31 -0700 (In reply to comment #4) > Does this bug still track anything useful, given that bug 113308 will fix the symptom? C++11 support may not be enabled in GCC. In fact it is default off. 864368 6 zan 2013-03-27 03:42:45 -0700 (In reply to comment #5) > (In reply to comment #4) > > Does this bug still track anything useful, given that bug 113308 will fix the symptom? > > C++11 support may not be enabled in GCC. In fact it is default off. The GTK port only enforces the C++11 standard when building the WebKit2 framework. This means that when building WTF, WebCore etc. static_assert is still not available and thus the same warnings are still being spat out. Is this true for the Qt port as well? 864376 7 abecsi 2013-03-27 03:55:05 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Does this bug still track anything useful, given that bug 113308 will fix the symptom? > > > > C++11 support may not be enabled in GCC. In fact it is default off. > > The GTK port only enforces the C++11 standard when building the WebKit2 framework. This means that when building WTF, WebCore etc. static_assert is still not available and thus the same warnings are still being spat out. > > Is this true for the Qt port as well? As far as I know Qt does not enforce C++11 on any framework yet. 864378 8 allan.jensen 2013-03-27 03:59:56 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Does this bug still track anything useful, given that bug 113308 will fix the symptom? > > > > C++11 support may not be enabled in GCC. In fact it is default off. > > The GTK port only enforces the C++11 standard when building the WebKit2 framework. This means that when building WTF, WebCore etc. static_assert is still not available and thus the same warnings are still being spat out. > > Is this true for the Qt port as well? Let me put it this way: WebCore doesn't build with C++11 enabled, see bug 111579. 864385 9 zan 2013-03-27 04:10:12 -0700 Right, understood. The warnings that the dummy COMPILE_ASSERT implementation is throwing out can be suppressed using the __attribute__((unused)) directive. It seems to work with GCC 4.7 and 4.8 and with Clang 3.2, though there are other compilers that people use that don't necessary support the directive. https://svn.boost.org/trac/boost/ticket/7242 866755 10 195890 net147 2013-03-31 01:17:12 -0700 Created attachment 195890 Patch 866830 11 webkit.review.bot 2013-03-31 16:04:21 -0700 Attachment 195890 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.h']" exit_code: 1 Source/WTF/wtf/Assertions.h:354: Extra space before [ [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 868633 12 rakuco 2013-04-03 05:05:47 -0700 There are also warnings generated by Source/WTF/wtf/dtoa/utils.h:294:22: error: typedef ‘VerifySizesAreEqual’ locally defined but not used [-Werror=unused-local-typedefs] typedef char VerifySizesAreEqual[sizeof(Dest) == sizeof(Source) ? 1 : -1]; Source/WTF/wtf/HashTable.h:1302:84: warning: typedef ‘HashTableType’ locally defined but not used [-Wunused-local-typedefs] typedef HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits> HashTableType; ^ Source/WTF/wtf/HashTable.h:1303:97: warning: typedef ‘const_iterator’ locally defined but not used [-Wunused-local-typedefs] typedef HashTableConstIterator<Key, Value, Extractor, HashFunctions, Traits, KeyTraits> const_iterator; ^ Doesn't it make more sense to add a macro to Compiler.h that's defined when we have either gcc or clang and use it in all those declarations? 868715 13 andersca 2013-04-03 07:54:16 -0700 This doesn't seem like a helpful warning, let's just turn it off. 868724 14 rakuco 2013-04-03 08:03:02 -0700 (In reply to comment #13) > This doesn't seem like a helpful warning, let's just turn it off. Hmm, do you mean leaving it up to each build system to detect the compiler and its version and pass -Wno-unused-local-typedefs accordingly? 869070 15 allan.jensen 2013-04-04 02:20:32 -0700 (In reply to comment #14) > (In reply to comment #13) > > This doesn't seem like a helpful warning, let's just turn it off. > > Hmm, do you mean leaving it up to each build system to detect the compiler and its version and pass -Wno-unused-local-typedefs accordingly? I think it would be better to disable it in source code than to try to rely on specific compiler flags. 869113 16 rakuco 2013-04-04 04:20:42 -0700 (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > This doesn't seem like a helpful warning, let's just turn it off. > > > > Hmm, do you mean leaving it up to each build system to detect the compiler and its version and pass -Wno-unused-local-typedefs accordingly? > > I think it would be better to disable it in source code than to try to rely on specific compiler flags. I agree, and I think this was the direction we were moving towards, but Anders' comment sounded like he had a different opinion. 869180 17 196483 abecsi 2013-04-04 08:59:04 -0700 Created attachment 196483 Patch 869192 18 196483 allan.jensen 2013-04-04 09:32:15 -0700 Comment on attachment 196483 Patch LGTM 869196 19 196483 abecsi 2013-04-04 09:39:05 -0700 Comment on attachment 196483 Patch Clearing flags on attachment: 196483 Committed r147640: <http://trac.webkit.org/changeset/147640> 869197 20 abecsi 2013-04-04 09:39:12 -0700 All reviewed patches have been landed. Closing bug. 195890 2013-03-31 01:17:12 -0700 2013-04-04 08:58:52 -0700 Patch bug-113147-20130331192804.patch text/plain 1366 net147 U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM3NjZhYzkxMTkyOTY1NTBjMGVkNDE3 Y2MwZTcyN2UzNWVmM2MwN2MuLmRjZjAzODE3ZDA5OTA3Njg0NjI1ZDBlZmQ5Mjc3ZDU3OTUzYzU5 MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDMtMzEgIEpvbmF0aGFuIExpdSAgPG5ldDE0 N0BnbWFpbC5jb20+CisKKyAgICAgICAgU2lsZW5jZSBDT01QSUxFX0FTU0VSVCB1bnVzZWQgdHlw ZWRlZiB3YXJuaW5nIHdpdGggR0NDIDQuNyBhbmQgbGF0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzE0NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKwogMjAxMy0w My0zMCAgVG9tIFNlcGV6ICA8dHNlcGV6QGNocm9taXVtLm9yZz4KIAogICAgICAgICBWaWV3LXNv dXJjZSBpZnJhbWVzIGFyZSBkYW5nZXJvdXMgKGFuZCBub3QgdmVyeSB1c2VmdWwpLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0 aW9ucy5oCmluZGV4IDdhMGM1OTNkYzU2Yjk0MTQ1M2E4NTkwOWZhMjE5ZGFkOTMxMmVmN2UuLjg5 Yzc0ZDY2OGU5NDY2ZDIxMGFiNDVmNDIwMjc5NTFhZWY3NDc4MDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgK QEAgLTM0OSw2ICszNDksOSBAQCB3aGlsZSAoMCkKICNkZWZpbmUgQ09NUElMRV9BU1NFUlQoZXhw LCBuYW1lKSBfU3RhdGljX2Fzc2VydCgoZXhwKSwgI25hbWUpCiAjZWxpZiBDT01QSUxFUl9TVVBQ T1JUUyhDWFhfU1RBVElDX0FTU0VSVCkKICNkZWZpbmUgQ09NUElMRV9BU1NFUlQoZXhwLCBuYW1l KSBzdGF0aWNfYXNzZXJ0KChleHApLCAjbmFtZSkKKyNlbGlmIENPTVBJTEVSKEdDQykgJiYgR0ND X1ZFUlNJT05fQVRfTEVBU1QoNCwgNywgMCkKKy8qIEdDQyA0LjcgYW5kIGxhdGVyIG1heSBnZW5l cmF0ZSBhbiB1bnVzZWQgdHlwZWRlZiB3YXJuaW5nLiAqLworI2RlZmluZSBDT01QSUxFX0FTU0VS VChleHAsIG5hbWUpIHR5cGVkZWYgaW50IGR1bW15IyNuYW1lIFsoZXhwKSA/IDEgOiAtMV0gX19h dHRyaWJ1dGVfXygodW51c2VkKSkKICNlbHNlCiAjZGVmaW5lIENPTVBJTEVfQVNTRVJUKGV4cCwg bmFtZSkgdHlwZWRlZiBpbnQgZHVtbXkjI25hbWUgWyhleHApID8gMSA6IC0xXQogI2VuZGlmCg== 196483 2013-04-04 08:59:04 -0700 2013-04-04 09:39:05 -0700 Patch bug-113147-20130404175538.patch text/plain 3290 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NGU0NTIzZTcwYTVlMTQ5Njc0YTY3NWUwM2FlMWRlZTBkMjczODRjLi4zMmViOTlmMDAzMWJiNTE5 NGIwMmZjZTI3NTUxMGY3ZDgyZDdkY2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0wNC0wNCAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQGRpZ2lh LmNvbT4KKworICAgICAgICBGaXggdGhlIGJ1aWxkIHdpdGggR0NDIDQuOAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMTQ3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGl6ZSBKU09iamVjdCog ZXhjZXB0aW9uIHRvIHN1cHByZXNzIHdhcm5pbmdzIHRoYXQgbWFrZQorICAgICAgICB0aGUgYnVp bGQgZmFpbCBiZWNhdXNlIG9mIC1XZXJyb3I9bWF5YmUtdW5pbml0aWFsaXplZC4KKworICAgICAg ICAqIHJ1bnRpbWUvRXhlY3V0YWJsZS5jcHA6CisgICAgICAgIChKU0M6OkZ1bmN0aW9uRXhlY3V0 YWJsZTo6Y29tcGlsZUZvckNhbGxJbnRlcm5hbCk6CisgICAgICAgIChKU0M6OkZ1bmN0aW9uRXhl Y3V0YWJsZTo6Y29tcGlsZUZvckNvbnN0cnVjdEludGVybmFsKToKKwogMjAxMy0wNC0wMiAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9ieV9w bmFtZSBjYW4gYmVjb21lIGNvbmZ1c2VkIHdoZW4gaXRlcmF0aW5nIG92ZXIgb2JqZWN0cyB3aXRo IHN0YXRpYyBwcm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDEwNTY4ZWZkMWY5YjkyN2IxMzA3MDhjMjFkMDg2ZDc4 Y2VhMWRmNzkuLmEwMmRmZDdlYmEzZTUyNzAzMjE3OGU4MDQwMWY1MzViZTU2MzFlZDYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDQtMDQgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBk aWdpYS5jb20+CisKKyAgICAgICAgRml4IHRoZSBidWlsZCB3aXRoIEdDQyA0LjgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzE0NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgZGlhZ25vc3Rp YyB3YXJuaW5nIC1XdW51c2VkLWxvY2FsLXR5cGVkZWZzIGZvciBHQ0MgNC44CisgICAgICAgIHNp bmNlIGR1bW15IHR5cGVkZWZzIGFyZSBjb21tb25seSB1c2VkIGluIHRoZSBjb2RlYmFzZS4KKwor ICAgICAgICAqIHd0Zi9Db21waWxlci5oOgorCiAyMDEzLTA0LTAzICBQcmF0aWsgU29sYW5raSAg PHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgSEFWRV9NQURWX0ZSRUVfUkVV U0Ugb24gaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVj dXRhYmxlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3Bw CmluZGV4IDhiNThiNjJhYTNlMzlhMzQ3ZmFlOTI5NjFhZjY5NDg0ZGU3OTVhMDcuLjA1N2JiNDNj Njc3N2JjNGI2M2IyM2MwY2FiZjMyZDEwNmNhMDI0M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCkBAIC01MjMsNyArNTIzLDcgQEAgSlNPYmplY3Qq IEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y29tcGlsZUZvckNhbGxJbnRlcm5hbChFeGVjU3RhdGUqIGV4 ZWMsIEpTU2NvcGUqIHMKICAgICBVTlVTRURfUEFSQU0oYnl0ZWNvZGVJbmRleCk7CiAjZW5kaWYK ICAgICBBU1NFUlQoKGppdFR5cGUgPT0gSklUQ29kZTo6Ym90dG9tVGllckpJVCgpKSA9PSAhbV9j b2RlQmxvY2tGb3JDYWxsKTsKLSAgICBKU09iamVjdCogZXhjZXB0aW9uOworICAgIEpTT2JqZWN0 KiBleGNlcHRpb24gPSAwOwogICAgIE93blB0cjxGdW5jdGlvbkNvZGVCbG9jaz4gbmV3Q29kZUJs b2NrID0gcHJvZHVjZUNvZGVCbG9ja0ZvcihzY29wZSwgQ29kZUZvckNhbGwsIGV4Y2VwdGlvbik7 CiAgICAgaWYgKCFuZXdDb2RlQmxvY2spCiAgICAgICAgIHJldHVybiBleGNlcHRpb247CkBAIC01 NTksNyArNTU5LDcgQEAgSlNPYmplY3QqIEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y29tcGlsZUZvckNv bnN0cnVjdEludGVybmFsKEV4ZWNTdGF0ZSogZXhlYywgSlNTY28KICNlbmRpZgogICAgIAogICAg IEFTU0VSVCgoaml0VHlwZSA9PSBKSVRDb2RlOjpib3R0b21UaWVySklUKCkpID09ICFtX2NvZGVC bG9ja0ZvckNvbnN0cnVjdCk7Ci0gICAgSlNPYmplY3QqIGV4Y2VwdGlvbjsKKyAgICBKU09iamVj dCogZXhjZXB0aW9uID0gMDsKICAgICBPd25QdHI8RnVuY3Rpb25Db2RlQmxvY2s+IG5ld0NvZGVC bG9jayA9IHByb2R1Y2VDb2RlQmxvY2tGb3Ioc2NvcGUsIENvZGVGb3JDb25zdHJ1Y3QsIGV4Y2Vw dGlvbik7CiAgICAgaWYgKCFuZXdDb2RlQmxvY2spCiAgICAgICAgIHJldHVybiBleGNlcHRpb247 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oIGIvU291cmNlL1dURi93dGYv Q29tcGlsZXIuaAppbmRleCBlMTE3NDdmYjY1MTlmZTU5NTYwYjQ3YWFiYmU1NDgwZTk4YTlmMTU1 Li5iODg2ZjM3MTUxMjkyODUxZjMxMTMwNmI5MGZhNWI5YmMyODgwZTA2IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgK QEAgLTEyMyw2ICsxMjMsOSBAQAogCiAvKiBTcGVjaWZpYyBjb21waWxlciBmZWF0dXJlcyAqLwog I2lmIENPTVBJTEVSKEdDQykgJiYgIUNPTVBJTEVSKENMQU5HKQorI2lmIEdDQ19WRVJTSU9OX0FU X0xFQVNUKDQsIDgsIDApCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XdW51c2Vk LWxvY2FsLXR5cGVkZWZzIgorI2VuZGlmCiAjaWYgZGVmaW5lZChfX1NURENfVkVSU0lPTl9fKSAm JiBfX1NURENfVkVSU0lPTl9fID49IDIwMTExMkwKIC8qIEMxMSBzdXBwb3J0ICovCiAjZGVmaW5l IFdURl9DT01QSUxFUl9TVVBQT1JUU19DX1NUQVRJQ19BU1NFUlQgMQo=