112767 2013-03-19 18:22:45 -0700 Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output> 2013-03-20 17:12:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112085 1 falken falken esprehn+autocc mifenton morrita ojan.autocc tkent webkit.review.bot oldest_to_newest 858949 0 falken 2013-03-19 18:22:45 -0700 The calls were added in http://trac.webkit.org/changeset/86526. disabled() never returns true for these elements, so we don't have to consider disabled() in supportsFocus(), and can just use HTMLElement::supportsFocus. Since HTMLMeterElement and HTMLProgressElement no longer inherit from HTMLFormControlElement, we don't need to override supportsFocus() at all. 858953 1 193963 falken 2013-03-19 18:30:56 -0700 Created attachment 193963 Patch 859828 2 193963 tkent 2013-03-20 15:54:03 -0700 Comment on attachment 193963 Patch ok 859874 3 193963 webkit.review.bot 2013-03-20 17:12:00 -0700 Comment on attachment 193963 Patch Clearing flags on attachment: 193963 Committed r146417: <http://trac.webkit.org/changeset/146417> 859875 4 webkit.review.bot 2013-03-20 17:12:03 -0700 All reviewed patches have been landed. Closing bug. 193963 2013-03-19 18:30:56 -0700 2013-03-20 17:11:59 -0700 Patch bug-112767-20130320102646.patch text/plain 4837 falken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VkYTg5MDU5MGZjMzFk YzUwNGFlZjY3MGQyZjczOWViYzc1ZmM3ZC4uYWY0NTMwMGQ2NmFhMDJlYzRkZDM5Zjc5MjI3ZDUw YTc1MTdiZmJhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAzLTE5ICBNYXR0 IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdW5u ZWNlc3NhcnkgY2FsbHMgdG8gTm9kZTo6ZGlzYWJsZWQgZm9yIDxtZXRlcj4sIDxwcm9ncmVzcz4s IGFuZCA8b3V0cHV0PgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEyNzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBpcyBwYXJ0IG9mIGEgcmVmYWN0b3JpbmcgdG8gbW92ZSBOb2RlOjpkaXNhYmxl ZCB0byBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpkaXNhYmxlZC4KKyAgICAgICAgVGhlIGNvbmNl cHQgb2YgZGlzYWJsZWQgaXMganVzdCBhIGZvcm0gY29udHJvbCBlbGVtZW50IG9uZS4KKworICAg ICAgICBIVE1MTWV0ZXJFbGVtZW50LCBIVE1MT3V0cHV0RWxlbWVudCwgYW5kIEhUTUxQcm9ncmVz c0VsZW1lbnQgbmV2ZXIKKyAgICAgICAgaGF2ZSBkaXNhYmxlZCgpIHJldHVybiB0cnVlLCBzbyB3 ZSBjYW4gcmVtb3ZlIHRoZSBjYWxsLiBJbiBhZGRpdGlvbiwKKyAgICAgICAgSFRNTE1ldGVyRWxl bWVudCBhbmQgSFRNTFByb2dyZXNzRWxlbWVudCBubyBsb25nZXIgaW5oZXJpdCBmcm9tCisgICAg ICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQsIHNvIHdlIGRvbid0IG5lZWQgdG8gb3ZlcnJpZGUg c3VwcG9ydHNGb2N1cy4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBiZWhhdmlv ciBjaGFuZ2UuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZXRlckVsZW1lbnQuY3BwOgorICAgICAg ICAqIGh0bWwvSFRNTE1ldGVyRWxlbWVudC5oOgorICAgICAgICAqIGh0bWwvSFRNTE91dHB1dEVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE91dHB1dEVsZW1lbnQ6OnN1cHBvcnRz Rm9jdXMpOgorICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6CisgICAgICAg ICogaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50Lmg6CisKIDIwMTMtMDMtMTkgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBXcm9u ZyBndWFyZCBVU0UoR0xYKSBpbiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWV0ZXJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1ldGVyRWxlbWVudC5jcHAKaW5kZXggNjVlYzFiMjg0NjgwMDY3ZGIwODE2 ZDY4MGRjMTIzYzIxNDYzZGFlNi4uYzRlZjcyMDdkNmNkZGNjNDQ1NGU5ZjM1M2M0YzgwYjk2Mzg4 OThjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWV0ZXJFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZXRlckVsZW1lbnQuY3BwCkBAIC03MSwx MSArNzEsNiBAQCBib29sIEhUTUxNZXRlckVsZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVy ZXIoY29uc3QgTm9kZVJlbmRlcmluZ0NvbnRleHQmIGNoaQogICAgIHJldHVybiBjaGlsZENvbnRl eHQuaXNPblVwcGVyRW5jYXBzdWxhdGlvbkJvdW5kYXJ5KCkgJiYgSFRNTEVsZW1lbnQ6OmNoaWxk U2hvdWxkQ3JlYXRlUmVuZGVyZXIoY2hpbGRDb250ZXh0KTsKIH0KIAotYm9vbCBIVE1MTWV0ZXJF bGVtZW50OjpzdXBwb3J0c0ZvY3VzKCkgY29uc3QKLXsKLSAgICByZXR1cm4gSFRNTEVsZW1lbnQ6 OnN1cHBvcnRzRm9jdXMoKSAmJiAhZGlzYWJsZWQoKTsKLX0KLQogdm9pZCBIVE1MTWV0ZXJFbGVt ZW50OjpwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9t aWNTdHJpbmcmIHZhbHVlKQogewogICAgIGlmIChuYW1lID09IHZhbHVlQXR0ciB8fCBuYW1lID09 IG1pbkF0dHIgfHwgbmFtZSA9PSBtYXhBdHRyIHx8IG5hbWUgPT0gbG93QXR0ciB8fCBuYW1lID09 IGhpZ2hBdHRyIHx8IG5hbWUgPT0gb3B0aW11bUF0dHIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZXRlckVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l dGVyRWxlbWVudC5oCmluZGV4IDY5NGY5MDBjYzM0OTU4ZDQyZjJjNmVmYTZmZTRmNjMwYzE4ZWU1 NzIuLmFjMjFjYTI4ODc0OTk5OWY1MDhjOGY3ZmY0MTI4ZTk4ZTJkNTExMzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1ldGVyRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1ldGVyRWxlbWVudC5oCkBAIC03MSw4ICs3MSw2IEBAIHByaXZhdGU6CiAK ICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydExhYmVscygpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJu IHRydWU7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0ZvY3VzKCkgY29uc3Q7Ci0KICAg ICB2aXJ0dWFsIGJvb2wgcmVjYWxjV2lsbFZhbGlkYXRlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KICAgICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEq LCBSZW5kZXJTdHlsZSopOwogICAgIHZpcnR1YWwgYm9vbCBjaGlsZFNob3VsZENyZWF0ZVJlbmRl cmVyKGNvbnN0IE5vZGVSZW5kZXJpbmdDb250ZXh0JikgY29uc3QgT1ZFUlJJREU7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPdXRwdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwCmluZGV4IDFhYzExMDk1MGQ5MWJhMDFj NWYwZWFkZDMxODJiNjM1NjJjNDNmNzguLmY5MDA1MWRmZWUxMTRhNzU4MjE4ZmZkY2ZkOTBlMDU3 ODUyMzViN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwCkBA IC01OSw3ICs1OSw3IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgSFRNTE91dHB1dEVsZW1lbnQ6OmZv cm1Db250cm9sVHlwZSgpIGNvbnN0CiAKIGJvb2wgSFRNTE91dHB1dEVsZW1lbnQ6OnN1cHBvcnRz Rm9jdXMoKSBjb25zdAogewotICAgIHJldHVybiBIVE1MRWxlbWVudDo6c3VwcG9ydHNGb2N1cygp ICYmICFkaXNhYmxlZCgpOworICAgIHJldHVybiBIVE1MRWxlbWVudDo6c3VwcG9ydHNGb2N1cygp OwogfQogCiB2b2lkIEhUTUxPdXRwdXRFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFs aWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAKaW5kZXggZDAxZWFkNTk3OGExNTQ0ZjE2 OGIwZDhhMzAwM2UwZTQ3ZDI4YTQ2Ny4uMzQwOWE4ZTIyZDZkOGI4ODhiYjUwZThiZmZiNTZhYWY3 YWQzODFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3Bw CkBAIC04MiwxMSArODIsNiBAQCBSZW5kZXJQcm9ncmVzcyogSFRNTFByb2dyZXNzRWxlbWVudDo6 cmVuZGVyUHJvZ3Jlc3MoKSBjb25zdAogICAgIHJldHVybiBzdGF0aWNfY2FzdDxSZW5kZXJQcm9n cmVzcyo+KHJlbmRlck9iamVjdCk7CiB9CiAKLWJvb2wgSFRNTFByb2dyZXNzRWxlbWVudDo6c3Vw cG9ydHNGb2N1cygpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIEhUTUxFbGVtZW50OjpzdXBwb3J0c0Zv Y3VzKCkgJiYgIWRpc2FibGVkKCk7Ci19Ci0KIHZvaWQgSFRNTFByb2dyZXNzRWxlbWVudDo6cGFy c2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyaW5n JiB2YWx1ZSkKIHsKICAgICBpZiAobmFtZSA9PSB2YWx1ZUF0dHIpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCmluZGV4IGNlNjMwOWNiYTgxODg5NjFkZWVjYmNiYmYy OGI2OWE3MDJlNDViOTYuLjEyOTBhMDFhYzFkZmY4N2JjNGZkMjVhMjYyYTEyYjRkMjM0MWZiNTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCkBAIC01Niw4ICs1 Niw2IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydExhYmVscygpIGNvbnN0 IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0Zv Y3VzKCkgY29uc3Q7Ci0KICAgICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIo UmVuZGVyQXJlbmEqLCBSZW5kZXJTdHlsZSopOwogICAgIHZpcnR1YWwgYm9vbCBjaGlsZFNob3Vs ZENyZWF0ZVJlbmRlcmVyKGNvbnN0IE5vZGVSZW5kZXJpbmdDb250ZXh0JikgY29uc3QgT1ZFUlJJ REU7CiAgICAgUmVuZGVyUHJvZ3Jlc3MqIHJlbmRlclByb2dyZXNzKCkgY29uc3Q7Cg==