112665 2013-03-18 23:45:57 -0700 Implement and32 on MIPS platform 2013-03-20 07:08:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 112599 1 ossy webkit-unassigned fpizlo fu galpeter gergely kilvadyb oliver ossy rgabor webkit.review.bot zherczeg oldest_to_newest 857981 0 ossy 2013-03-18 23:45:57 -0700 +++ This bug was initially created as a clone of Bug #112663 +++ http://trac.webkit.org/changeset/146164 broke the MIPS build because of missing add32 implementation: /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compileAdd(JSC::DFG::Node*)': /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3136: error: no matching function for call to 'JSC::DFG::JITCompiler::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Address, JSC::DFG::GPRReg&)' /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:270: note: candidates are: void JSC::MacroAssemblerMIPS::and32(JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID) /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:275: note: void JSC::MacroAssemblerMIPS::and32(JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID) /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:280: note: void JSC::MacroAssemblerMIPS::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::TrustedImm32, JSC::MIPSRegisters::RegisterID) /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:296: note: void JSC::MacroAssemblerMIPS::and32(JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::TrustedImm32, JSC::MIPSRegisters::RegisterID, JSC::MIPSRegisters::RegisterID) make[3]: *** [.obj/release-shared/dfg/DFGSpeculativeJIT.o] Error 1 857991 1 galpeter 2013-03-19 00:01:32 -0700 Please rename the bug. The 'and32' is missing not the 'add32'. 858044 2 193755 galpeter 2013-03-19 01:37:38 -0700 Created attachment 193755 speculative fix A MIPS guru should check this patch just to be on safe side. 858049 3 gergely 2013-03-19 01:42:10 -0700 Thanks for the patch, Balázs will check it first thing. 858122 4 kilvadyb 2013-03-19 03:43:43 -0700 (In reply to comment #2) > Created an attachment (id=193755) [details] > speculative fix The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. 859338 5 galpeter 2013-03-20 06:31:12 -0700 (In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=193755) [details] [details] > > speculative fix > > The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. Ok, in the meantime I think we should commit this in, just to get the bot a little greener. 859365 6 kilvadyb 2013-03-20 07:02:24 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Created an attachment (id=193755) [details] [details] [details] > > > speculative fix > > > > The patch seems to be OK. But I must work on an other issue around operationToString (likely new bug report/patch) to be able to run all the tests. > > Ok, in the meantime I think we should commit this in, just to get the bot a little greener. Agree. 859368 7 193755 zherczeg 2013-03-20 07:04:16 -0700 Comment on attachment 193755 speculative fix róme 859370 8 193755 webkit.review.bot 2013-03-20 07:08:35 -0700 Comment on attachment 193755 speculative fix Clearing flags on attachment: 193755 Committed r146339: <http://trac.webkit.org/changeset/146339> 859371 9 webkit.review.bot 2013-03-20 07:08:39 -0700 All reviewed patches have been landed. Closing bug. 193755 2013-03-19 01:37:38 -0700 2013-03-20 07:08:35 -0700 speculative fix mips_and32.patch text/plain 1256 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhkMzNmZTguLmI4YTQ5YjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTE5ICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgSW1wbGVtZW50IGFuZDMyIG9uIE1J UFMgcGxhdGZvcm0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMjY2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNy b0Fzc2VtYmxlck1JUFM6OmFuZDMyKTogQWRkZWQgbWlzc2luZyBtZXRob2QuCisgICAgICAgIChN YWNyb0Fzc2VtYmxlck1JUFMpOgorCiAyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgREZHIFRvU3RyaW5nIGdlbmVyaWMgY2FzZXMgc2hvdWxkIHdv cmsgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCA0ZjE0OTYwLi5lMThkODZjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKQEAg LTI2Nyw2ICsyNjcsMTIgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5zdyhkYXRhVGVt cFJlZ2lzdGVyLCBhZGRyVGVtcFJlZ2lzdGVyLCA0KTsKICAgICB9CiAKKyAgICB2b2lkIGFuZDMy KEFkZHJlc3Mgc3JjLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBsb2FkMzIoc3Jj LCBkYXRhVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgYW5kMzIoZGF0YVRlbXBSZWdpc3RlciwgZGVz dCk7CisgICAgfQorCiAgICAgdm9pZCBhbmQzMihSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBk ZXN0KQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIuYW5kSW5zbihkZXN0LCBkZXN0LCBzcmMp Owo=