112663 2013-03-18 23:43:11 -0700 Implement and32 on ARMv7 and ARM traditional platforms 2013-03-19 02:35:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 108645 112599 1 ossy webkit-unassigned fpizlo galpeter oliver ossy rgabor webkit.review.bot zherczeg oldest_to_newest 857978 0 ossy 2013-03-18 23:43:11 -0700 http://trac.webkit.org/changeset/146164 broke the ARM traditional build because of missing add32 implementation: /home/webkitbuildbot/slaves/armQt5Release-buildonly/buildslave/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compileAdd(JSC::DFG::Node*)': /home/webkitbuildbot/slaves/armQt5Release-buildonly/buildslave/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3136:88: error: no matching function for call to 'JSC::DFG::JITCompiler::and32(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Address, JSC::DFG::GPRReg&)' 857990 1 galpeter 2013-03-19 00:01:27 -0700 Please rename the bug. The 'and32' is missing not the 'add32'. 858001 2 ossy 2013-03-19 00:26:12 -0700 (In reply to comment #1) > Please rename the bug. The 'and32' is missing not the 'add32'. Done. 858069 3 193765 rgabor 2013-03-19 02:08:38 -0700 Created attachment 193765 proposed fix 858074 4 193765 zherczeg 2013-03-19 02:13:10 -0700 Comment on attachment 193765 proposed fix r=me 858085 5 193765 webkit.review.bot 2013-03-19 02:35:17 -0700 Comment on attachment 193765 proposed fix Clearing flags on attachment: 193765 Committed r146195: <http://trac.webkit.org/changeset/146195> 858086 6 webkit.review.bot 2013-03-19 02:35:20 -0700 All reviewed patches have been landed. Closing bug. 193765 2013-03-19 02:08:38 -0700 2013-03-19 02:35:17 -0700 proposed fix arm_fix.patch text/plain 1993 rgabor ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhkMzNmZTguLjcyNTZlZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTE5ICBHYWJvciBSYXBjc2Fu eWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBJbXBsZW1lbnQgYW5kMzIgb24gQVJN djcgYW5kIEFSTSB0cmFkaXRpb25hbCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjY2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjphbmQzMik6IEFkZCBtaXNzaW5nIG1l dGhvZC4KKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyQVJNKToKKyAgICAgICAgKiBhc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk12Ny5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTXY3 OjphbmQzMik6IEFkZCBtaXNzaW5nIG1ldGhvZC4KKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyQVJN djcpOgorCiAyMDEzLTAzLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgREZHIFRvU3RyaW5nIGdlbmVyaWMgY2FzZXMgc2hvdWxkIHdvcmsgY29ycmVjdGx5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN LmgKaW5kZXggZGI1ZjRhNS4uZDRiMDM3MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtMTUyLDYgKzE1MiwxMiBAQCBw dWJsaWM6CiAgICAgICAgICAgICBtX2Fzc2VtYmxlci5iaXRBbmRzKGRlc3QsIHNyYywgdyk7CiAg ICAgfQogCisgICAgdm9pZCBhbmQzMihBZGRyZXNzIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQorICAg IHsKKyAgICAgICAgbG9hZDMyKHNyYywgQVJNUmVnaXN0ZXJzOjpTMSk7CisgICAgICAgIGFuZDMy KEFSTVJlZ2lzdGVyczo6UzEsIGRlc3QpOworICAgIH0KKwogICAgIHZvaWQgbHNoaWZ0MzIoUmVn aXN0ZXJJRCBzaGlmdEFtb3VudCwgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgbHNo aWZ0MzIoZGVzdCwgc2hpZnRBbW91bnQsIGRlc3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaAppbmRleCA4ZDdhM2E2Li5i M2RlMzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNdjcuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNdjcuaApAQCAtMjYzLDYgKzI2MywxMiBAQCBwdWJsaWM6CiAgICAgICAg IGFuZDMyKGltbSwgZGVzdCwgZGVzdCk7CiAgICAgfQogCisgICAgdm9pZCBhbmQzMihBZGRyZXNz IHNyYywgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgbG9hZDMyKHNyYywgZGF0YVRl bXBSZWdpc3Rlcik7CisgICAgICAgIGFuZDMyKGRhdGFUZW1wUmVnaXN0ZXIsIGRlc3QpOworICAg IH0KKwogICAgIHZvaWQgY291bnRMZWFkaW5nWmVyb3MzMihSZWdpc3RlcklEIHNyYywgUmVnaXN0 ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIuY2x6KGRlc3QsIHNyYyk7Cg==