112242 2013-03-13 03:37:55 -0700 [BlackBerry] GraphicsContext3D: implement ImageExtractor::extractImage() 2013-03-14 08:27:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia dino mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 854174 0 berto 2013-03-13 03:37:55 -0700 In r136282 GraphicsContext3D::getImageData() was refactored in a new class called ImageExtractor. When the code for the BlackBerry port was upstreamed in r144465 it still contained the old GraphicsContext3D::getImageData() method. 854177 1 192895 berto 2013-03-13 03:40:08 -0700 Created attachment 192895 Patch 854260 2 192895 rwlbuis 2013-03-13 06:33:05 -0700 Comment on attachment 192895 Patch LGTM. 855208 3 192895 webkit.review.bot 2013-03-14 08:27:38 -0700 Comment on attachment 192895 Patch Clearing flags on attachment: 192895 Committed r145814: <http://trac.webkit.org/changeset/145814> 855209 4 webkit.review.bot 2013-03-14 08:27:42 -0700 All reviewed patches have been landed. Closing bug. 192895 2013-03-13 03:40:08 -0700 2013-03-14 08:27:38 -0700 Patch 112242.diff text/plain 3925 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZDBlOTlmLi4xMzUyMTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDMtMTMgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBHcmFwaGljc0NvbnRleHQzRDogaW1wbGVtZW50IEltYWdlRXh0 cmFjdG9yOjpleHRyYWN0SW1hZ2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyMjQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSW4gcjEzNjI4MiBHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRh KCkgd2FzIHJlZmFjdG9yZWQgaW4gYQorICAgICAgICBuZXcgY2xhc3MgY2FsbGVkIEltYWdlRXh0 cmFjdG9yLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW1wbGVtZW50cyB0aGUgbmVjZXNzYXJ5IGNo YW5nZXMgZm9yIHRoZSBCbGFja0JlcnJ5CisgICAgICAgIHBvcnQsIHdoaWNoIGlzIHN0aWxsIHVz aW5nIHRoZSBvbGQgQVBJLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0M0QuaDoKKyAgICAgICAgKEltYWdlRXh0cmFjdG9yKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6SW1hZ2VFeHRyYWN0b3I6On5JbWFn ZUV4dHJhY3Rvcik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKToKKwogMjAxMy0wMy0x MyAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFBhc3MgdGhlIFhT U0F1ZGl0b3IncyByZXBvcnQgVVJMIHRvIHRoZSBYU1NBdWRpdG9yRGVsZWdhdGUgb24gdGhlIG1h aW4gdGhyZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmgKaW5kZXggZTEyMjhlZi4uZWEzYTcyOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCkBAIC05 MzUsNiArOTM1LDggQEAgcHVibGljOgogICAgICAgICBPd25BcnJheVB0cjx1aW50OF90PiBtX2Zv cm1hbGl6ZWRSR0JBOERhdGE7CiAjZWxpZiBQTEFURk9STShRVCkKICAgICAgICAgUUltYWdlIG1f cXRJbWFnZTsKKyNlbGlmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgIFZlY3Rvcjx1bnNp Z25lZD4gbV9pbWFnZURhdGE7CiAjZW5kaWYKICAgICAgICAgSW1hZ2UqIG1faW1hZ2U7CiAgICAg ICAgIEltYWdlSHRtbERvbVNvdXJjZSBtX2ltYWdlSHRtbERvbVNvdXJjZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250 ZXh0M0RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAppbmRleCBlNzBmYzhkLi41 ZWI3YmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVy cnkuY3BwCkBAIC0zODgsMzAgKzM4OCwzOSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpzZXRF cnJvck1lc3NhZ2VDYWxsYmFjayhQYXNzT3duUHRyPEVycm9yTWVzc2FnZUNhbGxiYWNrPgogewog fQogCi1ib29sIEdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbWFnZURhdGEoSW1hZ2UqIGltYWdlLCBH QzNEZW51bSBmb3JtYXQsIEdDM0RlbnVtIHR5cGUsIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwgYm9v bCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSwgVmVjdG9yPHVpbnQ4X3Q+JiBvdXRwdXRWZWN0 b3IpCitHcmFwaGljc0NvbnRleHQzRDo6SW1hZ2VFeHRyYWN0b3I6On5JbWFnZUV4dHJhY3Rvcigp CiB7Ci0gICAgaWYgKCFpbWFnZSkKK30KKworYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6SW1hZ2VF eHRyYWN0b3I6OmV4dHJhY3RJbWFnZShib29sIHByZW11bHRpcGx5QWxwaGEsIGJvb2wgaWdub3Jl R2FtbWFBbmRDb2xvclByb2ZpbGUpCit7CisgICAgaWYgKCFtX2ltYWdlKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKLSAgICBOYXRpdmVJbWFnZVB0ciBuYXRpdmVJbWFnZSA9IGltYWdlLT5uYXRp dmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOworICAgIE5hdGl2ZUltYWdlUHRyIG5hdGl2ZUltYWdl ID0gbV9pbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKICAgICBpZiAoIW5hdGl2 ZUltYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICB1bnNpZ25lZCBpbWFnZVNpemUg PSBuYXRpdmVJbWFnZS0+c2l6ZSgpLndpZHRoKCkgKiBuYXRpdmVJbWFnZS0+c2l6ZSgpLmhlaWdo dCgpOwotICAgIFZlY3Rvcjx1bnNpZ25lZD4gaW1hZ2VEYXRhKGltYWdlU2l6ZSk7Ci0gICAgaWYg KCFuYXRpdmVJbWFnZS0+cmVhZFBpeGVscyhpbWFnZURhdGEuZGF0YSgpLCBpbWFnZVNpemUpKQor ICAgIG1faW1hZ2VXaWR0aCA9IG5hdGl2ZUltYWdlLT53aWR0aCgpOworICAgIG1faW1hZ2VIZWln aHQgPSBuYXRpdmVJbWFnZS0+aGVpZ2h0KCk7CisgICAgaWYgKCFtX2ltYWdlV2lkdGggfHwgIW1f aW1hZ2VIZWlnaHQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHVuc2lnbmVkIGltYWdl U2l6ZSA9IG1faW1hZ2VXaWR0aCAqIG1faW1hZ2VIZWlnaHQ7CisgICAgbV9pbWFnZURhdGEucmVz aXplKGltYWdlU2l6ZSk7CisgICAgaWYgKCFuYXRpdmVJbWFnZS0+cmVhZFBpeGVscyhtX2ltYWdl RGF0YS5kYXRhKCksIGltYWdlU2l6ZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8v IFJhdyBpbWFnZSBkYXRhIGlzIHByZW11bHRpcGxpZWQKLSAgICBBbHBoYU9wIG5lZWRlZEFscGhh T3AgPSBBbHBoYURvTm90aGluZzsKKyAgICBtX2FscGhhT3AgPSBBbHBoYURvTm90aGluZzsKICAg ICBpZiAoIXByZW11bHRpcGx5QWxwaGEpCi0gICAgICAgIG5lZWRlZEFscGhhT3AgPSBBbHBoYURv VW5tdWx0aXBseTsKKyAgICAgICAgbV9hbHBoYU9wID0gQWxwaGFEb1VubXVsdGlwbHk7CisKKyAg ICBtX2ltYWdlUGl4ZWxEYXRhID0gbV9pbWFnZURhdGEuZGF0YSgpOworICAgIG1faW1hZ2VTb3Vy Y2VGb3JtYXQgPSBEYXRhRm9ybWF0QkdSQTg7CisgICAgbV9pbWFnZVNvdXJjZVVucGFja0FsaWdu bWVudCA9IDA7CiAKLSAgICBvdXRwdXRWZWN0b3IucmVzaXplKGltYWdlU2l6ZSAqIDQpOwotICAg IHJldHVybiBwYWNrUGl4ZWxzKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KGltYWdl RGF0YS5kYXRhKCkpLAotICAgICAgICBTb3VyY2VGb3JtYXRCR1JBOCwKLSAgICAgICAgbmF0aXZl SW1hZ2UtPnNpemUoKS53aWR0aCgpLCBuYXRpdmVJbWFnZS0+c2l6ZSgpLmhlaWdodCgpLCAwLAot ICAgICAgICBmb3JtYXQsIHR5cGUsIG5lZWRlZEFscGhhT3AsIG91dHB1dFZlY3Rvci5kYXRhKCkp OworICAgIHJldHVybiB0cnVlOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==