112149 2013-03-12 07:15:22 -0700 [BlackBerry] SimpleFontData: remove duplicate code 2013-03-13 05:40:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 853431 0 berto 2013-03-12 07:15:22 -0700 smallCapsFontData() and emphasisMarkFontData() were moved from platform specific files into platform/graphics/SimpleFontData.cpp in r133362, so the BlackBerry port no longer needs its own implementation. 853433 1 192731 berto 2013-03-12 07:16:43 -0700 Created attachment 192731 Patch 854117 2 192731 cgarcia 2013-03-13 01:28:43 -0700 Comment on attachment 192731 Patch These methods now return a PassRefPtr, don't you need to adapt the callers too? or this are only called in cross platform code? 854179 3 berto 2013-03-13 03:50:07 -0700 (In reply to comment #2) > These methods now return a PassRefPtr, don't you need to adapt the > callers too? or this are only called in cross platform code? They're only called from SimpleFontData::variantFontData(), which is in Source/WebCore/platform/graphics/SimpleFontData.h 854227 4 192731 webkit.review.bot 2013-03-13 05:40:20 -0700 Comment on attachment 192731 Patch Clearing flags on attachment: 192731 Committed r145706: <http://trac.webkit.org/changeset/145706> 854228 5 webkit.review.bot 2013-03-13 05:40:24 -0700 All reviewed patches have been landed. Closing bug. 192731 2013-03-12 07:16:43 -0700 2013-03-13 05:40:20 -0700 Patch 112149.diff text/plain 2620 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmN2I5YjFkLi5jN2U0MTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDMtMTIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBTaW1wbGVGb250RGF0YTogcmVtb3ZlIGR1cGxpY2F0ZSBjb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxNDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzbWFsbENh cHNGb250RGF0YSgpIGFuZCBlbXBoYXNpc01hcmtGb250RGF0YSgpIHdlcmUgbW92ZWQgZnJvbQor ICAgICAgICBwbGF0Zm9ybSBzcGVjaWZpYyBmaWxlcyBpbnRvIHBsYXRmb3JtL2dyYXBoaWNzL1Np bXBsZUZvbnREYXRhLmNwcAorICAgICAgICBpbiByMTMzMzYyLCBzbyB0aGUgQmxhY2tCZXJyeSBw b3J0IG5vIGxvbmdlciBuZWVkcyBpdHMgb3duCisgICAgICAgIGltcGxlbWVudGF0aW9uLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9TaW1wbGVGb250RGF0YUJsYWNr QmVycnkuY3BwOgorCiAyMDEzLTAzLTEyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlc291cmNlU2NyaXB0RmlsZSBkaXZl cmdlZCBzdGF0ZSBzaG91bGQgYmUgY29ycmVjdGx5IHJlc2V0IGFmdGVyIGRlYnVnZ2VyIHJlc2V0 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJy eS9TaW1wbGVGb250RGF0YUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9TaW1wbGVGb250RGF0YUJsYWNrQmVycnkuY3BwCmluZGV4IGM2 NzAwOWIuLjcyMzhiMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvU2ltcGxlRm9udERhdGFCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L1NpbXBsZUZvbnREYXRhQmxhY2tC ZXJyeS5jcHAKQEAgLTMwLDEwICszMCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotLy8g U21hbGxjYXBzIHZlcnNpb25zIG9mIGZvbnRzIGFyZSA3MCUgdGhlIHNpemUgb2YgdGhlIG5vcm1h bCBmb250Lgotc3RhdGljIGNvbnN0IGZsb2F0IHNtYWxsQ2Fwc0ZyYWN0aW9uID0gMC43ZjsKLXN0 YXRpYyBjb25zdCBmbG9hdCBlbXBoYXNpc01hcmtGcmFjdGlvbiA9IC41OwotCiBzdGF0aWMgaW5s aW5lIGZsb2F0IEZTRml4ZWRUb0Zsb2F0KEZTX0ZJWEVEIG4pIHsgcmV0dXJuIG4gLyA2NTUzNi4w OyB9CiAKICNkZWZpbmUgb3BlblR5cGVUYWcoYSwgYiwgYywgZCkgKEZTX1VMT05HKSgoYSA8PCAy NCkgfCAoYiA8PCAxNikgfCAoYyA8PCA4KSB8IGQpCkBAIC0xMjEsMjYgKzExNyw2IEBAIFBhc3NP d25QdHI8U2ltcGxlRm9udERhdGE+IFNpbXBsZUZvbnREYXRhOjpjcmVhdGVTY2FsZWRGb250RGF0 YShjb25zdCBGb250RGVzY3JpCiAgICAgICAgIGlzQ3VzdG9tRm9udCgpLCBmYWxzZSkpOwogfQog Ci1TaW1wbGVGb250RGF0YSogU2ltcGxlRm9udERhdGE6OnNtYWxsQ2Fwc0ZvbnREYXRhKGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uKSBjb25zdAotewotICAgIGlmICghbV9k ZXJpdmVkRm9udERhdGEpCi0gICAgICAgIG1fZGVyaXZlZEZvbnREYXRhID0gRGVyaXZlZEZvbnRE YXRhOjpjcmVhdGUoaXNDdXN0b21Gb250KCkpOwotICAgIGlmICghbV9kZXJpdmVkRm9udERhdGEt PnNtYWxsQ2FwcykKLSAgICAgICAgbV9kZXJpdmVkRm9udERhdGEtPnNtYWxsQ2FwcyA9IGNyZWF0 ZVNjYWxlZEZvbnREYXRhKGZvbnREZXNjcmlwdGlvbiwgc21hbGxDYXBzRnJhY3Rpb24pOwotCi0g ICAgcmV0dXJuIG1fZGVyaXZlZEZvbnREYXRhLT5zbWFsbENhcHMuZ2V0KCk7Ci19Ci0KLVNpbXBs ZUZvbnREYXRhKiBTaW1wbGVGb250RGF0YTo6ZW1waGFzaXNNYXJrRm9udERhdGEoY29uc3QgRm9u dERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24pIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2Rlcml2 ZWRGb250RGF0YSkKLSAgICAgICAgbV9kZXJpdmVkRm9udERhdGEgPSBEZXJpdmVkRm9udERhdGE6 OmNyZWF0ZShpc0N1c3RvbUZvbnQoKSk7Ci0gICAgaWYgKCFtX2Rlcml2ZWRGb250RGF0YS0+ZW1w aGFzaXNNYXJrKQotICAgICAgICBtX2Rlcml2ZWRGb250RGF0YS0+ZW1waGFzaXNNYXJrID0gY3Jl YXRlU2NhbGVkRm9udERhdGEoZm9udERlc2NyaXB0aW9uLCBlbXBoYXNpc01hcmtGcmFjdGlvbik7 Ci0KLSAgICByZXR1cm4gbV9kZXJpdmVkRm9udERhdGEtPmVtcGhhc2lzTWFyay5nZXQoKTsKLX0K LQogYm9vbCBTaW1wbGVGb250RGF0YTo6Y29udGFpbnNDaGFyYWN0ZXJzKGNvbnN0IFVDaGFyKiBj aGFyYWN0ZXJzLCBpbnQgbGVuZ3RoKSBjb25zdAogewogICAgIGludCBwb3NpdGlvbiA9IDA7Cg==