112142 2013-03-12 06:13:12 -0700 [BlackBerry] FontPlatformData: HarfBuzz renaming 2013-03-12 08:18:20 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 853403 0 berto 2013-03-12 06:13:12 -0700 When the old HarfBuzz code was removed in r141291, HarfBuzzNGFace.h was renamed to HarfBuzzFace.h and m_harfbuzzFace was renamed to m_harfBuzzFace. These changes need to be reflected in the BlackBerry port. 853404 1 192722 berto 2013-03-12 06:15:17 -0700 Created attachment 192722 Patch 853475 2 192722 rwlbuis 2013-03-12 08:13:22 -0700 Comment on attachment 192722 Patch LGTM. 853479 3 192722 webkit.review.bot 2013-03-12 08:18:17 -0700 Comment on attachment 192722 Patch Clearing flags on attachment: 192722 Committed r145546: <http://trac.webkit.org/changeset/145546> 853480 4 webkit.review.bot 2013-03-12 08:18:20 -0700 All reviewed patches have been landed. Closing bug. 192722 2013-03-12 06:15:17 -0700 2013-03-12 08:18:17 -0700 Patch 112142.diff text/plain 3342 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NTlmMzdlLi5hNTMyMWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDMtMTIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBGb250UGxhdGZvcm1EYXRhOiBIYXJmQnV6eiByZW5hbWluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTQyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUg b2xkIEhhcmZCdXp6IGNvZGUgd2FzIHJlbW92ZWQgaW4gcjE0MTI5MSwKKyAgICAgICAgSGFyZkJ1 enpOR0ZhY2UuaCB3YXMgcmVuYW1lZCB0byBIYXJmQnV6ekZhY2UuaCBhbmQgbV9oYXJmYnV6ekZh Y2UKKyAgICAgICAgd2FzIHJlbmFtZWQgdG8gbV9oYXJmQnV6ekZhY2UuCisKKyAgICAgICAgVGhl c2UgY2hhbmdlcyBuZWVkIHRvIGJlIHJlZmxlY3RlZCBpbiB0aGUgQmxhY2tCZXJyeSBwb3J0Lgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9Gb250UGxhdGZvcm1EYXRh QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpGb250 UGxhdGZvcm1EYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OnBsYXRm b3JtRGF0YUluaXQpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6cGxhdGZv cm1EYXRhQXNzaWduKToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmhhcmZC dXp6RmFjZSk6CisKIDIwMTMtMDMtMTIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQnJva2VuIHNob3J0Y3V0cyBpbiBTbmlw cGV0cyBTb3VyY2VGcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9Gb250UGxhdGZvcm1EYXRhQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRQbGF0Zm9ybURhdGFCbGFj a0JlcnJ5LmNwcAppbmRleCA2MDRkMGUxLi44YjMxNWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRQbGF0Zm9ybURhdGFCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L0ZvbnRQbGF0Zm9ybURhdGFCbGFja0JlcnJ5LmNwcApAQCAtMTksNyArMTksNyBAQAogI2luY2x1 ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZvbnRQbGF0Zm9ybURhdGEuaCIKIAotI2luY2x1ZGUg IkhhcmZCdXp6TkdGYWNlLmgiCisjaW5jbHVkZSAiSGFyZkJ1enpGYWNlLmgiCiAjaW5jbHVkZSAi SVR5cGVVdGlscy5oIgogCiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtR3JhcGhpY3NDb250 ZXh0Lmg+CkBAIC0zOCw3ICszOCw3IEBAIEZvbnRQbGF0Zm9ybURhdGE6OkZvbnRQbGF0Zm9ybURh dGEoRklMRUNIQVIqIG5hbWUsIGZsb2F0IHNpemUsIGJvb2wgc3ludGhldGljQm9sCiAgICAgLCBt X2ZvbnQoMCkKICAgICAsIG1fbmFtZShmYXN0U3RyRHVwKG5hbWUpKQogICAgICwgbV9zY2FsZWRG b250KDApCi0gICAgLCBtX2hhcmZidXp6RmFjZSgpCisgICAgLCBtX2hhcmZCdXp6RmFjZSgpCiAg ICAgLCBtX2lzQ29sb3JCaXRtYXBGb250KGZhbHNlKQogewogICAgIEFTU0VSVChuYW1lKTsKQEAg LTEwOSw3ICsxMDksNyBAQCBib29sIEZvbnRQbGF0Zm9ybURhdGE6OmFwcGx5U3RhdGUoRlNfU1RB VEUqIGZvbnQsIGZsb2F0IHNjYWxlKSBjb25zdAogCiB2b2lkIEZvbnRQbGF0Zm9ybURhdGE6OnBs YXRmb3JtRGF0YUluaXQoY29uc3QgRm9udFBsYXRmb3JtRGF0YSYgc291cmNlKQogewotICAgIG1f aGFyZmJ1enpGYWNlID0gc291cmNlLm1faGFyZmJ1enpGYWNlOworICAgIG1faGFyZkJ1enpGYWNl ID0gc291cmNlLm1faGFyZkJ1enpGYWNlOwogICAgIG1fc2NhbGVkRm9udCA9IDA7CiAgICAgaWYg KHNvdXJjZS5tX2ZvbnQgJiYgc291cmNlLm1fZm9udCAhPSBoYXNoVGFibGVEZWxldGVkRm9udFZh bHVlKCkpIHsKICAgICAgICAgbV9mb250ID0gRlNfbmV3X2NsaWVudChzb3VyY2UubV9mb250LCAw KTsKQEAgLTEyMiw3ICsxMjIsNyBAQCB2b2lkIEZvbnRQbGF0Zm9ybURhdGE6OnBsYXRmb3JtRGF0 YUluaXQoY29uc3QgRm9udFBsYXRmb3JtRGF0YSYgc291cmNlKQogCiBjb25zdCBGb250UGxhdGZv cm1EYXRhJiBGb250UGxhdGZvcm1EYXRhOjpwbGF0Zm9ybURhdGFBc3NpZ24oY29uc3QgRm9udFBs YXRmb3JtRGF0YSYgb3RoZXIpCiB7Ci0gICAgbV9oYXJmYnV6ekZhY2UgPSBvdGhlci5tX2hhcmZi dXp6RmFjZTsKKyAgICBtX2hhcmZCdXp6RmFjZSA9IG90aGVyLm1faGFyZkJ1enpGYWNlOwogICAg IG1fc2NhbGVkRm9udCA9IDA7CiAgICAgaWYgKG90aGVyLm1fZm9udCAmJiBvdGhlci5tX2ZvbnQg IT0gaGFzaFRhYmxlRGVsZXRlZEZvbnRWYWx1ZSgpKSB7CiAgICAgICAgIG1fZm9udCA9IEZTX25l d19jbGllbnQob3RoZXIubV9mb250LCAwKTsKQEAgLTE1NCwxNCArMTU0LDE0IEBAIFN0cmluZyBG b250UGxhdGZvcm1EYXRhOjpkZXNjcmlwdGlvbigpIGNvbnN0CiB9CiAjZW5kaWYKIAotSGFyZkJ1 enpOR0ZhY2UqIEZvbnRQbGF0Zm9ybURhdGE6OmhhcmZidXp6RmFjZSgpCitIYXJmQnV6ekZhY2Uq IEZvbnRQbGF0Zm9ybURhdGE6OmhhcmZCdXp6RmFjZSgpCiB7Ci0gICAgaWYgKCFtX2hhcmZidXp6 RmFjZSkgeworICAgIGlmICghbV9oYXJmQnV6ekZhY2UpIHsKICAgICAgICAgdWludDY0X3QgdW5p cXVlSUQgPSByZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4obV9mb250KTsKLSAgICAgICAgbV9o YXJmYnV6ekZhY2UgPSBIYXJmQnV6ek5HRmFjZTo6Y3JlYXRlKGNvbnN0X2Nhc3Q8Rm9udFBsYXRm b3JtRGF0YSo+KHRoaXMpLCB1bmlxdWVJRCk7CisgICAgICAgIG1faGFyZkJ1enpGYWNlID0gSGFy ZkJ1enpGYWNlOjpjcmVhdGUoY29uc3RfY2FzdDxGb250UGxhdGZvcm1EYXRhKj4odGhpcyksIHVu aXF1ZUlEKTsKICAgICB9CiAKLSAgICByZXR1cm4gbV9oYXJmYnV6ekZhY2UuZ2V0KCk7CisgICAg cmV0dXJuIG1faGFyZkJ1enpGYWNlLmdldCgpOwogfQogCiBGU19TVEFURSogRm9udFBsYXRmb3Jt RGF0YTo6c2NhbGVkRm9udChmbG9hdCBzY2FsZSkgY29uc3QK