112096 2013-03-11 19:34:34 -0700 [Meta] Track all usage of HitTestRequest::DisallowShadowContent in HitTests. 2019-10-04 22:37:30 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 112073 113171 59805 1 hayato webkit-unassigned allan.jensen cbiesinger dglazkov rniwa tonikitoo webcomponents-bugzilla webkit-bug-importer oldest_to_newest 853010 0 hayato 2013-03-11 19:34:34 -0700 This meta bug should track all usage of HitTestRequest::AllowShadowContent in EventHandler. Some of them can be updated so that we can allow shadow content in HitTestResult. - TouchEvent was fixed in http://trac.webkit.org/changeset/144877. - Gesture Events should be also fixed, which is tracked in https://bugs.webkit.org/show_bug.cgi?id=112073 853014 1 dglazkov 2013-03-11 19:44:11 -0700 We should fix this flag to be on by default. It's very rare that AllowShadowContent == false. 853031 2 hayato 2013-03-11 20:41:30 -0700 Yeah, that's our goal. (In reply to comment #1) > We should fix this flag to be on by default. It's very rare that AllowShadowContent == false. 856864 3 hayato 2013-03-17 23:54:44 -0700 HitTests are used from a lot of places in WebCore. Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression. My current plan is conservative. Use this flag for each cases step by step. Tough, we need to figure out the usage in each places, which might take much time. 862543 4 hayato 2013-03-25 01:07:29 -0700 I feel that we must change the title of this bug after https://bugs.webkit.org/show_bug.cgi?id=113171 is landed, like: 'Track all usage of HitTestRequest::DisallowShadowContent' in WebKit. (In reply to comment #3) > HitTests are used from a lot of places in WebCore. > > Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression. > > My current plan is conservative. Use this flag for each cases step by step. > Tough, we need to figure out the usage in each places, which might take much time. 864263 5 hayato 2013-03-27 00:18:11 -0700 https://bugs.webkit.org/show_bug.cgi?id=113171 was landed. I've updated the title of this bug. 919411 6 tonikitoo 2013-08-21 07:48:30 -0700 Allan, I think we are good to close this bug now, right? 1577167 7 rniwa 2019-10-04 22:36:30 -0700 HitTestRequest::DisallowShadowContent is not a thing anymore. 1577168 8 webkit-bug-importer 2019-10-04 22:37:17 -0700 <rdar://problem/56003892> 1577169 9 rniwa 2019-10-04 22:37:30 -0700 Oh, actually, this got renamed to DisallowUserAgentShadowContent. But I don't think we need this meta bug to track this.