112001 2013-03-11 07:21:57 -0700 [EFL] accessibility/ignore-spacer-elements.html is failing. 2013-04-03 02:47:43 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 111985 0 k.czech webkit-unassigned aboxhall apinheiro cfleizach dmazzoni gyuyoung.kim jdiggs lucas.de.marchi mario mrobinson webkit.review.bot oldest_to_newest 852280 0 k.czech 2013-03-11 07:21:57 -0700 accessibility/ignore-spacer-elements.html is failing on all EFL platforms. 859431 1 194063 k.czech 2013-03-20 08:12:31 -0700 Created attachment 194063 Patch 860180 2 194063 mario 2013-03-21 03:21:45 -0700 Comment on attachment 194063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194063&action=review > LayoutTests/accessibility/ignore-spacer-elements.html:28 > + var expectedCount = (testRunner.platformName == "gtk" || testRunner.platformName == "efl") ? 2 : 4; I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. Thoughts? 860205 3 k.czech 2013-03-21 04:24:08 -0700 > I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. > > Thoughts? In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms. 860279 4 mario 2013-03-21 06:28:06 -0700 (In reply to comment #3) > > I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. > > > > Thoughts? > In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms. Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think). 865544 5 k.czech 2013-03-28 08:46:22 -0700 > Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think). Yes, it's only used in a11y tests. 868517 6 194063 gyuyoung.kim 2013-04-03 01:27:28 -0700 Comment on attachment 194063 Patch rs=me 868565 7 194063 webkit.review.bot 2013-04-03 02:47:39 -0700 Comment on attachment 194063 Patch Clearing flags on attachment: 194063 Committed r147534: <http://trac.webkit.org/changeset/147534> 868566 8 webkit.review.bot 2013-04-03 02:47:43 -0700 All reviewed patches have been landed. Closing bug. 194063 2013-03-20 08:12:31 -0700 2013-04-03 02:47:39 -0700 Patch a11y-ignore-spacer-elements.patch text/plain 3477 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YjNiZGQ0Li4yMjIyMjdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xMiw2ICsxMiwxOSBAQAogCiAyMDEz LTAzLTIwICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCisgICAgICAg IFtFRkxdIGFjY2Vzc2liaWxpdHkvaWdub3JlLXNwYWNlci1lbGVtZW50cy5odG1sIGlzIGZhaWxp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjAw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVk IGZhaWxpbmcgdGVzdC4gVGhlIHJlYXNvbiBvZiBmYWlsdXJlIGlzIGRpZmZlcmVudCBleHBlY3Rh dGlvbiBvZiBjaGlsZHJlbkNvdW50LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pZ25vcmUt c3BhY2VyLWVsZW1lbnRzLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhw ZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9uczoK KworMjAxMy0wMy0yMCAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKwog ICAgICAgICBbRUZMXSBhY2Nlc3NpYmlsaXR5L2FyaWEtc2Nyb2xsYmFyLXJvbGUuaHRtbCBpcyBm YWlsaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTE5ODkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pZ25vcmUtc3Bh Y2VyLWVsZW1lbnRzLmh0bWwgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2lnbm9yZS1zcGFj ZXItZWxlbWVudHMuaHRtbAppbmRleCA2MGVmMjNjLi4xOWFjOWNmIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2lnbm9yZS1zcGFjZXItZWxlbWVudHMuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2lnbm9yZS1zcGFjZXItZWxlbWVudHMuaHRtbApAQCAt MjQsOCArMjQsOCBAQAogICAgICAgICAgICAgYm9keS5mb2N1cygpOwogICAgICAgICAgICAgdmFy IGNvbnRhaW5lciA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNoaWxk QXRJbmRleCgwKTsKIAotICAgICAgICAgICAgLy8gVGhlIEd0ayBwb3J0IEFUcyBleHBlY3QgdGhl IGJvbGQgaW5saW5lIHRleHQgdG8gbm90IGhhdmUgYWNjZXNzaWJsZSBvYmplY3RzLgotICAgICAg ICAgICAgdmFyIGV4cGVjdGVkQ291bnQgPSAodGVzdFJ1bm5lci5wbGF0Zm9ybU5hbWUgPT0gImd0 ayIpID8gMiA6IDQ7CisgICAgICAgICAgICAvLyBUaGUgR3RrIGFuZCBFRkwgcG9ydHMgQVRzIGV4 cGVjdCB0aGUgYm9sZCBpbmxpbmUgdGV4dCB0byBub3QgaGF2ZSBhY2Nlc3NpYmxlIG9iamVjdHMu CisgICAgICAgICAgICB2YXIgZXhwZWN0ZWRDb3VudCA9ICh0ZXN0UnVubmVyLnBsYXRmb3JtTmFt ZSA9PSAiZ3RrIiB8fCB0ZXN0UnVubmVyLnBsYXRmb3JtTmFtZSA9PSAiZWZsIikgPyAyIDogNDsK ICAgICAgICAgICAgIGlmIChjb250YWluZXIuY2hpbGRyZW5Db3VudCA9PSBleHBlY3RlZENvdW50 KSB7CiAgICAgICAgICAgICAgICAgcmVzdWx0LmlubmVyVGV4dCArPSAiVGVzdCBwYXNzZWRcbiI7 CiAgICAgICAgICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sx L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggOTE0ODA3Yy4uNmFlMjFmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTE5LDcgKzExOSw2IEBAIHdlYmtpdC5v cmcvYi8xMTE5OTQgYWNjZXNzaWJpbGl0eS9jYW52YXMtYWNjZXNzaWJpbGl0eW5vZGVvYmplY3Qu aHRtbCBbIEZhaWx1cmUKIHdlYmtpdC5vcmcvYi8xMTE5OTYgYWNjZXNzaWJpbGl0eS9jYW52YXMt ZmFsbGJhY2stY29udGVudC0yLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTE5OTkg YWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLmh0bWwgWyBGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMDAgYWNjZXNzaWJpbGl0eS9oZWFkaW5nLWxldmVsLmh0 bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMTIwMDEgYWNjZXNzaWJpbGl0eS9pZ25vcmUt c3BhY2VyLWVsZW1lbnRzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMDIgYWNj ZXNzaWJpbGl0eS9pbmxpbmUtY29udGludWF0aW9ucy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMTEyMDAzIGFjY2Vzc2liaWxpdHkvbG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0 aW9uLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMjMgYWNjZXNzaWJpbGl0eS9s b2FkaW5nLWlmcmFtZS11cGRhdGVzLWF4dHJlZS5odG1sIFsgRmFpbHVyZSBdCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMjNmN2M4Yi4uYjE2 NjQzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMjU2LDcgKzI1Niw2IEBAIHdlYmtpdC5vcmcvYi8xMTE5OTQgYWNjZXNzaWJpbGl0eS9j YW52YXMtYWNjZXNzaWJpbGl0eW5vZGVvYmplY3QuaHRtbCBbIEZhaWx1cmUKIHdlYmtpdC5vcmcv Yi8xMTE5OTYgYWNjZXNzaWJpbGl0eS9jYW52YXMtZmFsbGJhY2stY29udGVudC0yLmh0bWwgWyBG YWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTE5OTkgYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250 cm9scy1ub3QtZm9jdXNhYmxlLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMDAg YWNjZXNzaWJpbGl0eS9oZWFkaW5nLWxldmVsLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcv Yi8xMTIwMDEgYWNjZXNzaWJpbGl0eS9pZ25vcmUtc3BhY2VyLWVsZW1lbnRzLmh0bWwgWyBGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMDIgYWNjZXNzaWJpbGl0eS9pbmxpbmUtY29udGludWF0 aW9ucy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTEyMDI5IGFjY2Vzc2liaWxpdHkv bGFiZWwtZm9yLWNvbnRyb2wtaGl0dGVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2Iv MTEyMDMwIGFjY2Vzc2liaWxpdHkvbGFuZ3VhZ2UtYXR0cmlidXRlLmh0bWwgWyBGYWlsdXJlIF0K