111999 2013-03-11 07:17:09 -0700 [EFL] accessibility/disabled-controls-not-focusable.html is failing 2017-03-11 10:42:21 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED WONTFIX P2 Normal --- 111985 0 k.czech webkit-unassigned aboxhall apinheiro cdumez cfleizach commit-queue darin dmazzoni g.czajkowski gyuyoung.kim gyuyoung.kim jdiggs justin.garcia lucas.de.marchi mario mcatanzaro rakuco rniwa oldest_to_newest 852275 0 k.czech 2013-03-11 07:17:09 -0700 accessibility/disabled-controls-not-focusable.html is failing on all EFL platforms. 937912 1 213775 k.czech 2013-10-09 07:11:19 -0700 Created attachment 213775 Patch 937914 2 213776 k.czech 2013-10-09 07:16:55 -0700 Created attachment 213776 Patch 937916 3 mario 2013-10-09 07:41:13 -0700 It's very weird that we need this specific expectation here (same for GTK), since it seems the only difference compared to the cross-platform expected results is that a blank space is missing in the first line (before "This test makes sure..."). I've observed that if I comment out the debug(element.id) line in the test, then the number of blank spaces there is always the same, which suggests that something is wrong with our version of DRT/WKTR (also happens there), potentially causing more trouble in other tests. You can check yourself this weird situation by checking the diff $ diff -u \ ./platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt \ ./accessibility/disabled-controls-not-focusable-expected.txt You will see how there are only 16 spaces in the first line of the output for the GTK specific version (identical to the one for EFL you are adding here now) and 17 spaces for the other version. How do you feel about investigating this issue instead of rebaselining this test? 937919 4 k.czech 2013-10-09 07:59:09 -0700 > How do you feel about investigating this issue instead of rebaselining this test? You are right, the difference is only in one space. Seems very weird. I will take a look at this. 941189 5 g.czajkowski 2013-10-18 07:30:11 -0700 As Mario said, the difference between cross-platform expectation and GTK/EFL is one space that seems to be missing. The problem is with dumping (via dumpAsText) the first <div>...</div> element which contains various HTML elements to be tested: <div> <button id="button"></button> <input id="text" type="text"> <input id="checkbox" type="checkbox"> <input id="radio" type="radio"> <input id="submit" type="submit"> <input id="slider" type="range"> <select id="listbox" multiple><option>1<option>2</select> <select id="combobox"><option>1<option>2</select> <textarea id="textarea"></textarea> </div> It seems that while dumping tree to text, we erroneously replace the last space with '\n' character indicating the end of div element. I've observed that if I exclude some elements from div, then the number of spaces seems fine. It looks that the problematic elements are: <input id="text" type="text"> <input id="submit" type="submit"> <input id="slider" type="range"> <select id="combobox"><option>1<option>2</select> <textarea id="textarea"></textarea> To check this, try to comment out one of above elements and then the number of spaces (decreased by removed element) is OK. What I found surprising that those elements cause problems only with this div element and its children. As a result, we cannot simplify the test case by defining own div, for example <div> <button id="button"></button> <input id="text" type="text"> <!-- cause problems in our accessibility test --> </div> because its output is correct here. As you've already mention, this bug is not related to accessibility at all and I could help in solving it. Do you guys prefer to continue work in this bug or creating a new one due to its core background? Then we could land EFL test expectation. CC'ing authors of editing/TextIterator where I see difference of behaviour between Mac and EFL/GTK (probably the cause of bug is somewhere deeper). 941263 6 darin 2013-10-18 10:32:31 -0700 We should keep reducing this to the smallest possible test case. 978715 7 gyuyoung.kim 2014-02-09 21:16:03 -0800 Krzystof, any update ? 978783 8 k.czech 2014-02-10 01:25:25 -0800 (In reply to comment #7) > Krzystof, any update ? Basically this issue is not related to Accessibility. I will create a bug to handle this problem. 978788 9 k.czech 2014-02-10 01:43:31 -0800 > I will create a bug to handle this problem. https://bugs.webkit.org/show_bug.cgi?id=128522 1172574 10 213776 commit-queue 2016-03-09 09:38:20 -0800 Comment on attachment 213776 Patch Rejecting attachment 213776 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 213776, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl-wk2/TestExpectations Hunk #1 FAILED at 160. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl-wk2/TestExpectations.rej patching file LayoutTests/platform/efl/accessibility/disabled-controls-not-focusable-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/948700 1286500 11 mcatanzaro 2017-03-11 10:42:21 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 213775 2013-10-09 07:11:19 -0700 2013-10-09 07:16:55 -0700 Patch a11y-disabled-controls-not-focusable.patch text/plain 2028 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZmNmZmVmLi44YTdmODUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTMtMTAt MDkgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VG TF0gYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLmh0bWwgaXMg ZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTExOTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgRUZMJ3Mgc3BlY2lmaWMgYmFzZWxpbmUgYWZ0ZXIgcjExNzgwMy4KKworICAgICAgICAq IHBsYXRmb3JtL2VmbC9hY2Nlc3NpYmlsaXR5L2Rpc2FibGVkLWNvbnRyb2xzLW5vdC1mb2N1c2Fi bGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKworMjAxMy0xMC0wOSAgS3J6eXN6dG9mIEN6ZWNoICA8 ay5jemVjaEBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbRUZMXSBhY2Nlc3NpYmlsaXR5L3RhYmxl LWNlbGxzLmh0bWwgaXMgZmFpbGluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIyNTQ0CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9hY2Nlc3NpYmlsaXR5L2Rpc2FibGVkLWNvbnRyb2xzLW5vdC1mb2N1c2FibGUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2FjY2Vzc2liaWxpdHkvZGlzYWJsZWQt Y29udHJvbHMtbm90LWZvY3VzYWJsZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uOTQxNjEwMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2VmbC9hY2Nlc3NpYmlsaXR5L2Rpc2FibGVkLWNvbnRyb2xzLW5vdC1mb2N1c2FibGUt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMzcgQEAKKyAgICAgICAgICAgICAgIAorVGhpcyB0ZXN0 IG1ha2VzIHN1cmUgdGhhdCBkaXNhYmxlZCBmb3JtIGNvbnRyb2xzIGFyZSBub3QgZXhwb3NlZCBh cyBmb2N1c2FibGUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitidXR0b24KK1BB U1MgYXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIHRydWUKK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNh YmxlIGlzIGZhbHNlCit0ZXh0CitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyB0cnVlCitQ QVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyBmYWxzZQorY2hlY2tib3gKK1BBU1MgYXhFbGVt ZW50LmlzRm9jdXNhYmxlIGlzIHRydWUKK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIGZh bHNlCityYWRpbworUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgdHJ1ZQorUEFTUyBheEVs ZW1lbnQuaXNGb2N1c2FibGUgaXMgZmFsc2UKK3N1Ym1pdAorUEFTUyBheEVsZW1lbnQuaXNGb2N1 c2FibGUgaXMgdHJ1ZQorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgZmFsc2UKK3NsaWRl cgorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgdHJ1ZQorUEFTUyBheEVsZW1lbnQuaXNG b2N1c2FibGUgaXMgZmFsc2UKK2NvbWJvYm94CitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBp cyB0cnVlCitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyBmYWxzZQorbGlzdGJveAorUEFT UyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgdHJ1ZQorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2Fi bGUgaXMgZmFsc2UKK3RleHRhcmVhCitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyB0cnVl CitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK 213776 2013-10-09 07:16:55 -0700 2016-03-09 09:38:20 -0800 Patch a11y-disabled-controls-not-focusable.patch text/plain 2938 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZmNmZmVmLi45N2E2ZDhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTMtMTAt MDkgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VG TF0gYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLmh0bWwgaXMg ZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIyNTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgRUZMJ3Mgc3BlY2lmaWMgYmFzZWxpbmUgYWZ0ZXIgcjExNzgwMy4KKworICAgICAgICAq IHBsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9l ZmwvYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLWV4cGVjdGVk LnR4dDogQWRkZWQuCisKKzIwMTMtMTAtMDkgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CisKICAgICAgICAgW0VGTF0gYWNjZXNzaWJpbGl0eS90YWJsZS1jZWxscy5odG1s IGlzIGZhaWxpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMjU0NAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rl c3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggOWMzMjNhYi4uOGNkMWJlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTYwLDcgKzE2MCw2IEBAIHdlYmtpdC5vcmcv Yi8xMTE5OTEgYWNjZXNzaWJpbGl0eS9hcmlhLXRleHQtcm9sZS5odG1sIFsgRmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTExOTkzIGFjY2Vzc2liaWxpdHkvYnV0dG9uLXByZXNzLWFjdGlvbi5odG1s IFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTExOTk0IGFjY2Vzc2liaWxpdHkvY2FudmFzLWFj Y2Vzc2liaWxpdHlub2Rlb2JqZWN0Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTE5 OTYgYWNjZXNzaWJpbGl0eS9jYW52YXMtZmFsbGJhY2stY29udGVudC0yLmh0bWwgWyBGYWlsdXJl IF0KLXdlYmtpdC5vcmcvYi8xMTE5OTkgYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1u b3QtZm9jdXNhYmxlLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMDIgYWNjZXNz aWJpbGl0eS9pbmxpbmUtY29udGludWF0aW9ucy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3Jn L2IvMTEyMDA1IGFjY2Vzc2liaWxpdHkvb25jbGljay1oYW5kbGVycy5odG1sIFsgRmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMTEyMDA2IGFjY2Vzc2liaWxpdHkvc2VjdXJlLXRleHRmaWVsZC10aXRs ZS11aS5odG1sIFsgRmFpbHVyZSBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9hY2Nlc3NpYmlsaXR5L2Rpc2FibGVkLWNv bnRyb2xzLW5vdC1mb2N1c2FibGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjk0MTYxMDAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9lZmwvYWNjZXNzaWJpbGl0eS9kaXNhYmxlZC1jb250cm9scy1ub3QtZm9jdXNhYmxlLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDM3IEBACisgICAgICAgICAgICAgICAKK1RoaXMgdGVzdCBt YWtlcyBzdXJlIHRoYXQgZGlzYWJsZWQgZm9ybSBjb250cm9scyBhcmUgbm90IGV4cG9zZWQgYXMg Zm9jdXNhYmxlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworYnV0dG9uCitQQVNT IGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyB0cnVlCitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJs ZSBpcyBmYWxzZQordGV4dAorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgdHJ1ZQorUEFT UyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgZmFsc2UKK2NoZWNrYm94CitQQVNTIGF4RWxlbWVu dC5pc0ZvY3VzYWJsZSBpcyB0cnVlCitQQVNTIGF4RWxlbWVudC5pc0ZvY3VzYWJsZSBpcyBmYWxz ZQorcmFkaW8KK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIHRydWUKK1BBU1MgYXhFbGVt ZW50LmlzRm9jdXNhYmxlIGlzIGZhbHNlCitzdWJtaXQKK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNh YmxlIGlzIHRydWUKK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIGZhbHNlCitzbGlkZXIK K1BBU1MgYXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIHRydWUKK1BBU1MgYXhFbGVtZW50LmlzRm9j dXNhYmxlIGlzIGZhbHNlCitjb21ib2JveAorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMg dHJ1ZQorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgZmFsc2UKK2xpc3Rib3gKK1BBU1Mg YXhFbGVtZW50LmlzRm9jdXNhYmxlIGlzIHRydWUKK1BBU1MgYXhFbGVtZW50LmlzRm9jdXNhYmxl IGlzIGZhbHNlCit0ZXh0YXJlYQorUEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgdHJ1ZQor UEFTUyBheEVsZW1lbnQuaXNGb2N1c2FibGUgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCg==