111972 2013-03-11 04:32:13 -0700 [BlackBerry] SelectionHandler: bring back m_lastSelection attribute 2013-03-11 08:35:51 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned buildbot cgarcia mifenton rniwa rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 852183 0 berto 2013-03-11 04:32:13 -0700 This was removed in r144515 but is still needed by SelectionHandler::selectionPositionChanged() http://trac.webkit.org/changeset/144515/trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h 852184 1 192438 berto 2013-03-11 04:33:26 -0700 Created attachment 192438 Patch 852228 2 192438 buildbot 2013-03-11 05:58:49 -0700 Comment on attachment 192438 Patch Attachment 192438 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17077829 New failing tests: fast/css/sticky/sticky-both-sides.html fast/css/sticky/inline-sticky.html 852292 3 192438 rwlbuis 2013-03-11 07:33:03 -0700 Comment on attachment 192438 Patch LGTM. 852352 4 192438 webkit.review.bot 2013-03-11 08:35:47 -0700 Comment on attachment 192438 Patch Clearing flags on attachment: 192438 Committed r145365: <http://trac.webkit.org/changeset/145365> 852353 5 webkit.review.bot 2013-03-11 08:35:51 -0700 All reviewed patches have been landed. Closing bug. 192438 2013-03-11 04:33:26 -0700 2013-03-11 08:35:47 -0700 Patch 111972.diff text/plain 1213 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGZiODA2OWYuLjVkOTIzMjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTExICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gU2VsZWN0aW9uSGFuZGxlcjogYnJpbmcgYmFjayBtX2xhc3RTZWxlY3Rpb24gYXR0cmlidXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE5NzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdh cyByZW1vdmVkIGluIHIxNDQ1MTUgYnV0IGlzIHN0aWxsIG5lZWRlZCBieQorICAgICAgICBTZWxl Y3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQoKS4KKworICAgICAgICAqIFdl YktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oOgorICAgICAgICAoU2VsZWN0aW9uSGFuZGxl cik6CisKIDIwMTMtMDMtMDcgIE90dG8gRGVyZWsgQ2hldW5nICA8b3RjaGV1bmdAcmltLmNvbT4K IAogICAgICAgICBbQmxhY2tCZXJyeV0gUmVmQ291bnRpbmcgUGFyc2VkQ29va2llIHRvIGF2b2lk IFNlZ0ZhdWx0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oCmluZGV4IDMzODhlOWEuLjA5MmNhYmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhh bmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxl Y3Rpb25IYW5kbGVyLmgKQEAgLTEyMiw2ICsxMjIsNyBAQCBwcml2YXRlOgogICAgIEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpTdG9wV2F0Y2ggbV90aW1lcjsKIAogICAgIFdlYkNvcmU6OkludFNpemUg bV9zY3JvbGxNYXJnaW47CisgICAgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbiBtX2xhc3RTZWxl Y3Rpb247CiB9OwogCiB9Cg==