111660 2013-03-06 18:46:20 -0800 [ARM] isVFPPresent failed to detect vfp3 2019-06-09 19:11:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Android Android UNCONFIRMED P1 Critical --- 108645 0 manjian2006 webkit-unassigned buildbot clopez commit-queue keith_miller mark.lam msaboff ngockhanhlam87 ossy saam oldest_to_newest 849595 0 manjian2006 2013-03-06 18:46:20 -0800 Currently,the ARM family assemblers only support vfp3.But the function isVFPPresent just determines if we want to use vfp by checking HWCAP_VFP. int fd = open("/proc/self/auxv", O_RDONLY); if (fd > 0) { Elf32_auxv_t aux; while (read(fd, &aux, sizeof(Elf32_auxv_t))) { if (aux.a_type == AT_HWCAP) { close(fd); return aux.a_un.a_val & HWCAP_VFP; } } close(fd); } This flag is on whenever the cpu has a vfp.But for armv5 family cpus,they just have vfp,not vfp3.So this will cause crash on these machines. You should change HWCAP_VFP to HWCAP_VFPv3. As the Linux kernel source arch/arm/vfp/vfpmodule.c descripts: #ifdef CONFIG_VFPv3 if (VFP_arch >= 2) { elf_hwcap |= HWCAP_VFPv3; /* * Check for VFPv3 D16. CPUs in this configuration * only have 16 x 64bit registers. */ if (((fmrx(MVFR0) & MVFR0_A_SIMD_MASK)) == 1) elf_hwcap |= HWCAP_VFPv3D16; } #endif 849597 1 manjian2006 2013-03-06 18:47:52 -0800 you don't want me to submit a patch,because I can't checkout the whole svn trunk.I am in China,where is "protected" by the Great Fire Wall. 859102 2 manjian2006 2013-03-19 23:39:25 -0700 well,seems a patch is mandatory here 859934 3 194165 manjian2006 2013-03-20 18:54:29 -0700 Created attachment 194165 change to vfp3 859937 4 194166 manjian2006 2013-03-20 18:56:36 -0700 Created attachment 194166 patch 859951 5 194167 manjian2006 2013-03-20 19:22:46 -0700 Created attachment 194167 patch 945742 6 194167 commit-queue 2013-10-31 16:20:59 -0700 Comment on attachment 194167 patch Rejecting attachment 194167 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 194167, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit ed46a0b..9cd447a master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 158402 = ed46a0b8b39c279bd312a1751a6d47cd897fafb8 r158404 = 9cd447a9654a49da4bb567a48886a88e9c6a144b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/19498010 1127125 7 clopez 2015-09-18 09:08:15 -0700 Hey. This patch has been sitting here for 2 years, with an r+ and just with a cq- because it don't has a changelog. The patch still applies, should we commit it? It only needs a changelog. 1127977 8 ossy 2015-09-22 03:36:01 -0700 (In reply to comment #7) > Hey. This patch has been sitting here for 2 years, with an r+ and just with > a cq- because it don't has a changelog. > > The patch still applies, should we commit it? It only needs a changelog. I agree, let's add a changelog and commit it. 194165 2013-03-20 18:54:29 -0700 2013-03-20 19:22:46 -0700 change to vfp3 patch.1 application/octet-stream 597 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTS5jcHAKaW5kZXggOThkYzNlOS4uNWQ4MzQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKQEAgLTUwLDcgKzUw LDcgQEAgc3RhdGljIGJvb2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgd2hpbGUgKHJlYWQoZmQs ICZhdXgsIHNpemVvZihFbGYzMl9hdXh2X3QpKSkgewogICAgICAgICAgICAgaWYgKGF1eC5hX3R5 cGUgPT0gQVRfSFdDQVApIHsKICAgICAgICAgICAgICAgICBjbG9zZShmZCk7Ci0gICAgICAgICAg ICAgICAgcmV0dXJuIGF1eC5hX3VuLmFfdmFsICYgSFdDQVBfVkZQOworICAgICAgICAgICAgICAg IHJldHVybiBhdXguYV91bi5hX3ZhbCAmIEhXQ0FQX1ZGUHYzOwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgICAgIGNsb3NlKGZkKTsK 194166 2013-03-20 18:56:36 -0700 2013-03-20 19:22:46 -0700 patch patch.diff text/plain 597 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTS5jcHAKaW5kZXggOThkYzNlOS4uNWQ4MzQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKQEAgLTUwLDcgKzUw LDcgQEAgc3RhdGljIGJvb2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgd2hpbGUgKHJlYWQoZmQs ICZhdXgsIHNpemVvZihFbGYzMl9hdXh2X3QpKSkgewogICAgICAgICAgICAgaWYgKGF1eC5hX3R5 cGUgPT0gQVRfSFdDQVApIHsKICAgICAgICAgICAgICAgICBjbG9zZShmZCk7Ci0gICAgICAgICAg ICAgICAgcmV0dXJuIGF1eC5hX3VuLmFfdmFsICYgSFdDQVBfVkZQOworICAgICAgICAgICAgICAg IHJldHVybiBhdXguYV91bi5hX3ZhbCAmIEhXQ0FQX1ZGUHYzOwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgICAgIGNsb3NlKGZkKTsK 194167 2013-03-20 19:22:46 -0700 2013-10-31 16:20:59 -0700 patch patch.patch text/plain 597 manjian2006 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTS5jcHAKaW5kZXggOThkYzNlOS4uNWQ4MzQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKQEAgLTUwLDcgKzUw LDcgQEAgc3RhdGljIGJvb2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgd2hpbGUgKHJlYWQoZmQs ICZhdXgsIHNpemVvZihFbGYzMl9hdXh2X3QpKSkgewogICAgICAgICAgICAgaWYgKGF1eC5hX3R5 cGUgPT0gQVRfSFdDQVApIHsKICAgICAgICAgICAgICAgICBjbG9zZShmZCk7Ci0gICAgICAgICAg ICAgICAgcmV0dXJuIGF1eC5hX3VuLmFfdmFsICYgSFdDQVBfVkZQOworICAgICAgICAgICAgICAg IHJldHVybiBhdXguYV91bi5hX3ZhbCAmIEhXQ0FQX1ZGUHYzOwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgICAgIGNsb3NlKGZkKTsK