<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>111636</bug_id>
          
          <creation_ts>2013-03-06 15:46:30 -0800</creation_ts>
          <short_desc>RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?)</short_desc>
          <delta_ts>2026-10-15 10:07:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>246065</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>276855</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Christian Biesinger">cbiesinger</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fred.wang</cc>
    
    <cc>hyatt</cc>
    
    <cc>jer.noble</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>849382</commentid>
    <comment_count>0</comment_count>
    <who name="Christian Biesinger">cbiesinger</who>
    <bug_when>2013-03-06 15:46:30 -0800</bug_when>
    <thetext>http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFullScreen.cpp?rev=HEAD#L154

The code here looks like:
154	        while ((child = firstChild())) {
155	            child-&gt;remove();
156	            parent()-&gt;addChild(child, this);
157	            parent()-&gt;setNeedsLayoutAndPrefWidthsRecalc();
158	        }

It seems to me like setNeedsLayoutAndPrefWidthsRecalc() should be called on the child (which then would recurse through the parents).

hyatt, does that seem plausible? At least, if it is right to call it on the parent, it should be outside the loop.

(I don&apos;t have a testcase either way, we found this by code inspection)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2263096</commentid>
    <comment_count>1</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2026-10-13 01:46:03 -0700</bug_when>
    <thetext>RenderFullScreen was removed in https://commits.webkit.org/255641@main

*** This bug has been marked as a duplicate of bug 246065 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>