111565 2013-03-06 05:27:31 -0800 [V8] REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding.cpp) 2013-03-06 06:32:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110875 1 marja marja dcarney haraken webkit.review.bot oldest_to_newest 848742 0 marja 2013-03-06 05:27:31 -0800 The patch in bug 110875 wasn't quite right. This should fix it. 848744 1 191726 marja 2013-03-06 05:28:21 -0800 Created attachment 191726 Patch 848747 2 191726 haraken 2013-03-06 05:30:52 -0800 Comment on attachment 191726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191726&action=review The change looks reasonable. > Source/WebCore/ChangeLog:3 > + Follow up-fixes to bug 110875 It's good to mention that this is a follow-up fix for the bug, but please add a more descriptive title. Some people in WebKit are scanning all titles. > Source/WebCore/ChangeLog:7 > + Ditto. Please explain the rationale for the change. 848753 3 191726 jochen 2013-03-06 05:35:39 -0800 Comment on attachment 191726 Patch ok. please modify the changelog as kentaro requested 848766 4 191734 marja 2013-03-06 05:46:55 -0800 Created attachment 191734 Patch 848767 5 191734 haraken 2013-03-06 05:47:32 -0800 Comment on attachment 191734 Patch Thanks! 848805 6 191734 webkit.review.bot 2013-03-06 06:32:46 -0800 Comment on attachment 191734 Patch Clearing flags on attachment: 191734 Committed r144919: <http://trac.webkit.org/changeset/144919> 848806 7 webkit.review.bot 2013-03-06 06:32:49 -0800 All reviewed patches have been landed. Closing bug. 191726 2013-03-06 05:28:21 -0800 2013-03-06 05:46:53 -0800 Patch bug-111565-20130306142427.patch text/plain 1489 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmYwOGJmOWE2NDRiYzk4 OTIxYjc5M2UxY2Q2OTQ0N2YyYjVjZWIwNy4uNThjOGQzMjdmYTIyMjdiYmJhN2RhYzg3Zjg5MmQ2 NGE1MTVlNjEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTA2ICBNYXJq YSBIw7ZsdHTDpCAgPG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBGb2xsb3cgdXAtZml4 ZXMgdG8gYnVnIDExMDg3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTExNTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIChubyBmdW5jdGlvbmFsaXR5IGNoYW5nZXMgeWV0KS4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0 b0RPTVdpbmRvdyk6CisKIDIwMTMtMDMtMDUgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBBZGQgdGhlIGdldFN0cmVhbUJ5 SWQgbWV0aG9kIG9uIFJUQ1BlZXJDb25uZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhCaW5kaW5nLmNwcAppbmRleCA5MjRjNzgwNDExMTVhYmZjMmRhZDRiNzVmZDJiYzkxNjY2MjNj OWZmLi5iNjIyMmNiZWU4YTgyODVmNWQyZGM4ZTU2NjU2NjM1YzBmY2Q5YzFhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKQEAgLTIyNCw2ICsyMjQsNyBAQCBET01X aW5kb3cqIHRvRE9NV2luZG93KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQpCiAgICAg Z2xvYmFsID0gZ2xvYmFsLT5GaW5kSW5zdGFuY2VJblByb3RvdHlwZUNoYWluKFY4RE9NV2luZG93 OjpHZXRUZW1wbGF0ZShjb250ZXh0LT5HZXRJc29sYXRlKCksIE1haW5Xb3JsZCkpOwogICAgIGlm ICghZ2xvYmFsLklzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIFY4RE9NV2luZG93Ojp0b05hdGl2 ZShnbG9iYWwpOworICAgIGdsb2JhbCA9IGNvbnRleHQtPkdsb2JhbCgpOwogICAgIGdsb2JhbCA9 IGdsb2JhbC0+RmluZEluc3RhbmNlSW5Qcm90b3R5cGVDaGFpbihWOERPTVdpbmRvdzo6R2V0VGVt cGxhdGUoY29udGV4dC0+R2V0SXNvbGF0ZSgpLCBJc29sYXRlZFdvcmxkKSk7CiAgICAgQVNTRVJU KCFnbG9iYWwuSXNFbXB0eSgpKTsKICAgICByZXR1cm4gVjhET01XaW5kb3c6OnRvTmF0aXZlKGds b2JhbCk7Cg== 191734 2013-03-06 05:46:55 -0800 2013-03-06 06:32:46 -0800 Patch bug-111565-20130306144301.patch text/plain 2225 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmYwOGJmOWE2NDRiYzk4 OTIxYjc5M2UxY2Q2OTQ0N2YyYjVjZWIwNy4uZGUwZjcyY2ZiYzE1NGQ2MjVjODg0YWE4ZmYxY2My YWRjMjUyYTFjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA2ICBNYXJq YSBIw7ZsdHTDpCAgPG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIx NDQ2MTcpOiBXcm9uZyB1c2FnZSBvZiBvdmVyd3JpdHRlbiB2YXJpYWJsZSBpbiB0b0RPTVdpbmRv dyAoVjhCaW5kaW5nLmNwcCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTU2NQorCisgICAgICAgIFJldmlld2VkIGJ5IEpvY2hlbiBFaXNpbmdlci4K KworICAgICAgICBJbiB0b0RPTVdpbmRvdywgdGhlIHZhcmlhYmxlICJnbG9iYWwiIHdhcyBmaXJz dCBudWtlZCwgYW5kIHRoZW4gdXNlZCBhZ2Fpbi4gVGhpcworICAgICAgICBjaGFuZ2Ugd2FzIGlu dHJvZHVjZWQgaW4gcjE0NDYxNy4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5vIGZ1bmN0aW9u YWwgY2hhbmdlcykuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6dG9ET01XaW5kb3cpOgorCiAyMDEzLTAzLTA1ICBUb21teSBXaWRlbmZs eWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogQWRk IHRoZSBnZXRTdHJlYW1CeUlkIG1ldGhvZCBvbiBSVENQZWVyQ29ubmVjdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKaW5kZXggOTI0Yzc4MDQxMTE1YWJmYzJkYWQ0 Yjc1ZmQyYmM5MTY2NjIzYzlmZi4uYzUwNTNiYTljYzlmYzVlYjNkZTdjNmFjODcxOWZhNGYxY2Ey NTdiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCkBAIC0yMjEs MTIgKzIyMSwxMiBAQCBET01XaW5kb3cqIHRvRE9NV2luZG93KHY4OjpIYW5kbGU8djg6OkNvbnRl eHQ+IGNvbnRleHQpCiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnbG9iYWwgPSBjb250 ZXh0LT5HbG9iYWwoKTsKICAgICBBU1NFUlQoIWdsb2JhbC5Jc0VtcHR5KCkpOwotICAgIGdsb2Jh bCA9IGdsb2JhbC0+RmluZEluc3RhbmNlSW5Qcm90b3R5cGVDaGFpbihWOERPTVdpbmRvdzo6R2V0 VGVtcGxhdGUoY29udGV4dC0+R2V0SXNvbGF0ZSgpLCBNYWluV29ybGQpKTsKLSAgICBpZiAoIWds b2JhbC5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiBWOERPTVdpbmRvdzo6dG9OYXRpdmUoZ2xv YmFsKTsKLSAgICBnbG9iYWwgPSBnbG9iYWwtPkZpbmRJbnN0YW5jZUluUHJvdG90eXBlQ2hhaW4o VjhET01XaW5kb3c6OkdldFRlbXBsYXRlKGNvbnRleHQtPkdldElzb2xhdGUoKSwgSXNvbGF0ZWRX b3JsZCkpOwotICAgIEFTU0VSVCghZ2xvYmFsLklzRW1wdHkoKSk7Ci0gICAgcmV0dXJuIFY4RE9N V2luZG93Ojp0b05hdGl2ZShnbG9iYWwpOworICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd2lu ZG93ID0gZ2xvYmFsLT5GaW5kSW5zdGFuY2VJblByb3RvdHlwZUNoYWluKFY4RE9NV2luZG93OjpH ZXRUZW1wbGF0ZShjb250ZXh0LT5HZXRJc29sYXRlKCksIE1haW5Xb3JsZCkpOworICAgIGlmICgh d2luZG93LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIFY4RE9NV2luZG93Ojp0b05hdGl2ZSh3 aW5kb3cpOworICAgIHdpbmRvdyA9IGdsb2JhbC0+RmluZEluc3RhbmNlSW5Qcm90b3R5cGVDaGFp bihWOERPTVdpbmRvdzo6R2V0VGVtcGxhdGUoY29udGV4dC0+R2V0SXNvbGF0ZSgpLCBJc29sYXRl ZFdvcmxkKSk7CisgICAgQVNTRVJUKCF3aW5kb3cuSXNFbXB0eSgpKTsKKyAgICByZXR1cm4gVjhE T01XaW5kb3c6OnRvTmF0aXZlKHdpbmRvdyk7CiB9CiAKIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IHRvU2NyaXB0RXhlY3V0aW9uQ29udGV4dCh2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0 KQo=