111436 2013-03-05 06:48:32 -0800 Fix cast-align warning in ASCIIFastPath.h on ARM 2013-03-05 13:43:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy benjamin cmarcelo darin loki ojan.autocc ossy webkit.review.bot zherczeg oldest_to_newest 847633 0 ossy 2013-03-05 06:48:32 -0800 ASCIIFastPath.h introduced in https://trac.webkit.org/changeset/104127 , but on ARM we get zillion warning from it: /home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/ASCIIFastPath.h: In instantiation of 'bool WTF::charactersAreAllASCII(const CharacterType*, size_t) [with CharacterType = short unsigned int; size_t = unsigned int]': /home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/WTFString.h:606:66: required from here /home/webkitbuildbot/oszi/WebKitNix/Source/WTF/wtf/text/ASCIIFastPath.h:88:9: warning: cast from 'const short unsigned int*' to 'const MachineWord* {aka const unsigned int*}' increases required alignment of target type [-Wcast-align] This cast is safe, because the adress is aligned here. Patch is coming soon. ( Similar fixes: - https://trac.webkit.org/changeset/67028 - https://trac.webkit.org/changeset/64302 ) 847636 1 191489 ossy 2013-03-05 06:50:16 -0800 Created attachment 191489 Patch 848025 2 191489 webkit.review.bot 2013-03-05 13:43:28 -0800 Comment on attachment 191489 Patch Clearing flags on attachment: 191489 Committed r144811: <http://trac.webkit.org/changeset/144811> 848026 3 webkit.review.bot 2013-03-05 13:43:31 -0800 All reviewed patches have been landed. Closing bug. 191489 2013-03-05 06:50:16 -0800 2013-03-05 13:43:28 -0800 Patch bug-111436-20130305154655.patch text/plain 1567 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZiYzFhMzI4NjI4OTJjZDFkNmMxZDYz Y2Q2OGNkODA5NzhhMjg2ZGMuLjUxZDBlN2VkYWVmNjQyNTcxNWM4NDcwZTY1ZDYwMzc3NDhjNjE1 NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDMtMDUgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggY2FzdC1hbGlnbiB3YXJuaW5nIGluIEFT Q0lJRmFzdFBhdGguaCBvbiBBUk0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTQzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd3RmL3RleHQvQVNDSUlGYXN0UGF0aC5oOgorICAgICAgICAoV1RGOjpj aGFyYWN0ZXJzQXJlQWxsQVNDSUkpOgorCiAyMDEzLTAzLTA0ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgSlNDX09CSkNfQVBJX0VOQUJMRUQgc2hvdWxk IGJlIHJlbW92ZWQgZnJvbSBGZWF0dXJlRGVmaW5lcy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi90ZXh0L0FTQ0lJRmFzdFBhdGguaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQVNDSUlGYXN0 UGF0aC5oCmluZGV4IDc5Y2E1YTc5YjRlZjQ4N2FhNjc5Y2ZjYTUzZDJkYWVjZmZkYTljNDUuLmUy NjZhZmQxZTMwNjBjZDUxZTNhYTdiMWFjMTU5NTg1ZmUyYzhmNGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL3RleHQvQVNDSUlGYXN0UGF0aC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQv QVNDSUlGYXN0UGF0aC5oCkBAIC0yNyw2ICsyNyw3IEBACiAjZW5kaWYKICNpbmNsdWRlIDxzdGRp bnQuaD4KICNpbmNsdWRlIDx3dGYvQWxpZ25tZW50Lmg+CisjaW5jbHVkZSA8d3RmL1N0ZExpYkV4 dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL1VuaWNvZGUuaD4KIAogbmFtZXNwYWNlIFdU RiB7CkBAIC04NSw3ICs4Niw3IEBAIGlubGluZSBib29sIGNoYXJhY3RlcnNBcmVBbGxBU0NJSShj b25zdCBDaGFyYWN0ZXJUeXBlKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoCiAgICAgY29uc3Qg Q2hhcmFjdGVyVHlwZSogd29yZEVuZCA9IGFsaWduVG9NYWNoaW5lV29yZChlbmQpOwogICAgIGNv bnN0IHNpemVfdCBsb29wSW5jcmVtZW50ID0gc2l6ZW9mKE1hY2hpbmVXb3JkKSAvIHNpemVvZihD aGFyYWN0ZXJUeXBlKTsKICAgICB3aGlsZSAoY2hhcmFjdGVycyA8IHdvcmRFbmQpIHsKLSAgICAg ICAgYWxsQ2hhckJpdHMgfD0gKihyZWludGVycHJldF9jYXN0PGNvbnN0IE1hY2hpbmVXb3JkKj4o Y2hhcmFjdGVycykpOworICAgICAgICBhbGxDaGFyQml0cyB8PSAqKHJlaW50ZXJwcmV0X2Nhc3Rf cHRyPGNvbnN0IE1hY2hpbmVXb3JkKj4oY2hhcmFjdGVycykpOwogICAgICAgICBjaGFyYWN0ZXJz ICs9IGxvb3BJbmNyZW1lbnQ7CiAgICAgfQogCg==