111433 2013-03-05 06:36:13 -0800 Fix unused parameter warnings in ARM assembler 2013-03-06 09:41:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy haraken ossy webkit.review.bot zherczeg oldest_to_newest 847621 0 ossy 2013-03-05 06:36:13 -0800 SSIA. Patch is coming soon. 847625 1 191486 ossy 2013-03-05 06:39:34 -0800 Created attachment 191486 Patch 848292 2 191486 haraken 2013-03-05 17:18:43 -0800 Comment on attachment 191486 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191486&action=review > Source/JavaScriptCore/assembler/ARMAssembler.h:407 > static void revertJump(void* instructionStart, RegisterID rd, ARMWord imm) > { > + UNUSED_PARAM(rd); You can remove the parameter name if there is no confusion. If the parameter name is needed for clarity, you can comment the parameter name. We use UNUSED_PARAM() only in an #if block. c.f. http://markmail.org/message/jv3ncbuhropkkzoq 848915 3 191763 ossy 2013-03-06 09:09:02 -0800 Created attachment 191763 Patch 848919 4 ossy 2013-03-06 09:11:08 -0800 (In reply to comment #2) > You can remove the parameter name if there is no confusion. If the parameter name is needed for clarity, you can comment the parameter name. We use UNUSED_PARAM() only in an #if block. > > c.f. http://markmail.org/message/jv3ncbuhropkkzoq Good point, I didn't remember this mail thread. But now I fixed the patch, remove the first function which is unreachable and changed one more older, but incorrect use of UNUSED_PARAM. 848960 5 191763 webkit.review.bot 2013-03-06 09:41:39 -0800 Comment on attachment 191763 Patch Clearing flags on attachment: 191763 Committed r144938: <http://trac.webkit.org/changeset/144938> 848961 6 webkit.review.bot 2013-03-06 09:41:42 -0800 All reviewed patches have been landed. Closing bug. 191486 2013-03-05 06:39:34 -0800 2013-03-06 09:08:58 -0800 Patch bug-111433-20130305153613.patch text/plain 2508 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YTg3NDQwZDBkMDUxNzFhZTdlNTc1MjdjNzYwMWI0N2FiZjE3NmJkLi40MzZlMjY5MWZkNGU2OTlh MWU5ZWViZmM4MDIzOWY2YzgyMzFlMjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wMy0wNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIEFSTSBhc3Nl bWJsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTQzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OnJl dmVydEp1bXApOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oOgorICAg ICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNoQ29udmVydERvdWJsZVRvSW50MzIp OgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6cmV2ZXJ0SnVtcFJlcGxhY2VtZW50 VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2gpOgorCiAyMDEzLTAzLTA0ICBBbmRyZWFzIEts aW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnVzZWQgU3RydWN0dXJlIHByb3Bl cnR5IHRhYmxlcyB3YXN0ZSAxNE1CIG9uIE1lbWJ1c3Rlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCmluZGV4IDg4NGUwY2QzNDhmMDQzYmYwMWYy NTg3YjdjZjkwODU0YWYwNzMxOTAuLmY0NTQyYWIxZWRlNGFjZTRhNjJkMDQwNjQ5MWM3ODFlZGMw NjcxNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNz ZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJs ZXIuaApAQCAtNDA0LDYgKzQwNCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIHN0YXRp YyB2b2lkIHJldmVydEp1bXAodm9pZCogaW5zdHJ1Y3Rpb25TdGFydCwgUmVnaXN0ZXJJRCByZCwg QVJNV29yZCBpbW0pCiAgICAgICAgIHsKKyAgICAgICAgICAgIFVOVVNFRF9QQVJBTShyZCk7CiAg ICAgICAgICAgICBBUk1Xb3JkKiBpbnNuID0gcmVpbnRlcnByZXRfY2FzdDxBUk1Xb3JkKj4oaW5z dHJ1Y3Rpb25TdGFydCk7CiAgICAgICAgICAgICBBUk1Xb3JkKiBhZGRyZXNzID0gZ2V0TGRySW1t QWRkcmVzcyhpbnNuKTsKICAgICAgICAgICAgICphZGRyZXNzID0gaW1tOwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCmluZGV4IDU4 YWFkNTkxMDFhZDI4MjQ2NDEzYTUyODc2MGVmODQ3MTNkZGY2MDIuLjRkN2IzZDQyODRhOTA2MjY2 YzhhZjQ4YTlhNGY2MGI3MjYwMjA2YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTEyNDQsNiArMTI0NCw3IEBAIHB1 YmxpYzoKICAgICAvLyAoc3BlY2lmaWNhbGx5LCBpbiB0aGlzIGNhc2UsIDApLgogICAgIHZvaWQg YnJhbmNoQ29udmVydERvdWJsZVRvSW50MzIoRlBSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBk ZXN0LCBKdW1wTGlzdCYgZmFpbHVyZUNhc2VzLCBGUFJlZ2lzdGVySUQgZnBUZW1wKQogICAgIHsK KyAgICAgICAgVU5VU0VEX1BBUkFNKGZwVGVtcCk7CiAgICAgICAgIG1fYXNzZW1ibGVyLnZjdnRf czMyX2Y2NChBUk1SZWdpc3RlcnM6OlNEMCA8PCAxLCBzcmMpOwogICAgICAgICBtX2Fzc2VtYmxl ci52bW92X2FybTMyKGRlc3QsIEFSTVJlZ2lzdGVyczo6U0QwIDw8IDEpOwogCkBAIC0xMzE3LDYg KzEzMTgsOCBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgdm9pZCByZXZlcnRKdW1wUmVwbGFjZW1l bnRUb1BhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaChDb2RlTG9jYXRpb25MYWJlbCBpbnN0cnVj dGlvblN0YXJ0LCBBZGRyZXNzLCB2b2lkKiBpbml0aWFsVmFsdWUpCiAgICAgeworICAgICAgICBV TlVTRURfUEFSQU0oaW5zdHJ1Y3Rpb25TdGFydCk7CisgICAgICAgIFVOVVNFRF9QQVJBTShpbml0 aWFsVmFsdWUpOwogICAgICAgICBVTlJFQUNIQUJMRV9GT1JfUExBVEZPUk0oKTsKICAgICB9CiAK 191763 2013-03-06 09:09:02 -0800 2013-03-06 09:41:39 -0800 Patch bug-111433-20130306180541.patch text/plain 3678 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NTk1ZDQ5MWQ4MjQ3YWM5Nzc3ZmJiMzkzYWEyZDAwYzNmYTkyYTkyLi41ZmU5NGYxYjk5MmVmNmY1 NWRlODk4MThkZWZmMjgwYjZiZGNkMjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wMy0wNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIEFSTSBhc3Nl bWJsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTQzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oOiBSZW1vdmUgdW5yZWFjaGFibGUgcmV2ZXJ0SnVtcCgp IGFmdGVyIHIxNDMzNDYuCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjptb3ZlSW50c1RvRG91YmxlKTogUmVt b3ZlIHVudXNlZCBzY3JhdGNoIHBhcmFtZXRlciBpbnN0ZWFkIG9mIFVOVVNFRF9QQVJBTS4KKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmJyYW5jaENvbnZlcnREb3VibGVUb0ludDMy KTogUmVtb3ZlIHVudXNlZCBmcFRlbXAgcGFyYW1ldGVyLgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlckFSTTo6cmV2ZXJ0SnVtcFJlcGxhY2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRo UGF0Y2gpOiBSZW1vdmUgdW51c2VkIHBhcmFtZXRlcnMuCisKIDIwMTMtMDMtMDYgIEFuZHJlYXMg S2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVudXNlZCBTdHJ1Y3R1cmUgcHJv cGVydHkgdGFibGVzIHdhc3RlIDE0TUIgb24gTWVtYnVzdGVyLgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKaW5kZXggODg0ZTBjZDM0OGYwNDNiZjAx ZjI1ODdiN2NmOTA4NTRhZjA3MzE5MC4uMThiMTAxNzljMTdhMDgxZjYwYTU0NzBlYzQ0MDQ4Mjkw ZGUwODViNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1B c3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2Vt Ymxlci5oCkBAIC00MDIsMTMgKzQwMiw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAg ZW1pdEluc3RydWN0aW9uKHRvQVJNV29yZChjYykgfCBNT1YgfCBTZXRDb25kaXRpb25hbENvZGVz LCByZCwgQVJNUmVnaXN0ZXJzOjpyMCwgb3AyKTsKICAgICAgICAgfQogCi0gICAgICAgIHN0YXRp YyB2b2lkIHJldmVydEp1bXAodm9pZCogaW5zdHJ1Y3Rpb25TdGFydCwgUmVnaXN0ZXJJRCByZCwg QVJNV29yZCBpbW0pCi0gICAgICAgIHsKLSAgICAgICAgICAgIEFSTVdvcmQqIGluc24gPSByZWlu dGVycHJldF9jYXN0PEFSTVdvcmQqPihpbnN0cnVjdGlvblN0YXJ0KTsKLSAgICAgICAgICAgIEFS TVdvcmQqIGFkZHJlc3MgPSBnZXRMZHJJbW1BZGRyZXNzKGluc24pOwotICAgICAgICAgICAgKmFk ZHJlc3MgPSBpbW07Ci0gICAgICAgIH0KLQogICAgICAgICB2b2lkIGJpYyhpbnQgcmQsIGludCBy biwgQVJNV29yZCBvcDIsIENvbmRpdGlvbiBjYyA9IEFMKQogICAgICAgICB7CiAgICAgICAgICAg ICBlbWl0SW5zdHJ1Y3Rpb24odG9BUk1Xb3JkKGNjKSB8IEJJQywgcmQsIHJuLCBvcDIpOwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5o CmluZGV4IDU4YWFkNTkxMDFhZDI4MjQ2NDEzYTUyODc2MGVmODQ3MTNkZGY2MDIuLmRiNWY0YTUz ZWJjNTQzNjc1NTU1MTcwMzQxZGE0MDk3MTBlZmJiMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTY3Myw5ICs2NzMs OCBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLnZtb3YoZGVzdDEsIGRlc3QyLCBzcmMp OwogICAgIH0KIAotICAgIHZvaWQgbW92ZUludHNUb0RvdWJsZShSZWdpc3RlcklEIHNyYzEsIFJl Z2lzdGVySUQgc3JjMiwgRlBSZWdpc3RlcklEIGRlc3QsIEZQUmVnaXN0ZXJJRCBzY3JhdGNoKQor ICAgIHZvaWQgbW92ZUludHNUb0RvdWJsZShSZWdpc3RlcklEIHNyYzEsIFJlZ2lzdGVySUQgc3Jj MiwgRlBSZWdpc3RlcklEIGRlc3QsIEZQUmVnaXN0ZXJJRCkKICAgICB7Ci0gICAgICAgIFVOVVNF RF9QQVJBTShzY3JhdGNoKTsKICAgICAgICAgbV9hc3NlbWJsZXIudm1vdihkZXN0LCBzcmMxLCBz cmMyKTsKICAgICB9CiAKQEAgLTEyNDIsNyArMTI0MSw3IEBAIHB1YmxpYzoKICAgICAvLyBJZiB0 aGUgcmVzdWx0IGlzIG5vdCByZXByZXNlbnRhYmxlIGFzIGEgMzIgYml0IHZhbHVlLCBicmFuY2gu CiAgICAgLy8gTWF5IGFsc28gYnJhbmNoIGZvciBzb21lIHZhbHVlcyB0aGF0IGFyZSByZXByZXNl bnRhYmxlIGluIDMyIGJpdHMKICAgICAvLyAoc3BlY2lmaWNhbGx5LCBpbiB0aGlzIGNhc2UsIDAp LgotICAgIHZvaWQgYnJhbmNoQ29udmVydERvdWJsZVRvSW50MzIoRlBSZWdpc3RlcklEIHNyYywg UmVnaXN0ZXJJRCBkZXN0LCBKdW1wTGlzdCYgZmFpbHVyZUNhc2VzLCBGUFJlZ2lzdGVySUQgZnBU ZW1wKQorICAgIHZvaWQgYnJhbmNoQ29udmVydERvdWJsZVRvSW50MzIoRlBSZWdpc3RlcklEIHNy YywgUmVnaXN0ZXJJRCBkZXN0LCBKdW1wTGlzdCYgZmFpbHVyZUNhc2VzLCBGUFJlZ2lzdGVySUQp CiAgICAgewogICAgICAgICBtX2Fzc2VtYmxlci52Y3Z0X3MzMl9mNjQoQVJNUmVnaXN0ZXJzOjpT RDAgPDwgMSwgc3JjKTsKICAgICAgICAgbV9hc3NlbWJsZXIudm1vdl9hcm0zMihkZXN0LCBBUk1S ZWdpc3RlcnM6OlNEMCA8PCAxKTsKQEAgLTEzMTUsNyArMTMxNCw3IEBAIHB1YmxpYzoKICAgICAg ICAgQVJNQXNzZW1ibGVyOjpyZXZlcnRCcmFuY2hQdHJXaXRoUGF0Y2goaW5zdHJ1Y3Rpb25TdGFy dC5kYXRhTG9jYXRpb24oKSwgcmVnLCByZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oaW5pdGlh bFZhbHVlKSAmIDB4ZmZmZik7CiAgICAgfQogCi0gICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVtcFJl cGxhY2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2goQ29kZUxvY2F0aW9uTGFiZWwg aW5zdHJ1Y3Rpb25TdGFydCwgQWRkcmVzcywgdm9pZCogaW5pdGlhbFZhbHVlKQorICAgIHN0YXRp YyB2b2lkIHJldmVydEp1bXBSZXBsYWNlbWVudFRvUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNo KENvZGVMb2NhdGlvbkxhYmVsLCBBZGRyZXNzLCB2b2lkKikKICAgICB7CiAgICAgICAgIFVOUkVB Q0hBQkxFX0ZPUl9QTEFURk9STSgpOwogICAgIH0K