111384 2013-03-04 16:53:43 -0800 run-webkit-tests should support --profile and --profiler= just like run-perf-tests does 2013-03-04 21:57:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth dpranke rniwa webkit.review.bot oldest_to_newest 847034 0 eric 2013-03-04 16:53:43 -0800 run-webkit-tests should support --profile and --profiler= just like run-perf-tests does 847035 1 191355 eric 2013-03-04 16:55:13 -0800 Created attachment 191355 Patch 847043 2 191355 dpranke 2013-03-04 16:58:33 -0800 Comment on attachment 191355 Patch I wonder if it makes sense to split out some of the options into a separate group if they are shared between layout tests and perf tests (much like we have configuration_options and platform_options)? 847048 3 eric 2013-03-04 17:00:50 -0800 Long ago I had a dream of moving NRWT's options down onto the objects which they applied to. In this case, these could move onto Driver or Port. webkit-patch does similar with its "steps" abstraction. So yes, I believe moving things like this to shared locations is good. :) 847261 4 191355 webkit.review.bot 2013-03-04 21:57:11 -0800 Comment on attachment 191355 Patch Clearing flags on attachment: 191355 Committed r144719: <http://trac.webkit.org/changeset/144719> 847262 5 webkit.review.bot 2013-03-04 21:57:14 -0800 All reviewed patches have been landed. Closing bug. 191355 2013-03-04 16:55:13 -0800 2013-03-04 21:57:11 -0800 Patch bug-111384-20130304165120.patch text/plain 2048 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3NThkM2JkNzE1MTk4YTQ3MDJhYWRkMDQwMTAwYzAw Yzk0N2QxOC4uN2Q2ZGFkOTE2YmIzZWJjOTUzNzdlYjVjZTc2MzQxNGNiNzk0ZWZiYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEzLTAzLTA0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBydW4td2Via2l0LXRlc3RzIHNob3VsZCBzdXBwb3J0IC0tcHJvZmlsZSBhbmQgLS1wcm9maWxl cj0ganVzdCBsaWtlIHJ1bi1wZXJmLXRlc3RzIGRvZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTM4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWV0aW1lcyBJIHdhbnQgdG8ga25vdyB3aHkgdmFy aW91cyBMYXlvdXRUZXN0cyBhcmUgc2xvdworICAgICAgICB3aXRob3V0IGhhdmluZyB0byBjb252 ZXJ0IHRoZW0gaW50byBQZXJmb3JtYW5jZVRlc3RzIGluIG9yZGVyCisgICAgICAgIHRvIHVzZSBv dXIgZmFuY3kgcHJvZmlsaW5nLiAgVGhlIERyaXZlciBhbHJlYWR5IGtub3dzIGhvdyB0bworICAg ICAgICBkbyB0aGUgcmlnaHQgdGhpbmcsIHdlIGp1c3QgbmVlZCB0byBleHBvc2UgdGhlIG9wdGlv bnMgdG8gdGhlIHVzZXIuCisKKyAgICAgICAgSGFuZGxpbmcgb2YgdGhlc2Ugb3B0aW9ucyBpcyBh bHJlYWR5IHVuaXR0ZXN0ZWQgaW4gdGhlIHBlcmZ0ZXN0c191bml0dGVzdC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAg ICAgIChwYXJzZV9hcmdzKToKKwogMjAxMy0wMy0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXph Y2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBVcHN0cmVhbSBpT1MgQWNjZXNzaWJpbGl0eSBE dW1wUmVuZGVyVHJlZSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA0MGY3ZDZjZjA4ZmMxZDA1 MDg4Y2RlYjkyNGI0OGY1OTRhMTJkNzIzLi5iMjExYjk3ZjI4YjM0MjdjYjIyNzY5YjEwYzA0ZDJj NmRlZDEwZGZiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTI3Miw2ICsyNzIsMTAgQEAgZGVmIHBhcnNl X2FyZ3MoYXJncyk6CiAgICAgICAgICAgICBoZWxwPSJTZXQgdGhlIG1heGltdW0gbnVtYmVyIG9m IGxvY2tlZCBzaGFyZHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYWRkaXRp b25hbC1lbnYtdmFyIiwgdHlwZT0ic3RyaW5nIiwgYWN0aW9uPSJhcHBlbmQiLCBkZWZhdWx0PVtd LAogICAgICAgICAgICAgaGVscD0iUGFzc2VzIHRoYXQgZW52aXJvbm1lbnQgdmFyaWFibGUgdG8g dGhlIHRlc3RzICgtLWFkZGl0aW9uYWwtZW52LXZhcj1OQU1FPVZBTFVFKSIpLAorICAgICAgICBv cHRwYXJzZS5tYWtlX29wdGlvbigiLS1wcm9maWxlIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKKyAg ICAgICAgICAgIGhlbHA9Ik91dHB1dCBwZXItdGVzdCBwcm9maWxlIGluZm9ybWF0aW9uLiIpLAor ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1wcm9maWxlciIsIGFjdGlvbj0ic3RvcmUi LAorICAgICAgICAgICAgaGVscD0iT3V0cHV0IHBlci10ZXN0IHByb2ZpbGUgaW5mb3JtYXRpb24s IHVzaW5nIHRoZSBzcGVjaWZpZWQgcHJvZmlsZXIuIiksCiAgICAgXSkpCiAKICAgICBvcHRpb25f Z3JvdXBfZGVmaW5pdGlvbnMuYXBwZW5kKCgiTWlzY2VsbGFuZW91cyBPcHRpb25zIiwgWwo=