111291 2013-03-04 00:59:28 -0800 [EFL] Build fix when compiling with GLES2 support enabled. 2013-03-04 05:09:56 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 105659 1 kalyan.kondapally kalyan.kondapally cmarcelo dino kenneth lucas.de.marchi luiz noam webkit.review.bot oldest_to_newest 846203 0 kalyan.kondapally 2013-03-04 00:59:28 -0800 Some changes are needed to be able to build successfully with EGL+GLES2 enabled. 1)Add support for GLES2 in SnapShotImageGL. 2)Remove the workarounds in place for EGL support with GLX as the main target for EGL is with GLES2. 3)Add platform checks in TextureMapper and OpenGLESShims.h This patch targets 2 and 3. 1 would be handled in a separate bug. 846251 1 191179 kalyan.kondapally 2013-03-04 02:14:51 -0800 Created attachment 191179 patch 846260 2 191179 kenneth 2013-03-04 02:30:29 -0800 Comment on attachment 191179 patch View in context: https://bugs.webkit.org/attachment.cgi?id=191179&action=review > Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:-41 > -#if HAVE(GLX) > -#include <GL/glx.h> > -#endif so I assume this was an evas specific work around? maybe clearify that in the changelog 846316 3 191196 kalyan.kondapally 2013-03-04 03:48:47 -0800 Created attachment 191196 patchv2 846317 4 kalyan.kondapally 2013-03-04 03:49:14 -0800 (In reply to comment #2) > (From update of attachment 191179 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191179&action=review > > so I assume this was an evas specific work around? maybe clearify that in the changelog done 846343 5 191196 webkit.review.bot 2013-03-04 05:09:52 -0800 Comment on attachment 191196 patchv2 Clearing flags on attachment: 191196 Committed r144620: <http://trac.webkit.org/changeset/144620> 846344 6 webkit.review.bot 2013-03-04 05:09:56 -0800 All reviewed patches have been landed. Closing bug. 191179 2013-03-04 02:14:51 -0800 2013-03-04 03:48:47 -0800 patch glesbuildfix2.patch text/plain 2879 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDc0YjQ4ZjYuLjk1ODJmOTggMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEz LTAzLTA0ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBCdWlsZCBmaXggd2hlbiBjb21waWxpbmcgd2l0aCBHTEVTMiBzdXBw b3J0IGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTEyOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHBhdGNoIGZpeGVzIGJ1aWxkIGlzc3VlcyB3aGVuIGNvbXBpbGluZyB3aXRoIEdM RVMyCisgICAgICAgIHN1cHBvcnQuIEFzIHBhcnQgb2YgdGhlIGZpeCB0aGUgcGF0Y2ggcmVtb3Zl cyBFdmFzIHNwZWNpZmljCisgICAgICAgIHdvcmthcm91bmQgaW4gUGxhdGZvcm1Db250ZXh0IGFz IEdMRVMyIGlzIHRoZSBtYWluIHRhcmdldCB3aXRoIEVHTC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL09wZW5HTEVTU2hpbXMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xDdXJyZW50 Q29udGV4dFdyYXBwZXI6OkdMQ3VycmVudENvbnRleHRXcmFwcGVyKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oOgorCiAyMDEzLTAzLTAzICBLb25k YXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAogICAgICAgICBb RUZMXVtXZWJHTF0gQWRkIHByb3BlciBjaGVja3MgdG8gZW5hYmxlIEdyYXBoaWNzU3VyZmFjZSB1 c2FnZSBvbiBFR0wgd2l0aG91dCBYQ29tcG9zaXRlV2luZG93LgpkaWZmIC0tZ2l0IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL09wZW5HTEVTU2hpbXMuaCBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9PcGVuR0xFU1NoaW1zLmgKaW5kZXggYmNhZjg1NS4uNGJiNWI1OSAx MDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL09wZW5HTEVTU2hpbXMu aAorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMRVNTaGltcy5oCkBA IC0yNiw3ICsyNiw3IEBACiAjaWZuZGVmIE9wZW5HTEVTU2hpbXNfaAogI2RlZmluZSBPcGVuR0xF U1NoaW1zX2gKIAotI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpIHx8IFBMQVRGT1JNKFFUKSB8fCBQ TEFURk9STShHVEspCisjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkgfHwgUExBVEZPUk0oUVQpIHx8 IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZMKQogI2RlZmluZSBnbEJpbmRGcmFtZWJ1ZmZl ckVYVCBnbEJpbmRGcmFtZWJ1ZmZlcgogI2RlZmluZSBnbEZyYW1lYnVmZmVyVGV4dHVyZTJERVhU IGdsRnJhbWVidWZmZXJUZXh0dXJlMkQKICNkZWZpbmUgZ2xCaW5kUmVuZGVyYnVmZmVyRVhUIGds QmluZFJlbmRlcmJ1ZmZlcgpkaWZmIC0tZ2l0IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HTFBsYXRmb3JtQ29udGV4dC5jcHAgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1Db250ZXh0LmNwcAppbmRleCBjZWQ3YmI4Li5iY2Uw NDI1IDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dM UGxhdGZvcm1Db250ZXh0LmNwcAorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dMUGxhdGZvcm1Db250ZXh0LmNwcApAQCAtMzYsMTAgKzM2LDYgQEAKIAogI2luY2x1 ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAKLSNpZiBIQVZFKEdMWCkKLSNpbmNsdWRlIDxHTC9nbHgu aD4KLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICNpZiBVU0UoT1BFTkdMX0VTXzIp CkBAIC01NSw4ICs1MSw3IEBAIHB1YmxpYzoKICAgICBHTEN1cnJlbnRDb250ZXh0V3JhcHBlcigp CiAgICAgICAgIDogR0xQbGF0Zm9ybUNvbnRleHQoKQogICAgIHsKLSAgICAgICAgLy8gRklYTUU6 OiBUaGlzIGlzIGEgd29ya2Fyb3VuZCB1bnRpbCBzdXBwb3J0IHRvIGJ1aWxkIGV2YXMgd2l0aCBF R0wgaGFzIGJlZW4gYWRkZWQuCi0jaWYgVVNFKEdMWCkgfHwgUExBVEZPUk0oRUZMKQorI2lmIFVT RShHTFgpCiAgICAgICAgIG1fY29udGV4dEhhbmRsZSA9IGdsWEdldEN1cnJlbnRDb250ZXh0KCk7 CiAjZWxpZiBVU0UoRUdMKQogICAgICAgICBtX2NvbnRleHRIYW5kbGUgPSBlZ2xHZXRDdXJyZW50 Q29udGV4dCgpOwpkaWZmIC0tZ2l0IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyLmggU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXIuaAppbmRleCA3MTIwMGVjLi44M2ZkMGM2IDEwMDY0NAotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaAorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaApA QCAtMjgsNyArMjgsNyBAQAogICAgICNkZWZpbmUgVEVYTUFQX09QRU5HTF9FU18yCiAjZW5kaWYK ICNlbmRpZgotI2lmIFBMQVRGT1JNKEdUSykgJiYgVVNFKE9QRU5HTF9FU18yKQorI2lmIChQTEFU Rk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkpICYmIFVTRShPUEVOR0xfRVNfMikKICNkZWZpbmUg VEVYTUFQX09QRU5HTF9FU18yCiAjZW5kaWYKIAo= 191196 2013-03-04 03:48:47 -0800 2013-03-04 05:09:52 -0800 patchv2 final.patch text/plain 2911 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGNmNGJhOGMuLjVmYWM4NTMgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEz LTAzLTA0ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBCdWlsZCBmaXggd2hlbiBjb21waWxpbmcgd2l0aCBHTEVTMiBzdXBw b3J0IGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTEyOTEKKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGJ1aWxkIGlzc3VlcyB3aGVuIGNvbXBp bGluZyB3aXRoIEdMRVMyCisgICAgICAgIHN1cHBvcnQuIEFzIHBhcnQgb2YgdGhlIGZpeCB0aGUg cGF0Y2ggcmVtb3ZlcyBFdmFzIHNwZWNpZmljCisgICAgICAgIHdvcmthcm91bmQgb2YgdXNpbmcg R0xYIHdpdGggRUdMIGluIFBsYXRmb3JtQ29udGV4dCBhcyBHTEVTMiAKKyAgICAgICAgaXMgdGhl IG1haW4gdGFyZ2V0IHdpdGggRUdMLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvT3Bl bkdMRVNTaGltcy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRm b3JtQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHTEN1cnJlbnRDb250ZXh0V3JhcHBl cjo6R0xDdXJyZW50Q29udGV4dFdyYXBwZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyLmg6CisKIDIwMTMtMDMtMDQgIEFkYW0gQmVyZ2t2aXN0ICA8 YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTog bG9jYWwgYWRkVHJhY2soKSBhbmQgcmVtb3ZlVHJhY2soKSBvcGVyYXRpb25zIHNob3VsZCBub3Qg ZmlyZSBldmVudHMuCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv T3BlbkdMRVNTaGltcy5oIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL09wZW5HTEVT U2hpbXMuaAppbmRleCBiY2FmODU1Li40YmI1YjU5IDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMRVNTaGltcy5oCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9PcGVuR0xFU1NoaW1zLmgKQEAgLTI2LDcgKzI2LDcgQEAKICNpZm5kZWYg T3BlbkdMRVNTaGltc19oCiAjZGVmaW5lIE9wZW5HTEVTU2hpbXNfaAogCi0jaWYgUExBVEZPUk0o QkxBQ0tCRVJSWSkgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykKKyNpZiBQTEFURk9S TShCTEFDS0JFUlJZKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9S TShFRkwpCiAjZGVmaW5lIGdsQmluZEZyYW1lYnVmZmVyRVhUIGdsQmluZEZyYW1lYnVmZmVyCiAj ZGVmaW5lIGdsRnJhbWVidWZmZXJUZXh0dXJlMkRFWFQgZ2xGcmFtZWJ1ZmZlclRleHR1cmUyRAog I2RlZmluZSBnbEJpbmRSZW5kZXJidWZmZXJFWFQgZ2xCaW5kUmVuZGVyYnVmZmVyCmRpZmYgLS1n aXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1Db250 ZXh0LmNwcCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9y bUNvbnRleHQuY3BwCmluZGV4IGNlZDdiYjguLmJjZTA0MjUgMTAwNjQ0Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3BwCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQu Y3BwCkBAIC0zNiwxMCArMzYsNiBAQAogCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKIAot I2lmIEhBVkUoR0xYKQotI2luY2x1ZGUgPEdML2dseC5oPgotI2VuZGlmCi0KIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogI2lmIFVTRShPUEVOR0xfRVNfMikKQEAgLTU1LDggKzUxLDcgQEAgcHVibGlj OgogICAgIEdMQ3VycmVudENvbnRleHRXcmFwcGVyKCkKICAgICAgICAgOiBHTFBsYXRmb3JtQ29u dGV4dCgpCiAgICAgewotICAgICAgICAvLyBGSVhNRTo6IFRoaXMgaXMgYSB3b3JrYXJvdW5kIHVu dGlsIHN1cHBvcnQgdG8gYnVpbGQgZXZhcyB3aXRoIEVHTCBoYXMgYmVlbiBhZGRlZC4KLSNpZiBV U0UoR0xYKSB8fCBQTEFURk9STShFRkwpCisjaWYgVVNFKEdMWCkKICAgICAgICAgbV9jb250ZXh0 SGFuZGxlID0gZ2xYR2V0Q3VycmVudENvbnRleHQoKTsKICNlbGlmIFVTRShFR0wpCiAgICAgICAg IG1fY29udGV4dEhhbmRsZSA9IGVnbEdldEN1cnJlbnRDb250ZXh0KCk7CmRpZmYgLS1naXQgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaCBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oCmluZGV4 IDcxMjAwZWMuLjgzZmQwYzYgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oCkBAIC0yOCw3ICsyOCw3IEBACiAgICAgI2Rl ZmluZSBURVhNQVBfT1BFTkdMX0VTXzIKICNlbmRpZgogI2VuZGlmCi0jaWYgUExBVEZPUk0oR1RL KSAmJiBVU0UoT1BFTkdMX0VTXzIpCisjaWYgKFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZM KSkgJiYgVVNFKE9QRU5HTF9FU18yKQogI2RlZmluZSBURVhNQVBfT1BFTkdMX0VTXzIKICNlbmRp ZgogCg==